ARI: Add detection of printf_vma and sprintf_vma

We shouldn't be using these, since their output goes straight to
stdout, which doesn't allow redirection. So this patch updates
the ARI to detect any such use.

gdb/ChangeLog:

        * contrib/ari/gdb_ari.sh: Add detection of printf_vma and
        sprintf_vma.
This commit is contained in:
Joel Brobecker 2016-11-19 10:40:17 -08:00
parent 0fc9967d0b
commit cc188e5fd6
2 changed files with 21 additions and 0 deletions

View File

@ -1,3 +1,8 @@
2016-11-19 Joel Brobecker <brobecker@adacore.com>
* contrib/ari/gdb_ari.sh: Add detection of printf_vma and
sprintf_vma.
2016-11-18 Simon Marchi <simon.marchi@polymtl.ca>
* Makefile.in (%.o: $(srcdir)/gdbtk/generic/%.c): Fix typo.

View File

@ -1097,6 +1097,22 @@ Do not use vasprintf(), instead use xstrvprintf"
fail("vasprintf")
}
BEGIN { doc["printf_vma"] = "\
Do not use printf_vma, instead use paddress or phex_nz"
category["printf_vma"] = ari_code
}
/(^|[^_[:alnum:]])printf_vma[[:space:]]*\(/ {
fail("printf_vma")
}
BEGIN { doc["sprintf_vma"] = "\
Do not use sprintf_vma, instead use paddress or phex_nz"
category["sprintf_vma"] = ari_code
}
/(^|[^_[:alnum:]])sprintf_vma[[:space:]]*\(/ {
fail("sprintf_vma")
}
# More generic memory operations
BEGIN { doc["bzero"] = "\