OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Microblaze: Reject invalid target descriptions

Browse Source 
We currently validate the target description, but then forget to
reject it if found invalid.

Tested that incorrect descriptions are rejected and GDB warns about
them.

Tested the Microblaze Design with and without stack-protect registers.
The gdb command "info registers" displayed the register correctly.  If
a stack protect design is not selected, only core registers are
displayed.  When the stack-protect registers are selected in the
design, the core registers along with stack-protect registers are
displayed.

gdb/
2014-10-10  Ajit Agarwal  <ajitkum@xilinx.com>

	* microblaze-tdep.c (microblaze_gdbarch_init): If the description
	isn't valid, release the tdesc arch data and return NULL.
This commit is contained in:
Ajit Kumar Agarwal 2014-10-10 18:07:06 +01:00 committed by Pedro Alves
parent cdfa0b0ac1
commit cc3afae25a
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2014-10-10 Ajit Agarwal <ajitkum@xilinx.com>
* microblaze-tdep.c (microblaze_gdbarch_init): If the description
isn't valid, release the tdesc arch data and return NULL.
2014-10-10 Pedro Alves <palves@redhat.com>
* linux-tdep.c: Include observer.h.

8
gdb/microblaze-tdep.c
View File

@ -722,7 +722,13 @@ microblaze_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
MICROBLAZE_SHR_REGNUM,
"rshr");
}
}
if (!valid_p)
{
tdesc_data_cleanup (tdesc_data);
return NULL;
}
}
/* Allocate space for the new architecture. */
tdep = XNEW (struct gdbarch_tdep);