OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Replace sprintf with xsnprintf

Browse Source 
gdb:

2013-12-18  Yao Qi  <yao@codesourcery.com>

	* linux-nat.c (linux_proc_xfer_partial): Call xsnprintf instead
	of sprintf.
	(linux_nat_detach, linux_child_pid_to_exec_file): Likewise.
	(linux_proc_pending_signals): Likewise.
This commit is contained in:
Yao Qi 2013-11-04 11:16:37 +08:00
parent 230de03ab4
commit cde33bf103
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2013-12-18 Yao Qi <yao@codesourcery.com>
* linux-nat.c (linux_proc_xfer_partial): Call xsnprintf instead
of sprintf.
(linux_nat_detach, linux_child_pid_to_exec_file): Likewise.
(linux_proc_pending_signals): Likewise.
2013-12-18 Joel Brobecker <brobecker@adacore.com> 2013-12-18 Joel Brobecker <brobecker@adacore.com>
* value.c (value_entirely_unavailable): ARI fix: Move trailing * value.c (value_entirely_unavailable): ARI fix: Move trailing

9
gdb/linux-nat.c
View File

@ -1592,7 +1592,7 @@ linux_nat_detach (struct target_ops *ops, const char *args, int from_tty)
/* Put the signal number in ARGS so that inf_ptrace_detach will /* Put the signal number in ARGS so that inf_ptrace_detach will
pass it along with PTRACE_DETACH. */ pass it along with PTRACE_DETACH. */
tem = alloca (8); tem = alloca (8);
sprintf (tem, "%d", (int) WSTOPSIG (status)); xsnprintf (tem, 8, "%d", (int) WSTOPSIG (status));
args = tem; args = tem;
if (debug_linux_nat) if (debug_linux_nat)
fprintf_unfiltered (gdb_stdlog, fprintf_unfiltered (gdb_stdlog,
@ -4049,7 +4049,7 @@ linux_child_pid_to_exec_file (int pid)
make_cleanup (xfree, name2); make_cleanup (xfree, name2);
memset (name2, 0, PATH_MAX); memset (name2, 0, PATH_MAX);
sprintf (name1, "/proc/%d/exe", pid); xsnprintf (name1, PATH_MAX, "/proc/%d/exe", pid);
if (readlink (name1, name2, PATH_MAX - 1) > 0) if (readlink (name1, name2, PATH_MAX - 1) > 0)
return name2; return name2;
else else
@ -4135,7 +4135,8 @@ linux_proc_xfer_partial (struct target_ops *ops, enum target_object object,
/* We could keep this file open and cache it - possibly one per /* We could keep this file open and cache it - possibly one per
thread. That requires some juggling, but is even faster. */ thread. That requires some juggling, but is even faster. */
sprintf (filename, "/proc/%d/mem", ptid_get_pid (inferior_ptid)); xsnprintf (filename, sizeof filename, "/proc/%d/mem",
ptid_get_pid (inferior_ptid));
fd = gdb_open_cloexec (filename, O_RDONLY | O_LARGEFILE, 0); fd = gdb_open_cloexec (filename, O_RDONLY | O_LARGEFILE, 0);
if (fd == -1) if (fd == -1)
return 0; return 0;
@ -4305,7 +4306,7 @@ linux_proc_pending_signals (int pid, sigset_t *pending,
sigemptyset (pending); sigemptyset (pending);
sigemptyset (blocked); sigemptyset (blocked);
sigemptyset (ignored); sigemptyset (ignored);
sprintf (fname, "/proc/%d/status", pid); xsnprintf (fname, sizeof fname, "/proc/%d/status", pid);
procfile = gdb_fopen_cloexec (fname, "r"); procfile = gdb_fopen_cloexec (fname, "r");
if (procfile == NULL) if (procfile == NULL)
error (_("Could not open %s"), fname); error (_("Could not open %s"), fname);