OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use fputc in place of putc to avoid -Wunused-value warning (AIX).

Browse Source 
Currently, bfd does not compile with -Wunused-value because
the following code:

        val = putc ('\n', f);

gets expanded into some code that triggers a warning:

        warning: value computed is not used [-Wunused-value]

This is because putc is implemented as a macro...

>#define putc(__x, __p)  (((!((__p)->_flag & 0xC000)) && \
>                        ((__p)->_flag = ((__p)->_flag  & 0x3FFF) | 0x8000)),\
>                        (--(__p)->_cnt < 0 ? \
>                        __flsbuf((unsigned char) (__x), (__p)) : \
>                        (int) (*(__p)->_ptr++ = (unsigned char) (__x))))

It's the first part, before the coma operator, which triggers
the unused-value warning.

This patch fixes the issue by simply avoiding the macro and using
fputc instead.

bfd/ChangeLog:

        * bfd.c (_bfd_default_error_handler): Replace use of putc
        by fputc.  Add comment explaining why.
This commit is contained in:
Joel Brobecker 2013-05-09 06:58:16 +00:00
parent 40aea47721
commit ceae87f3fe
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/ChangeLog
View File

@ -1,3 +1,8 @@
2013-05-09 Joel Brobecker <brobecker@adacore.com>
* bfd.c (_bfd_default_error_handler): Replace use of putc
by fputc. Add comment explaining why.
2013-05-09 Alan Modra <amodra@gmail.com>
* elflink.c (elf_link_add_object_symbols): Don't omit reading

4
bfd/bfd.c
View File

@ -733,7 +733,9 @@ _bfd_default_error_handler (const char *fmt, ...)
vfprintf (stderr, new_fmt, ap);
va_end (ap);
putc ('\n', stderr);
/* On AIX, putc is implemented as a macro that triggers a -Wunused-value
warning, so use the fputc function to avoid it. */
fputc ('\n', stderr);
fflush (stderr);
}