OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Skip two more attach tests when testing against stub-like targets 

This patch updates two attach tests to use utility procs for checking if
the attach test should run and for launching the program to be attached, as
follows:

1) Use can_spawn_for_attach instead of is_remote target
2) Use spawn_wait_for_attach instead of exec/sleep

Tested (1) with i686-mingw32 host and i686-pc-linux-gnu build/target and
both with x86_64 Ubuntu.

gdb/testsuite/ChangeLog:

	* gdb.base/attach-pie-noexec.exp: Use can_spawn_for_attach
	instead of checking whether the target board is remote and
	use spawn_wait_for_attach instead of exec/sleep.
	* gdb.base/attach-twice.exp: Likewise.
This commit is contained in:
Don Breazeal 2015-01-15 10:47:31 -08:00
parent cd21f5daad
commit d221e7efd6
3 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,10 @@
2015-01-15 Don Breazeal <donb@codesourcery.com>
* gdb.base/attach-pie-noexec.exp: Use can_spawn_for_attach
instead of checking whether the target board is remote and
use spawn_wait_for_attach instead of exec/sleep.
* gdb.base/attach-twice.exp: Likewise.
2015-01-15 Joel Brobecker <brobecker@adacore.com>
* gdb.ada/var_arr_attrs: New testcase.

9
gdb/testsuite/gdb.base/attach-pie-noexec.exp
View File

@ -13,8 +13,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Manipulation with PID on target is not supported.
if [is_remote target] then {
if {![can_spawn_for_attach]} {
return 0
}
@ -53,8 +52,10 @@ if {$arch == ""} {
return 0
}
set testpid [eval exec $binfile &]
exec sleep 2
# Start the program running and then wait for a bit, to be sure
# that it can be attached to.
set testpid [spawn_wait_for_attach $binfile]
gdb_start
file delete -- $binfile

9
gdb/testsuite/gdb.base/attach-twice.exp
View File

@ -13,8 +13,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Manipulation with PID on target is not supported.
if [is_remote target] then {
if {![can_spawn_for_attach]} {
return 0
}
@ -25,8 +24,10 @@ if { [prepare_for_testing ${testfile}.exp $executable] } {
return -1
}
set testpid [eval exec $binfile &]
exec sleep 2
# Start the program running and then wait for a bit, to be sure
# that it can be attached to.
set testpid [spawn_wait_for_attach $binfile]
set parentpid 0