From d3308cfdec5765e8667fa6f61f75bc36986cdcf9 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Wed, 19 Feb 2020 13:41:10 +0100 Subject: [PATCH] [gdb/testsuite] Fix c++/14186 kpass in cpexprs.exp With gdb.cp/cpexprs.exp, we see: ... KPASS: gdb.cp/cpexprs.exp: p CV::m(int) const (PRMS c++/14186) KPASS: gdb.cp/cpexprs.exp: p CV::m(int) volatile (PRMS c++/14186) KPASS: gdb.cp/cpexprs.exp: p CV::m(int) const volatile (PRMS c++/14186) ... The tests have been KPASSing since Sept 4 2017, due to commit 3693fdb3c8 'Make "p S::method() const::static_var" work too'. Fix this by removing the corresponding kfail. gdb/testsuite/ChangeLog: 2020-02-19 Tom de Vries * gdb.cp/cpexprs.exp: Remove c++/14186 kfail. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.cp/cpexprs.exp | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 49b0affaaf..b2f20fe38b 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2020-02-19 Tom de Vries + + * gdb.cp/cpexprs.exp: Remove c++/14186 kfail. + 2020-02-19 Tom de Vries * gdb.base/solib-overlap.exp: Use exec instead of system to execute diff --git a/gdb/testsuite/gdb.cp/cpexprs.exp b/gdb/testsuite/gdb.cp/cpexprs.exp index 9ccb94cf40..e8b898fa11 100644 --- a/gdb/testsuite/gdb.cp/cpexprs.exp +++ b/gdb/testsuite/gdb.cp/cpexprs.exp @@ -731,9 +731,6 @@ foreach cv {{} { const} { volatile} { const volatile}} { pass $test } } - if {"$cv" != ""} { - setup_kfail c++/14186 *-*-* - } gdb_test "p CV::m(int)$cv" [string_to_regexp $correct] }