From d44c67f38178c5ad0c083ebff6429d6e477ea42e Mon Sep 17 00:00:00 2001 From: Edjunior Barbosa Machado Date: Thu, 18 Aug 2016 10:45:12 -0300 Subject: [PATCH] ppc: Fix record of HTM instructions The patch fixes the record support of Hardware Transactional Memory instructions on Power. It also solves a large number of unexpected failures from gdb.reverse testcases sigall-precsave.exp and sigall-reverse.exp that occur on distros which glibc uses HTM instructions. gdb/ChangeLog 2016-08-18 Edjunior Barbosa Machado * rs6000-tdep.c (ppc_process_record_op31): Handle HTM instructions. --- gdb/ChangeLog | 4 ++++ gdb/rs6000-tdep.c | 10 +++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index dbd90ddb17..567b69c33b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2016-08-18 Edjunior Barbosa Machado + + * rs6000-tdep.c (ppc_process_record_op31): Handle HTM instructions. + 2016-08-17 Simon Marchi * inferior.c (remove_inferior_command): Fix error message. diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index a616cbe9c2..eb12c5d2a2 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -4613,17 +4613,17 @@ ppc_process_record_op31 (struct gdbarch *gdbarch, struct regcache *regcache, case 654: /* Transaction Begin */ case 686: /* Transaction End */ - case 718: /* Transaction Check */ case 750: /* Transaction Suspend or Resume */ case 782: /* Transaction Abort Word Conditional */ case 814: /* Transaction Abort Doubleword Conditional */ case 846: /* Transaction Abort Word Conditional Immediate */ case 878: /* Transaction Abort Doubleword Conditional Immediate */ case 910: /* Transaction Abort */ - fprintf_unfiltered (gdb_stdlog, "Cannot record Transaction instructions. " - "%08x at %s, 31-%d.\n", - insn, paddress (gdbarch, addr), ext); - return -1; + record_full_arch_list_add_reg (regcache, tdep->ppc_ps_regnum); + /* FALL-THROUGH */ + case 718: /* Transaction Check */ + record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum); + return 0; case 1014: /* Data Cache Block set to Zero */ if (target_auxv_search (¤t_target, AT_DCACHEBSIZE, &at_dcsz) <= 0