* symfile.h (quick_symbol_functions): Clarify usage of

expand_symtabs_with_filename.
	* dwarf2read.c (dw2_expand_symtabs_with_filename): Only iterate over
	comp units, ignore type units.
This commit is contained in:
Doug Evans 2010-12-08 18:04:08 +00:00
parent 1ef75ecca6
commit d4637a0471
3 changed files with 16 additions and 3 deletions

View File

@ -1,5 +1,10 @@
2010-12-08 Doug Evans <dje@google.com>
* symfile.h (quick_symbol_functions): Clarify usage of
expand_symtabs_with_filename.
* dwarf2read.c (dw2_expand_symtabs_with_filename): Only iterate over
comp units, ignore type units.
* dwarf2read.c (dw2_expand_symtabs_with_filename): Use FILENAME_CMP.
2010-12-07 Doug Evans <dje@google.com>

View File

@ -2323,8 +2323,13 @@ dw2_expand_symtabs_with_filename (struct objfile *objfile,
int i;
dw2_setup (objfile);
for (i = 0; i < (dwarf2_per_objfile->n_comp_units
+ dwarf2_per_objfile->n_type_comp_units); ++i)
/* We don't need to consider type units here.
This is only called for examining code, e.g. expand_line_sal.
There can be an order of magnitude (or more) more type units
than comp units, and we avoid them if we can. */
for (i = 0; i < dwarf2_per_objfile->n_comp_units; ++i)
{
int j;
struct dwarf2_per_cu_data *per_cu = dw2_get_cu (i);

View File

@ -209,7 +209,10 @@ struct quick_symbol_functions
void (*expand_all_symtabs) (struct objfile *objfile);
/* Read all symbol tables associated with OBJFILE which have the
file name FILENAME. */
file name FILENAME.
This is for the purposes of examining code only, e.g., expand_line_sal.
The routine may ignore debug info that is known to not be useful with
code, e.g., DW_TAG_type_unit for dwarf debug info. */
void (*expand_symtabs_with_filename) (struct objfile *objfile,
const char *filename);