OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

* cp-valprint.c (cp_print_value): Replace potentially unsafe

Browse Source 
alloca with xmalloc/xfree.
This commit is contained in:
Siddhesh Poyarekar 2012-07-06 05:36:07 +00:00
parent a74bc57646
commit d5161074cc
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2012-07-06 Siddhesh Poyarekar <siddhesh@redhat.com>
Jan Kratochvil <jan.kratochvil@redhat.com>
* cp-valprint.c (cp_print_value): Replace potentially unsafe
alloca with xmalloc/xfree.
2012-07-06 Siddhesh Poyarekar <siddhesh@redhat.com>
* MAINTAINERS (Write After Approval): Add myself to the list.

9
gdb/cp-valprint.c
View File

@ -554,9 +554,11 @@ cp_print_value (struct type *type, struct type *real_type,
if ((boffset + offset) < 0
|| (boffset + offset) >= TYPE_LENGTH (real_type))
{
/* FIXME (alloca): unsafe if baseclass is really
really large. */
gdb_byte *buf = alloca (TYPE_LENGTH (baseclass));
gdb_byte *buf;
struct cleanup *back_to;
buf = xmalloc (TYPE_LENGTH (baseclass));
back_to = make_cleanup (xfree, buf);
if (target_read_memory (address + boffset, buf,
TYPE_LENGTH (baseclass)) != 0)
@ -568,6 +570,7 @@ cp_print_value (struct type *type, struct type *real_type,
boffset = 0;
thistype = baseclass;
base_valaddr = value_contents_for_printing_const (base_val);
do_cleanups (back_to);
}
else
{