OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

expprint: Fix format string warning

Browse Source 
My compiler (gcc 5.4.0, clang 3.8) gives this warning:

/home/emaisin/src/binutils-gdb/gdb/expprint.c: In lambda function:
/home/emaisin/src/binutils-gdb/gdb/expprint.c:1055:35: error: format not a string literal and no format arguments [-Werror=format-security]
      fprintf_filtered (stream, mod);
                                   ^

Fix it by not using the passed string as the format string.

gdb/ChangeLog:

	* expprint.c (dump_subexp_body_standard): Use constant format
	string in fprintf_filtered call.
This commit is contained in:
Simon Marchi 2017-09-05 09:00:42 +02:00
parent 625ce09c1c
commit d6b687ac7a
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2017-09-05 Simon Marchi <simon.marchi@ericsson.com>
* expprint.c (dump_subexp_body_standard): Use constant format
string in fprintf_filtered call.
2017-09-04 John Baldwin <jhb@FreeBSD.org>
* configure.nat: Add "x86-nat.o x86-dregs.o" for NetBSD/amd64 and

2
gdb/expprint.c
View File

@ -1052,7 +1052,7 @@ dump_subexp_body_standard (struct expression *exp,
if (space)
fputs_filtered (" ", stream);
space = true;
fprintf_filtered (stream, mod);
fprintf_filtered (stream, "%s", mod);
};
if (flags & TYPE_INSTANCE_FLAG_CONST)
print_one ("const");