OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[gdb/testsuite] Handle missing gccgo 

Without gccgo installed I see in stdout/stderr:
...
Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.go/print.exp ...
Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.go/handcall.exp ...
gdb compile failed, default_target_compile: Can't find gccgo.
Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.go/max-depth.exp ...
gdb compile failed, default_target_compile: Can't find gccgo.
Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.go/integers.exp ...
gdb compile failed, default_target_compile: Can't find gccgo.
Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.go/unsafe.exp ...
gdb compile failed, default_target_compile: Can't find gccgo.
Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.go/package.exp ...
gdb compile failed, default_target_compile: Can't find gccgo.
Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.go/types.exp ...
gdb compile failed, default_target_compile: Can't find gccgo.
Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.go/chan.exp ...
gdb compile failed, default_target_compile: Can't find gccgo.
Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.go/strings.exp ...
gdb compile failed, default_target_compile: Can't find gccgo.
Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.go/basic-types.exp ...
Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.go/hello.exp ...
gdb compile failed, default_target_compile: Can't find gccgo.
Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.go/methods.exp ...
gdb compile failed, default_target_compile: Can't find gccgo.
...

Fix this by introducing a gdb_caching_proc support_go_compile, and using it in
the complaining test-cases.

Tested on x86_64-linux, with and without gccgo installed.

gdb/testsuite/ChangeLog:

2020-02-20  Tom de Vries  <tdevries@suse.de>

	* lib/gdb.exp (support_go_compile): New gdb_caching_proc.
	(gdb_simple_compile): Handle compile_flags go by using .go extension
	for source file.
	* gdb.go/chan.exp: Use support_go_compile.
	* gdb.go/handcall.exp: Same.
	* gdb.go/hello.exp: Same.
	* gdb.go/integers.exp: Same.
	* gdb.go/max-depth.exp: Same.
	* gdb.go/methods.exp: Same.
	* gdb.go/package.exp: Same.
	* gdb.go/strings.exp: Same.
	* gdb.go/types.exp: Same.
	* gdb.go/unsafe.exp: Same.
This commit is contained in:
Tom de Vries 2020-02-20 06:31:24 +01:00
parent cb54886dcb
commit d7445728b1
12 changed files with 46 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,19 @@
2020-02-20 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (support_go_compile): New gdb_caching_proc.
(gdb_simple_compile): Handle compile_flags go by using .go extension
for source file.
* gdb.go/chan.exp: Use support_go_compile.
* gdb.go/handcall.exp: Same.
* gdb.go/hello.exp: Same.
* gdb.go/integers.exp: Same.
* gdb.go/max-depth.exp: Same.
* gdb.go/methods.exp: Same.
* gdb.go/package.exp: Same.
* gdb.go/strings.exp: Same.
* gdb.go/types.exp: Same.
* gdb.go/unsafe.exp: Same.
2020-02-19 Tom de Vries <tdevries@suse.de>
* gdb.python/lib-types.exp: Make xfail more strict.

1
gdb/testsuite/gdb.go/chan.exp
View File

@ -21,6 +21,7 @@
load_lib "go.exp"
if { [skip_go_tests] } { continue }
if { [support_go_compile] == 0 } { continue }
standard_testfile .go

1
gdb/testsuite/gdb.go/handcall.exp
View File

@ -20,6 +20,7 @@
load_lib "go.exp"
if { [skip_go_tests] } { continue }
if { [support_go_compile] == 0 } { continue }
standard_testfile .go

1
gdb/testsuite/gdb.go/hello.exp
View File

@ -20,6 +20,7 @@
load_lib "go.exp"
if { [skip_go_tests] } { continue }
if { [support_go_compile] == 0 } { continue }
standard_testfile .go

1
gdb/testsuite/gdb.go/integers.exp
View File

@ -20,6 +20,7 @@
load_lib "go.exp"
if { [skip_go_tests] } { continue }
if { [support_go_compile] == 0 } { continue }
standard_testfile .go

1
gdb/testsuite/gdb.go/max-depth.exp
View File

@ -20,6 +20,7 @@
load_lib "go.exp"
if { [skip_go_tests] } { continue }
if { [support_go_compile] == 0 } { continue }
standard_testfile .go

1
gdb/testsuite/gdb.go/methods.exp
View File

@ -20,6 +20,7 @@
load_lib "go.exp"
if { [skip_go_tests] } { continue }
if { [support_go_compile] == 0 } { continue }
standard_testfile .go

1
gdb/testsuite/gdb.go/package.exp
View File

@ -20,6 +20,7 @@
load_lib "go.exp"
if { [skip_go_tests] } { continue }
if { [support_go_compile] == 0 } { continue }
standard_testfile package1.go package2.go

1
gdb/testsuite/gdb.go/strings.exp
View File

@ -18,6 +18,7 @@
load_lib "go.exp"
if { [skip_go_tests] } { continue }
if { [support_go_compile] == 0 } { continue }
standard_testfile .go

1
gdb/testsuite/gdb.go/types.exp
View File

@ -20,6 +20,7 @@
load_lib "go.exp"
if { [skip_go_tests] } { continue }
if { [support_go_compile] == 0 } { continue }
standard_testfile .go

1
gdb/testsuite/gdb.go/unsafe.exp
View File

@ -20,6 +20,7 @@
load_lib "go.exp"
if { [skip_go_tests] } { continue }
if { [support_go_compile] == 0 } { continue }
standard_testfile .go

21
gdb/testsuite/lib/gdb.exp
View File

@ -2490,6 +2490,18 @@ gdb_caching_proc support_complex_tests {
} executable]
}
# Return 1 if compiling go is supported.
gdb_caching_proc support_go_compile {
return [gdb_can_simple_compile go-hello {
package main
import "fmt"
func main() {
fmt.Println("hello world")
}
} executable go]
}
# Return 1 if GDB can get a type for siginfo from the target, otherwise
# return 0.
@ -3631,7 +3643,14 @@ proc gdb_simple_compile {name code {type object} {compile_flags {}} {object obj}
set postfix "s"
}
}
set src [standard_temp_file $name-[pid].c]
set ext "c"
foreach flag $compile_flags {
if { "$flag" == "go" } {
set ext "go"
break
}
}
set src [standard_temp_file $name-[pid].$ext]
set obj [standard_temp_file $name-[pid].$postfix]
set compile_flags [concat $compile_flags {debug nowarnings quiet}]