From d769e349bc2c28261d4b2391b58eb7dc3f452e99 Mon Sep 17 00:00:00 2001 From: Doug Evans Date: Mon, 11 Aug 2014 17:21:07 -0700 Subject: [PATCH] Delete "Loaded symbols for ..." message, it is redundant. * solib.c (solib_read_symbols): Delete "Loaded symbols for ..." message, it is redundant with "Reading symbols from ..." message. testsuite/ * gdb.base/print-symbol-loading.exp (test_load_core): Update. (test_load_shlib): Update. --- gdb/ChangeLog | 5 +++++ gdb/solib.c | 8 +------- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/print-symbol-loading.exp | 4 ++-- 4 files changed, 13 insertions(+), 9 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 33b6f540d0..5f962593d0 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2014-08-11 Doug Evans + + * solib.c (solib_read_symbols): Delete "Loaded symbols for ..." + message, it is redundant with "Reading symbols from ..." message. + 2014-08-10 Doug Evans * linux-nat.c (linux_nat_thread_address_space): Delete dead code. diff --git a/gdb/solib.c b/gdb/solib.c index 90ea45410b..2f641059b7 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -603,8 +603,6 @@ master_so_list (void) int solib_read_symbols (struct so_list *so, int flags) { - const int from_tty = flags & SYMFILE_VERBOSE; - if (so->symbols_loaded) { /* If needed, we've already warned in our caller. */ @@ -648,11 +646,7 @@ solib_read_symbols (struct so_list *so, int flags) " library symbols for %s:\n"), so->so_name); else - { - if (print_symbol_loading_p (from_tty, 0, 1)) - printf_unfiltered (_("Loaded symbols for %s\n"), so->so_name); - so->symbols_loaded = 1; - } + so->symbols_loaded = 1; return 1; } diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 6ae9f6eaa3..a6e47148ea 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-08-11 Doug Evans + + * gdb.base/print-symbol-loading.exp (test_load_core): Update. + (test_load_shlib): Update. + 2014-08-09 Yao Qi * gdb.base/display.exp: Invoke is_address_zero_readable. diff --git a/gdb/testsuite/gdb.base/print-symbol-loading.exp b/gdb/testsuite/gdb.base/print-symbol-loading.exp index a080ce1e5a..1abfa2aef9 100644 --- a/gdb/testsuite/gdb.base/print-symbol-loading.exp +++ b/gdb/testsuite/gdb.base/print-symbol-loading.exp @@ -93,7 +93,7 @@ proc test_load_core { print_symbol_loading } { } "full" { gdb_test "set solib-search-path [file dirname ${binfile_lib}]" \ - "Reading symbols from.*Loaded symbols for.*" \ + "Reading symbols from.*" \ ${test_name} } } @@ -129,7 +129,7 @@ proc test_load_shlib { print_symbol_loading } { } "full" { gdb_test "sharedlibrary .*" \ - "Reading symbols from.*Loaded symbols for.*" \ + "Reading symbols from.*" \ ${test_name} } }