* NEWS: Update.

* python/python.c (finalize_python): New function.
	(_initialize_python): Make a final cleanup.
testsuite
	* gdb.python/python.exp: Test atexit.register.
This commit is contained in:
Tom Tromey 2012-09-20 20:54:11 +00:00
parent 05eade73e1
commit d7de8e3ce9
5 changed files with 49 additions and 0 deletions

View File

@ -1,3 +1,9 @@
2012-09-20 Tom Tromey <tromey@redhat.com>
* NEWS: Update.
* python/python.c (finalize_python): New function.
(_initialize_python): Make a final cleanup.
2012-09-19 Doug Evans <dje@google.com>
* buildsym.h (param_symbols): Delete, unused.

View File

@ -7,6 +7,8 @@
** Vectors can be created with gdb.Type.vector.
** Python's atexit.register now works in GDB.
* New Python-based convenience functions:
** $_memeq(buf1, buf2, length)

View File

@ -1266,6 +1266,24 @@ user_show_python (char *args, int from_tty)
/* Initialize the Python code. */
/* This is installed as a final cleanup and cleans up the
interpreter. This lets Python's 'atexit' work. */
static void
finalize_python (void *ignore)
{
/* We don't use ensure_python_env here because if we ever ran the
cleanup, gdb would crash -- because the cleanup calls into the
Python interpreter, which we are about to destroy. It seems
clearer to make the needed calls explicitly here than to create a
cleanup and then mysteriously discard it. */
PyGILState_Ensure ();
python_gdbarch = target_gdbarch;
python_language = current_language;
Py_Finalize ();
}
/* Provide a prototype to silence -Wmissing-prototypes. */
extern initialize_file_ftype _initialize_python;
@ -1427,6 +1445,7 @@ message == an error message without a stack will be printed."),
PyThreadState_Swap (NULL);
PyEval_ReleaseLock ();
make_final_cleanup (finalize_python, NULL);
#endif /* HAVE_PYTHON */
}

View File

@ -1,3 +1,7 @@
2012-09-20 Tom Tromey <tromey@redhat.com>
* gdb.python/python.exp: Test atexit.register.
2012-09-20 Doug Evans <dje@google.com>
* boards/dwarf4-gdb-index.exp: New file.

View File

@ -141,6 +141,24 @@ gdb_test "python print a" ".*aliases -- Aliases of other commands.*" "verify hel
gdb_py_test_silent_cmd "python nothread = gdb.selected_thread()" "Attempt to aquire thread with no inferior" 1
gdb_test "python print nothread == None" "True" "Ensure that no threads are returned"
gdb_py_test_multiple "register atexit function" \
"python" "" \
"import atexit" "" \
"def printit(arg):" "" \
" print arg" "" \
"atexit.register(printit, 'good bye world')" "" \
"end" ""
send_gdb "quit\n"
gdb_expect {
-re "good bye world" {
pass "atexit handling"
}
default {
fail "atexit handling"
}
}
# Start with a fresh gdb.
clean_restart ${testfile}