OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

* libbfd-in.h: Remove alloca cruft. It was missing some necessary

Browse Source 
cruft (like the #pragma alloca for AIX).
	In addition to that problem, the C alloca calls xmalloc, which
	means checking for being out of memory can't work right.  The
	following changes remove all uses of alloca from BFD.
	* hosts/solaris2.h: Remove alloca cruft.
	* som.c: Replace alloca with a fixed size auto array.
	* aoutx.h, elfcode.h, nlmcode.h, bout.c, coff-alpha.c, ecoff.c,
	ecofflink.c, elf32-hppa.c, elf32-mips.c, linker.c, reloc.c, som.c,
	sunos.c: Replace alloca with malloc and appropriate error checking and
	freeing.
	* linker.c: Replace alloca with obstack_alloc.
	* libbfd.h: Rebuilt.
This commit is contained in:
Jim Kingdon 1994-03-10 02:33:01 +00:00
parent 6305159078
commit d7fb453182
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bfd/ChangeLog
View File

@ -8,8 +8,8 @@ Wed Mar 9 17:17:53 1994 Jim Kingdon (kingdon@lioth.cygnus.com)
* hosts/solaris2.h: Remove alloca cruft.
* som.c: Replace alloca with a fixed size auto array.
* aoutx.h, elfcode.h, nlmcode.h, bout.c, coff-alpha.c, ecoff.c,
ecofflink.c, elf32-hppa.c, elf32-mips.c, linker.c, reloc.c, som.c:
Replace alloca with malloc and appropriate error checking and
ecofflink.c, elf32-hppa.c, elf32-mips.c, linker.c, reloc.c, som.c,
sunos.c: Replace alloca with malloc and appropriate error checking and
freeing.
* linker.c: Replace alloca with obstack_alloc.
* libbfd.h: Rebuilt.

11
bfd/sunos.c
View File

@ -87,7 +87,7 @@ sunos_read_dynamic_info (abfd)
bfd_zalloc (abfd, sizeof (struct sunos_dynamic_info)));
if (!info)
{
bfd_error = no_memory;
bfd_set_error (bfd_error_no_memory);
return false;
}
info->valid = false;
@ -210,7 +210,7 @@ MY(read_dynamic_symbols) (abfd, syms, strs, strsize)
info->dynstr = (char *) bfd_alloc (abfd, info->dyninfo.ld_symb_size);
if (!info->dynsym || !info->dynstr)
{
bfd_error = no_memory;
bfd_set_error (bfd_error_no_memory);
return 0;
}
if (bfd_seek (abfd, info->dyninfo.ld_stab, SEEK_SET) != 0
@ -239,7 +239,9 @@ MY(read_dynamic_symbols) (abfd, syms, strs, strsize)
if (info->dyninfo.ld_buckets > info->dynsym_count)
abort ();
table_size = info->dyninfo.ld_stab - info->dyninfo.ld_hash;
table = (bfd_byte *) alloca (table_size);
table = (bfd_byte *) malloc (table_size);
if (table == NULL)
abort ();
if (bfd_seek (abfd, info->dyninfo.ld_hash, SEEK_SET) != 0
|| bfd_read ((PTR) table, 1, table_size, abfd) != table_size)
abort ();
@ -262,6 +264,7 @@ MY(read_dynamic_symbols) (abfd, syms, strs, strsize)
abort ();
}
}
free (table);
}
#endif /* CHECK_DYNAMIC_HASH */
@ -294,7 +297,7 @@ MY(read_dynamic_relocs) (abfd, relocs)
* obj_reloc_entry_size (abfd)));
if (!info->dynrel)
{
bfd_error = no_memory;
bfd_set_error (bfd_error_no_memory);
return (bfd_size_type) -1;
}
if (bfd_seek (abfd, info->dyninfo.ld_rel, SEEK_SET) != 0