OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Issue a linker error if TLS sections are not adjacent 

Bad linker script may lead to TLS sections separated by non-TLS sections
in output.  This patch changes linker assert to a linker error to
provide better linker diagnosis.

	PR ld/16498
	* elf.c (_bfd_elf_map_sections_to_segments): Issue a linker error
	if TLS sections are not adjacent.
This commit is contained in:
H.J. Lu 2014-01-23 08:15:17 -08:00
parent 83b645b833
commit d923cae027
2 changed files with 29 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bfd/ChangeLog
View File

@ -1,3 +1,9 @@
2014-01-23 H.J. Lu <hongjiu.lu@intel.com>
PR ld/16498
* elf.c (_bfd_elf_map_sections_to_segments): Issue a linker error
if TLS sections are not adjacent.
2014-01-22 Alan Modra <amodra@gmail.com>
* elflink.c (elf_link_add_object_symbols): Call minfo for --as-needed.

26
bfd/elf.c
View File

@ -4117,11 +4117,31 @@ _bfd_elf_map_sections_to_segments (bfd *abfd, struct bfd_link_info *info)
/* Mandated PF_R. */
m->p_flags = PF_R;
m->p_flags_valid = 1;
s = first_tls;
for (i = 0; i < (unsigned int) tls_count; ++i)
{
BFD_ASSERT (first_tls->flags & SEC_THREAD_LOCAL);
m->sections[i] = first_tls;
first_tls = first_tls->next;
if ((s->flags & SEC_THREAD_LOCAL) == 0)
{
_bfd_error_handler
(_("%B: TLS sections are not adjacent:"), abfd);
s = first_tls;
i = 0;
while (i < (unsigned int) tls_count)
{
if ((s->flags & SEC_THREAD_LOCAL) != 0)
{
_bfd_error_handler (_(" TLS: %A"), s);
i++;
}
else
_bfd_error_handler (_(" non-TLS: %A"), s);
s = s->next;
}
bfd_set_error (bfd_error_bad_value);
goto error_return;
}
m->sections[i] = s;
s = s->next;
}
*pm = m;