2008-03-02 H.J. Lu <hongjiu.lu@intel.com>

PR ld/5789
	* elflink.c (_bfd_elf_symbol_refs_local_p): Always return true
	for hidden and local symbols.
This commit is contained in:
H.J. Lu 2008-03-02 22:26:09 +00:00
parent 89200bf844
commit d95edcac72
2 changed files with 11 additions and 4 deletions

View File

@ -1,3 +1,9 @@
2008-03-02 H.J. Lu <hongjiu.lu@intel.com>
PR ld/5789
* elflink.c (_bfd_elf_symbol_refs_local_p): Always return true
for hidden and local symbols.
2008-03-03 Alan Modra <amodra@bigpond.net.au>
* elf32-ppc.c (allocate_dynrelocs): Discard relocs on

View File

@ -2789,6 +2789,11 @@ _bfd_elf_symbol_refs_local_p (struct elf_link_hash_entry *h,
if (h == NULL)
return TRUE;
/* STV_HIDDEN or STV_INTERNAL ones must be local. */
if (ELF_ST_VISIBILITY (h->other) == STV_HIDDEN
|| ELF_ST_VISIBILITY (h->other) == STV_INTERNAL)
return TRUE;
/* Common symbols that become definitions don't get the DEF_REGULAR
flag set, so test it first, and don't bail out. */
if (ELF_COMMON_DEF_P (h))
@ -2817,10 +2822,6 @@ _bfd_elf_symbol_refs_local_p (struct elf_link_hash_entry *h,
if (ELF_ST_VISIBILITY (h->other) == STV_DEFAULT)
return FALSE;
/* However, STV_HIDDEN or STV_INTERNAL ones must be local. */
if (ELF_ST_VISIBILITY (h->other) != STV_PROTECTED)
return TRUE;
hash_table = elf_hash_table (info);
if (!is_elf_hash_table (hash_table))
return TRUE;