OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Riscv shared libraries should not export __global_pointer$. 

ld/
	* emulparams/elf32lriscv-defs.sh (SDATA_START_SYMBOLS): Mark
	__global_pointer$ as HIDDEN.
	* testsuite/ld-riscv-elf/gp-hidden-64.rd: New.
	* testsuite/ld-riscv-elf/gp-hidden-lib.rd: New.
	* testsuite/ld-riscv-elf/gp-hidden-lib.s: New.
	* testsuite/ld-riscv-elf/gp-hidden-ver-64.rd: New.
	* testsuite/ld-riscv-elf/gp-hidden-ver.rd: New.
	* testsuite/ld-riscv-elf/gp-hidden-ver.s: New.
	* testsuite/ld-riscv-elf/gp-hidder-ver.ver: New.
	* testsuite/ld-riscv-elf/gp-hidden.rd: New.
	* testsuite/ld-riscv-elf/gp-hidden.s: New.
	* testsuite/ld-riscv-elf/gp-hidden.sd: New.
	* testsuite/ld-riscv-elf/ld-riscv-elf.exp: Change riscv to riscv*.
	Run the new tests with run_ld_link_tests.
This commit is contained in:
Jim Wilson 2017-12-04 17:37:55 -08:00
parent 4d7efb8ce2
commit da02107a39
13 changed files with 106 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ld/ChangeLog
View File

@ -1,3 +1,20 @@
2017-12-04 Jim Wilson <jimw@sifive.com>
* emulparams/elf32lriscv-defs.sh (SDATA_START_SYMBOLS): Mark
__global_pointer$ as HIDDEN.
* testsuite/ld-riscv-elf/gp-hidden-64.rd: New.
* testsuite/ld-riscv-elf/gp-hidden-lib.rd: New.
* testsuite/ld-riscv-elf/gp-hidden-lib.s: New.
* testsuite/ld-riscv-elf/gp-hidden-ver-64.rd: New.
* testsuite/ld-riscv-elf/gp-hidden-ver.rd: New.
* testsuite/ld-riscv-elf/gp-hidden-ver.s: New.
* testsuite/ld-riscv-elf/gp-hidder-ver.ver: New.
* testsuite/ld-riscv-elf/gp-hidden.rd: New.
* testsuite/ld-riscv-elf/gp-hidden.s: New.
* testsuite/ld-riscv-elf/gp-hidden.sd: New.
* testsuite/ld-riscv-elf/ld-riscv-elf.exp: Change riscv to riscv*.
Run the new tests with run_ld_link_tests.
2017-12-04 Alan Modra <amodra@gmail.com>
* testsuite/ld-i386/pr17935-1.d: Adjust expected error.

2
ld/emulparams/elf32lriscv-defs.sh
View File

@ -23,7 +23,7 @@ TEXT_START_ADDR=0x10000
MAXPAGESIZE="CONSTANT (MAXPAGESIZE)"
COMMONPAGESIZE="CONSTANT (COMMONPAGESIZE)"
SDATA_START_SYMBOLS="__global_pointer$ = . + 0x800;
SDATA_START_SYMBOLS="HIDDEN (__global_pointer$ = . + 0x800);
*(.srodata.cst16) *(.srodata.cst8) *(.srodata.cst4) *(.srodata.cst2) *(.srodata .srodata.*)"
INITIAL_READONLY_SECTIONS=".interp : { *(.interp) } ${CREATE_PIE-${INITIAL_READONLY_SECTIONS}}"

4
ld/testsuite/ld-riscv-elf/gp-hidden-64.rd Normal file
View File

@ -0,0 +1,4 @@
Relocation section '\.rela\.dyn' at offset .* contains 1 entry:
*Offset * Info * Type * Sym\. *Value * Sym\. *Name \+ Addend
[0-9a-f]+ * [0-9a-f]+02 * R_RISCV_64 * [0-9a-f]+ * foo \+ 0

5
ld/testsuite/ld-riscv-elf/gp-hidden-lib.rd Normal file
View File

@ -0,0 +1,5 @@
Relocation section '\.rela\.dyn' at offset .* contains 1 entry:
*Offset * Info * Type * Sym\. *Value * Sym\. *Name \+ Addend
# This must be an absolute relocation, there must not be a _gp reference.
[0-9a-f]+ * 0+03 * R_RISCV_RELATIVE * [0-9a-f]+

6
ld/testsuite/ld-riscv-elf/gp-hidden-lib.s Normal file
View File

@ -0,0 +1,6 @@
.data
.globl bar
.type bar, @object
bar:
.dc.a __global_pointer$
.size bar, . - bar

6
ld/testsuite/ld-riscv-elf/gp-hidden-ver-64.rd Normal file
View File

@ -0,0 +1,6 @@
Relocation section '\.rela\.dyn' at offset .* contains 2 entries:
*Offset * Info * Type * Sym\. *Value * Sym\. *Name \+ Addend
# This must be an absolute relocation, there must not be a _gp reference.
[0-9a-f]+ * 0+03 * R_RISCV_RELATIVE * [0-9a-f]+
[0-9a-f]+ * [0-9a-f]+02 * R_RISCV_64 * [0-9a-f]+ * bar \+ 0

6
ld/testsuite/ld-riscv-elf/gp-hidden-ver.rd Normal file
View File

@ -0,0 +1,6 @@
Relocation section '\.rela\.dyn' at offset .* contains 2 entries:
*Offset * Info * Type * Sym\. *Value * Sym\. *Name \+ Addend
# This must be an absolute relocation, there must not be a _gp reference.
[0-9a-f]+ * 0+03 * R_RISCV_RELATIVE * [0-9a-f]+
[0-9a-f]+ * [0-9a-f]+01 * R_RISCV_32 * [0-9a-f]+ * bar \+ 0

7
ld/testsuite/ld-riscv-elf/gp-hidden-ver.s Normal file
View File

@ -0,0 +1,7 @@
.data
.globl foo
.type foo, @object
foo:
.dc.a bar
.dc.a __global_pointer$
.size foo, . - foo

1
ld/testsuite/ld-riscv-elf/gp-hidden-ver.ver Normal file
View File

@ -0,0 +1 @@
{ global: foo; local: *; };

4
ld/testsuite/ld-riscv-elf/gp-hidden.rd Normal file
View File

@ -0,0 +1,4 @@
Relocation section '\.rela\.dyn' at offset .* contains 1 entry:
*Offset * Info * Type * Sym\. *Value * Sym\. *Name \+ Addend
[0-9a-f]+ * [0-9a-f]+01 * R_RISCV_32 * [0-9a-f]+ * foo \+ 0

7
ld/testsuite/ld-riscv-elf/gp-hidden.s Normal file
View File

@ -0,0 +1,7 @@
.data
.globl blah
.type blah, @object
blah:
.dc.a foo
.dc.a __global_pointer$
.size blah, . - blah

9
ld/testsuite/ld-riscv-elf/gp-hidden.sd Normal file
View File

@ -0,0 +1,9 @@
Symbol table '.dynsym' contains [0-9]+ entries:
* Num: * Value * Size * Type * Bind * Vis * Ndx * Name
#...
Symbol table '.symtab' contains [0-9]+ entries:
* Num: * Value * Size * Type * Bind * Vis * Ndx * Name
#...
* [0-9a-f]+: * [0-9a-f]+ * 0 * NOTYPE * LOCAL * DEFAULT .* __global_pointer\$
#pass

34
ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
View File

@ -19,6 +19,38 @@
# MA 02110-1301, USA.
#
if [istarget "riscv-*-*"] {
if [istarget "riscv*-*-*"] {
run_dump_test "c-lui"
set abis { rv32gc ilp32 elf32lriscv rv64gc lp64 elf64lriscv }
foreach { arch abi emul } $abis {
# This checks whether our linker scripts get the scope of
# __global_pointer$ right, and thus must therefore use default scripts.
set suff64 [string map {ilp32 "" lp64 -64} $abi]
run_ld_link_tests [list \
[list "gp scope test ($abi shared library)" \
"-m$emul -shared" "" \
"-march=$arch -mabi=$abi -fpic" \
{ gp-hidden-lib.s } \
[list \
"readelf --relocs gp-hidden-lib.rd" \
"readelf --syms gp-hidden.sd"] \
"gp-hidden-lib-${abi}.so"] \
[list "gp scope test ($abi versioned lib)" \
"-m$emul -shared -version-script gp-hidden-ver.ver tmpdir/gp-hidden-lib-${abi}.so" "" \
"-march=$arch -mabi=$abi -fpic" \
{ gp-hidden-ver.s } \
[list \
"readelf --relocs gp-hidden-ver${suff64}.rd" \
"readelf --syms gp-hidden.sd"] \
"gp-hidden-ver-${abi}.so"] \
[list "gp scope test ($abi executable)" \
"-m$emul -e 0 -rpath-link . tmpdir/gp-hidden-ver-${abi}.so" "" \
"-march=$arch -mabi=$abi" \
{gp-hidden.s} \
[list \
"readelf --relocs gp-hidden${suff64}.rd" \
"readelf --syms gp-hidden.sd"]\
"gp-hidden-${abi}"]]
}
}