Fix an illegal memory access when trying to copy an ELF binary with corrupt section symbols.

PR 23113
	* elf.c (ignore_section_sym): Check for the output_section pointer
	being NULL before dereferencing it.
This commit is contained in:
Nick Clifton 2018-04-24 16:57:04 +01:00
parent aa4a8c2a2a
commit db0c309f40
2 changed files with 12 additions and 1 deletions

View File

@ -1,5 +1,9 @@
2018-04-24 Nick Clifton <nickc@redhat.com>
PR 23113
* elf.c (ignore_section_sym): Check for the output_section pointer
being NULL before dereferencing it.
PR 23110
* peXXigen.c (_bfd_XX_bfd_copy_private_bfd_data_common): Check for
a negative PE_DEBUG_DATA size before iterating over the debug data.

View File

@ -4022,15 +4022,22 @@ ignore_section_sym (bfd *abfd, asymbol *sym)
{
elf_symbol_type *type_ptr;
if (sym == NULL)
return FALSE;
if ((sym->flags & BSF_SECTION_SYM) == 0)
return FALSE;
if (sym->section == NULL)
return TRUE;
type_ptr = elf_symbol_from (abfd, sym);
return ((type_ptr != NULL
&& type_ptr->internal_elf_sym.st_shndx != 0
&& bfd_is_abs_section (sym->section))
|| !(sym->section->owner == abfd
|| (sym->section->output_section->owner == abfd
|| (sym->section->output_section != NULL
&& sym->section->output_section->owner == abfd
&& sym->section->output_offset == 0)
|| bfd_is_abs_section (sym->section)));
}