OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

A few comment cleanups

Browse Source 
I stumbled upon a few comments that I think are outdated.

Comment for elfread.c (elf_symfile_init): As far as history goes in git,
I don't see anything related to that.

Comment for elfread.c (elf_symfile_read): References a parameter that was
removed in 1999.

Comment for struct sym_fns/sym_offsets: References a parameter that was
changed in 1999.

gdb/ChangeLog:

	* elfread.c (elf_symfile_init): Remove stale comment.
	(elf_symfile_read): Same.
	* symfile.h (struct sym_fns): Same.
This commit is contained in:
Simon Marchi 2014-12-18 11:39:44 -05:00
parent 1bab73830f
commit db7a9bcd53
3 changed files with 12 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2014-12-18 Simon Marchi <simon.marchi@ericsson.com>
* elfread.c (elf_symfile_init): Remove stale comment.
(elf_symfile_read): Same.
* symfile.h (struct sym_fns): Same.
2014-12-18 Nigel Stephens <nigel@mips.com>
Maciej W. Rozycki <macro@codesourcery.com>

13
gdb/elfread.c
View File

@ -1236,10 +1236,6 @@ elf_read_minimal_symbols (struct objfile *objfile, int symfile_flags,
We have been initialized by a call to elf_symfile_init, which
currently does nothing.
SECTION_OFFSETS is a set of offsets to apply to relocate the symbols
in each section. We simplify it down to a single offset for all
symbols. FIXME.
This function only does the minimum work necessary for letting the
user "name" things symbolically; it does not read the entire symtab.
Instead, it reads the external and static symbols and puts them in partial
@ -1418,14 +1414,7 @@ elf_symfile_finish (struct objfile *objfile)
dwarf2_free_objfile (objfile);
}
/* ELF specific initialization routine for reading symbols.
It is passed a pointer to a struct sym_fns which contains, among other
things, the BFD for the file whose symbols are being read, and a slot for
a pointer to "private data" which we can fill with goodies.
For now at least, we have nothing in particular to do, so this function is
just a stub. */
/* ELF specific initialization routine for reading symbols. */
static void
elf_symfile_init (struct objfile *objfile)

10
gdb/symfile.h
View File

@ -353,12 +353,12 @@ struct sym_fns
void (*sym_finish) (struct objfile *);
/* This function produces a file-dependent section_offsets
structure, allocated in the objfile's storage, and based on the
parameter. The parameter is currently a CORE_ADDR (FIXME!) for
backward compatibility with the higher levels of GDB. It should
probably be changed to a string, where NULL means the default,
and others are parsed in a file dependent way. */
structure, allocated in the objfile's storage.
The section_addr_info structure contains the offset of loadable and
allocated sections, relative to the absolute offsets found in the BFD. */
void (*sym_offsets) (struct objfile *, const struct section_addr_info *);