OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gdb: Disable -Werror for -Wmaybe-uninitialized

Browse Source 
Newer GCCs are triggering false-positive -Wmaybe-uninitialized
warnings around code that uses gdb::optional:
  https://sourceware.org/ml/gdb-patches/2017-05/msg00118.html

Using std::optional wouldn't help, it triggers the same warnings:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80635

Initializing the variables to quiet the warning would defeat the
purpose of gdb::optional.  Making the optional ctor memset its storage
would be a pessimization.  Wrapping gdb::optional's internals with
"#pragma GCC diagnostic push/ignored/pop" doesn't work, we'd have to
wrap uses of gdb::optional instead, which I think would get unwieldy
and ugly as we start using gdb::optional more and more.

The -Wmaybe-uninitialized warning is documented as producing false
positives (unlike -Wuninialized), so until we find a better
workaround, disable -Werror for this warning.  You'll still see the
warning when building gdb, but it won't cause a build failure.

Tested by building with gcc 4.8.5, 5.3.1, and gcc trunk (20170428).

gdb/ChangeLog:
2017-05-05  Pedro Alves  <palves@redhat.com>

	* warning.m4 (build_warnings): Add -Wno-error=maybe-uninitialized.
	* configure: Regenerate.

gdb/gdbserver/ChangeLog:
2017-05-05  Pedro Alves  <palves@redhat.com>

	* configure: Regenerate.
This commit is contained in:
Pedro Alves 2017-05-05 01:03:28 +01:00
parent 323449189c
commit e13cb306f0
5 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2017-05-05 Pedro Alves <palves@redhat.com>
* warning.m4 (build_warnings): Add -Wno-error=maybe-uninitialized.
* configure: Regenerate.
2017-05-04 Pedro Alves <palves@redhat.com>
* Makefile.in (SFILES): Add progspace-and-thread.c.

2
gdb/configure vendored
View File

@ -15108,7 +15108,7 @@ build_warnings="-Wall -Wpointer-arith \
-Wno-unused -Wunused-value -Wunused-function \
-Wno-switch -Wno-char-subscripts \
-Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable \
-Wno-sign-compare -Wno-narrowing"
-Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized"
# Enable -Wno-format by default when using gcc on mingw since many
# GCC versions complain about %I64.

4
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,7 @@
2017-05-05 Pedro Alves <palves@redhat.com>
* configure: Regenerate.
2017-05-03 Sergio Durigan Junior <sergiodj@redhat.com>
* configure: Regenerate.

2
gdb/gdbserver/configure vendored
View File

@ -7148,7 +7148,7 @@ build_warnings="-Wall -Wpointer-arith \
-Wno-unused -Wunused-value -Wunused-function \
-Wno-switch -Wno-char-subscripts \
-Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable \
-Wno-sign-compare -Wno-narrowing"
-Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized"
# Enable -Wno-format by default when using gcc on mingw since many
# GCC versions complain about %I64.

2
gdb/warning.m4
View File

@ -40,7 +40,7 @@ build_warnings="-Wall -Wpointer-arith \
-Wno-unused -Wunused-value -Wunused-function \
-Wno-switch -Wno-char-subscripts \
-Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable \
-Wno-sign-compare -Wno-narrowing"
-Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized"
# Enable -Wno-format by default when using gcc on mingw since many
# GCC versions complain about %I64.