OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix python-selftest.exp failure with gdbserver 

python-selftest.exp fails with an error when using the
native-gdbserver.exp board.

The bug is that the selftest code doesn't work in this situation.  It
never has.

This patch fixes the problem by pushing the needed check into
do_self_tests.  This helps prevent the problem in the future.

	* lib/selftest-support.exp (do_self_tests): Reject remote or
	non-native targets.
	* gdb.gdb/complaints.exp: Remove check.
	* gdb.gdb/observer.exp: Remove check.
	* gdb.gdb/xfullpath.exp: Remove check.
	* gdb.gdb/complaints.exp: Remove check.
This commit is contained in:
Tom Tromey 2013-06-18 14:12:09 +00:00
parent 9f9b731fe3
commit e379b39141
5 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,12 @@
2013-06-18 Tom Tromey <tromey@redhat.com>
* lib/selftest-support.exp (do_self_tests): Reject remote or
non-native targets.
* gdb.gdb/complaints.exp: Remove check.
* gdb.gdb/observer.exp: Remove check.
* gdb.gdb/xfullpath.exp: Remove check.
* gdb.gdb/complaints.exp: Remove check.
2013-06-07 Pedro Alves <palves@redhat.com>
* boards/native-extended-gdbserver.exp: Remove semicolon.

5
gdb/testsuite/gdb.gdb/complaints.exp
View File

@ -19,11 +19,6 @@
load_lib selftest-support.exp
# are we on a target board
if { [is_remote target] || ![isnative] } then {
return
}
if [target_info exists gdb,noinferiorio] {
verbose "Skipping because of no inferiorio capabilities."
return

5
gdb/testsuite/gdb.gdb/observer.exp
View File

@ -18,11 +18,6 @@
load_lib selftest-support.exp
# are we on a target board
if { [is_remote target] || ![isnative] } then {
return
}
proc attach_first_observer { message } {
gdb_test_no_output "set \$first_obs = observer_attach_test_notification (&observer_test_first_notification_function)" \
"$message; attach first observer"

5
gdb/testsuite/gdb.gdb/xfullpath.exp
View File

@ -18,11 +18,6 @@
load_lib selftest-support.exp
# are we on a target board
if { [is_remote target] || ![isnative] } then {
return
}
proc test_with_self {} {
# A file which contains a directory prefix
gdb_test "print gdb_realpath (\"./xfullpath.exp\")" \

5
gdb/testsuite/lib/selftest-support.exp
View File

@ -119,6 +119,11 @@ proc selftest_setup { executable function } {
proc do_self_tests {function body} {
global GDB tool
# Are we on a target board.
if { [is_remote target] || ![isnative] } then {
return
}
# Run the test with self. Copy the file executable file in case
# this OS doesn't like to edit its own text space.