OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix cleanup handling in macho_symfile_read

Browse Source 
macho_symfile_read leaks a cleanup by assigning to 'back_to' too late.

	* machoread.c (macho_symfile_read): Assign first cleanup to
	'back_to'.
This commit is contained in:
Tom Tromey 2013-05-30 17:06:31 +00:00
parent 4bbc010a2d
commit e42d0aa5ba
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2013-05-30 Tom Tromey <tromey@redhat.com>
* machoread.c (macho_symfile_read): Assign first cleanup to
'back_to'.
2013-05-30 Tom Tromey <tromey@redhat.com>
* m32r-rom.c (m32r_load): Call do_cleanups at all returns.

4
gdb/machoread.c
View File

@ -871,10 +871,10 @@ macho_symfile_read (struct objfile *objfile, int symfile_flags)
struct cleanup *back_to;
symbol_table = (asymbol **) xmalloc (storage_needed);
make_cleanup (xfree, symbol_table);
back_to = make_cleanup (xfree, symbol_table);
init_minimal_symbol_collection ();
back_to = make_cleanup_discard_minimal_symbols ();
make_cleanup_discard_minimal_symbols ();
symcount = bfd_canonicalize_symtab (objfile->obfd, symbol_table);