OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Change tui_show_frame_info to return bool 

This changes tui_show_frame_info to return bool.

gdb/ChangeLog
2019-12-20  Tom Tromey  <tom@tromey.com>

	* tui/tui-stack.h (tui_show_frame_info): Return bool.
	* tui/tui-stack.c (tui_show_frame_info): Return bool.
	* tui/tui-hooks.c (tui_refresh_frame_and_register_information):
	Update.

Change-Id: Id1374f04f919c30a9f50c1beeb70cbc10b9a8f3b
This commit is contained in:
Tom Tromey 2019-11-13 16:33:21 -07:00
parent fc9d2d724f
commit eb390f499b
4 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2019-12-20 Tom Tromey <tom@tromey.com>
* tui/tui-stack.h (tui_show_frame_info): Return bool.
* tui/tui-stack.c (tui_show_frame_info): Return bool.
* tui/tui-hooks.c (tui_refresh_frame_and_register_information):
Update.
2019-12-20 Tom Tromey <tom@tromey.com>
PR tui/18932:

2
gdb/tui/tui-hooks.c
View File

@ -133,7 +133,7 @@ tui_refresh_frame_and_register_information ()
/* Display the frame position (even if there is no symbols or
the PC is not known). */
int frame_info_changed_p = tui_show_frame_info (fi);
bool frame_info_changed_p = tui_show_frame_info (fi);
/* Refresh the register window if it's visible. */
if (tui_is_window_visible (DATA_WIN)

16
gdb/tui/tui-stack.c
View File

@ -301,10 +301,10 @@ tui_update_locator_fullname (struct symtab *symtab)
/* Function to print the frame information for the TUI. The windows are
refreshed only if frame information has changed since the last refresh.
Return 1 if frame information has changed (and windows subsequently
refreshed), 0 otherwise. */
Return true if frame information has changed (and windows
subsequently refreshed), false otherwise. */
int
bool
tui_show_frame_info (struct frame_info *fi)
{
bool locator_changed_p;
@ -329,15 +329,13 @@ tui_show_frame_info (struct frame_info *fi)
not changed. If frame information has not changed, then the windows'
contents will not change. So don't bother refreshing the windows. */
if (!locator_changed_p)
return 0;
return false;
for (struct tui_source_window_base *win_info : tui_source_windows ())
{
win_info->maybe_update (fi, sal);
win_info->update_exec_info ();
}
return 1;
}
else
{
@ -346,13 +344,13 @@ tui_show_frame_info (struct frame_info *fi)
locator_changed_p = locator->set_locator_info (NULL, sal, "");
if (!locator_changed_p)
return 0;
return false;
for (struct tui_source_window_base *win_info : tui_source_windows ())
win_info->erase_source_content ();
return 1;
}
return true;
}
void

2
gdb/tui/tui-stack.h
View File

@ -78,6 +78,6 @@ private:
extern void tui_update_locator_fullname (struct symtab *symtab);
extern void tui_show_locator_content (void);
extern int tui_show_frame_info (struct frame_info *);
extern bool tui_show_frame_info (struct frame_info *);
#endif /* TUI_TUI_STACK_H */