OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

2003-02-04 David Carlton <carlton@math.stanford.edu>

Browse Source 
* objfiles.c (allocate_objfile): Always set name.  Add comment at
	start of function.
	* jv-lang.c (get_dynamics_objfile): Add comment.
This commit is contained in:
David Carlton 2003-02-04 21:55:26 +00:00
parent 406fc7fbeb
commit eb9a305d40
3 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2003-02-04 David Carlton <carlton@math.stanford.edu>
* objfiles.c (allocate_objfile): Always set name. Add comment at
start of function.
* jv-lang.c (get_dynamics_objfile): Add comment.
2003-02-04 David Carlton <carlton@math.stanford.edu>
* symtab.h (SYMBOL_LINKAGE_NAME): Delete.

6
gdb/jv-lang.c
View File

@ -68,6 +68,12 @@ static struct objfile *dynamics_objfile = NULL;
static struct type *java_link_class_type (struct type *, struct value *);
/* FIXME: carlton/2003-02-04: This is the main or only caller of
allocate_objfile with first argument NULL; as a result, this code
breaks every so often. Somebody should write a test case that
exercises GDB in various ways (e.g. something involving loading a
dynamic library) after this code has been called. */
static struct objfile *
get_dynamics_objfile (void)
{

13
gdb/objfiles.c
View File

@ -150,6 +150,15 @@ build_objfile_section_table (struct objfile *objfile)
OBJF_SHARED are simply copied through to the new objfile flags
member. */
/* NOTE: carlton/2003-02-04: This function is called with args NULL, 0
by jv-lang.c, to create an artificial objfile used to hold
information about dynamically-loaded Java classes. Unfortunately,
that branch of this function doesn't get tested very frequently, so
it's prone to breakage. (E.g. at one time the name was set to NULL
in that situation, which broke a loop over all names in the dynamic
library loader.) If you change this function, please try to leave
things in a consistent state even if abfd is NULL. */
struct objfile *
allocate_objfile (bfd *abfd, int flags)
{
@ -313,6 +322,10 @@ allocate_objfile (bfd *abfd, int flags)
objfile->name, bfd_errmsg (bfd_get_error ()));
}
}
else
{
objfile->name = "<<anonymous objfile>>";
}
/* Initialize the section indexes for this objfile, so that we can
later detect if they are used w/o being properly assigned to. */