OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix PR 12028: "GDB crashes on a double free during overload resolution "

Browse Source 
2010-09-22  Sami Wagiaalla  <swagiaal@redhat.com>

	PR C++/12028
	* valops.c (find_oload_champ_namespace_loop): removed incorrect
	'old_cleanups' reassignment.

2010-09-22  Sami Wagiaalla  <swagiaal@redhat.com>

	* gdb.cp/pr12028.cc: New.
	* gdb.cp/pr12028.exp: New.
This commit is contained in:
Sami Wagiaalla 2010-09-22 15:48:59 +00:00
parent e4b0fe2fa7
commit ec32282347
5 changed files with 62 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2010-09-22 Sami Wagiaalla <swagiaal@redhat.com>
PR C++/12028
* valops.c (find_oload_champ_namespace_loop): removed incorrect
'old_cleanups' reassignment.
2010-09-16 Jan Kratochvil <jan.kratochvil@redhat.com>
* charset.c (wchar_iterate) <EILSEQ>: Return any possibly converted

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2010-09-22 Sami Wagiaalla <swagiaal@redhat.com>
* gdb.cp/pr12028.cc: New.
* gdb.cp/pr12028.exp: New.
2010-09-16 Phil Muldoon <pmuldoon@redhat.com>
Jan Kratochvil <jan.kratochvil@redhat.com>

21
gdb/testsuite/gdb.cp/pr12028.cc Normal file
View File

@ -0,0 +1,21 @@
class A{};
class B{};
class C: public B {};
namespace D{
int foo (A) { return 11; }
int foo (C) { return 12; }
}
int main()
{
A a;
B b;
C c;
D::foo (a);
// D::foo (b);
D::foo (c);
return 0;
}

29
gdb/testsuite/gdb.cp/pr12028.exp Normal file
View File

@ -0,0 +1,29 @@
# Copyright 2008 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
set testfile pr12028
set srcfile ${testfile}.cc
if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} {debug c++}] } {
return -1
}
############################################
if ![runto_main] then {
perror "couldn't run to breakpoint main"
continue
}
gdb_test "p D::foo(b)" "Cannot resolve function foo to any overloaded instance"

2
gdb/valops.c
View File

@ -2713,7 +2713,7 @@ find_oload_champ_namespace_loop (struct type **arg_types, int nargs,
function symbol to start off with.) */
old_cleanups = make_cleanup (xfree, *oload_syms);
old_cleanups = make_cleanup (xfree, *oload_champ_bv);
make_cleanup (xfree, *oload_champ_bv);
new_namespace = alloca (namespace_len + 1);
strncpy (new_namespace, qualified_name, namespace_len);
new_namespace[namespace_len] = '\0';