OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove a double free in the BFD library triggered when parsing a corrupt file. 

PR 25687
	* elf.c (_bfd_elf_slurp_secondary_reloc_section): Remove redundant
	free.  Add free on another failure path.
This commit is contained in:
Nick Clifton 2020-03-17 16:45:07 +00:00
parent a225c9a869
commit ecbbbdba71
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bfd/ChangeLog
View File

@ -1,3 +1,9 @@
2020-03-17 Nick Clifton <nickc@redhat.com>
PR 25687
* elf.c (_bfd_elf_slurp_secondary_reloc_section): Remove redundant
free. Add free on another failure path.
2020-03-16 Alan Modra <amodra@gmail.com>
PR 25675

4
bfd/elf.c
View File

@ -12454,6 +12454,7 @@ _bfd_elf_slurp_secondary_reloc_section (bfd * abfd,
reloc_count = NUM_SHDR_ENTRIES (hdr);
if (_bfd_mul_overflow (reloc_count, sizeof (arelent), & amt))
{
free (native_relocs);
bfd_set_error (bfd_error_file_too_big);
result = FALSE;
continue;
@ -12472,7 +12473,8 @@ _bfd_elf_slurp_secondary_reloc_section (bfd * abfd,
!= hdr->sh_size))
{
free (native_relocs);
free (internal_relocs);
/* The internal_relocs will be freed when
the memory for the bfd is released. */
result = FALSE;
continue;
}