OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improve warning messages for la/dla 

gas/

	* config/tc-mips.c (macro): State the recommended way of creating
	32-bit or 64-bit addresses.

gas/testsuite/

	* gas/mips/dla-warn.l: New file.
	* gas/mips/dla-warn.s: New file.
	* gas/mips/la-warn.l: New file.
	* gas/mips/la-warn.s: New file.
	* gas/mips/mips.exp: Run new tests.
This commit is contained in:
Matthew Fortune 2015-04-23 20:09:13 +01:00
parent a100d66fb4
commit ece794d9c4
8 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gas/ChangeLog
View File

@ -1,3 +1,8 @@
2015-04-23 Matthew Fortune <matthew.fortune@imgtec.com>
* config/tc-mips.c (macro): State the recommended way of creating
32-bit or 64-bit addresses.
2015-04-23 Jan Beulich <jbeulich@suse.com>
* config/tc-i386.c (match_mem_size): Also allow no size

6
gas/config/tc-mips.c
View File

@ -10331,10 +10331,12 @@ macro (struct mips_cl_insn *ip, char *str)
breg = op[2];
if (dbl && GPR_SIZE == 32)
as_warn (_("dla used to load 32-bit register"));
as_warn (_("dla used to load 32-bit register; recommend using la "
"instead"));
if (!dbl && HAVE_64BIT_OBJECTS)
as_warn (_("la used to load 64-bit address"));
as_warn (_("la used to load 64-bit address; recommend using dla "
"instead"));
if (small_offset_p (0, align, 16))
{

8
gas/testsuite/ChangeLog
View File

@ -1,3 +1,11 @@
2015-04-23 Matthew Fortune <matthew.fortune@imgtec.com>
* gas/mips/dla-warn.l: New file.
* gas/mips/dla-warn.s: New file.
* gas/mips/la-warn.l: New file.
* gas/mips/la-warn.s: New file.
* gas/mips/mips.exp: Run new tests.
2015-04-23 Matthew Fortune <matthew.fortune@imgtec.com>
* gas/mips/mips.exp: Require o32 for r6-branch-constraints.

2
gas/testsuite/gas/mips/dla-warn.l Normal file
View File

@ -0,0 +1,2 @@
.*: Assembler messages:
.*:1: Warning: dla used to load 32-bit register; recommend using la instead

1
gas/testsuite/gas/mips/dla-warn.s Normal file
View File

@ -0,0 +1 @@
dla $2, foo

2
gas/testsuite/gas/mips/la-warn.l Normal file
View File

@ -0,0 +1,2 @@
.*: Assembler messages:
.*:1: Warning: la used to load 64-bit address; recommend using dla instead

1
gas/testsuite/gas/mips/la-warn.s Normal file
View File

@ -0,0 +1 @@
la $2, foo

4
gas/testsuite/gas/mips/mips.exp
View File

@ -1223,8 +1223,12 @@ if { [istarget mips*-*-vxworks*] } {
run_list_test "ase-errors-4" "-mabi=o64 -march=mips3" "ASE errors (4)"
run_dump_test_arches "la-reloc" [mips_arch_list_matching mips1]
run_list_test "dla-warn" "-mabi=32 -march=mips3" \
"DLA with 32-bit addresses"
if { $has_newabi } {
run_dump_test_arches "dla-reloc" [mips_arch_list_matching mips3]
run_list_test "la-warn" "-mabi=64 -march=mips3" \
"LA with 64-bit addresses"
}
# Start with MIPS II to avoid load delay nops.