Split rank_one_type_parm_func from rank_one_type

gdb/ChangeLog:

	* gdbtypes.c (rank_one_type_parm_func): New function extracted
	from...
	(rank_one_type): ... this.
This commit is contained in:
Simon Marchi 2019-03-08 10:15:08 -05:00
parent b9f4512f25
commit f1f832d6cd
2 changed files with 21 additions and 7 deletions

View File

@ -1,3 +1,9 @@
2019-03-08 Simon Marchi <simon.marchi@efficios.com>
* gdbtypes.c (rank_one_type_parm_func): New function extracted
from...
(rank_one_type): ... this.
2019-03-08 Simon Marchi <simon.marchi@efficios.com>
* gdbtypes.c (rank_one_type_parm_array): New function extracted

View File

@ -3873,6 +3873,20 @@ rank_one_type_parm_array (struct type *parm, struct type *arg, struct value *val
}
}
/* rank_one_type helper for when PARM's type code is TYPE_CODE_FUNC. */
static struct rank
rank_one_type_parm_func (struct type *parm, struct type *arg, struct value *value)
{
switch (TYPE_CODE (arg))
{
case TYPE_CODE_PTR: /* funcptr -> func */
return rank_one_type (parm, TYPE_TARGET_TYPE (arg), NULL);
default:
return INCOMPATIBLE_TYPE_BADNESS;
}
}
/* Compare one type (PARM) for compatibility with another (ARG).
* PARM is intended to be the parameter type of a function; and
* ARG is the supplied argument's type. This function tests if
@ -3967,13 +3981,7 @@ rank_one_type (struct type *parm, struct type *arg, struct value *value)
case TYPE_CODE_ARRAY:
return rank_one_type_parm_array (parm, arg, value);
case TYPE_CODE_FUNC:
switch (TYPE_CODE (arg))
{
case TYPE_CODE_PTR: /* funcptr -> func */
return rank_one_type (parm, TYPE_TARGET_TYPE (arg), NULL);
default:
return INCOMPATIBLE_TYPE_BADNESS;
}
return rank_one_type_parm_func (parm, arg, value);
case TYPE_CODE_INT:
switch (TYPE_CODE (arg))
{