OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Cast the pointer assigned to ss_sp to char *.

Browse Source 
FreeBSD versions older than 11.0 use char * as the type of ss_sp in
stack_t instead of the standards-defined void *.  C++ allows a char *
pointer to be converted to a void *, so it is safe to cast the return
value of xmalloc to char * if ss_sp is either a char * or void *.
Just always use the cast to char * since that is less ugly than having
to add a special case.

gdb/ChangeLog:

	* main.c (setup_alternate_signal_stack): Cast to char *.
This commit is contained in:
John Baldwin 2016-04-19 13:51:05 -07:00
parent 537aefaf18
commit f39c07acc8
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2016-04-19 John Baldwin <jhb@FreeBSD.org>
* main.c (setup_alternate_signal_stack): Cast to char *.
2016-04-19 Doug Evans <xdje42@gmail.com>
* symmisc.c (dump_symtab_1, dump_symtab): Delete arg objfile.

4
gdb/main.c
View File

@ -297,7 +297,9 @@ setup_alternate_signal_stack (void)
#ifdef HAVE_SIGALTSTACK
stack_t ss;
ss.ss_sp = xmalloc (SIGSTKSZ);
/* FreeBSD versions older than 11.0 use char * for ss_sp instead of
void *. This cast works with both types. */
ss.ss_sp = (char *) xmalloc (SIGSTKSZ);
ss.ss_size = SIGSTKSZ;
ss.ss_flags = 0;