OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gdbserver: include aarch32/aarch64 header file in corresponding source file 

When building gdbserver for an aarch64 host with -Wmissing-declarations,
I see:

  CXX    linux-aarch32-tdesc.o
/home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch32-tdesc.c:28:1: error: no previous declaration for 'const target_desc* aarch32_linux_read_description()' [-Werror=missing-declarations]
 aarch32_linux_read_description ()
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch32-tdesc.c:43:1: error: no previous declaration for 'bool is_aarch32_linux_description(const target_desc*)' [-Werror=missing-declarations]
 is_aarch32_linux_description (const target_desc *tdesc)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

  CXX    linux-aarch64-tdesc.o
/home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch64-tdesc.c:32:1: error: no previous declaration for 'const target_desc* aarch64_linux_read_description(uint64_t, bool)' [-Werror=missing-declarations]
 aarch64_linux_read_description (uint64_t vq, bool pauth_p)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fix it by including linux-aarch32-tdesc.h in linux-aarch32-tdesc.c and
linux-aarch64-tdesc.h in linux-aarch64-tdesc.c.

gdb/gdbserver/ChangeLog:

	* linux-aarch32-tdesc.c: Include linux-aarch32-tdesc.h.
	* linux-aarch64-tdesc.c: Include linux-aarch64-tdesc.h.
This commit is contained in:
Simon Marchi 2020-01-12 11:06:21 -05:00
parent 4ec89149dd
commit f5df0b5f08
3 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,8 @@
2020-01-12 Simon Marchi <simon.marchi@polymtl.ca>
* linux-aarch32-tdesc.c: Include linux-aarch32-tdesc.h.
* linux-aarch64-tdesc.c: Include linux-aarch64-tdesc.h.
2020-01-10 Pedro Alves <palves@redhat.com>
* fork-child.c (post_fork_inferior): Pass target down to

3
gdb/gdbserver/linux-aarch32-tdesc.c
View File

@ -16,6 +16,9 @@
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "server.h"
#include "linux-aarch32-tdesc.h"
#include "tdesc.h"
#include "arch/aarch32.h"
#include <inttypes.h>

3
gdb/gdbserver/linux-aarch64-tdesc.c
View File

@ -18,6 +18,9 @@
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "server.h"
#include "linux-aarch64-tdesc.h"
#include "tdesc.h"
#include "arch/aarch64.h"
#include "linux-aarch32-low.h"