objcopy add-symbol uninitialised struct
* objcopy.c: Formatting, whitespace throughout. (copy_main): Init newsym->othersym. (parse_symflags): Make len a size_t. Adjust uses.
This commit is contained in:
parent
c12969f8b5
commit
f7433f011e
|
@ -1,3 +1,9 @@
|
|||
2016-05-31 Alan Modra <amodra@gmail.com>
|
||||
|
||||
* objcopy.c: Formatting, whitespace throughout.
|
||||
(copy_main): Init newsym->othersym.
|
||||
(parse_symflags): Make len a size_t. Adjust uses.
|
||||
|
||||
2016-05-25 H.J. Lu <hongjiu.lu@intel.com>
|
||||
|
||||
PR binutils/14625
|
||||
|
|
|
@ -757,7 +757,7 @@ parse_symflags (const char *s, char **other)
|
|||
{
|
||||
flagword ret;
|
||||
const char *snext;
|
||||
int len;
|
||||
size_t len;
|
||||
|
||||
ret = BSF_NO_FLAGS;
|
||||
|
||||
|
@ -772,12 +772,14 @@ parse_symflags (const char *s, char **other)
|
|||
++snext;
|
||||
}
|
||||
|
||||
#define PARSE_FLAG(fname,fval) \
|
||||
else if (len == (int) sizeof fname - 1 && strncasecmp (fname, s, len) == 0) \
|
||||
#define PARSE_FLAG(fname, fval) \
|
||||
else if (len == sizeof fname - 1 \
|
||||
&& strncasecmp (fname, s, len) == 0) \
|
||||
ret |= fval
|
||||
|
||||
#define PARSE_OTHER(fname,fval) \
|
||||
else if (len >= (int) sizeof fname && strncasecmp (fname, s, sizeof fname - 1) == 0) \
|
||||
#define PARSE_OTHER(fname, fval) \
|
||||
else if (len >= sizeof fname \
|
||||
&& strncasecmp (fname, s, sizeof fname - 1) == 0) \
|
||||
fval = xstrndup (s + sizeof fname - 1, len - sizeof fname + 1)
|
||||
|
||||
if (0) ;
|
||||
|
@ -1333,9 +1335,9 @@ need_sym_before (struct addsym_node **node, const char *sym)
|
|||
static asymbol *
|
||||
create_new_symbol (struct addsym_node *ptr, bfd *obfd)
|
||||
{
|
||||
asymbol *sym = bfd_make_empty_symbol(obfd);
|
||||
asymbol *sym = bfd_make_empty_symbol (obfd);
|
||||
|
||||
bfd_asymbol_name(sym) = ptr->symdef;
|
||||
bfd_asymbol_name (sym) = ptr->symdef;
|
||||
sym->value = ptr->symval;
|
||||
sym->flags = ptr->flags;
|
||||
if (ptr->section)
|
||||
|
@ -3141,7 +3143,7 @@ setup_section (bfd *ibfd, sec_ptr isection, void *obfdarg)
|
|||
/* All went well. */
|
||||
return;
|
||||
|
||||
loser:
|
||||
loser:
|
||||
status = 1;
|
||||
bfd_nonfatal_message (NULL, obfd, osection, err);
|
||||
}
|
||||
|
@ -4127,6 +4129,7 @@ copy_main (int argc, char *argv[])
|
|||
}
|
||||
|
||||
t = strchr (t + 1, ',');
|
||||
newsym->othersym = NULL;
|
||||
if (t)
|
||||
newsym->flags = parse_symflags (t+1, &newsym->othersym);
|
||||
else
|
||||
|
|
Loading…
Reference in New Issue