Add regcache raw_compare method

gdb/
	* common/common-regcache.h (raw_compare): New function.
	* regcache.c (regcache::raw_compare): Likewise.
	* regcache.h (regcache::raw_compare): New declaration.

gdbserver/
	* regcache.c (regcache::raw_compare): New function.
	* regcache.h (regcache::raw_compare): New declaration.
This commit is contained in:
Alan Hayward 2018-06-11 10:09:30 +01:00
parent 9c86188316
commit f868386e72
7 changed files with 50 additions and 0 deletions

View File

@ -1,3 +1,9 @@
2018-06-11 Alan Hayward <alan.hayward@arm.com>
* common/common-regcache.h (raw_compare): New function.
* regcache.c (regcache::raw_compare): Likewise.
* regcache.h (regcache::raw_compare): New declaration.
2018-06-11 Alan Hayward <alan.hayward@arm.com>
* common/common-regcache.h (reg_buffer_common): New structure.

View File

@ -75,6 +75,11 @@ struct reg_buffer_common
/* Collect register REGNUM from REGCACHE and store its contents in BUF. */
virtual void raw_collect (int regnum, void *buf) const = 0;
/* Compare the contents of the register stored in the regcache (ignoring the
first OFFSET bytes) to the contents of BUF (without any offset). Returns
true if the same. */
virtual bool raw_compare (int regnum, const void *buf, int offset) const = 0;
};
#endif /* COMMON_REGCACHE_H */

View File

@ -1,3 +1,8 @@
2018-06-11 Alan Hayward <alan.hayward@arm.com>
* regcache.c (regcache::raw_compare): New function.
* regcache.h (regcache::raw_compare): New declaration.
2018-06-11 Alan Hayward <alan.hayward@arm.com>
* regcache.c (new_register_cache): Use new.

View File

@ -502,3 +502,17 @@ regcache::get_register_status (int regnum) const
return REG_VALID;
#endif
}
/* See common/common-regcache.h. */
bool
regcache::raw_compare (int regnum, const void *buf, int offset) const
{
gdb_assert (buf != NULL);
const unsigned char *regbuf = register_data (this, regnum, 1);
int size = register_size (tdesc, regnum);
gdb_assert (size >= offset);
return (memcmp (buf, regbuf + offset, size - offset) == 0);
}

View File

@ -54,6 +54,9 @@ struct regcache : public reg_buffer_common
/* See common/common-regcache.h. */
void raw_collect (int regnum, void *buf) const override;
/* See common/common-regcache.h. */
bool raw_compare (int regnum, const void *buf, int offset) const override;
};
struct regcache *init_register_cache (struct regcache *regcache,

View File

@ -1079,6 +1079,20 @@ regcache::collect_regset (const struct regset *regset,
transfer_regset (regset, NULL, regnum, NULL, buf, size);
}
/* See common/common-regcache.h. */
bool
reg_buffer::raw_compare (int regnum, const void *buf, int offset) const
{
gdb_assert (buf != NULL);
assert_regnum (regnum);
const char *regbuf = (const char *) register_buffer (regnum);
size_t size = m_descr->sizeof_register[regnum];
gdb_assert (size >= offset);
return (memcmp (buf, regbuf + offset, size - offset) == 0);
}
/* Special handling for register PC. */

View File

@ -188,6 +188,9 @@ public:
virtual ~reg_buffer () = default;
/* See common/common-regcache.h. */
bool raw_compare (int regnum, const void *buf, int offset) const override;
protected:
/* Assert on the range of REGNUM. */
void assert_regnum (int regnum) const;