OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

constify maint.c

Browse Source 
This does a bit of constification in maint.c, making
print_bfd_section_info a bit cleaner in the process.

2014-07-24  Tom Tromey  <tromey@redhat.com>

	* maint.c (match_bfd_flags): Make "string" const.
	(print_bfd_section_info): Remove casts.
	(print_objfile_section_info): Make "string" const.
This commit is contained in:
Tom Tromey 2014-07-21 16:54:06 -06:00
parent 0d5f0dbeb0
commit fc4baa5e1f
2 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2014-07-24 Tom Tromey <tromey@redhat.com>
* maint.c (match_bfd_flags): Make "string" const.
(print_bfd_section_info): Remove casts.
(print_objfile_section_info): Make "string" const.
2014-07-24 Tom Tromey <tromey@redhat.com> 2014-07-24 Tom Tromey <tromey@redhat.com>
* inf-child.c (inf_child_open_target): Make "arg" const. * inf-child.c (inf_child_open_target): Make "arg" const.

13
gdb/maint.c
View File

@ -236,7 +236,7 @@ match_substring (const char *string, const char *substr)
} }
static int static int
match_bfd_flags (char *string, flagword flags) match_bfd_flags (const char *string, flagword flags)
{ {
if (flags & SEC_ALLOC) if (flags & SEC_ALLOC)
if (match_substring (string, "ALLOC")) if (match_substring (string, "ALLOC"))
@ -324,14 +324,15 @@ maint_print_section_info (const char *name, flagword flags,
static void static void
print_bfd_section_info (bfd *abfd, print_bfd_section_info (bfd *abfd,
asection *asect, asection *asect,
void *arg) void *datum)
{ {
flagword flags = bfd_get_section_flags (abfd, asect); flagword flags = bfd_get_section_flags (abfd, asect);
const char *name = bfd_section_name (abfd, asect); const char *name = bfd_section_name (abfd, asect);
const char *arg = datum;
if (arg == NULL || *((char *) arg) == '\0' if (arg == NULL || *arg == '\0'
|| match_substring ((char *) arg, name) || match_substring (arg, name)
|| match_bfd_flags ((char *) arg, flags)) || match_bfd_flags (arg, flags))
{ {
struct gdbarch *gdbarch = gdbarch_from_bfd (abfd); struct gdbarch *gdbarch = gdbarch_from_bfd (abfd);
int addr_size = gdbarch_addr_bit (gdbarch) / 8; int addr_size = gdbarch_addr_bit (gdbarch) / 8;
@ -348,7 +349,7 @@ print_bfd_section_info (bfd *abfd,
static void static void
print_objfile_section_info (bfd *abfd, print_objfile_section_info (bfd *abfd,
struct obj_section *asect, struct obj_section *asect,
char *string) const char *string)
{ {
flagword flags = bfd_get_section_flags (abfd, asect->the_bfd_section); flagword flags = bfd_get_section_flags (abfd, asect->the_bfd_section);
const char *name = bfd_section_name (abfd, asect->the_bfd_section); const char *name = bfd_section_name (abfd, asect->the_bfd_section);