OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

constify to_disconnect

Browse Source 
This constifies an parameter of to_disconnect and updates
target_disconnect as well.

2014-06-16  Tom Tromey  <tromey@redhat.com>

	* target.h (struct target_ops) <to_disconnect>: Make parameter
	const.
	(target_disconnect): Update.
	* target.c (target_disconnect): Make "args" const.
	* target-delegates.c: Rebuild.
	* remote.c (remote_disconnect): Update.
	* record.h (record_disconnect): Update.
	* record.c (record_disconnect): Update.
	* inf-child.c (inf_child_disconnect): Update.
This commit is contained in:
Tom Tromey 2014-06-06 13:26:53 -06:00
parent a30bf1f15c
commit fee354eeef
8 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gdb/ChangeLog
View File

@ -1,3 +1,15 @@
2014-06-16 Tom Tromey <tromey@redhat.com>
* target.h (struct target_ops) <to_disconnect>: Make parameter
const.
(target_disconnect): Update.
* target.c (target_disconnect): Make "args" const.
* target-delegates.c: Rebuild.
* remote.c (remote_disconnect): Update.
* record.h (record_disconnect): Update.
* record.c (record_disconnect): Update.
* inf-child.c (inf_child_disconnect): Update.
2014-06-16 Tom Tromey <tromey@redhat.com> 2014-06-16 Tom Tromey <tromey@redhat.com>
* target.h (struct target_ops) <to_rcmd>: Make "command" const. * target.h (struct target_ops) <to_rcmd>: Make "command" const.

2
gdb/inf-child.c
View File

@ -140,7 +140,7 @@ inf_child_open (char *arg, int from_tty)
/* Implement the to_disconnect target_ops method. */ /* Implement the to_disconnect target_ops method. */
static void static void
inf_child_disconnect (struct target_ops *target, char *args, int from_tty) inf_child_disconnect (struct target_ops *target, const char *args, int from_tty)
{ {
if (args != NULL) if (args != NULL)
error (_("Argument given to \"disconnect\".")); error (_("Argument given to \"disconnect\"."));

2
gdb/record.c
View File

@ -130,7 +130,7 @@ record_unpush (struct target_ops *t)
/* See record.h. */ /* See record.h. */
void void
record_disconnect (struct target_ops *t, char *args, int from_tty) record_disconnect (struct target_ops *t, const char *args, int from_tty)
{ {
gdb_assert (t->to_stratum == record_stratum); gdb_assert (t->to_stratum == record_stratum);

2
gdb/record.h
View File

@ -57,7 +57,7 @@ extern int record_read_memory (struct gdbarch *gdbarch,
extern void cmd_record_goto (char *arg, int from_tty); extern void cmd_record_goto (char *arg, int from_tty);
/* The default "to_disconnect" target method for record targets. */ /* The default "to_disconnect" target method for record targets. */
extern void record_disconnect (struct target_ops *, char *, int); extern void record_disconnect (struct target_ops *, const char *, int);
/* The default "to_detach" target method for record targets. */ /* The default "to_detach" target method for record targets. */
extern void record_detach (struct target_ops *, const char *, int); extern void record_detach (struct target_ops *, const char *, int);

2
gdb/remote.c
View File

@ -4347,7 +4347,7 @@ extended_remote_detach (struct target_ops *ops, const char *args, int from_tty)
/* Same as remote_detach, but don't send the "D" packet; just disconnect. */ /* Same as remote_detach, but don't send the "D" packet; just disconnect. */
static void static void
remote_disconnect (struct target_ops *target, char *args, int from_tty) remote_disconnect (struct target_ops *target, const char *args, int from_tty)
{ {
if (args) if (args)
error (_("Argument given to \"disconnect\" when remotely debugging.")); error (_("Argument given to \"disconnect\" when remotely debugging."));

4
gdb/target-delegates.c
View File

@ -28,14 +28,14 @@ tdefault_detach (struct target_ops *self, const char *arg1, int arg2)
} }
static void static void
delegate_disconnect (struct target_ops *self, char *arg1, int arg2) delegate_disconnect (struct target_ops *self, const char *arg1, int arg2)
{ {
self = self->beneath; self = self->beneath;
self->to_disconnect (self, arg1, arg2); self->to_disconnect (self, arg1, arg2);
} }
static void static void
tdefault_disconnect (struct target_ops *self, char *arg1, int arg2) tdefault_disconnect (struct target_ops *self, const char *arg1, int arg2)
{ {
tcomplain (); tcomplain ();
} }

2
gdb/target.c
View File

@ -2087,7 +2087,7 @@ target_detach (const char *args, int from_tty)
} }
void void
target_disconnect (char *args, int from_tty) target_disconnect (const char *args, int from_tty)
{ {
/* If we're in breakpoints-always-inserted mode or if breakpoints /* If we're in breakpoints-always-inserted mode or if breakpoints
are global across processes, we have to remove them before are global across processes, we have to remove them before

4
gdb/target.h
View File

@ -414,7 +414,7 @@ struct target_ops
TARGET_DEFAULT_IGNORE (); TARGET_DEFAULT_IGNORE ();
void (*to_detach) (struct target_ops *ops, const char *, int) void (*to_detach) (struct target_ops *ops, const char *, int)
TARGET_DEFAULT_IGNORE (); TARGET_DEFAULT_IGNORE ();
void (*to_disconnect) (struct target_ops *, char *, int) void (*to_disconnect) (struct target_ops *, const char *, int)
TARGET_DEFAULT_NORETURN (tcomplain ()); TARGET_DEFAULT_NORETURN (tcomplain ());
void (*to_resume) (struct target_ops *, ptid_t, int, enum gdb_signal) void (*to_resume) (struct target_ops *, ptid_t, int, enum gdb_signal)
TARGET_DEFAULT_NORETURN (noprocess ()); TARGET_DEFAULT_NORETURN (noprocess ());
@ -1177,7 +1177,7 @@ extern void target_detach (const char *, int);
/* Disconnect from the current target without resuming it (leaving it /* Disconnect from the current target without resuming it (leaving it
waiting for a debugger). */ waiting for a debugger). */
extern void target_disconnect (char *, int); extern void target_disconnect (const char *, int);
/* Resume execution of the target process PTID (or a group of /* Resume execution of the target process PTID (or a group of
threads). STEP says whether to single-step or to run free; SIGGNAL threads). STEP says whether to single-step or to run free; SIGGNAL