80bb239e1e
2004-05-01 Andrew Cagney <cagney@redhat.com>
...
* frame.c (deprecated_generic_get_saved_register): Delete
function, moved to "xstormy16-tdep.c".
* xstormy16-tdep.c (xstormy16_get_saved_register): Inline
deprecated_generic_get_saved_register from "frame.c".
(xstormy16_frame_saved_register): Call
xstormy16_get_saved_register.
* dummy-frame.c (deprecated_find_dummy_frame_regcache): Make
static.
* dummy-frame.h (deprecated_find_dummy_frame_regcache): Delete.
* frame.h (deprecated_generic_get_saved_register): Delete.
2004-05-01 22:41:34 +00:00
0e100dab2e
2004-05-01 Andrew Cagney <cagney@redhat.com>
...
* frame.c (create_sentinel_frame): Set type to SENTINEL_FRAME.
* dummy-frame.c (dummy_frame_this_id): Use get_frame_type, instead
of frame_relative_level.
* sentinel-frame.c (sentinel_frame_unwinder): Set unwinder's type
to SENTINEL_FRAME.
* frame.h (enum frame_type): Add SENTINEL_FRAME.
* s390-tdep.c (s390_prologue_frame_unwind_cache): Delete calls to
frame_relative_level.
2004-05-01 19:35:22 +00:00
55699d593f
2004-05-01 Andrew Cagney <cagney@redhat.com>
...
* frame.h (deprecated_set_frame_type): Delete declaration.
* frame.c (deprecated_set_frame_type): Delete function, update
comments.
2004-05-01 19:02:11 +00:00
fcf70625fc
2004-05-01 Andrew Cagney <cagney@redhat.com>
...
* gdbarch.sh (DEPRECATED_PC_IN_SIGTRAMP): Delete.
* gdbarch.h, gdbarch.c: Re-generate.
* shnbsd-tdep.c (shnbsd_init_abi): Do not set pc_in_sigtramp.
(shnbsd_pc_in_sigtramp): Delete.
* i386-interix-tdep.c (i386_interix_init_abi): Do not set
pc_in_sigtramp.
* hppa-hpux-tdep.c (hppa_hpux_init_abi): Do not set
pc_in_sigtramp.
* frame.h: Update comments.
* ppc-linux-tdep.c: Update comments.
* breakpoint.c (bpstat_what): Update comments.
Index: doc/ChangeLog
2004-05-01 Andrew Cagney <cagney@redhat.com>
* gdbint.texinfo (Target Architecture Definition): Delete
description of DEPRECATED_PC_IN_SIGTRAMP.
2004-05-01 16:52:30 +00:00
0faf007628
2004-04-28 Andrew Cagney <cagney@redhat.com>
...
* stack.c (print_stack_frame_stub): Delete declaration.
(struct print_stack_frame_args, print_stack_frame)
(print_frame_info, print_frame): Replace "source" with print what.
Replace "print" with "print_level". Replace "args" with
"print_args".
* frame.h (show_and_print_stack_frame, print_stack_frame)
(print_frame_info): Update declarations.
* stack.c (select_and_print_frame, frame_command)
(current_frame_command, up_command, down_command): Update calls -
use get_selected_frame, pass "enum print_what" for source, do not
call frame_relative_level.
* mi/mi-cmd-stack.c (mi_cmd_stack_list_frames): Ditto.
* remote-rdp.c (remote_rdp_open): Ditto.
* remote-mips.c (common_open): Ditto.
* remote-e7000.c (e7000_start_remote): Ditto.
* ocd.c (ocd_start_remote): Ditto.
* mi/mi-main.c (mi_cmd_exec_return): Ditto.
* infrun.c (normal_stop): Ditto.
* inflow.c (kill_command): Ditto.
* infcmd.c (finish_command): Ditto.
* corelow.c (core_open): Ditto.
* tracepoint.c (finish_tfind_command): Ditto.
* thread.c (info_threads_command, info_threads_command)
(restore_current_thread, do_captured_thread_select): Ditto.
* ada-tasks.c (task_command): Ditto.
2004-04-28 16:36:25 +00:00
fcf29e5f0e
2004-04-22 Andrew Cagney <cagney@redhat.com>
...
* frame.h (show_frame_info): Delete declaration.
2004-04-22 18:19:56 +00:00
9a4105ab85
2004-04-21 Andrew Cagney <cagney@redhat.com>
...
* annotate.h (deprecated_annotate_starting_hook)
(deprecated_annotate_stopped_hook)
(deprecated_annotate_exited_hook)
(deprecated_annotate_signal_hook)
(deprecated_annotate_signalled_hook): Deprecate.
* tracepoint.h (deprecated_create_tracepoint_hook)
(deprecated_delete_tracepoint_hook)
(deprecated_modify_tracepoint_hook)
(deprecated_trace_find_hook)
(deprecated_trace_start_stop_hook): Deprecate.
* target.h (deprecated_target_new_objfile_hook): Deprecate.
* remote.h (deprecated_target_resume_hook)
(deprecated_target_wait_loop_hook): Deprecate.
* gdbcore.h (deprecated_exec_file_display_hook)
(deprecated_file_changed_hook): Deprecate.
* frame.h (deprecated_selected_frame_level_changed_hook): Deprecate.
* defs.h (deprecated_modify_breakpoint_hook)
(deprecated_command_loop_hook, deprecated_show_load_progress)
(deprecated_print_frame_info_listing_hook)
(deprecated_query_hook, deprecated_warning_hook)
(deprecated_flush_hook, deprecated_create_breakpoint_hook)
(deprecated_delete_breakpoint_hook)
(deprecated_interactive_hook, deprecated_registers_changed_hook)
(deprecated_readline_begin_hook, deprecated_readline_hook)
(deprecated_readline_end_hook, deprecated_register_changed_hook)
(deprecated_memory_changed_hook, deprecated_init_ui_hook)
(deprecated_context_hook, deprecated_target_wait_hook)
(deprecated_attach_hook, deprecated_detach_hook)
(deprecated_call_command_hook, deprecated_set_hook)
(deprecated_error_hook, deprecated_error_begin_hook)
(deprecated_ui_load_progress_hook): Deprecate.
* valops.c, uw-thread.c, utils.c, tui/tui-io.c: Update.
* tui/tui-hooks.c, tracepoint.c, top.c, thread-db.c: Update.
* target.c, symfile.c, stack.c, sol-thread.c, rs6000-nat.c: Update.
* remote.c, remote-mips.c, regcache.c, mi/mi-interp.c: Update.
* main.c, interps.c, infcmd.c, hpux-thread.c, frame.c: Update.
* exec.c, dsrec.c, d10v-tdep.c, corefile.c, complaints.c: Update.
* cli/cli-script.c, cli/cli-setshow.c, breakpoint.c: Update.
* annotate.c, aix-thread.c: Update.
2004-04-21 23:52:21 +00:00
4a0e2f88c6
2004-04-07 Jason Molenda (jmolenda@apple.com)
...
* frame.h: Typeo corrections in comments.
2004-04-07 20:38:26 +00:00
304396fba9
2004-04-02 Andrew Cagney <cagney@redhat.com>
...
* frame.c (safe_frame_unwind_memory): New function.
* frame.h (safe_frame_unwind_memory): Declare. Update description
of /safe_/ methods.
* tramp-frame.c (tramp_frame_start): Re-order parmeters, add
"next_frame". Use safe_frame_unwind_memory.
(tramp_frame_sniffer): Update call to tramp_frame_start.
2004-04-02 19:44:25 +00:00
5613d8d3a3
2004-03-31 Andrew Cagney <cagney@redhat.com>
...
* frame.h (frame_unwind_id): Declare.
* frame.c (frame_unwind_id): New function.
(get_prev_frame_1): New function.
(frame_debug_got_null_frame): New function.
(get_prev_frame): Use frame_debug_got_null_frame. Move unwind
code proper to prev_frame, update description.
* infrun.c (step_over_function): Use frame_unwind_id.
2004-03-31 19:40:28 +00:00
f561f02630
2004-03-23 Andrew Cagney <cagney@redhat.com>
...
* gdbarch.sh (PC_IN_SIGTRAMP): Change to a function with
predicate, deprecate.
* gdbarch.h, gdbarch.c: Re-generate.
* alpha-linux-tdep.c (alpha_linux_init_abi): Update.
* alpha-osf1-tdep.c (alpha_osf1_init_abi): Update.
* alpha-tdep.c (alpha_sigtramp_frame_sniffer): Update.
* alphafbsd-tdep.c (alphafbsd_init_abi): Update.
* alphanbsd-tdep.c (alphanbsd_init_abi): Update.
* amd64-linux-tdep.c (amd64_linux_init_abi): Update.
* amd64-tdep.c (amd64_sigtramp_frame_sniffer): Update.
* amd64nbsd-tdep.c (amd64nbsd_init_abi): Update.
* amd64obsd-tdep.c (amd64obsd_init_abi): Update.
* arm-tdep.c (arm_sigtramp_unwind_sniffer): Update.
* blockframe.c (find_pc_partial_function): Update.
* breakpoint.c (bpstat_what): Update.
* frame.c (frame_type_from_pc, legacy_get_prev_frame): Update.
* frv-linux-tdep.c (frv_linux_init_abi): Update.
* frv-tdep.c (frv_sigtramp_frame_sniffer): Update.
* hppa-hpux-tdep.c (hppa_hpux_init_abi): Update.
* i386-interix-tdep.c (i386_interix_init_abi): Update.
* i386-linux-tdep.c (i386_linux_init_abi): Update.
* i386-nto-tdep.c (i386nto_init_abi): Update.
* i386-sol2-tdep.c (i386_sol2_init_abi): Update.
* i386-tdep.c (i386_sigtramp_frame_sniffer)
(i386_svr4_init_abi, i386_go32_init_abi, i386_gdbarch_init): Update.
* i386bsd-tdep.c (i386bsd_init_abi): Update.
* i386nbsd-tdep.c (i386nbsd_init_abi): Update.
* i386obsd-tdep.c (i386obsd_init_abi): Update.
* ia64-tdep.c (ia64_sigtramp_frame_sniffer): Update.
* infrun.c (pc_in_sigtramp): Update.
* m68k-tdep.c (m68k_sigtramp_frame_sniffer): Update.
* m68klinux-tdep.c (m68k_linux_init_abi): Update.
* mips-tdep.c (mips_gdbarch_init): Update.
* mipsnbsd-tdep.c (mipsnbsd_init_abi): Update.
* ppc-linux-tdep.c: Update comment.
* ppcnbsd-tdep.c (ppcnbsd_init_abi): Update.
* shnbsd-tdep.c (shnbsd_init_abi): Update.
* sparc-linux-tdep.c (sparc32_linux_init_abi): Update.
* sparc-sol2-tdep.c (sparc32_sol2_init_abi): Update.
* sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Update.
* sparc64fbsd-tdep.c (sparc64fbsd_init_abi): Update.
* sparc64nbsd-tdep.c (sparc64nbsd_init_abi): Update.
* sparc64obsd-tdep.c (sparc64obsd_init_abi): Update.
* sparcnbsd-tdep.c (sparc32nbsd_init_abi): Update.
* sparcobsd-tdep.c (sparc32obsd_init_abi): Update.
Index: doc/ChangeLog
2004-03-23 Andrew Cagney <cagney@redhat.com>
* gdbint.texinfo (Target Architecture Definition): Deprecate
references to PC_IN_SIGTRAMP.
2004-03-23 14:48:00 +00:00
8adf9e781b
2004-03-22 Andrew Cagney <cagney@redhat.com>
...
* frame.h (generic_pop_current_frame): Delete declaration.
(deprecate_pop_dummy_frame): Deprecate
generic_pop_dummy_frame.
* dummy-frame.c (deprecated_pop_dummy_frame): Update.
(generic_pop_current_frame): Delete function.
* mn10300-tdep.c (mn10300_pop_frame): Eliminate call to
generic_pop_current_frame.
* v850-tdep.c (v850_pop_frame): Update.
* mcore-tdep.c (mcore_pop_frame): Update.
* sh64-tdep.c (sh64_pop_frame): Update.
* h8300-tdep.c (h8300_pop_frame): Update.
2004-03-22 16:58:08 +00:00
90ba813f1f
2004-03-22 Andrew Cagney <cagney@redhat.com>
...
* frame.h (deprecated_pc_in_call_dummy): Rename
generic_pc_in_call_dummy.
* dummy-frame.h (pc_in_dummy_frame): Delete declaration.
* dummy-frame.c (deprecated_pc_in_call_dummy): Rename
generic_pc_in_call_dummy.
(pc_in_dummy_frame): Make static.
* gdbarch.sh (DEPRECATED_PC_IN_CALL_DUMMY): Update.
* gdbarch.h, gdbarch.c: Re-generate.
* dummy-frame.c (dummy_frame_sniffer): Simplify.
* frame.c (frame_type_from_pc): Call deprecated_pc_in_call_dummy.
(legacy_get_prev_frame): Ditto.
* inferior.h: Delete reference to generic_pc_in_call_dummy in
comment.
2004-03-22 15:36:47 +00:00
19772a2ce2
2004-02-09 Andrew Cagney <cagney@redhat.com>
...
* gdbarch.sh (DEPRECATED_FRAMELESS_FUNCTION_INVOCATION): Predicate
and function replacing FRAMELESS_FUNCTION_INVOCATION.
* blockframe.c (legacy_frameless_look_for_prologue): Rename
frameless_look_for_prologue.
* frame.h (legacy_frameless_look_for_prologue): Rename
frameless_look_for_prologue.
* gdbarch.h, gdbarch.c: Re-generate.
* sh64-tdep.c (sh64_gdbarch_init): Update.
* sh-tdep.c (sh_gdbarch_init): Update.
* s390-tdep.c (s390_gdbarch_init): Update.
* rs6000-tdep.c (rs6000_gdbarch_init): Update.
* ppc-linux-tdep.c (ppc_linux_init_abi): Update.
* m68k-tdep.c (m68k_gdbarch_init): Update.
(delta68_frame_args_address): Update.
* m32r-tdep.c (m32r_gdbarch_init): Update.
* hppa-tdep.c (hppa_gdbarch_init): Update.
* h8300-tdep.c (h8300_gdbarch_init): Update.
* frv-tdep.c (frv_gdbarch_init): Update.
(frv_frameless_function_invocation): Update.
* cris-tdep.c (cris_gdbarch_init): Update.
(cris_frameless_function_invocation): Update.
* avr-tdep.c (avr_gdbarch_init): Update.
* arm-tdep.c (arm_gdbarch_init): Update.
* stack.c (frame_info): Update, call predicate.
* rs6000-tdep.c (rs6000_frame_chain): Update, call predicate..
* frame.c (legacy_get_prev_frame): Update, call predicate..
* arch-utils.c (generic_frameless_function_invocation_not): Delete.
* arch-utils.h (generic_frameless_function_invocation_not): Delete.
* alpha-tdep.c (alpha_gdbarch_init): Do not set frameless function
invocation.
* d10v-tdep.c (d10v_gdbarch_init): Ditto.
* ns32k-tdep.c (ns32k_gdbarch_init): Ditto.
* vax-tdep.c (vax_gdbarch_init): Ditto.
2004-02-16 21:49:22 +00:00
b9d26eb9b8
2004-02-14 Andrew Cagney <cagney@redhat.com>
...
* gdbarch.sh (DEPRECATED_EXTRA_STACK_ALIGNMENT_NEEDED): Delete.
(DEPRECATED_CALL_DUMMY_STACK_ADJUST): Delete.
(DEPRECATED_CALL_DUMMY_ADDRESS): Delete.
* gdbarch.h, gdbarch.c: Re-generate.
* frame.c (deprecated_get_next_frame_hack): Delete function.
* frame.h (deprecated_get_next_frame_hack): Delete declaration.
* blockframe.c (deprecated_pc_in_call_dummy_at_entry_point):
Update.
* infcall.c (call_function_by_hand): Update.
Index: doc/ChangeLog
2004-02-14 Andrew Cagney <cagney@redhat.com>
* gdbint.texinfo (Target Architecture Definition): Delete
description of DEPRECATED_CALL_DUMMY_STACK_ADJUST.
2004-02-14 17:01:01 +00:00
9564ee9f56
Fix obvious typo (completly -> completely) and update copyrights as needed
2004-02-12 00:17:53 +00:00
dd3ecc148c
2003-11-23 Andrew Cagney <cagney@redhat.com>
...
* frame.c (frame_unwind_signed_register): Delete function.
* frame.h (frame_unwind_register_signed): Delete declaration.
* mips-tdep.c (mips_frame_saved_pc): Use frame_unwind_register_signed.
2003-11-23 21:49:12 +00:00
213cc0adce
2003-11-22 Andrew Cagney <cagney@redhat.com>
...
* frame.c (deprecated_frame_xmalloc): Delete function.
(deprecated_set_frame_extra_info_hack): Delete function.
(deprecated_set_frame_saved_regs_hack): Delete function.
* frame.h (deprecated_frame_xmalloc): Delete declaration.
(deprecated_set_frame_extra_info_hack): Delete declaration.
(deprecated_set_frame_saved_regs_hack): Delete declaration.
* mcore-tdep.c (analyze_dummy_frame): Instead of
deprecated_frame_xmalloc, deprecated_set_frame_saved_regs_hack,
and deprecated_set_frame_extra_info_hack use
deprecated_frame_xmalloc_with_cleanup.
* mn10300-tdep.c (analyze_dummy_frame): Ditto.
* mips-tdep.c (mips_init_extra_frame_info): Delete call to
deprecated_set_frame_saved_regs_hack.
2003-11-23 02:48:40 +00:00
38a7ce4b44
2003-11-22 Andrew Cagney <cagney@redhat.com>
...
* frame.h (deprecated_set_frame_next_hack): Delete declaration.
(deprecated_set_frame_prev_hack): Delete declaration.
* frame.c (deprecated_set_frame_next_hack): Delete function.
(deprecated_set_frame_prev_hack): Delete function.
* mcore-tdep.c (analyze_dummy_frame): Delete calls to
"deprecated_set_frame_next_hack" and
"deprecated_set_frame_prev_hack".
* mn10300-tdep.c (analyze_dummy_frame): Ditto.
2003-11-23 00:27:54 +00:00
2a9264f126
2003-11-22 Andrew Cagney <cagney@redhat.com>
...
* frame.c (deprecated_get_frame_context): Delete function.
(deprecated_set_frame_prev_hack): Delete function.
(struct frame_info): Delete member "context".
* frame.h (deprecated_get_frame_context): Delete declaration.
(deprecated_set_frame_context): Delete declaration.
2003-11-22 23:00:37 +00:00
ce2826aa7a
Index: mi/ChangeLog
...
2003-10-24 Andrew Cagney <cagney@redhat.com>
* tui-out.c: Fix "fortunatly"[sic].
Index: doc/ChangeLog
2003-10-24 Andrew Cagney <cagney@redhat.com>
* annotate.texinfo: Fix "fortunatly"[sic].
2003-10-24 Andrew Cagney <cagney@redhat.com>
* osabi.c (gdbarch_init_osabi): Fix typos, and "fortunatly"[sic].
* PROBLEMS, arch-utils.c, cli-out.c, command.h: Ditto.
* complaints.c, cris-tdep.c, disasm.c, dwarf2-frame.c: Ditto.
* frame.c, frame.h, infcall.c, infcmd.c, infrun.c: Ditto.
* kod.c, mips-tdep.c, regcache.c, regcache.h, remote.c: Ditto.
2003-10-24 17:37:04 +00:00
48c6672556
2003-10-17 Jeff Johnston <jjohnstn@redhat.com>
...
* frame.h (struct frame_id): Add new field: special_addr.
(frame_id_build_special): New prototype.
* frame.c (frame_id_build_special): New function.
(frame_id_build): Change to call frame_id_build_special().
(frame_id_eq): Change to also test special_addr field.
(frame_id_inner): Update comment.
2003-10-17 16:32:17 +00:00
f3efb16c92
2003-10-09 Michael Snyder <msnyder@redhat.com>
...
* frame.h: Fix typo in comment.
2003-10-10 00:32:04 +00:00
7f5f525dc2
2003-09-28 Andrew Cagney <cagney@redhat.com>
...
* frame.c (frame_read_unsigned_register): Delete function.
* frame.h (frame_read_unsigned_register): Delete declaration.
* sparc-tdep.c (sparc_init_extra_frame_info): Use
get_frame_register_unsigned.
(sparc_frame_saved_pc, sparc_pop_frame): Ditto.
* m68hc11-tdep.c (m68hc11_print_register): Ditto.
* d10v-tdep.c (d10v_print_registers_info): Ditto.
* frame.h (frame_read_register): Delete declaration.
* frame.c (frame_read_register): Delete function.
* arch-utils.c (legacy_register_to_value): Use get_frame_register.
* sparc-tdep.c (sparc_fetch_pointer_argument): Ditto.
* rs6000-tdep.c (rs6000_fetch_pointer_argument): Ditto.
* mips-tdep.c (mips_register_to_value): Ditto.
* hppa-tdep.c (hppa_fetch_pointer_argument): Ditto.
* d10v-tdep.c (d10v_print_registers_info): Ditto.
* frame.c (frame_read_signed_register): Delete function.
(frame_read_unsigned_register): Update comments.
* frame.h (frame_read_signed_register): Delete declaration.
* h8300-tdep.c (h8300_print_register): Use
get_frame_register_signed.
* m68hc11-tdep.c (m68hc11_print_register): Ditto.
2003-09-28 22:32:20 +00:00
1b1d37945b
2003-09-25 Andrew Cagney <cagney@redhat.com>
...
* frame.h (deprecated_frame_saved_regs): Rename
get_frame_saved_regs.
* cris-tdep.c, frame.c, h8300-tdep.c, hppa-tdep.c: Update.
* mcore-tdep.c, mips-tdep.c, mn10300-tdep.c: Update.
* ns32k-tdep.c, ppc-linux-tdep.c, rs6000-tdep.c: Update.
* s390-tdep.c, sh64-tdep.c, stack.c: Update.
* v850-tdep.c, vax-tdep.c, xstormy16-tdep.c: Update.
2003-09-25 20:44:02 +00:00
7dd8898670
* frame.c (deprecated_safe_get_selected_frame): New function.
...
* frame.h (deprecated_safe_get_selected_frame): Add prototype.
* findvar.c (read_var_value): Call it.
2003-09-08 18:56:03 +00:00
c4a095243b
2003-07-11 Andrew Cagney <cagney@redhat.com>
...
* frame.h (frame_address_in_block): Delete declaration.
* blockframe.c (frame_address_in_block): Delete function.
(get_frame_block): Use get_frame_address_in_block.
(block_innermost_frame): Ditto.
* stack.c (print_frame, backtrace_command_1): Ditto.
2003-07-11 15:31:43 +00:00
8edd5d0153
2003-07-11 Andrew Cagney <cagney@redhat.com>
...
* frame.h (get_frame_address_in_block): Declare.
(frame_unwind_address_in_block): Declare.
* frame.c (frame_unwind_address_in_block): New function.
(get_frame_address_in_block): New function.
2003-07-11 14:52:17 +00:00
eb8bc28217
2003-07-07 Andrew Cagney <cagney@redhat.com>
...
* expprint.c: Include "user-regs.h" instead of "frame.h".
(print_subexp): Use user_reg_map_regnum_to_name, instead of
frame_map_regnum_to_name.
* frame.c: Include "user-regs.h" instead of "builtin-regs.h".
(frame_map_name_to_regnum): Simplify, call
user_reg_map_name_to_regnum.
(frame_map_regnum_to_name): Simplify, call
user_reg_map_regnum_to_name.
(frame_register_unwind): Update.
* std-regs.c: Include "user-regs.h" instead of "builtin-regs.h".
(_initialize_frame_reg): Call user_reg_add_builtin.
* findvar.c: Include "user-regs.h" instead of "builtin-regs.h".
(value_of_register): Use value_of_user_reg.
* eval.c (evaluate_subexp_standard): Update.
* parse.c (write_dollar_variable): Update.
* d10v-tdep.c (d10v_print_registers_info): Update.
* infcmd.c (registers_info): Update.
* Makefile.in (SFILES): Delete "builtin-regs.c", add "user-regs.c".
(builtin_regs_h): Delete macro.
(user_regs_h): Define.
(COMMON_OBS): Delete "builtin-regs.o", add "user-regs.o".
(builtin-regs.o): Delete target.
(user-regs.o): Specify dependencies.
(expprint.o): Update dependencies.
(findvar.o): Update dependencies.
(frame.o): Update dependencies.
(std-regs.o): Update dependencies.
2003-07-07 14:36:58 +00:00
6e51443a2a
2003-06-21 Andrew Cagney <cagney@redhat.com>
...
* frame.h (deprecated_unwind_get_saved_register): Delete.
* frame.c (deprecated_unwind_get_saved_register): Delete function.
* mips-tdep.c (mips_get_saved_register): Use frame_register_unwind
and deprecated_get_next_frame_hack instead of
deprecated_unwind_get_saved_register.
2003-06-21 16:51:47 +00:00
f0e7d0e8f2
2003-06-21 Andrew Cagney <cagney@redhat.com>
...
* frame.c (get_frame_register): New function.
(frame_unwind_register_signed): New function.
(get_frame_register_signed): New function.
(frame_unwind_register_unsigned): New function.
(get_frame_register_unsigned): New function.
* frame.h: Add comments on naming schema.
(get_frame_register, frame_unwind_register_signed): Declare.
(get_frame_register_signed, get_frame_register_signed): Declare.
(frame_unwind_register_unsigned): Declare.
(get_frame_register_unsigned): Declare.
2003-06-21 16:26:02 +00:00
870b3035a4
2003-06-16 Andrew Cagney <cagney@redhat.com>
...
* frame.h (deprecated_get_next_frame_hack): Declare.
* frame.c (legacy_saved_regs_prev_register): Only require
DEPRECATED_FRAME_INIT_SAVED_REGS when it is needed. Assert that
there are always saved regs.
(deprecated_generic_get_saved_register): Do not require
DEPRECATED_FRAME_INIT_SAVED_REGS.
(legacy_get_prev_frame): Do not require DEPRECATED_FRAME_CHAIN,
use frame ID unwind instead.
(deprecated_get_next_frame_hack): New function.
2003-06-16 20:05:56 +00:00
ff2e87acc7
2003-06-14 Andrew Cagney <cagney@redhat.com>
...
Mark Kettenis <kettenis@gnu.org>
* gdbarch.sh (CONVERT_REGISTER_P): Add "type" parameter.
(REGISTER_TO_VALUE, VALUE_TO_REGISTER): Replace raw buffer
parameter with "frame".
* gdbarch.h, gdbarch.c: Re-generate.
* frame.h (put_frame_register): Declare.
* frame.c (put_frame_register): New function.
* arch-utils.c (legacy_convert_register_p): Add "type" parameter.
(legacy_register_to_value): Rewrite, use "frame" to get the
register value.
(legacy_value_to_register): Rewrite, use "frame" to find the
register's location before storing.
* arch-utils.h (legacy_convert_register_p): Update.
(legacy_register_to_value, legacy_value_to_register): Update.
* findvar.c (value_from_register): Rewrite, eliminate use of
REGISTER_CONVERT_TO_TYPE, pass "type" to CONVERT_REGISTER_P, pass
"frame" to REGISTER_TO_VALUE.
* valops.c (value_assign): Move the CONVERT_REGISTER code to the
lval_reg_frame_relative + lval_register branch of the switch. Do
not use REGISTER_CONVERT_FROM_TYPE. Use put_frame_register.
* i386-tdep.c (I386_EBX_REGNUM, I386_ECX_REGNUM, I386_ESI_REGNUM,
I386_EDI_REGNUM): New defines.
(i386_next_regnum, i386_convert_register_p,
i386_register_to_value, i386_value_to_register): New functions.
(i386_register_convertible, i386_register_convert_to_virtual,
i386_convert_to_raw): Remove functions.
(i386_gdbarch_init): Set convert_register_p, register_to_value and
value_to_register instead of register_convertible,
register_convert_to_virtual and register_convert_to_raw.
* mips-tdep.c (mips_convert_register_p): New function.
(mips_value_to_register): Replace mips_register_convert_from_type.
(mips_register_to_value): Replace mips_register_convert_to_type.
(mips_gdbarch_init): Set conver_register_p, value_to_register and
register_to_value.
* alpha-tdep.c (alpha_convert_register_p): Update.
(alpha_value_to_register): Update, store the register.
(alpha_register_to_value): Update, fetch the register.
2003-06-14 22:35:25 +00:00
248de703d4
2003-06-09 Andrew Cagney <cagney@redhat.com>
...
* frame.h (deprecated_unwind_get_saved_register): Rename
generic_unwind_get_saved_register, update comments.
* mips-tdep.c (mips_get_saved_register): Update.
* frame.c (deprecated_unwind_get_saved_register): Update.
2003-06-09 22:20:43 +00:00
8d3b0994cd
2003-06-09 Andrew Cagney <cagney@redhat.com>
...
* printcmd.c (print_frame_nameless_args): Moved to "stack.c".
(print_frame_args): Moved to "stack.c".
* stack.c: Include "gdb_assert.h".
(print_frame_nameless_args): Moved from "printcmd.c", made static.
(print_frame_args): Moved from "printcmd.c".
* frame.h (print_frame_args): Delete declaration.
* Makefile.in (stack.o): Update dependencies.
2003-06-09 15:20:21 +00:00
a9e5fdc219
2003-06-08 Andrew Cagney <cagney@redhat.com>
...
* gdbarch.sh (UNWIND_SP): Add.
* gdbarch.h, gdbarch.c: Re-generate.
* frame.c (frame_sp_unwind): New function.
(get_frame_sp): New function.
* frame.h (get_frame_sp, frame_sp_unwind): Declare.
* regcache.c (read_sp): Rewrite, try each of TARGET_READ_SP,
gdbarch_unwind_sp and SP_REGNUM when looking for the SP register
value.
* d10v-tdep.c (d10v_unwind_sp): Replace d10v_read_sp.
(d10v_gdbarch_init): Set unwind_sp instead of read_sp.
2003-06-08 Andrew Cagney <cagney@redhat.com>
* gdbint.texinfo (Target Architecture Definition): Document
"unwind_sp". Cross reference "unwind_sp" and TARGET_READ_SP.
2003-06-09 01:02:07 +00:00
ae1e741769
2003-06-03 Andrew Cagney <cagney@redhat.com>
...
* frame.c (get_frame_memory_signed): New function.
(get_frame_memory, get_frame_memory_unsigned): New function.
(get_frame_arch): New function.
* frame.h (get_frame_signed_memory, get_frame_arch): Declare.
(get_frame_memory, get_frame_unsigned_memory): Declare.
* d10v-tdep.c (d10v_frame_unwind_cache): Use
get_frame_memory_unsigned and get_frame_arch.
(d10v_frame_unwind_cache, saved_regs_unwinder): Ditto.
2003-06-03 18:53:37 +00:00
30e221b4d3
Index: gdb/ChangeLog
...
2003-05-11 Andrew Cagney <cagney@redhat.com>
* Makefile.in (mi-symbol-cmds.o): Rename mi-cmd-symbol.
* config/djgpp/fnchange.lst: Rename include/xtensa-isa-internal.h,
include/xtensa-isa.h, sim/testsuite/sim/arm/misaligned1.ms,
sim/testsuite/sim/arm/misaligned2.ms, and
sim/testsuite/sim/arm/misaligned3.ms.
* disasm.h (struct ui_file): Add opaque struct declaration.
* config/pa/tm-hppa64.h (struct type, struct frame_info): Ditto.
* frame.h (struct ui_file): Ditto.
Index: gdb/mi/ChangeLog
2003-05-11 Andrew Cagney <cagney@redhat.com>
* mi-symbol-cmds.c: Rename "mi-cmd-symbol.c", avoid 8.3 problem.
2003-05-12 00:26:19 +00:00
00905d52fe
Index: testsuite/ChangeLog
...
2003-05-05 Andrew Cagney <cagney@redhat.com>
* gdb.base/maint.exp: Add tests for "maint print dummy-frames".
Index: doc/ChangeLog
2003-05-05 Andrew Cagney <cagney@redhat.com>
* gdb.texinfo (Maintenance Commands): Document "maint print
dummy-frames".
2003-05-05 Andrew Cagney <cagney@redhat.com>
* dummy-frame.c: Include "command.h" and "gdbcmd.h".
(fprint_dummy_frames): New function.
(maintenance_print_dummy_frames): New function.
(_initialize_dummy_frame): Add command "maint print dummy-frames".
* frame.c (fprint_frame_id): Make global.
* frame.h (fprint_frame_id): Declare.
* Makefile.in (dummy-frame.o): Update dependencies.
2003-05-05 18:33:11 +00:00
0ba6dca974
2003-04-28 Andrew Cagney <cagney@redhat.com>
...
* gdbarch.sh (DEPRECATED_TARGET_READ_FP): Replace TARGET_READ_FP.
(DEPRECATED_FP_REGNUM): Replace FP_REGNUM.
* gdbarch.h, gdbarch.c: Re-generate.
* infcall.c (call_function_by_hand): Use DEPRECATED_FP_REGNUM,
DEPRECATED_TARGET_READ_FP, or "sp" to create the dummy frame ID.
* inferior.h (deprecated_read_fp): Rename read_fp.
(generic_target_read_fp): Delete declaration.
* regcache.c (generic_target_read_fp): Delete function.
(deprecated_read_fp): Replace read_fp, use
DEPRECATED_TARGET_READ_FP or DEPRECATED_FP_REGNUM.
* d10v-tdep.c (d10v_read_fp): Delete function.
(d10v_gdbarch_init): Do not set deprecated_read_fp.
* sparc-tdep.c (sparc_gdbarch_init): Do not set
deprecated_target_read_fp to generic_target_read_fp.
* sh-tdep.c (sh_gdbarch_init): Ditto.
* rs6000-tdep.c (rs6000_gdbarch_init): Ditto.
* m68hc11-tdep.c (m68hc11_gdbarch_init): Ditto.
* frv-tdep.c (frv_gdbarch_init): Ditto.
* xstormy16-tdep.c (xstormy16_gdbarch_init): Set
deprecated_fp_regnum.
* x86-64-tdep.c (x86_64_init_abi): Ditto.
* vax-tdep.c (vax_gdbarch_init): Ditto.
* v850-tdep.c (v850_gdbarch_init): Ditto.
* sparc-tdep.c (sparc_gdbarch_init): Ditto.
* sh-tdep.c (sh_gdbarch_init): Ditto.
* s390-tdep.c (s390_gdbarch_init): Ditto.
* rs6000-tdep.c (rs6000_gdbarch_init): Ditto.
* mn10300-tdep.c (mn10300_gdbarch_init): Ditto.
* mcore-tdep.c (mcore_gdbarch_init): Ditto.
* m68k-tdep.c (m68k_gdbarch_init): Ditto.
* m68hc11-tdep.c (m68hc11_gdbarch_init): Ditto.
* ia64-tdep.c (ia64_gdbarch_init): Ditto.
* i386-tdep.c (i386_gdbarch_init): Ditto.
* hppa-tdep.c (hppa_gdbarch_init): Ditto.
* h8300-tdep.c (h8300_gdbarch_init): Ditto.
* frv-tdep.c (frv_gdbarch_init): Ditto.
* cris-tdep.c (cris_gdbarch_init): Ditto.
* avr-tdep.c (avr_gdbarch_init): Ditto.
* arm-tdep.c (arm_gdbarch_init): Ditto.
* alpha-tdep.c (alpha_gdbarch_init): Ditto.
* x86-64-tdep.c (x86_64_init_abi): Set deprecated_target_read_fp.
* v850-tdep.c (v850_gdbarch_init): Ditto.
* sparc-tdep.c (sparc_gdbarch_init): Ditto.
* sh-tdep.c (sh_gdbarch_init): Ditto.
* s390-tdep.c (s390_gdbarch_init): Ditto.
* rs6000-tdep.c (rs6000_gdbarch_init): Ditto.
* mn10300-tdep.c (mn10300_gdbarch_init): Ditto.
* mips-tdep.c (mips_gdbarch_init): Ditto.
* m68hc11-tdep.c (m68hc11_gdbarch_init): Ditto.
* ia64-tdep.c (ia64_gdbarch_init): Ditto.
* hppa-tdep.c (hppa_gdbarch_init): Ditto.
* frv-tdep.c (frv_gdbarch_init): Ditto.
* avr-tdep.c (avr_gdbarch_init): Ditto.
* arm-tdep.c (arm_gdbarch_init): Ditto.
* vax-tdep.c (vax_frame_init_saved_regs): Replace FP_REGNUM with
DEPRECATED_FP_REGNUM.
(vax_push_dummy_frame, vax_pop_frame): Ditto.
* std-regs.c (value_of_builtin_frame_fp_reg): Ditto.
* sparc-tdep.c (sparc_init_extra_frame_info): Ditto.
(sparc_push_dummy_frame, sparc64_read_fp): Ditto.
(sparc32_register_virtual_type): Ditto.
* sh-tdep.c (sh64_frame_chain): Ditto.
(sh64_get_saved_register, sh64_pop_frame): Ditto.
(sh_nofp_frame_init_saved_regs): Ditto.
(sh64_nofp_frame_init_saved_regs): Ditto.
(sh_fp_frame_init_saved_regs): Ditto.
* remote-mips.c (mips_wait, mips_fetch_registers): Ditto.
* remote-e7000.c (fetch_regs_from_dump): Ditto.
* procfs.c (procfs_fetch_registers): Ditto.
(procfs_store_registers): Ditto.
* ns32knbsd-nat.c (fetch_inferior_registers): Ditto.
(store_inferior_registers, fetch_core_registers): Ditto.
(fetch_kcore_registers, clear_regs): Ditto.
* ns32k-tdep.c (ns32k_frame_init_saved_regs): Ditto.
(ns32k_push_dummy_frame, ns32k_pop_frame): Ditto.
* nlm/i386.h (DEPRECATED_FP_REGNUM): Ditto.
* nlm/i386.c (do_status): Ditto.
* mipsv4-nat.c (supply_gregset): Ditto.
* mips-tdep.c: Ditto for comments.
* mips-nat.c (fetch_inferior_registers): Ditto.
(store_inferior_registers, fetch_core_registers): Ditto.
* m68k-tdep.c (m68k_push_dummy_frame): Ditto.
(m68k_pop_frame, m68k_frame_init_saved_regs): Ditto.
* i386-tdep.c (i386_frame_init_saved_regs): Ditto.
(i386_do_pop_frame, i386_register_type): Ditto.
* hppa-tdep.c (hppa_frame_chain): Ditto.
(hppa_push_dummy_frame, find_dummy_frame_regs): Ditto.
(hppa_pop_frame, hppa_read_fp): Ditto.
(skip_prologue_hard_way, hppa_frame_find_saved_regs): Ditto.
* cris-tdep.c (cris_examine, cris_pop_frame): Ditto.
* config/vax/nm-vax.h (REGISTER_U_ADDR): Ditto.
* config/sparc/tm-sparc.h (DEPRECATED_FP_REGNUM): Ditto.
* config/sparc/tm-sp64.h (DEPRECATED_FP_REGNUM): Ditto.
* config/s390/tm-s390.h (DEPRECATED_FP_REGNUM): Ditto.
* config/pa/tm-hppa64.h (DEPRECATED_FP_REGNUM): Ditto.
* config/ia64/tm-ia64.h (DEPRECATED_FP_REGNUM): Ditto.
* blockframe.c: Ditto for comments.
* arch-utils.h: Ditto for comments.
* arch-utils.c (legacy_virtual_frame_pointer): Ditto.
* alphanbsd-tdep.c (fetch_core_registers): Ditto.
* alphabsd-nat.c (fetch_inferior_registers): Ditto.
* alpha-tdep.h: Ditto for comments.
* alpha-tdep.c (alpha_cannot_fetch_register): Ditto.
(alpha_cannot_store_register): Ditto.
(alpha_push_dummy_frame): Ditto.
* alpha-nat.c (supply_gregset): Ditto.
* config/sparc/tm-sp64.h (DEPRECATED_TARGET_READ_FP): Update.
* config/pa/tm-hppa64.h (DEPRECATED_TARGET_READ_FP): Update.
* config/sparc/tm-sparc.h: Update comment.
* hppa-tdep.c (hppa_init_extra_frame_info): Use
deprecated_read_fp instead of TARGET_READ_FP.
(hppa_init_extra_frame_info, hppa_frame_chain): Ditto.
(hppa_push_dummy_frame, hppa_read_fp): Ditto.
* sparc-tdep.c (sparc_init_extra_frame_info): Use
deprecated_read_fp instead of read_fp.
* s390-tdep.c (s390_push_arguments): Ditto.
* ia64-tdep.c (ia64_gdbarch_init): Ditto.
* frame.h: Ditto in comments.
* frame.c (legacy_get_prev_frame): Ditto.
* dummy-frame.c (dummy_frame_this_id): Ditto.
* arm-tdep.c (arm_init_extra_frame_info): Ditto.
2003-04-28 Andrew Cagney <cagney@redhat.com>
* gdbint.texinfo (Target Architecture Definition): Replace
read_fp, TARGET_READ_FP and FP_REGNUM, with deprecated_read_fp,
DEPRECATED_TARGET_READ_FP and DEPRECATED_REGNUM.
2003-04-29 01:49:49 +00:00
f75493ed72
2003-04-25 Andrew Cagney <cagney@redhat.com>
...
* d10v-tdep.c (d10v_extract_return_value): Delete call to printf.
(_initialize_d10v_tdep): Use add_setshow_boolean_cmd.
(d10v_frame_unwind_cache): Use FRAME_OBSTACK_CALLOC.
(NR_DMAP_REGS, A0_REGNUM): Delete, replaced by ...
(nr_dmap_regs, a0_regnum): ... new functions.
(d10v_print_registers_info): Use a0_regnum, use register_size.
(d10v_register_byte): Delete function.
(d10v_register_raw_size): Delete function.
(d10v_register_type): Use a0_regnum.
(d10v_print_registers_info): Use a0_regnum.
(D10V_SP_REGNUM): Rename _SP_REGNUM, replace it and SP_REGNUM.
(d10v_gdbarch_init): Do not set register_byte or
register_raw_size, use D10V_SP_REGNUM to set sp_regnum.
(d10v_pointer_to_address): Use extract_unsigned_integer instead of
extract_address.
(trace_command): Use XCALLOC.
(print_insn): Delete reference to tm_print_insn.
(saved_regs_unwinder): Use store_unsigned_integer instead of
store_address.
* frame.h (FRAME_OBSTACK_CALLOC): Define
2003-04-25 21:20:58 +00:00
ef6e7e1393
2003-04-13 Andrew Cagney <cagney@redhat.com>
...
* frame.h: Mention what replaced what in "struct frame_info".
* hppa-hpux-tdep.c: Use get_frame_base, get_frame_pc and
deprecated_update_frame_base_hack and
deprecated_update_frame_pc_hack.
* hppa-tdep.c: Ditto.
2003-04-13 15:54:58 +00:00
bd013d5471
2003-04-12 Andrew Cagney <cagney@redhat.com>
...
* frame.h (struct frame_info): Move definition from here ...
* frame.c (struct frame_info): ... to here.
2003-04-13 00:10:22 +00:00
d0a557723a
2003-04-09 Andrew Cagney <cagney@redhat.com>
...
* frame.h (struct frame_id): Replace "pc" and "base" with
"stack_addr" and "code_addr". Update comments.
(frame_id_build): Update parameter names and comment.
(struct frame_info): Replace "id_p" and "id" with "this_id".
* dummy-frame.c (dummy_frame_this_id): Update.
* breakpoint.c (print_one_breakpoint): Update.
* frame.c (get_frame_id): Update.
(get_frame_base, frame_id_build): Update.
(create_sentinel_frame, legacy_get_prev_frame): Update.
(deprecated_update_frame_base_hack): Update.
(frame_id_p, frame_id_eq): Rework, return 0 when an invalid ID.
(frame_id_inner): Ditto.
2003-04-10 03:30:36 +00:00
cd983b5cd0
* frame.h (struct gdbarch): Add opaque structure definition
...
to avoid a compilation warning on LynxOS 4.0.
2003-04-09 21:53:28 +00:00
d134026405
2003-04-09 Andrew Cagney <cagney@redhat.com>
...
* frame.h (struct frame_info): Delete field "pc". Replace
"pc_unwind_cache" and "pc_unwind_cache_p" with "prev_pc"
structure.
* frame.c (frame_pc_unwind): Update.
(create_sentinel_frame): Do not set "pc".
(get_prev_frame): Do not set "pc". Use frame_pc_unwind.
(get_frame_pc): Call frame_pc_unwind.
(deprecated_update_frame_pc_hack): Update.
(create_new_frame): Use "pc" not "->pc".
2003-04-09 20:49:22 +00:00
90a6fffbda
2003-04-09 Andrew Cagney <cagney@redhat.com>
...
* frame.c (get_frame_id): Eliminate code updating "frame".
(legacy_get_prev_frame): Ditto.
(get_frame_base): Return id.base directly.
(deprecated_update_frame_base_hack): Update "id.base".
* frame.h (struct frame_info): Delete field "frame".
2003-04-09 18:24:01 +00:00
e6ba3bc976
2003-04-06 Andrew Cagney <cagney@redhat.com>
...
* frame.h (legacy_frame_chain_valid): Rename frame_chain_valid.
Update comment.
* frame.c (legacy_saved_regs_this_id): Update.
(legacy_get_prev_frame): Update.
* xstormy16-tdep.c: Update comment.
* sparc-tdep.c (sparc_frame_chain): Update comment.
* blockframe.c (legacy_frame_chain_valid): Update.
2003-04-06 18:36:23 +00:00
43bd9a9e02
2003-04-05 Andrew Cagney <cagney@redhat.com>
...
Eliminate FRAME_FIND_SAVED_REGS.
* config/pa/tm-hppah.h (hppa_hpux_frame_find_saved_regs_in_sigtramp):
Change FSR parameter to a pointer.
* config/pa/tm-hppa64.h (FRAME_FIND_SAVED_REGS_IN_SIGTRAMP):
Assume FSR parameter is a pointer.
* hppa-hpux-tdep.c (hppa_hpux_frame_find_saved_regs_in_sigtramp):
Make fsr a pointer.
* hppa-tdep.c (hppa_frame_find_saved_regs): New function.
(hppa_frame_saved_pc): Call hppa_frame_init_saved_regs. Make
saved_regs a pointer.
(hppa_frame_saved_pc): Ditto.
(find_dummy_frame_regs): Make frame_saved_regs a pointer
(hppa_pop_frame): Call hppa_frame_init_saved_regs. Make fsr a
pointer.
(restore_pc_queue): Make fsr a pointer.
(hppa_frame_find_saved_regs): Make frame_saved_regs a pointer.
(hppa_frame_chain): Make saved_regs a pointer, call
hppa_frame_init_saved_regs.
* sparc-tdep.c: Include "gdb_assert.h".
(sparc_frame_find_saved_regs): Replace internal_error with
gdb_assert.
* remote-vxsparc.c (vx_read_register): Delete reference to
FRAME_FIND_SAVED_REGS.
* gdbarch.sh: Delete check for FRAME_FIND_SAVED_REGS.
* gdbarch.h: Regenerate.
* frame.h (DEPRECATED_FRAME_INIT_SAVED_REGS): Delete macro.
(deprecated_get_frame_saved_regs): Delete declaration.
(struct frame_saved_regs): Delete definition.
* frame.c (deprecated_get_frame_saved_regs): Delete function.
* config/pa/tm-hppa.h (hppa_frame_init_saved_regs): Declare.
(hppa_frame_find_saved_regs): Delete declaration.
(FRAME_FIND_SAVED_REGS): Delete macro.
(DEPRECATED_FRAME_INIT_SAVED_REGS): Define.
* config/i386/tm-ptx.h (FRAME_FIND_SAVED_REGS): Delete
FRAME_FIND_SAVED_REGS in comment.
2003-04-06 01:13:59 +00:00
be41e9f456
2003-04-05 Andrew Cagney <cagney@redhat.com>
...
* frame.c (frame_func_unwind, get_frame_func): New functions.
* frame.h (get_frame_func, frame_func_unwind): Declare.
(struct frame_info): Add field "prev_func" for caching the
previous frame's function address.
* arm-tdep.c (arm_frameless_function_invocation): Combine
get_pc_function_start and get_frame_pc into get_frame_func.
* sh-tdep.c (sh_nofp_frame_init_saved_regs): Ditto.
(sh64_nofp_frame_init_saved_regs): Ditto.
* s390-tdep.c (s390_function_start): Ditto.
* rs6000-tdep.c (rs6000_pop_frame): Ditto.
(rs6000_frameless_function_invocation): Ditto.
(rs6000_frame_saved_pc): Ditto.
* m68k-tdep.c (m68k_frame_init_saved_regs): Ditto.
* ia64-tdep.c (ia64_frame_init_saved_regs): Ditto.
* i386-tdep.c (i386_frameless_signal_p): Ditto.
(i386_frame_init_saved_regs): Ditto.
* hppa-tdep.c (hppa_frame_find_saved_regs): Ditto.
* d10v-tdep.c (d10v_frame_unwind_cache): Combine
get_pc_function_start and frame_pc_unwind into frame_func_unwind.
* cris-tdep.c (cris_frame_init_saved_regs): Ditto.
* blockframe.c (frameless_look_for_prologue): Ditto.
2003-04-05 18:54:38 +00:00
Andrew Cagney
Jason Molenda
Fred Fish
Jeff Johnston
Michael Snyder
Daniel Jacobowitz
Joel Brobecker