Tom Tromey
bd4c9dfe67
Constify some commands in mips-tdep.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* mips-tdep.c (show_mipsfpu_command, set_mipsfpu_single_command)
(set_mipsfpu_double_command, set_mipsfpu_none_command)
(set_mipsfpu_auto_command): Constify.
2017-09-27 08:44:52 -06:00
Tom Tromey
5e93d4c64b
Constify cd_command
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cli/cli-cmds.h (cd_command): Constify.
* cli/cli-cmds.c (cd_command): Constify.
2017-09-27 08:44:51 -06:00
Tom Tromey
fc41a75bee
Constify some commands in thread.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* thread.c (thread_name_command, thread_find_command): Constify.
2017-09-27 08:44:51 -06:00
Tom Tromey
6781007668
Constify some commands in probes.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* probe.c (enable_probes_command, disable_probes_command):
Constify.
2017-09-27 08:44:50 -06:00
Tom Tromey
1d8b34a7a2
Constify some commands in exec.c, plus symbol_file_command
...
Note that this commit also changes deprecated_file_changed_hook -- not
used in the tree, but Insight will require a (presumably minor)
change.
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* symfile.c (symbol_file_command): Constify.
* gdbcore.h (deprecated_file_changed_hook): Constify.
* exec.c (deprecated_file_changed_hook, exec_file_command)
(file_command): Constify.
* defs.h (symbol_file_command): Constify.
2017-09-27 08:44:49 -06:00
Tom Tromey
442019e118
Constify some commands in remote-fileio.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* remote-fileio.c (set_system_call_allowed)
(show_system_call_allowed): Constify.
2017-09-27 08:44:48 -06:00
Tom Tromey
2983f7cbdb
Constify some commands in tracepoint.c
...
In addition to the constification, this fixes a command-repeat bug.
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* tracepoint.c (delete_trace_variable_command)
(tfind_end_command, tfind_start_command, tfind_pc_command)
(tfind_tracepoint_command, tfind_line_command)
(tfind_range_command, tfind_outside_command): Constify.
2017-09-27 08:44:47 -06:00
Tom Tromey
4fd41b2486
Constify some commands in ax-gdb.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* ax-gdb.c (maint_agent_printf_command, agent_command)
(agent_eval_command): Constify.
2017-09-27 08:44:46 -06:00
Tom Tromey
f2fc30156c
Constify some linespec functions
...
This changes a few linespec functions to work on "const char *" and
then fixes up all the callers. This allows further constification
elsewhere.
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* tracepoint.c (info_scope_command): Constify.
* python/python.c (gdbpy_decode_line): Constify.
* python/py-breakpoint.c (bppy_init): Constify.
* mi/mi-cmd-break.c (mi_cmd_break_insert_1): Constify.
* location.h: (new_linespec_location)
(string_to_event_location_basic, string_to_event_location):
Constify.
* location.c (new_linespec_location)
(string_to_event_location_basic, string_to_event_location):
Constify.
* linespec.h (decode_line_with_current_source)
(decode_line_with_last_displayed, linespec_lex_to_end): Constify.
* linespec.c (linespec_lex_to_end)
(decode_line_with_current_source)
(decode_line_with_last_displayed): Constify.
* guile/scm-breakpoint.c (gdbscm_register_breakpoint_x):
Constify.
* cli/cli-cmds.c (edit_command, list_command): Constify.
* breakpoint.h (until_break_command, watch_command_wrapper)
(awatch_command_wrapper, rwatch_command_wrapper)
(init_ada_exception_breakpoint): Constify.
* breakpoint.c (break_command_1, dprintf_command)
(break_range_command, watch_command_wrapper)
(rwatch_command_wrapper, awatch_command_wrapper)
(until_break_command, init_ada_exception_breakpoint)
(strace_marker_create_sals_from_location, trace_command)
(ftrace_command, strace_command, struct tracepoint): Constify.
* ax-gdb.c (agent_command_1): Constify.
* ada-lang.c (ada_exception_sal): Constify.
2017-09-27 08:44:45 -06:00
Tom Tromey
8c2f95f434
Constify some commands in record.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* record.c (cmd_record_delete, cmd_record_stop, cmd_record_save)
(cmd_record_goto_begin, cmd_record_goto_end, get_insn_number)
(get_context_size, no_chunk, get_insn_history_modifiers)
(cmd_record_insn_history, get_call_history_modifiers)
(cmd_record_call_history): Constify.
2017-09-27 08:44:44 -06:00
Tom Tromey
a0d65762f1
Constify some commands in source.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* source.c (show_substitute_path_command)
(unset_substitute_path_command, set_substitute_path_command):
Constify.
2017-09-27 08:44:43 -06:00
Tom Tromey
5897114462
Constify commands maint.c, plus maintenance_print_type
...
In addition to the constification, this fixes a command-repeat bug.
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* typeprint.c (maintenance_print_type): Constify.
* maint.c (maintenance_dump_me, maintenance_demangle)
(maintenance_time_display, maintenance_info_sections)
(maintenance_print_statistics, maintenance_deprecate)
(maintenance_undeprecate): Constify.
(maintenance_do_deprecate): Constify. Use std::string.
(maintenance_selftest): Constify.
* gdbtypes.h (maintenance_print_type): Constify.
2017-09-27 08:44:43 -06:00
Tom Tromey
c482f52ccf
Constify unwind_command
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* hppa-tdep.c (unwind_command): Constify.
2017-09-27 08:44:42 -06:00
Tom Tromey
e100df1a2e
Constify some commands in target-descriptions.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* target-descriptions.c (unset_tdesc_filename_cmd)
(maint_print_c_tdesc_cmd, maintenance_check_xml_descriptions):
Constify.
2017-09-27 08:44:41 -06:00
Tom Tromey
31d56ade0e
Constify maintenance_print_dummy_frames
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* dummy-frame.c (maintenance_print_dummy_frames): Constify.
2017-09-27 08:44:40 -06:00
Tom Tromey
b961da0bb0
Constify some commands in tui.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* tui/tui.c (tui_enable_command, tui_disable_command): Constify.
2017-09-27 08:44:39 -06:00
Tom Tromey
e2d8ae16c0
Constify tui_reg_command
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* tui/tui-regs.c (tui_reg_command): Constify.
2017-09-27 08:44:38 -06:00
Tom Tromey
863779b0c6
Constify some commands in skip.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* skip.c (skip_file_command, skip_function_command)
(skip_enable_command, skip_disable_command, skip_delete_command):
Constify.
2017-09-27 08:44:37 -06:00
Tom Tromey
cdb34d4a1c
Constify some commands in record-btrace.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* record-btrace.c (cmd_record_btrace_bts_start)
(cmd_record_btrace_pt_start): Constify.
2017-09-27 08:44:37 -06:00
Tom Tromey
e99c83e741
Constify some commands in symmisc.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* symmisc.c (maintenance_print_symbols)
(maintenance_print_msymbols, maintenance_print_objfiles)
(maintenance_info_symtabs, maintenance_check_symtabs)
(maintenance_expand_symtabs, maintenance_info_line_tables):
Constify.
2017-09-27 08:44:36 -06:00
Tom Tromey
32faf971cd
Constify new_ui_command
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* top.c (new_ui_command): Constify.
2017-09-27 08:44:35 -06:00
Tom Tromey
2cf311ebad
Constify some commands in symfile.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* symfile.c (add_symbol_file_command)
(remove_symbol_file_command, list_overlays_command)
(map_overlay_command, unmap_overlay_command)
(overlay_auto_command, overlay_manual_command)
(overlay_off_command, overlay_load_command): Constify.
2017-09-27 08:44:34 -06:00
Tom Tromey
e6738699f7
Constify some commands in spu-tdep.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* spu-tdep.c (info_spu_event_command, info_spu_signal_command)
(info_spu_mailbox_command, info_spu_dma_command)
(info_spu_proxydma_command): Constify.
2017-09-27 08:44:33 -06:00
Tom Tromey
aa360cd5dd
Constify some commands in cli-logging.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cli/cli-logging.c (set_logging_on, set_logging_off): Constify.
2017-09-27 08:44:32 -06:00
Tom Tromey
898241a5ba
Constify user_defined_command
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cli/cli-script.c (user_defined_command): Constify.
2017-09-27 08:44:31 -06:00
Tom Tromey
2d0ac1068b
Constify commands in cli-dump.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cli/cli-dump.c (dump_memory_command, dump_value_command)
(dump_srec_memory, dump_srec_value, dump_ihex_memory)
(dump_ihex_value, dump_verilog_memory, dump_verilog_value)
(dump_tekhex_memory, dump_tekhex_value, dump_binary_memory)
(dump_binary_value, append_binary_memory, append_binary_value):
Constify.
(struct dump_context) <func>: Constify.
(add_dump_command): Update.
2017-09-27 08:44:31 -06:00
Tom Tromey
dede02ce4d
Constify some commands in cli-cmds.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cli/cli-cmds.c (show_version, show_configuration)
(source_command, show_user): Constify.
2017-09-27 08:44:30 -06:00
Tom Tromey
d3cb6b99c5
Constify maintenance_print_target_stack
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* target.c (maintenance_print_target_stack): Constify.
2017-09-27 08:44:29 -06:00
Tom Tromey
1970a12f32
Constify interpreter_exec_cmd
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* interps.c (interpreter_exec_cmd): Constify.
2017-09-27 08:44:28 -06:00
Tom Tromey
4124365135
Constify cmd_record_full_restore
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* record-full.c (cmd_record_full_restore): Constify.
2017-09-27 08:44:27 -06:00
Tom Tromey
4465d9db2f
Constify some functions in memattr.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* memattr.c (enable_mem_command, disable_mem_command)
(delete_mem_command): Constify.
2017-09-27 08:44:26 -06:00
Tom Tromey
ad25e4234a
Constify show_convenience
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* value.c (show_convenience): Constify.
2017-09-27 08:44:25 -06:00
Tom Tromey
d64097b17c
Constify core_file_command
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* gdbcore.h (core_file_command): Update.
* corefile.c (core_file_command): Constify.
2017-09-27 08:44:25 -06:00
Tom Tromey
4d4589ef76
Constify maintenance_print_user_registers
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* user-regs.c (maintenance_print_user_registers): Constify.
2017-09-27 08:44:24 -06:00
Tom Tromey
32a7bf17c9
Constify maintenance_cplus_namespace
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cp-namespace.c (maintenance_cplus_namespace): Constify.
2017-09-27 08:44:23 -06:00
Tom Tromey
4a47555179
Constify first_component_command
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cp-support.c (first_component_command): Constify.
2017-09-27 08:44:22 -06:00
Tom Tromey
990b9f9f5a
Constify some functions in psymtab.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* psymtab.c (maintenance_print_psymbols)
(maintenance_info_psymtabs, maintenance_check_psymtabs):
Constify.
2017-09-27 08:44:21 -06:00
Tom Tromey
c281872eec
Constify display_tib
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* windows-tdep.c (display_tib): Constify.
2017-09-27 08:44:20 -06:00
Tom Tromey
5b64bf744c
Constify two functions in linux-fork.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* linux-fork.c (delete_checkpoint_command)
(detach_checkpoint_command): Constify.
2017-09-27 08:44:19 -06:00
Tom Tromey
4ada038f6a
Constify two functions in cp-abi.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cp-abi.c (set_cp_abi_cmd, show_cp_abi_cmd): Constify.
2017-09-27 08:44:19 -06:00
Tom Tromey
57f5a81bd2
Constify dump_arc_instruction_command
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* arc-tdep.c (dump_arc_instruction_command): Constify.
2017-09-27 08:44:18 -06:00
Tom Tromey
b0a8e6c443
Constify two functions in valprint.c
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* valprint.c (set_radix, show_radix): Constify.
2017-09-27 08:44:17 -06:00
Tom Tromey
8d97dc1cea
Constify info_probes_dtrace_command
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* dtrace-probe.c (info_probes_dtrace_command): Constify.
2017-09-27 08:44:16 -06:00
Tom Tromey
eb7c454d73
Constify not_just_help_class_command
...
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* command.h (not_just_help_class_command): Update.
* cli/cli-decode.h (not_just_help_class_command): Update.
* cli/cli-decode.c (not_just_help_class_command): Constify.
2017-09-27 08:44:15 -06:00
Tom Tromey
e4e3333549
Constify add_cmd gdb_bfd.c
...
This constifies a command function in gdb_bfd.c.
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* gdb_bfd.c (maintenance_info_bfds): Constify.
2017-09-27 08:44:14 -06:00
Tom Tromey
0450cc4ce8
Add add_cmd function overloads
...
This adds two add_cmd overloads: one whose callback takes a const char *,
and one that doesn't accept a function at all. The no-function overload
was introduced to avoid ambiguity when NULL was passed as the function.
Long term the goal is for all commands to take const arguments, and
for the non-const variants to be removed entirely.
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* cli/cli-decode.c (add_cmd, set_cmd_cfunc): New function
overloads.
(do_add_cmd): Rename from add_cmd. Don't call set_cmd_cfunc.
(do_const_cfunc): New function.
(cmd_cfunc_eq): New overload.
(cli_user_command_p): Check do_const_cfunc.
* cli/cli-decode.h (struct cmd_list_element) <function>: New field
const_cfunc.
* command.h (add_cmd): Add const overload and no-function
overload.
(set_cmd_cfunc): Add const overload.
(cmd_const_cfunc_ftype): Declare.
(cmd_cfunc_eq): Add const overload.
* breakpoint.c, cli-cmds.c, cli-dump.c, guile/scm-cmd.c,
python/py-cmd.c, target.c, tracepoint.c: Use no-function add_cmd
overload.
2017-09-27 08:44:14 -06:00
Tom Tromey
a9bbfbd85f
Add support for __VA_OPT__
...
C++2a adds a "__VA_OPT__" feature that can be used to control the
pesky "," emission when the final (variable) argument of a variadic
macro is empty. This patch implements this feature for gdb. (A patch
to implement it for gcc is pending.)
gdb/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* macroexp.c (get_next_token_for_substitution): New function.
(substitute_args): Call it. Check for __VA_OPT__.
gdb/testsuite/ChangeLog
2017-09-27 Tom Tromey <tom@tromey.com>
* gdb.base/macscp.exp: Add __VA_OPT__ tests.
2017-09-27 07:51:33 -06:00
Nick Clifton
1948519604
Prevent an infinite loop in the DWARF parsing code when encountering a CU structure with a small negative size.
...
PR 22219
* dwarf.c (process_debug_info): Add a check for a negative
cu_length field.
2017-09-27 10:42:51 +01:00
Alan Modra
6bd6a03d69
PR22216, infinite loop in readelf process_symbol_table
...
This should make readelf bombproof given a fuzzed DT_HASH. Also
removes a bogus check that would have resulted in wrong histograms.
PR 22216
* readelf.c (process_symbol_table): Check that DT_HASH symbol
chains are only visited once, and report an error if not. Display
invalid symbol index if chain is out of range. Use the same logic
when calculating histograms rather than the PR 17531 fix. Delete
bogus check that chained index is less than number of buckets.
2017-09-27 15:54:18 +09:30
Kuan-Lin Chen
cd28e7aaf3
nds32: Fix a tautological comparison.
2017-09-27 13:07:19 +08:00