798a7429f9
This patch removes some unused variables, found with -Wunused. I have not removed everything reported by -Wunused, because some expressions such as struct type *arg_type = check_typedef (value_type); in bfin-tdep.c could have an unexpected but important side-effect. I removed others that I considered more low-risk, such as: struct gdbarch *gdbarch = get_objfile_arch (objfile); I tested building with Python 2/Python 3/no Python, with/without expat, with/without libipt and with/without babeltrace. gdb/ChangeLog: * ada-lang.c (ada_collect_symbol_completion_matches): Remove unused variables. (ada_is_redundant_range_encoding): Likewise. * ada-varobj.c (ada_varobj_get_value_of_array_variable): Likewise. * alpha-tdep.c (alpha_software_single_step): Likewise. * arm-tdep.c (_initialize_arm_tdep): Likewise. * auto-load.c (info_auto_load_cmd): Likewise. * break-catch-syscall.c (insert_catch_syscall): Likewise. (remove_catch_syscall): Likewise. * breakpoint.c (condition_completer): Likewise. (clear_command): Likewise. (update_breakpoint_locations): Likewise. * btrace.c (btrace_disable): Likewise. (btrace_teardown): Likewise. (btrace_maint_update_pt_packets): Likewise. (maint_btrace_clear_cmd): Likewise. * cli/cli-decode.c (lookup_cmd_1): Likewise. (lookup_cmd_composition): Likewise. * cli/cli-dump.c (scan_filename): Likewise. (restore_command): Likewise. * compile/compile-loc2c.c (compute_stack_depth): Likewise. * compile/compile-object-load.c (compile_object_load): Likewise. * compile/compile-object-run.c (compile_object_run): Likewise. * compile/compile.c (compile_to_object): Likewise. * completer.c (filename_completer): Likewise. (complete_files_symbols): Likewise. (complete_expression): Likewise. * corelow.c (core_open): Likewise. * ctf.c (ctf_start): Likewise. (ctf_write_status): Likewise. (ctf_write_uploaded_tsv): Likewise. (ctf_write_definition_end): Likewise. (ctf_open_dir): Likewise. (ctf_xfer_partial): Likewise. (ctf_trace_find): Likewise. * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Likewise. * dwarf2loc.c (allocate_piece_closure): Likewise. (indirect_pieced_value): Likewise. (dwarf2_evaluate_loc_desc_full): Likewise. * dwarf2read.c (dw2_expand_marked_cus): Likewise. (dw2_expand_symtabs_matching): Likewise. (dw2_map_symbol_filenames): Likewise. (read_and_check_comp_unit_head): Likewise. (read_cutu_die_from_dwo): Likewise. (lookup_dwo_unit): Likewise. (read_comp_units_from_section): Likewise. (dwarf2_compute_name): Likewise. (handle_DW_AT_stmt_list): Likewise. (create_cus_hash_table): Likewise. (create_dwp_v2_section): Likewise. (dwarf2_rnglists_process): Likewise. (dwarf2_ranges_process): Likewise. (dwarf2_record_block_ranges): Likewise. (is_vtable_name): Likewise. (read_formatted_entries): Likewise. (skip_form_bytes): Likewise. * elfread.c (elf_symtab_read): Likewise. * exec.c (exec_file_command): Likewise. * f-valprint.c (f_val_print): Likewise. (info_common_command_for_block): Likewise. * guile/guile.c (initialize_scheme_side): Likewise. * guile/scm-breakpoint.c (gdbscm_breakpoint_commands): Likewise. * guile/scm-cmd.c (cmdscm_completer): Likewise. (gdbscm_register_command_x): Likewise. * guile/scm-frame.c (gdbscm_frame_read_var): Likewise. * guile/scm-param.c (gdbscm_parameter_value): Likewise. * guile/scm-ports.c (file_port_magic): Likewise. * guile/scm-pretty-print.c (ppscm_search_pp_list): Likewise. (ppscm_pretty_print_one_value): Likewise. (ppscm_print_children): Likewise. * guile/scm-string.c (gdbscm_string_to_argv): Likewise. * guile/scm-symtab.c (gdbscm_sal_symtab): Likewise. * guile/scm-type.c (gdbscm_type_next_field_x): Likewise. * guile/scm-utils.c (gdbscm_parse_function_args): Likewise. * i386-tdep.c (i386_register_reggroup_p): Likewise. * infcmd.c (run_command_1): Likewise. (until_next_fsm_clean_up): Likewise. * linespec.c (linespec_complete): Likewise. (find_label_symbols): Likewise. * m2-valprint.c (m2_val_print): Likewise. * memattr.c (require_user_regions): Likewise. (lookup_mem_region): Likewise. (disable_mem_command): Likewise. (mem_delete): Likewise. * mep-tdep.c (mep_register_name): Likewise. (mep_analyze_prologue): Likewise. * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Likewise. * mi/mi-interp.c (mi_on_sync_execution_done): Likewise. * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise. * microblaze-linux-tdep.c (microblaze_linux_init_abi): Likewise. * minidebug.c (lzma_open): Likewise. * minsyms.c (lookup_minimal_symbol): Likewise. * mips-linux-tdep.c (mips64_fill_fpregset): Likewise. * mips-tdep.c (mips_stub_frame_sniffer): Likewise. (mips_o64_return_value): Likewise. (mips_single_step_through_delay): Likewise. (_initialize_mips_tdep): Likewise. * nios2-tdep.c (nios2_push_dummy_call): Likewise. (nios2_software_single_step): Likewise. * parse.c (find_minsym_type_and_address): Likewise. * psymtab.c (psym_relocate): Likewise. * python/py-breakpoint.c (bppy_get_commands): Likewise. (gdbpy_breakpoint_modified): Likewise. * python/py-infevents.c (create_inferior_call_event_object): Likewise. * python/py-record-btrace.c (btpy_list_item): Likewise. * python/py-type.c (typy_str): Likewise. * python/py-value.c (valpy_call): Likewise. * python/python.c (do_start_initialization): Likewise. * record-btrace.c (record_btrace_insn_history_range): Likewise. (record_btrace_call_history_range): Likewise. (record_btrace_record_method): Likewise. (record_btrace_xfer_partial): Likewise. (btrace_get_frame_function): Likewise. * record-full.c (record_full_open): Likewise. * record.c (get_context_size): Likewise. * registry.h (DEFINE_REGISTRY): Likewise. * remote-fileio.c (remote_fileio_request): Likewise. * remote.c (remote_update_thread_list): Likewise. (remote_check_symbols): Likewise. (remote_commit_resume): Likewise. (remote_interrupt): Likewise. (remote_insert_breakpoint): Likewise. (compare_sections_command): Likewise. * rust-exp.y (super_name): Likewise. (lex_string): Likewise. (convert_ast_to_type): Likewise. (convert_ast_to_expression): Likewise. * rust-lang.c (rust_print_struct_def): Likewise. (rust_print_type): Likewise. (rust_evaluate_subexp): Likewise. * rx-tdep.c (rx_register_type): Likewise. * ser-event.c (serial_event_clear): Likewise. * serial.c (serial_open): Likewise. * spu-tdep.c (spu_overlay_new_objfile): Likewise. * symfile.c (section_is_overlay): Likewise. (overlay_unmapped_address): Likewise. (overlay_mapped_address): Likewise. (simple_overlay_update_1): Likewise. (simple_overlay_update): Likewise. * symtab.c (symbol_find_demangled_name): Likewise. (search_symbols): Likewise. * target-descriptions.c (tdesc_predefined_type): Likewise. * target.c (target_commit_resume): Likewise. * thread.c (print_selected_thread_frame): Likewise. * top.c (new_ui_command): Likewise. (gdb_readline_no_editing): Likewise. * tracefile-tfile.c (tfile_open): Likewise. * tracepoint.c (create_tsv_from_upload): Likewise. * utils.c (quit): Likewise. (defaulted_query): Likewise. * valarith.c (value_concat): Likewise. * xml-syscall.c (xml_list_syscalls_by_group): Likewise. * xml-tdesc.c (target_fetch_description_xml): Likewise. * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise. (xtensa_pseudo_register_write): Likewise. gdb/gdbserver/ChangeLog: * regcache.c (registers_to_string): Remove unused variable.
254 lines
8.5 KiB
C
254 lines
8.5 KiB
C
/* Macros for general registry objects.
|
|
|
|
Copyright (C) 2011-2017 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef REGISTRY_H
|
|
#define REGISTRY_H
|
|
|
|
/* The macros here implement a template type and functions for
|
|
associating some user data with a container object.
|
|
|
|
A registry is associated with a struct tag name. To attach a
|
|
registry to a structure, use DEFINE_REGISTRY. This takes the
|
|
structure tag and an access method as arguments. In the usual
|
|
case, where the registry fields appear directly in the struct, you
|
|
can use the 'REGISTRY_FIELDS' macro to declare the fields in the
|
|
struct definition, and you can pass 'REGISTRY_ACCESS_FIELD' as the
|
|
access argument to DEFINE_REGISTRY. In other cases, use
|
|
REGISTRY_FIELDS to define the fields in the appropriate spot, and
|
|
then define your own accessor to find the registry field structure
|
|
given an instance of your type.
|
|
|
|
The API user requests a key from a registry during gdb
|
|
initialization. Later this key can be used to associate some
|
|
module-specific data with a specific container object.
|
|
|
|
The exported API is best used via the wrapper macros:
|
|
|
|
- register_TAG_data(TAG)
|
|
Get a new key for the container type TAG.
|
|
|
|
- register_TAG_data_with_cleanup(TAG, SAVE, FREE)
|
|
Get a new key for the container type TAG.
|
|
SAVE and FREE are defined as void (*) (struct TAG *object, void *data)
|
|
When the container object OBJECT is destroyed, first all registered SAVE
|
|
functions are called.
|
|
Then all FREE functions are called.
|
|
Either or both may be NULL. DATA is the data associated with the
|
|
container object OBJECT.
|
|
|
|
- clear_TAG_data(TAG, OBJECT)
|
|
Clear all the data associated with OBJECT. Should be called by the
|
|
container implementation when a container object is destroyed.
|
|
|
|
- set_TAG_data(TAG, OBJECT, KEY, DATA)
|
|
Set the data on an object.
|
|
|
|
- TAG_data(TAG, OBJECT, KEY)
|
|
Fetch the data for an object; returns NULL if it has not been set.
|
|
*/
|
|
|
|
/* This structure is used in a container to hold the data that the
|
|
registry uses. */
|
|
|
|
struct registry_fields
|
|
{
|
|
void **data;
|
|
unsigned num_data;
|
|
};
|
|
|
|
/* This macro is used in a container struct definition to define the
|
|
fields used by the registry code. */
|
|
|
|
#define REGISTRY_FIELDS \
|
|
struct registry_fields registry_data
|
|
|
|
/* A convenience macro for the typical case where the registry data is
|
|
kept as fields of the object. This can be passed as the ACCESS
|
|
method to DEFINE_REGISTRY. */
|
|
|
|
#define REGISTRY_ACCESS_FIELD(CONTAINER) \
|
|
(CONTAINER)
|
|
|
|
/* Opaque type representing a container type with a registry. This
|
|
type is never defined. This is used to factor out common
|
|
functionality of all struct tag names into common code. IOW,
|
|
"struct tag name" pointers are cast to and from "struct
|
|
registry_container" pointers when calling the common registry
|
|
"backend" functions. */
|
|
struct registry_container;
|
|
|
|
/* Registry callbacks have this type. */
|
|
typedef void (*registry_data_callback) (struct registry_container *, void *);
|
|
|
|
struct registry_data
|
|
{
|
|
unsigned index;
|
|
registry_data_callback save;
|
|
registry_data_callback free;
|
|
};
|
|
|
|
struct registry_data_registration
|
|
{
|
|
struct registry_data *data;
|
|
struct registry_data_registration *next;
|
|
};
|
|
|
|
struct registry_data_registry
|
|
{
|
|
struct registry_data_registration *registrations;
|
|
unsigned num_registrations;
|
|
};
|
|
|
|
/* Registry backend functions. Client code uses the frontend
|
|
functions defined by DEFINE_REGISTRY below instead. */
|
|
|
|
const struct registry_data *register_data_with_cleanup
|
|
(struct registry_data_registry *registry,
|
|
registry_data_callback save,
|
|
registry_data_callback free);
|
|
|
|
void registry_alloc_data (struct registry_data_registry *registry,
|
|
struct registry_fields *registry_fields);
|
|
|
|
/* Cast FUNC and CONTAINER to the real types, and call FUNC, also
|
|
passing DATA. */
|
|
typedef void (*registry_callback_adaptor) (registry_data_callback func,
|
|
struct registry_container *container,
|
|
void *data);
|
|
|
|
void registry_clear_data (struct registry_data_registry *data_registry,
|
|
registry_callback_adaptor adaptor,
|
|
struct registry_container *container,
|
|
struct registry_fields *fields);
|
|
|
|
void registry_container_free_data (struct registry_data_registry *data_registry,
|
|
registry_callback_adaptor adaptor,
|
|
struct registry_container *container,
|
|
struct registry_fields *fields);
|
|
|
|
void registry_set_data (struct registry_fields *fields,
|
|
const struct registry_data *data,
|
|
void *value);
|
|
|
|
void *registry_data (struct registry_fields *fields,
|
|
const struct registry_data *data);
|
|
|
|
/* Define a new registry implementation. */
|
|
|
|
#define DEFINE_REGISTRY(TAG, ACCESS) \
|
|
struct registry_data_registry TAG ## _data_registry = { NULL, 0 }; \
|
|
\
|
|
const struct TAG ## _data * \
|
|
register_ ## TAG ## _data_with_cleanup (void (*save) (struct TAG *, void *), \
|
|
void (*free) (struct TAG *, void *)) \
|
|
{ \
|
|
return (struct TAG ## _data *) \
|
|
register_data_with_cleanup (&TAG ## _data_registry, \
|
|
(registry_data_callback) save, \
|
|
(registry_data_callback) free); \
|
|
} \
|
|
\
|
|
const struct TAG ## _data * \
|
|
register_ ## TAG ## _data (void) \
|
|
{ \
|
|
return register_ ## TAG ## _data_with_cleanup (NULL, NULL); \
|
|
} \
|
|
\
|
|
static void \
|
|
TAG ## _alloc_data (struct TAG *container) \
|
|
{ \
|
|
struct registry_fields *rdata = &ACCESS (container)->registry_data; \
|
|
\
|
|
registry_alloc_data (&TAG ## _data_registry, rdata); \
|
|
} \
|
|
\
|
|
static void \
|
|
TAG ## registry_callback_adaptor (registry_data_callback func, \
|
|
struct registry_container *container, \
|
|
void *data) \
|
|
{ \
|
|
struct TAG *tagged_container = (struct TAG *) container; \
|
|
\
|
|
registry_ ## TAG ## _callback tagged_func \
|
|
= (registry_ ## TAG ## _callback) func; \
|
|
\
|
|
tagged_func (tagged_container, data); \
|
|
} \
|
|
\
|
|
void \
|
|
clear_ ## TAG ## _data (struct TAG *container) \
|
|
{ \
|
|
struct registry_fields *rdata = &ACCESS (container)->registry_data; \
|
|
\
|
|
registry_clear_data (&TAG ## _data_registry, \
|
|
TAG ## registry_callback_adaptor, \
|
|
(struct registry_container *) container, \
|
|
rdata); \
|
|
} \
|
|
\
|
|
static void \
|
|
TAG ## _free_data (struct TAG *container) \
|
|
{ \
|
|
struct registry_fields *rdata = &ACCESS (container)->registry_data; \
|
|
\
|
|
registry_container_free_data (&TAG ## _data_registry, \
|
|
TAG ## registry_callback_adaptor, \
|
|
(struct registry_container *) container, \
|
|
rdata); \
|
|
} \
|
|
\
|
|
void \
|
|
set_ ## TAG ## _data (struct TAG *container, \
|
|
const struct TAG ## _data *data, \
|
|
void *value) \
|
|
{ \
|
|
struct registry_fields *rdata = &ACCESS (container)->registry_data; \
|
|
\
|
|
registry_set_data (rdata, \
|
|
(struct registry_data *) data, \
|
|
value); \
|
|
} \
|
|
\
|
|
void * \
|
|
TAG ## _data (struct TAG *container, const struct TAG ## _data *data) \
|
|
{ \
|
|
struct registry_fields *rdata = &ACCESS (container)->registry_data; \
|
|
\
|
|
return registry_data (rdata, \
|
|
(struct registry_data *) data); \
|
|
}
|
|
|
|
|
|
/* External declarations for the registry functions. */
|
|
|
|
#define DECLARE_REGISTRY(TAG) \
|
|
struct TAG ## _data; \
|
|
typedef void (*registry_ ## TAG ## _callback) (struct TAG *, void *); \
|
|
extern const struct TAG ## _data *register_ ## TAG ## _data (void); \
|
|
extern const struct TAG ## _data *register_ ## TAG ## _data_with_cleanup \
|
|
(registry_ ## TAG ## _callback save, registry_ ## TAG ## _callback free); \
|
|
extern void clear_ ## TAG ## _data (struct TAG *); \
|
|
extern void set_ ## TAG ## _data (struct TAG *, \
|
|
const struct TAG ## _data *data, \
|
|
void *value); \
|
|
extern void *TAG ## _data (struct TAG *, \
|
|
const struct TAG ## _data *data);
|
|
|
|
#endif /* REGISTRY_H */
|