590042fc45
With this patch, the help docs now respect 2 invariants: * The first line of a command help is terminated by a '.' character. * The last character of a command help is not a newline character. Note that the changes for the last invariant were done by Tom, as part of : [PATCH] Remove trailing newlines from help text https://sourceware.org/ml/gdb-patches/2019-06/msg00050.html but some occurrences have been re-introduced since then. Some help docs had to be rephrased/restructured to respect the above invariants. Before this patch, print_doc_line was printing the first line of a command help documentation, but stopping at the first '.' or ',' character. This was giving inconsistent results : * The first line of command helps was sometimes '.' terminated, sometimes not. * The first line of command helps was not always designed to be readable/understandable/unambiguous when stopping at the first '.' or ',' character. This e.g. created the following inconsistencies/problems: < catch exception -- Catch Ada exceptions < catch handlers -- Catch Ada exceptions < catch syscall -- Catch system calls by their names < down-silently -- Same as the `down' command while the new help is: > catch exception -- Catch Ada exceptions, when raised. > catch handlers -- Catch Ada exceptions, when handled. > catch syscall -- Catch system calls by their names, groups and/or numbers. > down-silently -- Same as the `down' command, but does not print anything. Also, the command help doc should not be terminated by a newline character, but this was not respected by all commands. The cli-option -OPT framework re-introduced some occurences. So, the -OPT build help framework was changed to not output newlines at the end of %OPTIONS% replacement. This patch changes the help documentations to ensure the 2 invariants given above. It implied to slightly rephrase or restructure some help docs. Based on the above invariants, print_doc_line (called by 'apropos' and 'help' commands to print the first line of a command help) now outputs the full first line of a command help. This all results in a lot of small changes in the produced help docs. There are less code changes than changes in the help docs, as a lot of docs are produced by some code (e.g. the remote packet usage settings). gdb/ChangeLog 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be> * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument. * cli/cli-decode.c (print_doc_line): Likewise. It now prints the full first line, except when FOR_VALUE_PREFIX. In this case, the trailing '.' is not output, and the first character is uppercased. (print_help_for_command): Update call to print_doc_line. (print_doc_of_command): Likewise. * cli/cli-setshow.c (deprecated_show_value_hack): Likewise. * cli/cli-option.c (append_indented_doc): Do not append newline. (build_help_option): Append newline after first appended_indented_doc only if a second call is done. (build_help): Append 2 new lines before each option, except the first one. * compile/compile.c (_initialize_compile): Add new lines after %OPTIONS%, when not at the end of the help. Change help doc or code producing the help doc to respect the invariants. * maint-test-options.c (_initialize_maint_test_options): Likewise. Also removed the new line after 'Options:', as all other commands do not put an empty line between 'Options:' and the first option. * printcmd.c (_initialize_printcmd): Likewise. * stack.c (_initialize_stack): Likewise. * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was incorrectly telling COMMAND is optional. * ada-lang.c (_initialize_ada_language): Change help doc or code producing the help doc to respect the invariants. * ada-tasks.c (_initialize_ada_tasks): Likewise. * breakpoint.c (_initialize_breakpoint): Likewise. * cli/cli-cmds.c (_initialize_cli_cmds): Likewise. * cli/cli-logging.c (_initialize_cli_logging): Likewise. * cli/cli-setshow.c (_initialize_cli_setshow): Likewise. * cli/cli-style.c (cli_style_option::add_setshow_commands, _initialize_cli_style): Likewise. * corelow.c (core_target_info): Likewise. * dwarf-index-cache.c (_initialize_index_cache): Likewise. * dwarf2read.c (_initialize_dwarf2_read): Likewise. * filesystem.c (_initialize_filesystem): Likewise. * frame.c (_initialize_frame): Likewise. * gnu-nat.c (add_task_commands): Likewise. * infcall.c (_initialize_infcall): Likewise. * infcmd.c (_initialize_infcmd): Likewise. * interps.c (_initialize_interpreter): Likewise. * language.c (_initialize_language): Likewise. * linux-fork.c (_initialize_linux_fork): Likewise. * maint-test-settings.c (_initialize_maint_test_settings): Likewise. * maint.c (_initialize_maint_cmds): Likewise. * memattr.c (_initialize_mem): Likewise. * printcmd.c (_initialize_printcmd): Likewise. * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq, _RegEx): Likewise. * ravenscar-thread.c (_initialize_ravenscar): Likewise. * record-btrace.c (_initialize_record_btrace): Likewise. * record-full.c (_initialize_record_full): Likewise. * record.c (_initialize_record): Likewise. * regcache-dump.c (_initialize_regcache_dump): Likewise. * regcache.c (_initialize_regcache): Likewise. * remote.c (add_packet_config_cmd, init_remote_threadtests, _initialize_remote): Likewise. * ser-tcp.c (_initialize_ser_tcp): Likewise. * serial.c (_initialize_serial): Likewise. * skip.c (_initialize_step_skip): Likewise. * source.c (_initialize_source): Likewise. * stack.c (_initialize_stack): Likewise. * symfile.c (_initialize_symfile): Likewise. * symtab.c (_initialize_symtab): Likewise. * target-descriptions.c (_initialize_target_descriptions): Likewise. * top.c (init_main): Likewise. * tracefile-tfile.c (tfile_target_info): Likewise. * tracepoint.c (_initialize_tracepoint): Likewise. * tui/tui-win.c (_initialize_tui_win): Likewise. * utils.c (add_internal_problem_command): Likewise. * valprint.c (value_print_option_defs): Likewise. gdb/testsuite/ChangeLog 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be> * gdb.base/style.exp: Update tests for help doc new invariants. * gdb.base/help.exp: Likewise.
743 lines
21 KiB
C
743 lines
21 KiB
C
/* Skipping uninteresting files and functions while stepping.
|
|
|
|
Copyright (C) 2011-2019 Free Software Foundation, Inc.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "skip.h"
|
|
#include "value.h"
|
|
#include "valprint.h"
|
|
#include "ui-out.h"
|
|
#include "symtab.h"
|
|
#include "gdbcmd.h"
|
|
#include "command.h"
|
|
#include "completer.h"
|
|
#include "stack.h"
|
|
#include "cli/cli-utils.h"
|
|
#include "arch-utils.h"
|
|
#include "linespec.h"
|
|
#include "objfiles.h"
|
|
#include "breakpoint.h" /* for get_sal_arch () */
|
|
#include "source.h"
|
|
#include "filenames.h"
|
|
#include "fnmatch.h"
|
|
#include "gdb_regex.h"
|
|
#include "gdbsupport/gdb_optional.h"
|
|
#include <list>
|
|
|
|
/* True if we want to print debug printouts related to file/function
|
|
skipping. */
|
|
static int debug_skip = 0;
|
|
|
|
class skiplist_entry
|
|
{
|
|
public:
|
|
/* Create a skiplist_entry object and add it to the chain. */
|
|
static void add_entry (bool file_is_glob,
|
|
std::string &&file,
|
|
bool function_is_regexp,
|
|
std::string &&function);
|
|
|
|
/* Return true if the skip entry has a file or glob-style file
|
|
pattern that matches FUNCTION_SAL. */
|
|
bool skip_file_p (const symtab_and_line &function_sal) const;
|
|
|
|
/* Return true if the skip entry has a function or function regexp
|
|
that matches FUNCTION_NAME. */
|
|
bool skip_function_p (const char *function_name) const;
|
|
|
|
/* Getters. */
|
|
int number () const { return m_number; };
|
|
bool enabled () const { return m_enabled; };
|
|
bool file_is_glob () const { return m_file_is_glob; }
|
|
const std::string &file () const { return m_file; }
|
|
const std::string &function () const { return m_function; }
|
|
bool function_is_regexp () const { return m_function_is_regexp; }
|
|
|
|
/* Setters. */
|
|
void enable () { m_enabled = true; };
|
|
void disable () { m_enabled = false; };
|
|
|
|
/* Disable copy. */
|
|
skiplist_entry (const skiplist_entry &) = delete;
|
|
void operator= (const skiplist_entry &) = delete;
|
|
|
|
private:
|
|
/* Key that grants access to the constructor. */
|
|
struct private_key {};
|
|
public:
|
|
/* Public so we can construct with container::emplace_back. Since
|
|
it requires a private class key, it can't be called from outside.
|
|
Use the add_entry static factory method to construct instead. */
|
|
skiplist_entry (bool file_is_glob, std::string &&file,
|
|
bool function_is_regexp, std::string &&function,
|
|
private_key);
|
|
|
|
private:
|
|
/* Return true if we're stopped at a file to be skipped. */
|
|
bool do_skip_file_p (const symtab_and_line &function_sal) const;
|
|
|
|
/* Return true if we're stopped at a globbed file to be skipped. */
|
|
bool do_skip_gfile_p (const symtab_and_line &function_sal) const;
|
|
|
|
private: /* data */
|
|
int m_number = -1;
|
|
|
|
/* True if FILE is a glob-style pattern.
|
|
Otherwise it is the plain file name (possibly with directories). */
|
|
bool m_file_is_glob;
|
|
|
|
/* The name of the file or empty if no name. */
|
|
std::string m_file;
|
|
|
|
/* True if FUNCTION is a regexp.
|
|
Otherwise it is a plain function name (possibly with arguments,
|
|
for C++). */
|
|
bool m_function_is_regexp;
|
|
|
|
/* The name of the function or empty if no name. */
|
|
std::string m_function;
|
|
|
|
/* If this is a function regexp, the compiled form. */
|
|
gdb::optional<compiled_regex> m_compiled_function_regexp;
|
|
|
|
/* Enabled/disabled state. */
|
|
bool m_enabled = true;
|
|
};
|
|
|
|
static std::list<skiplist_entry> skiplist_entries;
|
|
static int highest_skiplist_entry_num = 0;
|
|
|
|
skiplist_entry::skiplist_entry (bool file_is_glob,
|
|
std::string &&file,
|
|
bool function_is_regexp,
|
|
std::string &&function,
|
|
private_key)
|
|
: m_file_is_glob (file_is_glob),
|
|
m_file (std::move (file)),
|
|
m_function_is_regexp (function_is_regexp),
|
|
m_function (std::move (function))
|
|
{
|
|
gdb_assert (!m_file.empty () || !m_function.empty ());
|
|
|
|
if (m_file_is_glob)
|
|
gdb_assert (!m_file.empty ());
|
|
|
|
if (m_function_is_regexp)
|
|
{
|
|
gdb_assert (!m_function.empty ());
|
|
|
|
int flags = REG_NOSUB;
|
|
#ifdef REG_EXTENDED
|
|
flags |= REG_EXTENDED;
|
|
#endif
|
|
|
|
gdb_assert (!m_function.empty ());
|
|
m_compiled_function_regexp.emplace (m_function.c_str (), flags,
|
|
_("regexp"));
|
|
}
|
|
}
|
|
|
|
void
|
|
skiplist_entry::add_entry (bool file_is_glob, std::string &&file,
|
|
bool function_is_regexp, std::string &&function)
|
|
{
|
|
skiplist_entries.emplace_back (file_is_glob,
|
|
std::move (file),
|
|
function_is_regexp,
|
|
std::move (function),
|
|
private_key {});
|
|
|
|
/* Incremented after push_back, in case push_back throws. */
|
|
skiplist_entries.back ().m_number = ++highest_skiplist_entry_num;
|
|
}
|
|
|
|
static void
|
|
skip_file_command (const char *arg, int from_tty)
|
|
{
|
|
struct symtab *symtab;
|
|
const char *filename = NULL;
|
|
|
|
/* If no argument was given, try to default to the last
|
|
displayed codepoint. */
|
|
if (arg == NULL)
|
|
{
|
|
symtab = get_last_displayed_symtab ();
|
|
if (symtab == NULL)
|
|
error (_("No default file now."));
|
|
|
|
/* It is not a typo, symtab_to_filename_for_display woule be needlessly
|
|
ambiguous. */
|
|
filename = symtab_to_fullname (symtab);
|
|
}
|
|
else
|
|
filename = arg;
|
|
|
|
skiplist_entry::add_entry (false, std::string (filename),
|
|
false, std::string ());
|
|
|
|
printf_filtered (_("File %s will be skipped when stepping.\n"), filename);
|
|
}
|
|
|
|
/* Create a skiplist entry for the given function NAME and add it to the
|
|
list. */
|
|
|
|
static void
|
|
skip_function (const char *name)
|
|
{
|
|
skiplist_entry::add_entry (false, std::string (), false, std::string (name));
|
|
|
|
printf_filtered (_("Function %s will be skipped when stepping.\n"), name);
|
|
}
|
|
|
|
static void
|
|
skip_function_command (const char *arg, int from_tty)
|
|
{
|
|
/* Default to the current function if no argument is given. */
|
|
if (arg == NULL)
|
|
{
|
|
const char *name = NULL;
|
|
CORE_ADDR pc;
|
|
|
|
if (!last_displayed_sal_is_valid ())
|
|
error (_("No default function now."));
|
|
|
|
pc = get_last_displayed_addr ();
|
|
if (!find_pc_partial_function (pc, &name, NULL, NULL))
|
|
{
|
|
error (_("No function found containing current program point %s."),
|
|
paddress (get_current_arch (), pc));
|
|
}
|
|
skip_function (name);
|
|
return;
|
|
}
|
|
|
|
skip_function (arg);
|
|
}
|
|
|
|
/* Process "skip ..." that does not match "skip file" or "skip function". */
|
|
|
|
static void
|
|
skip_command (const char *arg, int from_tty)
|
|
{
|
|
const char *file = NULL;
|
|
const char *gfile = NULL;
|
|
const char *function = NULL;
|
|
const char *rfunction = NULL;
|
|
int i;
|
|
|
|
if (arg == NULL)
|
|
{
|
|
skip_function_command (arg, from_tty);
|
|
return;
|
|
}
|
|
|
|
gdb_argv argv (arg);
|
|
|
|
for (i = 0; argv[i] != NULL; ++i)
|
|
{
|
|
const char *p = argv[i];
|
|
const char *value = argv[i + 1];
|
|
|
|
if (strcmp (p, "-fi") == 0
|
|
|| strcmp (p, "-file") == 0)
|
|
{
|
|
if (value == NULL)
|
|
error (_("Missing value for %s option."), p);
|
|
file = value;
|
|
++i;
|
|
}
|
|
else if (strcmp (p, "-gfi") == 0
|
|
|| strcmp (p, "-gfile") == 0)
|
|
{
|
|
if (value == NULL)
|
|
error (_("Missing value for %s option."), p);
|
|
gfile = value;
|
|
++i;
|
|
}
|
|
else if (strcmp (p, "-fu") == 0
|
|
|| strcmp (p, "-function") == 0)
|
|
{
|
|
if (value == NULL)
|
|
error (_("Missing value for %s option."), p);
|
|
function = value;
|
|
++i;
|
|
}
|
|
else if (strcmp (p, "-rfu") == 0
|
|
|| strcmp (p, "-rfunction") == 0)
|
|
{
|
|
if (value == NULL)
|
|
error (_("Missing value for %s option."), p);
|
|
rfunction = value;
|
|
++i;
|
|
}
|
|
else if (*p == '-')
|
|
error (_("Invalid skip option: %s"), p);
|
|
else if (i == 0)
|
|
{
|
|
/* Assume the user entered "skip FUNCTION-NAME".
|
|
FUNCTION-NAME may be `foo (int)', and therefore we pass the
|
|
complete original arg to skip_function command as if the user
|
|
typed "skip function arg". */
|
|
skip_function_command (arg, from_tty);
|
|
return;
|
|
}
|
|
else
|
|
error (_("Invalid argument: %s"), p);
|
|
}
|
|
|
|
if (file != NULL && gfile != NULL)
|
|
error (_("Cannot specify both -file and -gfile."));
|
|
|
|
if (function != NULL && rfunction != NULL)
|
|
error (_("Cannot specify both -function and -rfunction."));
|
|
|
|
/* This shouldn't happen as "skip" by itself gets punted to
|
|
skip_function_command. */
|
|
gdb_assert (file != NULL || gfile != NULL
|
|
|| function != NULL || rfunction != NULL);
|
|
|
|
std::string entry_file;
|
|
if (file != NULL)
|
|
entry_file = file;
|
|
else if (gfile != NULL)
|
|
entry_file = gfile;
|
|
|
|
std::string entry_function;
|
|
if (function != NULL)
|
|
entry_function = function;
|
|
else if (rfunction != NULL)
|
|
entry_function = rfunction;
|
|
|
|
skiplist_entry::add_entry (gfile != NULL, std::move (entry_file),
|
|
rfunction != NULL, std::move (entry_function));
|
|
|
|
/* I18N concerns drive some of the choices here (we can't piece together
|
|
the output too much). OTOH we want to keep this simple. Therefore the
|
|
only polish we add to the output is to append "(s)" to "File" or
|
|
"Function" if they're a glob/regexp. */
|
|
{
|
|
const char *file_to_print = file != NULL ? file : gfile;
|
|
const char *function_to_print = function != NULL ? function : rfunction;
|
|
const char *file_text = gfile != NULL ? _("File(s)") : _("File");
|
|
const char *lower_file_text = gfile != NULL ? _("file(s)") : _("file");
|
|
const char *function_text
|
|
= rfunction != NULL ? _("Function(s)") : _("Function");
|
|
|
|
if (function_to_print == NULL)
|
|
{
|
|
printf_filtered (_("%s %s will be skipped when stepping.\n"),
|
|
file_text, file_to_print);
|
|
}
|
|
else if (file_to_print == NULL)
|
|
{
|
|
printf_filtered (_("%s %s will be skipped when stepping.\n"),
|
|
function_text, function_to_print);
|
|
}
|
|
else
|
|
{
|
|
printf_filtered (_("%s %s in %s %s will be skipped"
|
|
" when stepping.\n"),
|
|
function_text, function_to_print,
|
|
lower_file_text, file_to_print);
|
|
}
|
|
}
|
|
}
|
|
|
|
static void
|
|
info_skip_command (const char *arg, int from_tty)
|
|
{
|
|
int num_printable_entries = 0;
|
|
struct value_print_options opts;
|
|
|
|
get_user_print_options (&opts);
|
|
|
|
/* Count the number of rows in the table and see if we need space for a
|
|
64-bit address anywhere. */
|
|
for (const skiplist_entry &e : skiplist_entries)
|
|
if (arg == NULL || number_is_in_list (arg, e.number ()))
|
|
num_printable_entries++;
|
|
|
|
if (num_printable_entries == 0)
|
|
{
|
|
if (arg == NULL)
|
|
current_uiout->message (_("Not skipping any files or functions.\n"));
|
|
else
|
|
current_uiout->message (
|
|
_("No skiplist entries found with number %s.\n"), arg);
|
|
|
|
return;
|
|
}
|
|
|
|
ui_out_emit_table table_emitter (current_uiout, 6, num_printable_entries,
|
|
"SkiplistTable");
|
|
|
|
current_uiout->table_header (5, ui_left, "number", "Num"); /* 1 */
|
|
current_uiout->table_header (3, ui_left, "enabled", "Enb"); /* 2 */
|
|
current_uiout->table_header (4, ui_right, "regexp", "Glob"); /* 3 */
|
|
current_uiout->table_header (20, ui_left, "file", "File"); /* 4 */
|
|
current_uiout->table_header (2, ui_right, "regexp", "RE"); /* 5 */
|
|
current_uiout->table_header (40, ui_noalign, "function", "Function"); /* 6 */
|
|
current_uiout->table_body ();
|
|
|
|
for (const skiplist_entry &e : skiplist_entries)
|
|
{
|
|
QUIT;
|
|
if (arg != NULL && !number_is_in_list (arg, e.number ()))
|
|
continue;
|
|
|
|
ui_out_emit_tuple tuple_emitter (current_uiout, "blklst-entry");
|
|
current_uiout->field_signed ("number", e.number ()); /* 1 */
|
|
|
|
if (e.enabled ())
|
|
current_uiout->field_string ("enabled", "y"); /* 2 */
|
|
else
|
|
current_uiout->field_string ("enabled", "n"); /* 2 */
|
|
|
|
if (e.file_is_glob ())
|
|
current_uiout->field_string ("regexp", "y"); /* 3 */
|
|
else
|
|
current_uiout->field_string ("regexp", "n"); /* 3 */
|
|
|
|
current_uiout->field_string ("file",
|
|
e.file ().empty () ? "<none>"
|
|
: e.file ().c_str (),
|
|
ui_out_style_kind::FILE); /* 4 */
|
|
if (e.function_is_regexp ())
|
|
current_uiout->field_string ("regexp", "y"); /* 5 */
|
|
else
|
|
current_uiout->field_string ("regexp", "n"); /* 5 */
|
|
|
|
current_uiout->field_string ("function",
|
|
e.function ().empty () ? "<none>"
|
|
: e.function ().c_str (),
|
|
ui_out_style_kind::FUNCTION); /* 6 */
|
|
|
|
current_uiout->text ("\n");
|
|
}
|
|
}
|
|
|
|
static void
|
|
skip_enable_command (const char *arg, int from_tty)
|
|
{
|
|
bool found = false;
|
|
|
|
for (skiplist_entry &e : skiplist_entries)
|
|
if (arg == NULL || number_is_in_list (arg, e.number ()))
|
|
{
|
|
e.enable ();
|
|
found = true;
|
|
}
|
|
|
|
if (!found)
|
|
error (_("No skiplist entries found with number %s."), arg);
|
|
}
|
|
|
|
static void
|
|
skip_disable_command (const char *arg, int from_tty)
|
|
{
|
|
bool found = false;
|
|
|
|
for (skiplist_entry &e : skiplist_entries)
|
|
if (arg == NULL || number_is_in_list (arg, e.number ()))
|
|
{
|
|
e.disable ();
|
|
found = true;
|
|
}
|
|
|
|
if (!found)
|
|
error (_("No skiplist entries found with number %s."), arg);
|
|
}
|
|
|
|
static void
|
|
skip_delete_command (const char *arg, int from_tty)
|
|
{
|
|
bool found = false;
|
|
|
|
for (auto it = skiplist_entries.begin (),
|
|
end = skiplist_entries.end ();
|
|
it != end;)
|
|
{
|
|
const skiplist_entry &e = *it;
|
|
|
|
if (arg == NULL || number_is_in_list (arg, e.number ()))
|
|
{
|
|
it = skiplist_entries.erase (it);
|
|
found = true;
|
|
}
|
|
else
|
|
++it;
|
|
}
|
|
|
|
if (!found)
|
|
error (_("No skiplist entries found with number %s."), arg);
|
|
}
|
|
|
|
bool
|
|
skiplist_entry::do_skip_file_p (const symtab_and_line &function_sal) const
|
|
{
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"skip: checking if file %s matches non-glob %s...",
|
|
function_sal.symtab->filename, m_file.c_str ());
|
|
|
|
bool result;
|
|
|
|
/* Check first sole SYMTAB->FILENAME. It may not be a substring of
|
|
symtab_to_fullname as it may contain "./" etc. */
|
|
if (compare_filenames_for_search (function_sal.symtab->filename,
|
|
m_file.c_str ()))
|
|
result = true;
|
|
|
|
/* Before we invoke realpath, which can get expensive when many
|
|
files are involved, do a quick comparison of the basenames. */
|
|
else if (!basenames_may_differ
|
|
&& filename_cmp (lbasename (function_sal.symtab->filename),
|
|
lbasename (m_file.c_str ())) != 0)
|
|
result = false;
|
|
else
|
|
{
|
|
/* Note: symtab_to_fullname caches its result, thus we don't have to. */
|
|
const char *fullname = symtab_to_fullname (function_sal.symtab);
|
|
|
|
result = compare_filenames_for_search (fullname, m_file.c_str ());
|
|
}
|
|
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog, result ? "yes.\n" : "no.\n");
|
|
|
|
return result;
|
|
}
|
|
|
|
bool
|
|
skiplist_entry::do_skip_gfile_p (const symtab_and_line &function_sal) const
|
|
{
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"skip: checking if file %s matches glob %s...",
|
|
function_sal.symtab->filename, m_file.c_str ());
|
|
|
|
bool result;
|
|
|
|
/* Check first sole SYMTAB->FILENAME. It may not be a substring of
|
|
symtab_to_fullname as it may contain "./" etc. */
|
|
if (gdb_filename_fnmatch (m_file.c_str (), function_sal.symtab->filename,
|
|
FNM_FILE_NAME | FNM_NOESCAPE) == 0)
|
|
result = true;
|
|
|
|
/* Before we invoke symtab_to_fullname, which is expensive, do a quick
|
|
comparison of the basenames.
|
|
Note that we assume that lbasename works with glob-style patterns.
|
|
If the basename of the glob pattern is something like "*.c" then this
|
|
isn't much of a win. Oh well. */
|
|
else if (!basenames_may_differ
|
|
&& gdb_filename_fnmatch (lbasename (m_file.c_str ()),
|
|
lbasename (function_sal.symtab->filename),
|
|
FNM_FILE_NAME | FNM_NOESCAPE) != 0)
|
|
result = false;
|
|
else
|
|
{
|
|
/* Note: symtab_to_fullname caches its result, thus we don't have to. */
|
|
const char *fullname = symtab_to_fullname (function_sal.symtab);
|
|
|
|
result = compare_glob_filenames_for_search (fullname, m_file.c_str ());
|
|
}
|
|
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog, result ? "yes.\n" : "no.\n");
|
|
|
|
return result;
|
|
}
|
|
|
|
bool
|
|
skiplist_entry::skip_file_p (const symtab_and_line &function_sal) const
|
|
{
|
|
if (m_file.empty ())
|
|
return false;
|
|
|
|
if (function_sal.symtab == NULL)
|
|
return false;
|
|
|
|
if (m_file_is_glob)
|
|
return do_skip_gfile_p (function_sal);
|
|
else
|
|
return do_skip_file_p (function_sal);
|
|
}
|
|
|
|
bool
|
|
skiplist_entry::skip_function_p (const char *function_name) const
|
|
{
|
|
if (m_function.empty ())
|
|
return false;
|
|
|
|
bool result;
|
|
|
|
if (m_function_is_regexp)
|
|
{
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"skip: checking if function %s matches regex %s...",
|
|
function_name, m_function.c_str ());
|
|
|
|
gdb_assert (m_compiled_function_regexp);
|
|
result
|
|
= (m_compiled_function_regexp->exec (function_name, 0, NULL, 0) == 0);
|
|
}
|
|
else
|
|
{
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
("skip: checking if function %s matches non-regex "
|
|
"%s..."),
|
|
function_name, m_function.c_str ());
|
|
result = (strcmp_iw (function_name, m_function.c_str ()) == 0);
|
|
}
|
|
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog, result ? "yes.\n" : "no.\n");
|
|
|
|
return result;
|
|
}
|
|
|
|
/* See skip.h. */
|
|
|
|
bool
|
|
function_name_is_marked_for_skip (const char *function_name,
|
|
const symtab_and_line &function_sal)
|
|
{
|
|
if (function_name == NULL)
|
|
return false;
|
|
|
|
for (const skiplist_entry &e : skiplist_entries)
|
|
{
|
|
if (!e.enabled ())
|
|
continue;
|
|
|
|
bool skip_by_file = e.skip_file_p (function_sal);
|
|
bool skip_by_function = e.skip_function_p (function_name);
|
|
|
|
/* If both file and function must match, make sure we don't errantly
|
|
exit if only one of them match. */
|
|
if (!e.file ().empty () && !e.function ().empty ())
|
|
{
|
|
if (skip_by_file && skip_by_function)
|
|
return true;
|
|
}
|
|
/* Only one of file/function is specified. */
|
|
else if (skip_by_file || skip_by_function)
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/* Completer for skip numbers. */
|
|
|
|
static void
|
|
complete_skip_number (cmd_list_element *cmd,
|
|
completion_tracker &completer,
|
|
const char *text, const char *word)
|
|
{
|
|
size_t word_len = strlen (word);
|
|
|
|
for (const skiplist_entry &entry : skiplist_entries)
|
|
{
|
|
gdb::unique_xmalloc_ptr<char> name (xstrprintf ("%d", entry.number ()));
|
|
if (strncmp (word, name.get (), word_len) == 0)
|
|
completer.add_completion (std::move (name));
|
|
}
|
|
}
|
|
|
|
void
|
|
_initialize_step_skip (void)
|
|
{
|
|
static struct cmd_list_element *skiplist = NULL;
|
|
struct cmd_list_element *c;
|
|
|
|
add_prefix_cmd ("skip", class_breakpoint, skip_command, _("\
|
|
Ignore a function while stepping.\n\
|
|
\n\
|
|
Usage: skip [FUNCTION-NAME]\n\
|
|
skip [FILE-SPEC] [FUNCTION-SPEC]\n\
|
|
If no arguments are given, ignore the current function.\n\
|
|
\n\
|
|
FILE-SPEC is one of:\n\
|
|
-fi|-file FILE-NAME\n\
|
|
-gfi|-gfile GLOB-FILE-PATTERN\n\
|
|
FUNCTION-SPEC is one of:\n\
|
|
-fu|-function FUNCTION-NAME\n\
|
|
-rfu|-rfunction FUNCTION-NAME-REGULAR-EXPRESSION"),
|
|
&skiplist, "skip ", 1, &cmdlist);
|
|
|
|
c = add_cmd ("file", class_breakpoint, skip_file_command, _("\
|
|
Ignore a file while stepping.\n\
|
|
Usage: skip file [FILE-NAME]\n\
|
|
If no filename is given, ignore the current file."),
|
|
&skiplist);
|
|
set_cmd_completer (c, filename_completer);
|
|
|
|
c = add_cmd ("function", class_breakpoint, skip_function_command, _("\
|
|
Ignore a function while stepping.\n\
|
|
Usage: skip function [FUNCTION-NAME]\n\
|
|
If no function name is given, skip the current function."),
|
|
&skiplist);
|
|
set_cmd_completer (c, location_completer);
|
|
|
|
c = add_cmd ("enable", class_breakpoint, skip_enable_command, _("\
|
|
Enable skip entries.\n\
|
|
Usage: skip enable [NUMBER | RANGE]...\n\
|
|
You can specify numbers (e.g. \"skip enable 1 3\"),\n\
|
|
ranges (e.g. \"skip enable 4-8\"), or both (e.g. \"skip enable 1 3 4-8\").\n\n\
|
|
If you don't specify any numbers or ranges, we'll enable all skip entries."),
|
|
&skiplist);
|
|
set_cmd_completer (c, complete_skip_number);
|
|
|
|
c = add_cmd ("disable", class_breakpoint, skip_disable_command, _("\
|
|
Disable skip entries.\n\
|
|
Usage: skip disable [NUMBER | RANGE]...\n\
|
|
You can specify numbers (e.g. \"skip disable 1 3\"),\n\
|
|
ranges (e.g. \"skip disable 4-8\"), or both (e.g. \"skip disable 1 3 4-8\").\n\n\
|
|
If you don't specify any numbers or ranges, we'll disable all skip entries."),
|
|
&skiplist);
|
|
set_cmd_completer (c, complete_skip_number);
|
|
|
|
c = add_cmd ("delete", class_breakpoint, skip_delete_command, _("\
|
|
Delete skip entries.\n\
|
|
Usage: skip delete [NUMBER | RANGES]...\n\
|
|
You can specify numbers (e.g. \"skip delete 1 3\"),\n\
|
|
ranges (e.g. \"skip delete 4-8\"), or both (e.g. \"skip delete 1 3 4-8\").\n\n\
|
|
If you don't specify any numbers or ranges, we'll delete all skip entries."),
|
|
&skiplist);
|
|
set_cmd_completer (c, complete_skip_number);
|
|
|
|
add_info ("skip", info_skip_command, _("\
|
|
Display the status of skips.\n\
|
|
Usage: info skip [NUMBER | RANGES]...\n\
|
|
You can specify numbers (e.g. \"info skip 1 3\"), \n\
|
|
ranges (e.g. \"info skip 4-8\"), or both (e.g. \"info skip 1 3 4-8\").\n\n\
|
|
If you don't specify any numbers or ranges, we'll show all skips."));
|
|
set_cmd_completer (c, complete_skip_number);
|
|
|
|
add_setshow_boolean_cmd ("skip", class_maintenance,
|
|
&debug_skip, _("\
|
|
Set whether to print the debug output about skipping files and functions."),
|
|
_("\
|
|
Show whether the debug output about skipping files and functions is printed."),
|
|
_("\
|
|
When non-zero, debug output about skipping files and functions is displayed."),
|
|
NULL, NULL,
|
|
&setdebuglist, &showdebuglist);
|
|
}
|