6c2659886f
I'd like to enable the -Wmissing-declarations warning. However, it
warns for every _initialize function, for example:
CXX dcache.o
/home/smarchi/src/binutils-gdb/gdb/dcache.c: In function ‘void _initialize_dcache()’:
/home/smarchi/src/binutils-gdb/gdb/dcache.c:688:1: error: no previous declaration for ‘void _initialize_dcache()’ [-Werror=missing-declarations]
_initialize_dcache (void)
^~~~~~~~~~~~~~~~~~
The only practical way forward I found is to add back the declarations,
which were removed by this commit:
commit 481695ed5f
Author: John Baldwin <jhb@FreeBSD.org>
Date: Sat Sep 9 11:02:37 2017 -0700
Remove unnecessary function prototypes.
I don't think it's a big problem to have the declarations for these
functions, but if anybody has a better solution for this, I'll be happy
to use it.
gdb/ChangeLog:
* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
* aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
* aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
* aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
* aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
* ada-exp.y (_initialize_ada_exp): Add declaration.
* ada-lang.c (_initialize_ada_language): Add declaration.
* ada-tasks.c (_initialize_tasks): Add declaration.
* agent.c (_initialize_agent): Add declaration.
* aix-thread.c (_initialize_aix_thread): Add declaration.
* alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
* alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
* alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
* alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
* alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
* alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
* amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
* amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
* amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
* amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
* amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
* amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
* amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
* amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
* amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
* amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
* amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
* annotate.c (_initialize_annotate): Add declaration.
* arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
* arc-tdep.c (_initialize_arc_tdep): Add declaration.
* arch-utils.c (_initialize_gdbarch_utils): Add declaration.
* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
* arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
* arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
* arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
* arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
* arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
* arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
* arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
* arm-tdep.c (_initialize_arm_tdep): Add declaration.
* arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
* auto-load.c (_initialize_auto_load): Add declaration.
* auxv.c (_initialize_auxv): Add declaration.
* avr-tdep.c (_initialize_avr_tdep): Add declaration.
* ax-gdb.c (_initialize_ax_gdb): Add declaration.
* bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
* bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
* break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
* break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
* break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
* breakpoint.c (_initialize_breakpoint): Add declaration.
* bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
* btrace.c (_initialize_btrace): Add declaration.
* charset.c (_initialize_charset): Add declaration.
* cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
* cli/cli-dump.c (_initialize_cli_dump): Add declaration.
* cli/cli-interp.c (_initialize_cli_interp): Add declaration.
* cli/cli-logging.c (_initialize_cli_logging): Add declaration.
* cli/cli-script.c (_initialize_cli_script): Add declaration.
* cli/cli-style.c (_initialize_cli_style): Add declaration.
* coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
* coffread.c (_initialize_coffread): Add declaration.
* compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
* compile/compile.c (_initialize_compile): Add declaration.
* complaints.c (_initialize_complaints): Add declaration.
* completer.c (_initialize_completer): Add declaration.
* copying.c (_initialize_copying): Add declaration.
* corefile.c (_initialize_core): Add declaration.
* corelow.c (_initialize_corelow): Add declaration.
* cp-abi.c (_initialize_cp_abi): Add declaration.
* cp-namespace.c (_initialize_cp_namespace): Add declaration.
* cp-support.c (_initialize_cp_support): Add declaration.
* cp-valprint.c (_initialize_cp_valprint): Add declaration.
* cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
* cris-tdep.c (_initialize_cris_tdep): Add declaration.
* csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
* csky-tdep.c (_initialize_csky_tdep): Add declaration.
* ctfread.c (_initialize_ctfread): Add declaration.
* d-lang.c (_initialize_d_language): Add declaration.
* darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
* darwin-nat.c (_initialize_darwin_nat): Add declaration.
* dbxread.c (_initialize_dbxread): Add declaration.
* dcache.c (_initialize_dcache): Add declaration.
* disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
* disasm.c (_initialize_disasm): Add declaration.
* dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
* dummy-frame.c (_initialize_dummy_frame): Add declaration.
* dwarf-index-cache.c (_initialize_index_cache): Add declaration.
* dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
* dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
* dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
* dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
* dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
* dwarf2read.c (_initialize_dwarf2_read): Add declaration.
* elfread.c (_initialize_elfread): Add declaration.
* exec.c (_initialize_exec): Add declaration.
* extension.c (_initialize_extension): Add declaration.
* f-lang.c (_initialize_f_language): Add declaration.
* f-valprint.c (_initialize_f_valprint): Add declaration.
* fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
* fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
* filesystem.c (_initialize_filesystem): Add declaration.
* findcmd.c (_initialize_mem_search): Add declaration.
* findvar.c (_initialize_findvar): Add declaration.
* fork-child.c (_initialize_fork_child): Add declaration.
* frame-base.c (_initialize_frame_base): Add declaration.
* frame-unwind.c (_initialize_frame_unwind): Add declaration.
* frame.c (_initialize_frame): Add declaration.
* frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
* frv-tdep.c (_initialize_frv_tdep): Add declaration.
* ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
* gcore.c (_initialize_gcore): Add declaration.
* gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
* gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
* gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
* gdbarch.c (_initialize_gdbarch): Add declaration.
* gdbtypes.c (_initialize_gdbtypes): Add declaration.
* gnu-nat.c (_initialize_gnu_nat): Add declaration.
* gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
* go-lang.c (_initialize_go_language): Add declaration.
* go32-nat.c (_initialize_go32_nat): Add declaration.
* guile/guile.c (_initialize_guile): Add declaration.
* h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
* hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
* hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
* hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
* hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
* hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
* i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
* i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
* i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
* i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
* i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
* i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
* i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
* i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
* i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
* i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
* i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
* i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
* i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
* i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
* i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
* i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
* i386-tdep.c (_initialize_i386_tdep): Add declaration.
* i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
* ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
* ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
* ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
* ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
* ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
* infcall.c (_initialize_infcall): Add declaration.
* infcmd.c (_initialize_infcmd): Add declaration.
* inflow.c (_initialize_inflow): Add declaration.
* infrun.c (_initialize_infrun): Add declaration.
* interps.c (_initialize_interpreter): Add declaration.
* iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
* jit.c (_initialize_jit): Add declaration.
* language.c (_initialize_language): Add declaration.
* linux-fork.c (_initialize_linux_fork): Add declaration.
* linux-nat.c (_initialize_linux_nat): Add declaration.
* linux-tdep.c (_initialize_linux_tdep): Add declaration.
* linux-thread-db.c (_initialize_thread_db): Add declaration.
* lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
* m2-lang.c (_initialize_m2_language): Add declaration.
* m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
* m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
* m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
* m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
* m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
* m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
* m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
* m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
* m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
* machoread.c (_initialize_machoread): Add declaration.
* macrocmd.c (_initialize_macrocmd): Add declaration.
* macroscope.c (_initialize_macroscope): Add declaration.
* maint-test-options.c (_initialize_maint_test_options): Add declaration.
* maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
* maint.c (_initialize_maint_cmds): Add declaration.
* mdebugread.c (_initialize_mdebugread): Add declaration.
* memattr.c (_initialize_mem): Add declaration.
* mep-tdep.c (_initialize_mep_tdep): Add declaration.
* mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
* mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
* mi/mi-interp.c (_initialize_mi_interp): Add declaration.
* mi/mi-main.c (_initialize_mi_main): Add declaration.
* microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
* microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
* mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
* mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
* mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
* mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
* mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
* mips-tdep.c (_initialize_mips_tdep): Add declaration.
* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
* mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
* mipsread.c (_initialize_mipsread): Add declaration.
* mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
* mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
* moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
* msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
* nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
* nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
* nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
* nto-procfs.c (_initialize_procfs): Add declaration.
* objc-lang.c (_initialize_objc_language): Add declaration.
* observable.c (_initialize_observer): Add declaration.
* opencl-lang.c (_initialize_opencl_language): Add declaration.
* or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
* or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
* osabi.c (_initialize_gdb_osabi): Add declaration.
* osdata.c (_initialize_osdata): Add declaration.
* p-valprint.c (_initialize_pascal_valprint): Add declaration.
* parse.c (_initialize_parse): Add declaration.
* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
* ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
* ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
* ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
* ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
* printcmd.c (_initialize_printcmd): Add declaration.
* probe.c (_initialize_probe): Add declaration.
* proc-api.c (_initialize_proc_api): Add declaration.
* proc-events.c (_initialize_proc_events): Add declaration.
* proc-service.c (_initialize_proc_service): Add declaration.
* procfs.c (_initialize_procfs): Add declaration.
* producer.c (_initialize_producer): Add declaration.
* psymtab.c (_initialize_psymtab): Add declaration.
* python/python.c (_initialize_python): Add declaration.
* ravenscar-thread.c (_initialize_ravenscar): Add declaration.
* record-btrace.c (_initialize_record_btrace): Add declaration.
* record-full.c (_initialize_record_full): Add declaration.
* record.c (_initialize_record): Add declaration.
* regcache-dump.c (_initialize_regcache_dump): Add declaration.
* regcache.c (_initialize_regcache): Add declaration.
* reggroups.c (_initialize_reggroup): Add declaration.
* remote-notif.c (_initialize_notif): Add declaration.
* remote-sim.c (_initialize_remote_sim): Add declaration.
* remote.c (_initialize_remote): Add declaration.
* reverse.c (_initialize_reverse): Add declaration.
* riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
* riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
* riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
* riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
* riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
* rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
* rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
* rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
Add declaration.
* rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
* rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
* run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
* rust-exp.y (_initialize_rust_exp): Add declaration.
* rx-tdep.c (_initialize_rx_tdep): Add declaration.
* s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
* s390-linux-nat.c (_initialize_s390_nat): Add declaration.
* s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
* s390-tdep.c (_initialize_s390_tdep): Add declaration.
* score-tdep.c (_initialize_score_tdep): Add declaration.
* ser-go32.c (_initialize_ser_dos): Add declaration.
* ser-mingw.c (_initialize_ser_windows): Add declaration.
* ser-pipe.c (_initialize_ser_pipe): Add declaration.
* ser-tcp.c (_initialize_ser_tcp): Add declaration.
* ser-uds.c (_initialize_ser_socket): Add declaration.
* ser-unix.c (_initialize_ser_hardwire): Add declaration.
* serial.c (_initialize_serial): Add declaration.
* sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
* sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
* sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
* sh-tdep.c (_initialize_sh_tdep): Add declaration.
* skip.c (_initialize_step_skip): Add declaration.
* sol-thread.c (_initialize_sol_thread): Add declaration.
* solib-aix.c (_initialize_solib_aix): Add declaration.
* solib-darwin.c (_initialize_darwin_solib): Add declaration.
* solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
* solib-frv.c (_initialize_frv_solib): Add declaration.
* solib-svr4.c (_initialize_svr4_solib): Add declaration.
* solib-target.c (_initialize_solib_target): Add declaration.
* solib.c (_initialize_solib): Add declaration.
* source-cache.c (_initialize_source_cache): Add declaration.
* source.c (_initialize_source): Add declaration.
* sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
* sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
* sparc-nat.c (_initialize_sparc_nat): Add declaration.
* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
* sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
* sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
* sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
* sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
* sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
* sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
* sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
* sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
* sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
* sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
* sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
* stabsread.c (_initialize_stabsread): Add declaration.
* stack.c (_initialize_stack): Add declaration.
* stap-probe.c (_initialize_stap_probe): Add declaration.
* std-regs.c (_initialize_frame_reg): Add declaration.
* symfile-debug.c (_initialize_symfile_debug): Add declaration.
* symfile-mem.c (_initialize_symfile_mem): Add declaration.
* symfile.c (_initialize_symfile): Add declaration.
* symmisc.c (_initialize_symmisc): Add declaration.
* symtab.c (_initialize_symtab): Add declaration.
* target.c (_initialize_target): Add declaration.
* target-connection.c (_initialize_target_connection): Add
declaration.
* target-dcache.c (_initialize_target_dcache): Add declaration.
* target-descriptions.c (_initialize_target_descriptions): Add declaration.
* thread.c (_initialize_thread): Add declaration.
* tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
* tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
* tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
* tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
* tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
* tracectf.c (_initialize_ctf): Add declaration.
* tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
* tracefile.c (_initialize_tracefile): Add declaration.
* tracepoint.c (_initialize_tracepoint): Add declaration.
* tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
* tui/tui-interp.c (_initialize_tui_interp): Add declaration.
* tui/tui-layout.c (_initialize_tui_layout): Add declaration.
* tui/tui-regs.c (_initialize_tui_regs): Add declaration.
* tui/tui-stack.c (_initialize_tui_stack): Add declaration.
* tui/tui-win.c (_initialize_tui_win): Add declaration.
* tui/tui.c (_initialize_tui): Add declaration.
* typeprint.c (_initialize_typeprint): Add declaration.
* ui-style.c (_initialize_ui_style): Add declaration.
* unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
* unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
* unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
* unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
* unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
* unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
* unittests/filtered_iterator-selftests.c
(_initialize_filtered_iterator_selftests): Add declaration.
* unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
* unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
* unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
* unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
* unittests/main-thread-selftests.c
(_initialize_main_thread_selftests): Add declaration.
* unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
* unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
* unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
* unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
* unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
* unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
* unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
* unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
* unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
* unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
* unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
* unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
* unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
* unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
* unittests/tui-selftests.c (_initialize_tui_selftest): Add
declaration.
* unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
* unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
* unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
* unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
* user-regs.c (_initialize_user_regs): Add declaration.
* utils.c (_initialize_utils): Add declaration.
* v850-tdep.c (_initialize_v850_tdep): Add declaration.
* valops.c (_initialize_valops): Add declaration.
* valprint.c (_initialize_valprint): Add declaration.
* value.c (_initialize_values): Add declaration.
* varobj.c (_initialize_varobj): Add declaration.
* vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
* vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
* vax-tdep.c (_initialize_vax_tdep): Add declaration.
* windows-nat.c (_initialize_windows_nat): Add declaration.
(_initialize_check_for_gdb_ini): Add declaration.
(_initialize_loadable): Add declaration.
* windows-tdep.c (_initialize_windows_tdep): Add declaration.
* x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
* x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
* xcoffread.c (_initialize_xcoffread): Add declaration.
* xml-support.c (_initialize_xml_support): Add declaration.
* xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
* xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
* xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
Change-Id: I13eec7e0ed2b3c427377a7bdb055cf46da64def9
484 lines
13 KiB
C
484 lines
13 KiB
C
/* Trace file support in GDB.
|
|
|
|
Copyright (C) 1997-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "tracefile.h"
|
|
#include "tracectf.h"
|
|
#include "exec.h"
|
|
#include "regcache.h"
|
|
#include "gdbsupport/byte-vector.h"
|
|
#include "gdbarch.h"
|
|
|
|
/* Helper macros. */
|
|
|
|
#define TRACE_WRITE_R_BLOCK(writer, buf, size) \
|
|
writer->ops->frame_ops->write_r_block ((writer), (buf), (size))
|
|
#define TRACE_WRITE_M_BLOCK_HEADER(writer, addr, size) \
|
|
writer->ops->frame_ops->write_m_block_header ((writer), (addr), \
|
|
(size))
|
|
#define TRACE_WRITE_M_BLOCK_MEMORY(writer, buf, size) \
|
|
writer->ops->frame_ops->write_m_block_memory ((writer), (buf), \
|
|
(size))
|
|
#define TRACE_WRITE_V_BLOCK(writer, num, val) \
|
|
writer->ops->frame_ops->write_v_block ((writer), (num), (val))
|
|
|
|
/* A unique pointer policy class for trace_file_writer. */
|
|
|
|
struct trace_file_writer_deleter
|
|
{
|
|
void operator() (struct trace_file_writer *writer)
|
|
{
|
|
writer->ops->dtor (writer);
|
|
xfree (writer);
|
|
}
|
|
};
|
|
|
|
/* A unique_ptr specialization for trace_file_writer. */
|
|
|
|
typedef std::unique_ptr<trace_file_writer, trace_file_writer_deleter>
|
|
trace_file_writer_up;
|
|
|
|
/* Save tracepoint data to file named FILENAME through WRITER. WRITER
|
|
determines the trace file format. If TARGET_DOES_SAVE is non-zero,
|
|
the save is performed on the target, otherwise GDB obtains all trace
|
|
data and saves it locally. */
|
|
|
|
static void
|
|
trace_save (const char *filename, struct trace_file_writer *writer,
|
|
int target_does_save)
|
|
{
|
|
struct trace_status *ts = current_trace_status ();
|
|
struct uploaded_tp *uploaded_tps = NULL, *utp;
|
|
struct uploaded_tsv *uploaded_tsvs = NULL, *utsv;
|
|
|
|
ULONGEST offset = 0;
|
|
#define MAX_TRACE_UPLOAD 2000
|
|
gdb::byte_vector buf (std::max (MAX_TRACE_UPLOAD, trace_regblock_size));
|
|
enum bfd_endian byte_order = gdbarch_byte_order (target_gdbarch ());
|
|
|
|
/* If the target is to save the data to a file on its own, then just
|
|
send the command and be done with it. */
|
|
if (target_does_save)
|
|
{
|
|
if (!writer->ops->target_save (writer, filename))
|
|
error (_("Target failed to save trace data to '%s'."),
|
|
filename);
|
|
return;
|
|
}
|
|
|
|
/* Get the trace status first before opening the file, so if the
|
|
target is losing, we can get out without touching files. Since
|
|
we're just calling this for side effects, we ignore the
|
|
result. */
|
|
target_get_trace_status (ts);
|
|
|
|
writer->ops->start (writer, filename);
|
|
|
|
writer->ops->write_header (writer);
|
|
|
|
/* Write descriptive info. */
|
|
|
|
/* Write out the size of a register block. */
|
|
writer->ops->write_regblock_type (writer, trace_regblock_size);
|
|
|
|
/* Write out the target description info. */
|
|
writer->ops->write_tdesc (writer);
|
|
|
|
/* Write out status of the tracing run (aka "tstatus" info). */
|
|
writer->ops->write_status (writer, ts);
|
|
|
|
/* Note that we want to upload tracepoints and save those, rather
|
|
than simply writing out the local ones, because the user may have
|
|
changed tracepoints in GDB in preparation for a future tracing
|
|
run, or maybe just mass-deleted all types of breakpoints as part
|
|
of cleaning up. So as not to contaminate the session, leave the
|
|
data in its uploaded form, don't make into real tracepoints. */
|
|
|
|
/* Get trace state variables first, they may be checked when parsing
|
|
uploaded commands. */
|
|
|
|
target_upload_trace_state_variables (&uploaded_tsvs);
|
|
|
|
for (utsv = uploaded_tsvs; utsv; utsv = utsv->next)
|
|
writer->ops->write_uploaded_tsv (writer, utsv);
|
|
|
|
free_uploaded_tsvs (&uploaded_tsvs);
|
|
|
|
target_upload_tracepoints (&uploaded_tps);
|
|
|
|
for (utp = uploaded_tps; utp; utp = utp->next)
|
|
target_get_tracepoint_status (NULL, utp);
|
|
|
|
for (utp = uploaded_tps; utp; utp = utp->next)
|
|
writer->ops->write_uploaded_tp (writer, utp);
|
|
|
|
free_uploaded_tps (&uploaded_tps);
|
|
|
|
/* Mark the end of the definition section. */
|
|
writer->ops->write_definition_end (writer);
|
|
|
|
/* Get and write the trace data proper. */
|
|
while (1)
|
|
{
|
|
LONGEST gotten = 0;
|
|
|
|
/* The writer supports writing the contents of trace buffer
|
|
directly to trace file. Don't parse the contents of trace
|
|
buffer. */
|
|
if (writer->ops->write_trace_buffer != NULL)
|
|
{
|
|
/* We ask for big blocks, in the hopes of efficiency, but
|
|
will take less if the target has packet size limitations
|
|
or some such. */
|
|
gotten = target_get_raw_trace_data (buf.data (), offset,
|
|
MAX_TRACE_UPLOAD);
|
|
if (gotten < 0)
|
|
error (_("Failure to get requested trace buffer data"));
|
|
/* No more data is forthcoming, we're done. */
|
|
if (gotten == 0)
|
|
break;
|
|
|
|
writer->ops->write_trace_buffer (writer, buf.data (), gotten);
|
|
|
|
offset += gotten;
|
|
}
|
|
else
|
|
{
|
|
uint16_t tp_num;
|
|
uint32_t tf_size;
|
|
/* Parse the trace buffers according to how data are stored
|
|
in trace buffer in GDBserver. */
|
|
|
|
gotten = target_get_raw_trace_data (buf.data (), offset, 6);
|
|
|
|
if (gotten == 0)
|
|
break;
|
|
|
|
/* Read the first six bytes in, which is the tracepoint
|
|
number and trace frame size. */
|
|
tp_num = (uint16_t)
|
|
extract_unsigned_integer (&((buf.data ())[0]), 2, byte_order);
|
|
|
|
tf_size = (uint32_t)
|
|
extract_unsigned_integer (&((buf.data ())[2]), 4, byte_order);
|
|
|
|
writer->ops->frame_ops->start (writer, tp_num);
|
|
gotten = 6;
|
|
|
|
if (tf_size > 0)
|
|
{
|
|
unsigned int block;
|
|
|
|
offset += 6;
|
|
|
|
for (block = 0; block < tf_size; )
|
|
{
|
|
gdb_byte block_type;
|
|
|
|
/* We'll fetch one block each time, in order to
|
|
handle the extremely large 'M' block. We first
|
|
fetch one byte to get the type of the block. */
|
|
gotten = target_get_raw_trace_data (buf.data (),
|
|
offset, 1);
|
|
if (gotten < 1)
|
|
error (_("Failure to get requested trace buffer data"));
|
|
|
|
gotten = 1;
|
|
block += 1;
|
|
offset += 1;
|
|
|
|
block_type = buf[0];
|
|
switch (block_type)
|
|
{
|
|
case 'R':
|
|
gotten
|
|
= target_get_raw_trace_data (buf.data (), offset,
|
|
trace_regblock_size);
|
|
if (gotten < trace_regblock_size)
|
|
error (_("Failure to get requested trace"
|
|
" buffer data"));
|
|
|
|
TRACE_WRITE_R_BLOCK (writer, buf.data (),
|
|
trace_regblock_size);
|
|
break;
|
|
case 'M':
|
|
{
|
|
unsigned short mlen;
|
|
ULONGEST addr;
|
|
LONGEST t;
|
|
int j;
|
|
|
|
t = target_get_raw_trace_data (buf.data (),
|
|
offset, 10);
|
|
if (t < 10)
|
|
error (_("Failure to get requested trace"
|
|
" buffer data"));
|
|
|
|
offset += 10;
|
|
block += 10;
|
|
|
|
gotten = 0;
|
|
addr = (ULONGEST)
|
|
extract_unsigned_integer (buf.data (), 8,
|
|
byte_order);
|
|
mlen = (unsigned short)
|
|
extract_unsigned_integer (&((buf.data ())[8]), 2,
|
|
byte_order);
|
|
|
|
TRACE_WRITE_M_BLOCK_HEADER (writer, addr,
|
|
mlen);
|
|
|
|
/* The memory contents in 'M' block may be
|
|
very large. Fetch the data from the target
|
|
and write them into file one by one. */
|
|
for (j = 0; j < mlen; )
|
|
{
|
|
unsigned int read_length;
|
|
|
|
if (mlen - j > MAX_TRACE_UPLOAD)
|
|
read_length = MAX_TRACE_UPLOAD;
|
|
else
|
|
read_length = mlen - j;
|
|
|
|
t = target_get_raw_trace_data (buf.data (),
|
|
offset + j,
|
|
read_length);
|
|
if (t < read_length)
|
|
error (_("Failure to get requested"
|
|
" trace buffer data"));
|
|
|
|
TRACE_WRITE_M_BLOCK_MEMORY (writer,
|
|
buf.data (),
|
|
read_length);
|
|
|
|
j += read_length;
|
|
gotten += read_length;
|
|
}
|
|
|
|
break;
|
|
}
|
|
case 'V':
|
|
{
|
|
int vnum;
|
|
LONGEST val;
|
|
|
|
gotten
|
|
= target_get_raw_trace_data (buf.data (),
|
|
offset, 12);
|
|
if (gotten < 12)
|
|
error (_("Failure to get requested"
|
|
" trace buffer data"));
|
|
|
|
vnum = (int) extract_signed_integer (buf.data (),
|
|
4,
|
|
byte_order);
|
|
val
|
|
= extract_signed_integer (&((buf.data ())[4]),
|
|
8, byte_order);
|
|
|
|
TRACE_WRITE_V_BLOCK (writer, vnum, val);
|
|
}
|
|
break;
|
|
default:
|
|
error (_("Unknown block type '%c' (0x%x) in"
|
|
" trace frame"),
|
|
block_type, block_type);
|
|
}
|
|
|
|
block += gotten;
|
|
offset += gotten;
|
|
}
|
|
}
|
|
else
|
|
offset += gotten;
|
|
|
|
writer->ops->frame_ops->end (writer);
|
|
}
|
|
}
|
|
|
|
writer->ops->end (writer);
|
|
}
|
|
|
|
static void
|
|
tsave_command (const char *args, int from_tty)
|
|
{
|
|
int target_does_save = 0;
|
|
char **argv;
|
|
char *filename = NULL;
|
|
int generate_ctf = 0;
|
|
|
|
if (args == NULL)
|
|
error_no_arg (_("file in which to save trace data"));
|
|
|
|
gdb_argv built_argv (args);
|
|
argv = built_argv.get ();
|
|
|
|
for (; *argv; ++argv)
|
|
{
|
|
if (strcmp (*argv, "-r") == 0)
|
|
target_does_save = 1;
|
|
else if (strcmp (*argv, "-ctf") == 0)
|
|
generate_ctf = 1;
|
|
else if (**argv == '-')
|
|
error (_("unknown option `%s'"), *argv);
|
|
else
|
|
filename = *argv;
|
|
}
|
|
|
|
if (!filename)
|
|
error_no_arg (_("file in which to save trace data"));
|
|
|
|
if (generate_ctf)
|
|
trace_save_ctf (filename, target_does_save);
|
|
else
|
|
trace_save_tfile (filename, target_does_save);
|
|
|
|
if (from_tty)
|
|
printf_filtered (_("Trace data saved to %s '%s'.\n"),
|
|
generate_ctf ? "directory" : "file", filename);
|
|
}
|
|
|
|
/* Save the trace data to file FILENAME of tfile format. */
|
|
|
|
void
|
|
trace_save_tfile (const char *filename, int target_does_save)
|
|
{
|
|
trace_file_writer_up writer (tfile_trace_file_writer_new ());
|
|
trace_save (filename, writer.get (), target_does_save);
|
|
}
|
|
|
|
/* Save the trace data to dir DIRNAME of ctf format. */
|
|
|
|
void
|
|
trace_save_ctf (const char *dirname, int target_does_save)
|
|
{
|
|
trace_file_writer_up writer (ctf_trace_file_writer_new ());
|
|
trace_save (dirname, writer.get (), target_does_save);
|
|
}
|
|
|
|
/* Fetch register data from tracefile, shared for both tfile and
|
|
ctf. */
|
|
|
|
void
|
|
tracefile_fetch_registers (struct regcache *regcache, int regno)
|
|
{
|
|
struct gdbarch *gdbarch = regcache->arch ();
|
|
struct tracepoint *tp = get_tracepoint (get_tracepoint_number ());
|
|
int regn;
|
|
|
|
/* We get here if no register data has been found. Mark registers
|
|
as unavailable. */
|
|
for (regn = 0; regn < gdbarch_num_regs (gdbarch); regn++)
|
|
regcache->raw_supply (regn, NULL);
|
|
|
|
/* We can often usefully guess that the PC is going to be the same
|
|
as the address of the tracepoint. */
|
|
if (tp == NULL || tp->loc == NULL)
|
|
return;
|
|
|
|
/* But don't try to guess if tracepoint is multi-location... */
|
|
if (tp->loc->next)
|
|
{
|
|
warning (_("Tracepoint %d has multiple "
|
|
"locations, cannot infer $pc"),
|
|
tp->number);
|
|
return;
|
|
}
|
|
/* ... or does while-stepping. */
|
|
else if (tp->step_count > 0)
|
|
{
|
|
warning (_("Tracepoint %d does while-stepping, "
|
|
"cannot infer $pc"),
|
|
tp->number);
|
|
return;
|
|
}
|
|
|
|
/* Guess what we can from the tracepoint location. */
|
|
gdbarch_guess_tracepoint_registers (gdbarch, regcache,
|
|
tp->loc->address);
|
|
}
|
|
|
|
/* This is the implementation of target_ops method to_has_all_memory. */
|
|
|
|
bool
|
|
tracefile_target::has_all_memory ()
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
/* This is the implementation of target_ops method to_has_memory. */
|
|
|
|
bool
|
|
tracefile_target::has_memory ()
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
/* This is the implementation of target_ops method to_has_stack.
|
|
The target has a stack when GDB has already selected one trace
|
|
frame. */
|
|
|
|
bool
|
|
tracefile_target::has_stack ()
|
|
{
|
|
return get_traceframe_number () != -1;
|
|
}
|
|
|
|
/* This is the implementation of target_ops method to_has_registers.
|
|
The target has registers when GDB has already selected one trace
|
|
frame. */
|
|
|
|
bool
|
|
tracefile_target::has_registers ()
|
|
{
|
|
return get_traceframe_number () != -1;
|
|
}
|
|
|
|
/* This is the implementation of target_ops method to_thread_alive.
|
|
tracefile has one thread faked by GDB. */
|
|
|
|
bool
|
|
tracefile_target::thread_alive (ptid_t ptid)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
/* This is the implementation of target_ops method to_get_trace_status.
|
|
The trace status for a file is that tracing can never be run. */
|
|
|
|
int
|
|
tracefile_target::get_trace_status (struct trace_status *ts)
|
|
{
|
|
/* Other bits of trace status were collected as part of opening the
|
|
trace files, so nothing to do here. */
|
|
|
|
return -1;
|
|
}
|
|
|
|
void _initialize_tracefile ();
|
|
void
|
|
_initialize_tracefile ()
|
|
{
|
|
add_com ("tsave", class_trace, tsave_command, _("\
|
|
Save the trace data to a file.\n\
|
|
Use the '-ctf' option to save the data to CTF format.\n\
|
|
Use the '-r' option to direct the target to save directly to the file,\n\
|
|
using its own filesystem."));
|
|
}
|