224c3ddb89
Most allocation functions (if not all) return a void* pointing to the allocated memory. In C++, we need to add an explicit cast when assigning the result to a pointer to another type (which is the case more often than not). The content of this patch is taken from Pedro's branch, from commit "(mostly) auto-generated patch to insert casts needed for C++". I validated that the changes make sense and manually reflowed the code to make it respect the coding style. I also found multiple places where I could use XNEW/XNEWVEC/XRESIZEVEC/etc. Thanks a lot to whoever did that automated script to insert casts, doing it completely by hand would have taken a ridiculous amount of time. Only files built on x86 with --enable-targets=all are modified. This means that all other -nat.c files are untouched and will have to be dealt with later by using appropiate compilers. Or maybe we can try to build them with a regular g++ just to know where to add casts, I don't know. I built-tested this with --enable-targets=all and reg-tested. Here's the changelog entry, which was not too bad to make despite the size, thanks to David Malcom's script. I fixed some bits by hand, but there might be some wrong parts left (hopefully not). gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_stap_parse_special_token): Add cast to allocation result assignment. * ada-exp.y (write_object_renaming): Likewise. (write_ambiguous_var): Likewise. (ada_nget_field_index): Likewise. (write_var_or_type): Likewise. * ada-lang.c (ada_decode_symbol): Likewise. (ada_value_assign): Likewise. (value_pointer): Likewise. (cache_symbol): Likewise. (add_nonlocal_symbols): Likewise. (ada_name_for_lookup): Likewise. (symbol_completion_add): Likewise. (ada_to_fixed_type_1): Likewise. (ada_get_next_arg): Likewise. (defns_collected): Likewise. * ada-lex.l (processId): Likewise. (processString): Likewise. * ada-tasks.c (read_known_tasks_array): Likewise. (read_known_tasks_list): Likewise. * ada-typeprint.c (decoded_type_name): Likewise. * addrmap.c (addrmap_mutable_create_fixed): Likewise. * amd64-tdep.c (amd64_push_arguments): Likewise. (amd64_displaced_step_copy_insn): Likewise. (amd64_classify_insn_at): Likewise. (amd64_relocate_instruction): Likewise. * amd64obsd-tdep.c (amd64obsd_sigtramp_p): Likewise. * arch-utils.c (simple_displaced_step_copy_insn): Likewise. (initialize_current_architecture): Likewise. * arm-linux-tdep.c (arm_stap_parse_special_token): Likewise. * arm-symbian-tdep.c (arm_symbian_osabi_sniffer): Likewise. * arm-tdep.c (arm_exidx_new_objfile): Likewise. (arm_push_dummy_call): Likewise. (extend_buffer_earlier): Likewise. (arm_adjust_breakpoint_address): Likewise. (arm_skip_stub): Likewise. * auto-load.c (filename_is_in_pattern): Likewise. (maybe_add_script_file): Likewise. (maybe_add_script_text): Likewise. (auto_load_objfile_script_1): Likewise. * auxv.c (ld_so_xfer_auxv): Likewise. * ax-general.c (new_agent_expr): Likewise. (grow_expr): Likewise. (ax_reg_mask): Likewise. * bcache.c (bcache_full): Likewise. * breakpoint.c (program_breakpoint_here_p): Likewise. * btrace.c (parse_xml_raw): Likewise. * build-id.c (build_id_to_debug_bfd): Likewise. * buildsym.c (end_symtab_with_blockvector): Likewise. * c-exp.y (string_exp): Likewise. (qualified_name): Likewise. (write_destructor_name): Likewise. (operator_stoken): Likewise. (parse_number): Likewise. (scan_macro_expansion): Likewise. (yylex): Likewise. (c_print_token): Likewise. * c-lang.c (c_get_string): Likewise. (emit_numeric_character): Likewise. * charset.c (wchar_iterate): Likewise. * cli/cli-cmds.c (complete_command): Likewise. (make_command): Likewise. * cli/cli-dump.c (restore_section_callback): Likewise. (restore_binary_file): Likewise. * cli/cli-interp.c (cli_interpreter_exec): Likewise. * cli/cli-script.c (execute_control_command): Likewise. * cli/cli-setshow.c (do_set_command): Likewise. * coff-pe-read.c (add_pe_forwarded_sym): Likewise. (read_pe_exported_syms): Likewise. * coffread.c (coff_read_struct_type): Likewise. (coff_read_enum_type): Likewise. * common/btrace-common.c (btrace_data_append): Likewise. * common/buffer.c (buffer_grow): Likewise. * common/filestuff.c (gdb_fopen_cloexec): Likewise. * common/format.c (parse_format_string): Likewise. * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append): Likewise. * common/xml-utils.c (xml_escape_text): Likewise. * compile/compile-object-load.c (copy_sections): Likewise. (compile_object_load): Likewise. * compile/compile-object-run.c (compile_object_run): Likewise. * completer.c (filename_completer): Likewise. * corefile.c (read_memory_typed_address): Likewise. (write_memory_unsigned_integer): Likewise. (write_memory_signed_integer): Likewise. (complete_set_gnutarget): Likewise. * corelow.c (get_core_register_section): Likewise. * cp-name-parser.y (d_grab): Likewise. (allocate_info): Likewise. (cp_new_demangle_parse_info): Likewise. * cp-namespace.c (cp_scan_for_anonymous_namespaces): Likewise. (cp_lookup_symbol_in_namespace): Likewise. (lookup_namespace_scope): Likewise. (find_symbol_in_baseclass): Likewise. (cp_lookup_nested_symbol): Likewise. (cp_lookup_transparent_type_loop): Likewise. * cp-support.c (copy_string_to_obstack): Likewise. (make_symbol_overload_list): Likewise. (make_symbol_overload_list_namespace): Likewise. (make_symbol_overload_list_adl_namespace): Likewise. (first_component_command): Likewise. * cp-valprint.c (cp_print_value): Likewise. * ctf.c (ctf_xfer_partial): Likewise. * d-exp.y (StringExp): Likewise. * d-namespace.c (d_lookup_symbol_in_module): Likewise. (lookup_module_scope): Likewise. (find_symbol_in_baseclass): Likewise. (d_lookup_nested_symbol): Likewise. * dbxread.c (find_stab_function_addr): Likewise. (read_dbx_symtab): Likewise. (dbx_end_psymtab): Likewise. (cp_set_block_scope): Likewise. * dcache.c (dcache_alloc): Likewise. * demangle.c (_initialize_demangler): Likewise. * dicos-tdep.c (dicos_load_module_p): Likewise. * dictionary.c (dict_create_hashed_expandable): Likewise. (dict_create_linear_expandable): Likewise. (expand_hashtable): Likewise. (add_symbol_linear_expandable): Likewise. * dwarf2-frame.c (add_cie): Likewise. (add_fde): Likewise. (dwarf2_build_frame_info): Likewise. * dwarf2expr.c (dwarf_expr_grow_stack): Likewise. (dwarf_expr_fetch_address): Likewise. (add_piece): Likewise. (execute_stack_op): Likewise. * dwarf2loc.c (chain_candidate): Likewise. (dwarf_entry_parameter_to_value): Likewise. (read_pieced_value): Likewise. (write_pieced_value): Likewise. * dwarf2read.c (dwarf2_read_section): Likewise. (add_type_unit): Likewise. (read_comp_units_from_section): Likewise. (fixup_go_packaging): Likewise. (dwarf2_compute_name): Likewise. (dwarf2_physname): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (read_func_scope): Likewise. (read_call_site_scope): Likewise. (dwarf2_attach_fields_to_type): Likewise. (process_structure_scope): Likewise. (mark_common_block_symbol_computed): Likewise. (read_common_block): Likewise. (abbrev_table_read_table): Likewise. (guess_partial_die_structure_name): Likewise. (fixup_partial_die): Likewise. (add_file_name): Likewise. (dwarf2_const_value_data): Likewise. (dwarf2_const_value_attr): Likewise. (build_error_marker_type): Likewise. (guess_full_die_structure_name): Likewise. (anonymous_struct_prefix): Likewise. (typename_concat): Likewise. (dwarf2_canonicalize_name): Likewise. (dwarf2_name): Likewise. (write_constant_as_bytes): Likewise. (dwarf2_fetch_constant_bytes): Likewise. (copy_string): Likewise. (parse_macro_definition): Likewise. * elfread.c (elf_symfile_segments): Likewise. (elf_rel_plt_read): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_gnu_ifunc_resolve_by_got): Likewise. (elf_read_minimal_symbols): Likewise. (elf_gnu_ifunc_record_cache): Likewise. * event-top.c (top_level_prompt): Likewise. (command_line_handler): Likewise. * exec.c (resize_section_table): Likewise. * expprint.c (print_subexp_standard): Likewise. * fbsd-tdep.c (fbsd_collect_regset_section_cb): Likewise. * findcmd.c (parse_find_args): Likewise. * findvar.c (address_from_register): Likewise. * frame.c (get_prev_frame_always): Likewise. * gdb_bfd.c (gdb_bfd_ref): Likewise. (get_section_descriptor): Likewise. * gdb_obstack.c (obconcat): Likewise. (obstack_strdup): Likewise. * gdbtypes.c (lookup_function_type_with_arguments): Likewise. (create_set_type): Likewise. (lookup_unsigned_typename): Likewise. (lookup_signed_typename): Likewise. (resolve_dynamic_union): Likewise. (resolve_dynamic_struct): Likewise. (add_dyn_prop): Likewise. (copy_dynamic_prop_list): Likewise. (arch_flags_type): Likewise. (append_composite_type_field_raw): Likewise. * gdbtypes.h (INIT_FUNC_SPECIFIC): Likewise. * gnu-v3-abi.c (gnuv3_rtti_type): Likewise. * go-exp.y (string_exp): Likewise. * go-lang.c (go_demangle): Likewise. * guile/guile.c (compute_scheme_string): Likewise. * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise. (gdbscm_canonicalize_command_name): Likewise. * guile/scm-ports.c (ioscm_init_stdio_buffers): Likewise. (ioscm_init_memory_port): Likewise. (ioscm_reinit_memory_port): Likewise. * guile/scm-utils.c (gdbscm_gc_xstrdup): Likewise. (gdbscm_gc_dup_argv): Likewise. * h8300-tdep.c (h8300_push_dummy_call): Likewise. * hppa-tdep.c (internalize_unwinds): Likewise. (read_unwind_info): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. (windows_core_xfer_shared_libraries): Likewise. * i386-tdep.c (i386_displaced_step_copy_insn): Likewise. (i386_stap_parse_special_token_triplet): Likewise. (i386_stap_parse_special_token_three_arg_disp): Likewise. * i386obsd-tdep.c (i386obsd_sigtramp_p): Likewise. * inf-child.c (inf_child_fileio_readlink): Likewise. * inf-ptrace.c (inf_ptrace_fetch_register): Likewise. (inf_ptrace_store_register): Likewise. * infrun.c (follow_exec): Likewise. (displaced_step_prepare_throw): Likewise. (save_stop_context): Likewise. (save_infcall_suspend_state): Likewise. * jit.c (jit_read_descriptor): Likewise. (jit_read_code_entry): Likewise. (jit_symtab_line_mapping_add_impl): Likewise. (finalize_symtab): Likewise. (jit_unwind_reg_get_impl): Likewise. * jv-exp.y (QualifiedName): Likewise. * jv-lang.c (get_java_utf8_name): Likewise. (type_from_class): Likewise. (java_demangle_type_signature): Likewise. (java_class_name_from_physname): Likewise. * jv-typeprint.c (java_type_print_base): Likewise. * jv-valprint.c (java_value_print): Likewise. * language.c (add_language): Likewise. * linespec.c (add_sal_to_sals_basic): Likewise. (add_sal_to_sals): Likewise. (decode_objc): Likewise. (find_linespec_symbols): Likewise. * linux-fork.c (fork_save_infrun_state): Likewise. * linux-nat.c (linux_nat_detach): Likewise. (linux_nat_fileio_readlink): Likewise. * linux-record.c (record_linux_sockaddr): Likewise. (record_linux_msghdr): Likewise. (Do): Likewise. * linux-tdep.c (linux_core_info_proc_mappings): Likewise. (linux_collect_regset_section_cb): Likewise. (linux_get_siginfo_data): Likewise. * linux-thread-db.c (try_thread_db_load_from_pdir_1): Likewise. (try_thread_db_load_from_dir): Likewise. (thread_db_load_search): Likewise. (info_auto_load_libthread_db): Likewise. * m32c-tdep.c (m32c_m16c_address_to_pointer): Likewise. (m32c_m16c_pointer_to_address): Likewise. * m68hc11-tdep.c (m68hc11_pseudo_register_write): Likewise. * m68k-tdep.c (m68k_get_longjmp_target): Likewise. * machoread.c (macho_check_dsym): Likewise. * macroexp.c (resize_buffer): Likewise. (gather_arguments): Likewise. (maybe_expand): Likewise. * macrotab.c (new_macro_key): Likewise. (new_source_file): Likewise. (new_macro_definition): Likewise. * mdebugread.c (parse_symbol): Likewise. (parse_type): Likewise. (parse_partial_symbols): Likewise. (psymtab_to_symtab_1): Likewise. * mem-break.c (default_memory_insert_breakpoint): Likewise. * mi/mi-cmd-break.c (mi_argv_to_format): Likewise. * mi/mi-main.c (mi_cmd_data_read_memory): Likewise. (mi_cmd_data_read_memory_bytes): Likewise. (mi_cmd_data_write_memory_bytes): Likewise. (mi_cmd_trace_frame_collected): Likewise. * mi/mi-parse.c (mi_parse_argv): Likewise. (mi_parse): Likewise. * minidebug.c (lzma_open): Likewise. (lzma_pread): Likewise. * mips-tdep.c (mips_read_fp_register_single): Likewise. (mips_print_fp_register): Likewise. * mipsnbsd-tdep.c (mipsnbsd_get_longjmp_target): Likewise. * mipsread.c (read_alphacoff_dynamic_symtab): Likewise. * mt-tdep.c (mt_register_name): Likewise. (mt_registers_info): Likewise. (mt_push_dummy_call): Likewise. * namespace.c (add_using_directive): Likewise. * nat/linux-btrace.c (perf_event_read): Likewise. (linux_enable_bts): Likewise. * nat/linux-osdata.c (linux_common_core_of_thread): Likewise. * nat/linux-ptrace.c (linux_ptrace_test_ret_to_nx): Likewise. * nto-tdep.c (nto_find_and_open_solib): Likewise. (nto_parse_redirection): Likewise. * objc-lang.c (objc_demangle): Likewise. (find_methods): Likewise. * objfiles.c (get_objfile_bfd_data): Likewise. (set_objfile_main_name): Likewise. (allocate_objfile): Likewise. (objfile_relocate): Likewise. (update_section_map): Likewise. * osabi.c (generic_elf_osabi_sniff_abi_tag_sections): Likewise. * p-exp.y (exp): Likewise. (yylex): Likewise. * p-valprint.c (pascal_object_print_value): Likewise. * parse.c (initialize_expout): Likewise. (mark_completion_tag): Likewise. (copy_name): Likewise. (parse_float): Likewise. (type_stack_reserve): Likewise. * ppc-linux-tdep.c (ppc_stap_parse_special_token): Likewise. (ppu2spu_prev_register): Likewise. * ppc-ravenscar-thread.c (supply_register_at_address): Likewise. * printcmd.c (printf_wide_c_string): Likewise. (printf_pointer): Likewise. * probe.c (parse_probes): Likewise. * python/py-cmd.c (gdbpy_parse_command_name): Likewise. (cmdpy_init): Likewise. * python/py-gdb-readline.c (gdbpy_readline_wrapper): Likewise. * python/py-symtab.c (set_sal): Likewise. * python/py-unwind.c (pyuw_sniffer): Likewise. * python/python.c (python_interactive_command): Likewise. (compute_python_string): Likewise. * ravenscar-thread.c (get_running_thread_id): Likewise. * record-full.c (record_full_exec_insn): Likewise. (record_full_core_open_1): Likewise. * regcache.c (regcache_raw_read_signed): Likewise. (regcache_raw_read_unsigned): Likewise. (regcache_cooked_read_signed): Likewise. (regcache_cooked_read_unsigned): Likewise. * remote-fileio.c (remote_fileio_func_open): Likewise. (remote_fileio_func_rename): Likewise. (remote_fileio_func_unlink): Likewise. (remote_fileio_func_stat): Likewise. (remote_fileio_func_system): Likewise. * remote-mips.c (mips_xfer_memory): Likewise. (mips_load_srec): Likewise. (pmon_end_download): Likewise. * remote.c (new_remote_state): Likewise. (map_regcache_remote_table): Likewise. (remote_register_number_and_offset): Likewise. (init_remote_state): Likewise. (get_memory_packet_size): Likewise. (remote_pass_signals): Likewise. (remote_program_signals): Likewise. (remote_start_remote): Likewise. (remote_check_symbols): Likewise. (remote_query_supported): Likewise. (extended_remote_attach): Likewise. (process_g_packet): Likewise. (store_registers_using_G): Likewise. (putpkt_binary): Likewise. (read_frame): Likewise. (compare_sections_command): Likewise. (remote_hostio_pread): Likewise. (remote_hostio_readlink): Likewise. (remote_file_put): Likewise. (remote_file_get): Likewise. (remote_pid_to_exec_file): Likewise. (_initialize_remote): Likewise. * rs6000-aix-tdep.c (rs6000_aix_ld_info_to_xml): Likewise. (rs6000_aix_core_xfer_shared_libraries_aix): Likewise. * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise. (bfd_uses_spe_extensions): Likewise. * s390-linux-tdep.c (s390_displaced_step_copy_insn): Likewise. * score-tdep.c (score7_malloc_and_get_memblock): Likewise. * solib-dsbt.c (decode_loadmap): Likewise. (fetch_loadmap): Likewise. (scan_dyntag): Likewise. (enable_break): Likewise. (dsbt_relocate_main_executable): Likewise. * solib-frv.c (fetch_loadmap): Likewise. (enable_break2): Likewise. (frv_relocate_main_executable): Likewise. * solib-spu.c (spu_relocate_main_executable): Likewise. (spu_bfd_open): Likewise. * solib-svr4.c (lm_info_read): Likewise. (read_program_header): Likewise. (find_program_interpreter): Likewise. (scan_dyntag): Likewise. (elf_locate_base): Likewise. (open_symbol_file_object): Likewise. (read_program_headers_from_bfd): Likewise. (svr4_relocate_main_executable): Likewise. * solib-target.c (solib_target_relocate_section_addresses): Likewise. * solib.c (solib_find_1): Likewise. (exec_file_find): Likewise. (solib_find): Likewise. * source.c (openp): Likewise. (print_source_lines_base): Likewise. (forward_search_command): Likewise. * sparc-ravenscar-thread.c (supply_register_at_address): Likewise. * spu-tdep.c (spu2ppu_prev_register): Likewise. (spu_get_overlay_table): Likewise. * stabsread.c (patch_block_stabs): Likewise. (define_symbol): Likewise. (again:): Likewise. (read_member_functions): Likewise. (read_one_struct_field): Likewise. (read_enum_type): Likewise. (common_block_start): Likewise. * stack.c (read_frame_arg): Likewise. (backtrace_command): Likewise. * stap-probe.c (stap_parse_register_operand): Likewise. * symfile.c (syms_from_objfile_1): Likewise. (find_separate_debug_file): Likewise. (load_command): Likewise. (load_progress): Likewise. (load_section_callback): Likewise. (reread_symbols): Likewise. (add_filename_language): Likewise. (allocate_compunit_symtab): Likewise. (read_target_long_array): Likewise. (simple_read_overlay_table): Likewise. * symtab.c (symbol_set_names): Likewise. (resize_symbol_cache): Likewise. (rbreak_command): Likewise. (completion_list_add_name): Likewise. (completion_list_objc_symbol): Likewise. (add_filename_to_list): Likewise. * target-descriptions.c (maint_print_c_tdesc_cmd): Likewise. * target-memory.c (target_write_memory_blocks): Likewise. * target.c (target_read_string): Likewise. (read_whatever_is_readable): Likewise. (target_read_alloc_1): Likewise. (simple_search_memory): Likewise. (target_fileio_read_alloc_1): Likewise. * tilegx-tdep.c (tilegx_push_dummy_call): Likewise. * top.c (command_line_input): Likewise. * tracefile-tfile.c (tfile_fetch_registers): Likewise. * tracefile.c (tracefile_fetch_registers): Likewise. * tracepoint.c (add_memrange): Likewise. (init_collection_list): Likewise. (add_aexpr): Likewise. (trace_dump_actions): Likewise. (parse_trace_status): Likewise. (parse_tracepoint_definition): Likewise. (parse_tsv_definition): Likewise. (parse_static_tracepoint_marker_definition): Likewise. * tui/tui-file.c (tui_sfileopen): Likewise. (tui_file_adjust_strbuf): Likewise. * tui/tui-io.c (tui_expand_tabs): Likewise. * tui/tui-source.c (tui_set_source_content): Likewise. * typeprint.c (find_global_typedef): Likewise. * ui-file.c (do_ui_file_xstrdup): Likewise. (ui_file_obsavestring): Likewise. (mem_file_write): Likewise. * utils.c (make_hex_string): Likewise. (get_regcomp_error): Likewise. (puts_filtered_tabular): Likewise. (gdb_realpath_keepfile): Likewise. (ldirname): Likewise. (gdb_bfd_errmsg): Likewise. (substitute_path_component): Likewise. * valops.c (search_struct_method): Likewise. (find_oload_champ_namespace_loop): Likewise. * valprint.c (print_decimal_chars): Likewise. (read_string): Likewise. (generic_emit_char): Likewise. * varobj.c (varobj_delete): Likewise. (varobj_value_get_print_value): Likewise. * vaxobsd-tdep.c (vaxobsd_sigtramp_sniffer): Likewise. * windows-tdep.c (display_one_tib): Likewise. * xcoffread.c (read_xcoff_symtab): Likewise. (process_xcoff_symbol): Likewise. (swap_sym): Likewise. (scan_xcoff_symtab): Likewise. (xcoff_initial_scan): Likewise. * xml-support.c (gdb_xml_end_element): Likewise. (xml_process_xincludes): Likewise. (xml_fetch_content_from_file): Likewise. * xml-syscall.c (xml_list_of_syscalls): Likewise. * xstormy16-tdep.c (xstormy16_push_dummy_call): Likewise. gdb/gdbserver/ChangeLog: * ax.c (gdb_parse_agent_expr): Add cast to allocation result assignment. (gdb_unparse_agent_expr): Likewise. * hostio.c (require_data): Likewise. (handle_pread): Likewise. * linux-low.c (disable_regset): Likewise. (fetch_register): Likewise. (store_register): Likewise. (get_dynamic): Likewise. (linux_qxfer_libraries_svr4): Likewise. * mem-break.c (delete_fast_tracepoint_jump): Likewise. (set_fast_tracepoint_jump): Likewise. (uninsert_fast_tracepoint_jumps_at): Likewise. (reinsert_fast_tracepoint_jumps_at): Likewise. (validate_inserted_breakpoint): Likewise. (clone_agent_expr): Likewise. * regcache.c (init_register_cache): Likewise. * remote-utils.c (putpkt_binary_1): Likewise. (decode_M_packet): Likewise. (decode_X_packet): Likewise. (look_up_one_symbol): Likewise. (relocate_instruction): Likewise. (monitor_output): Likewise. * server.c (handle_search_memory): Likewise. (handle_qxfer_exec_file): Likewise. (handle_qxfer_libraries): Likewise. (handle_qxfer): Likewise. (handle_query): Likewise. (handle_v_cont): Likewise. (handle_v_run): Likewise. (captured_main): Likewise. * target.c (write_inferior_memory): Likewise. * thread-db.c (try_thread_db_load_from_dir): Likewise. * tracepoint.c (init_trace_buffer): Likewise. (add_tracepoint_action): Likewise. (add_traceframe): Likewise. (add_traceframe_block): Likewise. (cmd_qtdpsrc): Likewise. (cmd_qtdv): Likewise. (cmd_qtstatus): Likewise. (response_source): Likewise. (response_tsv): Likewise. (cmd_qtnotes): Likewise. (gdb_collect): Likewise. (initialize_tracepoint): Likewise.
618 lines
13 KiB
C
618 lines
13 KiB
C
/* Host file transfer support for gdbserver.
|
|
Copyright (C) 2007-2015 Free Software Foundation, Inc.
|
|
|
|
Contributed by CodeSourcery.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "server.h"
|
|
#include "gdb/fileio.h"
|
|
#include "hostio.h"
|
|
|
|
#include <fcntl.h>
|
|
#include <limits.h>
|
|
#include <unistd.h>
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include "fileio.h"
|
|
|
|
extern int remote_debug;
|
|
|
|
struct fd_list
|
|
{
|
|
int fd;
|
|
struct fd_list *next;
|
|
};
|
|
|
|
static struct fd_list *open_fds;
|
|
|
|
static int
|
|
safe_fromhex (char a, int *nibble)
|
|
{
|
|
if (a >= '0' && a <= '9')
|
|
*nibble = a - '0';
|
|
else if (a >= 'a' && a <= 'f')
|
|
*nibble = a - 'a' + 10;
|
|
else if (a >= 'A' && a <= 'F')
|
|
*nibble = a - 'A' + 10;
|
|
else
|
|
return -1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* Filenames are hex encoded, so the maximum we can handle is half the
|
|
packet buffer size. Cap to PATH_MAX, if it is shorter. */
|
|
#if !defined (PATH_MAX) || (PATH_MAX > (PBUFSIZ / 2 + 1))
|
|
# define HOSTIO_PATH_MAX (PBUFSIZ / 2 + 1)
|
|
#else
|
|
# define HOSTIO_PATH_MAX PATH_MAX
|
|
#endif
|
|
|
|
static int
|
|
require_filename (char **pp, char *filename)
|
|
{
|
|
int count;
|
|
char *p;
|
|
|
|
p = *pp;
|
|
count = 0;
|
|
|
|
while (*p && *p != ',')
|
|
{
|
|
int nib1, nib2;
|
|
|
|
/* Don't allow overflow. */
|
|
if (count >= HOSTIO_PATH_MAX - 1)
|
|
return -1;
|
|
|
|
if (safe_fromhex (p[0], &nib1)
|
|
|| safe_fromhex (p[1], &nib2))
|
|
return -1;
|
|
|
|
filename[count++] = nib1 * 16 + nib2;
|
|
p += 2;
|
|
}
|
|
|
|
filename[count] = '\0';
|
|
*pp = p;
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
require_int (char **pp, int *value)
|
|
{
|
|
char *p;
|
|
int count;
|
|
|
|
p = *pp;
|
|
*value = 0;
|
|
count = 0;
|
|
|
|
while (*p && *p != ',')
|
|
{
|
|
int nib;
|
|
|
|
/* Don't allow overflow. */
|
|
if (count >= 7)
|
|
return -1;
|
|
|
|
if (safe_fromhex (p[0], &nib))
|
|
return -1;
|
|
*value = *value * 16 + nib;
|
|
p++;
|
|
count++;
|
|
}
|
|
|
|
*pp = p;
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
require_data (char *p, int p_len, char **data, int *data_len)
|
|
{
|
|
int input_index, output_index, escaped;
|
|
|
|
*data = (char *) xmalloc (p_len);
|
|
|
|
output_index = 0;
|
|
escaped = 0;
|
|
for (input_index = 0; input_index < p_len; input_index++)
|
|
{
|
|
char b = p[input_index];
|
|
|
|
if (escaped)
|
|
{
|
|
(*data)[output_index++] = b ^ 0x20;
|
|
escaped = 0;
|
|
}
|
|
else if (b == '}')
|
|
escaped = 1;
|
|
else
|
|
(*data)[output_index++] = b;
|
|
}
|
|
|
|
if (escaped)
|
|
{
|
|
free (*data);
|
|
return -1;
|
|
}
|
|
|
|
*data_len = output_index;
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
require_comma (char **pp)
|
|
{
|
|
if (**pp == ',')
|
|
{
|
|
(*pp)++;
|
|
return 0;
|
|
}
|
|
else
|
|
return -1;
|
|
}
|
|
|
|
static int
|
|
require_end (char *p)
|
|
{
|
|
if (*p == '\0')
|
|
return 0;
|
|
else
|
|
return -1;
|
|
}
|
|
|
|
static int
|
|
require_valid_fd (int fd)
|
|
{
|
|
struct fd_list *fd_ptr;
|
|
|
|
for (fd_ptr = open_fds; fd_ptr != NULL; fd_ptr = fd_ptr->next)
|
|
if (fd_ptr->fd == fd)
|
|
return 0;
|
|
|
|
return -1;
|
|
}
|
|
|
|
/* Fill in own_buf with the last hostio error packet, however it
|
|
suitable for the target. */
|
|
static void
|
|
hostio_error (char *own_buf)
|
|
{
|
|
the_target->hostio_last_error (own_buf);
|
|
}
|
|
|
|
static void
|
|
hostio_packet_error (char *own_buf)
|
|
{
|
|
sprintf (own_buf, "F-1,%x", FILEIO_EINVAL);
|
|
}
|
|
|
|
static void
|
|
hostio_reply (char *own_buf, int result)
|
|
{
|
|
sprintf (own_buf, "F%x", result);
|
|
}
|
|
|
|
static int
|
|
hostio_reply_with_data (char *own_buf, char *buffer, int len,
|
|
int *new_packet_len)
|
|
{
|
|
int input_index, output_index, out_maxlen;
|
|
|
|
sprintf (own_buf, "F%x;", len);
|
|
output_index = strlen (own_buf);
|
|
|
|
out_maxlen = PBUFSIZ;
|
|
|
|
for (input_index = 0; input_index < len; input_index++)
|
|
{
|
|
char b = buffer[input_index];
|
|
|
|
if (b == '$' || b == '#' || b == '}' || b == '*')
|
|
{
|
|
/* These must be escaped. */
|
|
if (output_index + 2 > out_maxlen)
|
|
break;
|
|
own_buf[output_index++] = '}';
|
|
own_buf[output_index++] = b ^ 0x20;
|
|
}
|
|
else
|
|
{
|
|
if (output_index + 1 > out_maxlen)
|
|
break;
|
|
own_buf[output_index++] = b;
|
|
}
|
|
}
|
|
|
|
*new_packet_len = output_index;
|
|
return input_index;
|
|
}
|
|
|
|
/* Process ID of inferior whose filesystem hostio functions
|
|
that take FILENAME arguments will use. Zero means to use
|
|
our own filesystem. */
|
|
|
|
static int hostio_fs_pid;
|
|
|
|
/* See hostio.h. */
|
|
|
|
void
|
|
hostio_handle_new_gdb_connection (void)
|
|
{
|
|
hostio_fs_pid = 0;
|
|
}
|
|
|
|
/* Handle a "vFile:setfs:" packet. */
|
|
|
|
static void
|
|
handle_setfs (char *own_buf)
|
|
{
|
|
char *p;
|
|
int pid;
|
|
|
|
/* If the target doesn't have any of the in-filesystem-of methods
|
|
then there's no point in GDB sending "vFile:setfs:" packets. We
|
|
reply with an empty packet (i.e. we pretend we don't understand
|
|
"vFile:setfs:") and that should stop GDB sending any more. */
|
|
if (the_target->multifs_open == NULL
|
|
&& the_target->multifs_unlink == NULL
|
|
&& the_target->multifs_readlink == NULL)
|
|
{
|
|
own_buf[0] = '\0';
|
|
return;
|
|
}
|
|
|
|
p = own_buf + strlen ("vFile:setfs:");
|
|
|
|
if (require_int (&p, &pid)
|
|
|| pid < 0
|
|
|| require_end (p))
|
|
{
|
|
hostio_packet_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
hostio_fs_pid = pid;
|
|
|
|
hostio_reply (own_buf, 0);
|
|
}
|
|
|
|
static void
|
|
handle_open (char *own_buf)
|
|
{
|
|
char filename[HOSTIO_PATH_MAX];
|
|
char *p;
|
|
int fileio_flags, fileio_mode, flags, fd;
|
|
mode_t mode;
|
|
struct fd_list *new_fd;
|
|
|
|
p = own_buf + strlen ("vFile:open:");
|
|
|
|
if (require_filename (&p, filename)
|
|
|| require_comma (&p)
|
|
|| require_int (&p, &fileio_flags)
|
|
|| require_comma (&p)
|
|
|| require_int (&p, &fileio_mode)
|
|
|| require_end (p)
|
|
|| fileio_to_host_openflags (fileio_flags, &flags)
|
|
|| fileio_to_host_mode (fileio_mode, &mode))
|
|
{
|
|
hostio_packet_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
/* We do not need to convert MODE, since the fileio protocol
|
|
uses the standard values. */
|
|
if (hostio_fs_pid != 0 && the_target->multifs_open != NULL)
|
|
fd = the_target->multifs_open (hostio_fs_pid, filename,
|
|
flags, mode);
|
|
else
|
|
fd = open (filename, flags, mode);
|
|
|
|
if (fd == -1)
|
|
{
|
|
hostio_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
/* Record the new file descriptor. */
|
|
new_fd = XNEW (struct fd_list);
|
|
new_fd->fd = fd;
|
|
new_fd->next = open_fds;
|
|
open_fds = new_fd;
|
|
|
|
hostio_reply (own_buf, fd);
|
|
}
|
|
|
|
static void
|
|
handle_pread (char *own_buf, int *new_packet_len)
|
|
{
|
|
int fd, ret, len, offset, bytes_sent;
|
|
char *p, *data;
|
|
static int max_reply_size = -1;
|
|
|
|
p = own_buf + strlen ("vFile:pread:");
|
|
|
|
if (require_int (&p, &fd)
|
|
|| require_comma (&p)
|
|
|| require_valid_fd (fd)
|
|
|| require_int (&p, &len)
|
|
|| require_comma (&p)
|
|
|| require_int (&p, &offset)
|
|
|| require_end (p))
|
|
{
|
|
hostio_packet_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
/* Do not attempt to read more than the maximum number of bytes
|
|
hostio_reply_with_data can fit in a packet. We may still read
|
|
too much because of escaping, but this is handled below. */
|
|
if (max_reply_size == -1)
|
|
{
|
|
sprintf (own_buf, "F%x;", PBUFSIZ);
|
|
max_reply_size = PBUFSIZ - strlen (own_buf);
|
|
}
|
|
if (len > max_reply_size)
|
|
len = max_reply_size;
|
|
|
|
data = (char *) xmalloc (len);
|
|
#ifdef HAVE_PREAD
|
|
ret = pread (fd, data, len, offset);
|
|
#else
|
|
ret = -1;
|
|
#endif
|
|
/* If we have no pread or it failed for this file, use lseek/read. */
|
|
if (ret == -1)
|
|
{
|
|
ret = lseek (fd, offset, SEEK_SET);
|
|
if (ret != -1)
|
|
ret = read (fd, data, len);
|
|
}
|
|
|
|
if (ret == -1)
|
|
{
|
|
hostio_error (own_buf);
|
|
free (data);
|
|
return;
|
|
}
|
|
|
|
bytes_sent = hostio_reply_with_data (own_buf, data, ret, new_packet_len);
|
|
|
|
/* If we were using read, and the data did not all fit in the reply,
|
|
we would have to back up using lseek here. With pread it does
|
|
not matter. But we still have a problem; the return value in the
|
|
packet might be wrong, so we must fix it. This time it will
|
|
definitely fit. */
|
|
if (bytes_sent < ret)
|
|
bytes_sent = hostio_reply_with_data (own_buf, data, bytes_sent,
|
|
new_packet_len);
|
|
|
|
free (data);
|
|
}
|
|
|
|
static void
|
|
handle_pwrite (char *own_buf, int packet_len)
|
|
{
|
|
int fd, ret, len, offset;
|
|
char *p, *data;
|
|
|
|
p = own_buf + strlen ("vFile:pwrite:");
|
|
|
|
if (require_int (&p, &fd)
|
|
|| require_comma (&p)
|
|
|| require_valid_fd (fd)
|
|
|| require_int (&p, &offset)
|
|
|| require_comma (&p)
|
|
|| require_data (p, packet_len - (p - own_buf), &data, &len))
|
|
{
|
|
hostio_packet_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
#ifdef HAVE_PWRITE
|
|
ret = pwrite (fd, data, len, offset);
|
|
#else
|
|
ret = -1;
|
|
#endif
|
|
/* If we have no pwrite or it failed for this file, use lseek/write. */
|
|
if (ret == -1)
|
|
{
|
|
ret = lseek (fd, offset, SEEK_SET);
|
|
if (ret != -1)
|
|
ret = write (fd, data, len);
|
|
}
|
|
|
|
if (ret == -1)
|
|
{
|
|
hostio_error (own_buf);
|
|
free (data);
|
|
return;
|
|
}
|
|
|
|
hostio_reply (own_buf, ret);
|
|
free (data);
|
|
}
|
|
|
|
static void
|
|
handle_fstat (char *own_buf, int *new_packet_len)
|
|
{
|
|
int fd, bytes_sent;
|
|
char *p;
|
|
struct stat st;
|
|
struct fio_stat fst;
|
|
|
|
p = own_buf + strlen ("vFile:fstat:");
|
|
|
|
if (require_int (&p, &fd)
|
|
|| require_valid_fd (fd)
|
|
|| require_end (p))
|
|
{
|
|
hostio_packet_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
if (fstat (fd, &st) == -1)
|
|
{
|
|
hostio_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
host_to_fileio_stat (&st, &fst);
|
|
|
|
bytes_sent = hostio_reply_with_data (own_buf,
|
|
(char *) &fst, sizeof (fst),
|
|
new_packet_len);
|
|
|
|
/* If the response does not fit into a single packet, do not attempt
|
|
to return a partial response, but simply fail. */
|
|
if (bytes_sent < sizeof (fst))
|
|
write_enn (own_buf);
|
|
}
|
|
|
|
static void
|
|
handle_close (char *own_buf)
|
|
{
|
|
int fd, ret;
|
|
char *p;
|
|
struct fd_list **open_fd_p, *old_fd;
|
|
|
|
p = own_buf + strlen ("vFile:close:");
|
|
|
|
if (require_int (&p, &fd)
|
|
|| require_valid_fd (fd)
|
|
|| require_end (p))
|
|
{
|
|
hostio_packet_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
ret = close (fd);
|
|
|
|
if (ret == -1)
|
|
{
|
|
hostio_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
open_fd_p = &open_fds;
|
|
/* We know that fd is in the list, thanks to require_valid_fd. */
|
|
while ((*open_fd_p)->fd != fd)
|
|
open_fd_p = &(*open_fd_p)->next;
|
|
|
|
old_fd = *open_fd_p;
|
|
*open_fd_p = (*open_fd_p)->next;
|
|
free (old_fd);
|
|
|
|
hostio_reply (own_buf, ret);
|
|
}
|
|
|
|
static void
|
|
handle_unlink (char *own_buf)
|
|
{
|
|
char filename[HOSTIO_PATH_MAX];
|
|
char *p;
|
|
int ret;
|
|
|
|
p = own_buf + strlen ("vFile:unlink:");
|
|
|
|
if (require_filename (&p, filename)
|
|
|| require_end (p))
|
|
{
|
|
hostio_packet_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
if (hostio_fs_pid != 0 && the_target->multifs_unlink != NULL)
|
|
ret = the_target->multifs_unlink (hostio_fs_pid, filename);
|
|
else
|
|
ret = unlink (filename);
|
|
|
|
if (ret == -1)
|
|
{
|
|
hostio_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
hostio_reply (own_buf, ret);
|
|
}
|
|
|
|
static void
|
|
handle_readlink (char *own_buf, int *new_packet_len)
|
|
{
|
|
char filename[HOSTIO_PATH_MAX], linkname[HOSTIO_PATH_MAX];
|
|
char *p;
|
|
int ret, bytes_sent;
|
|
|
|
p = own_buf + strlen ("vFile:readlink:");
|
|
|
|
if (require_filename (&p, filename)
|
|
|| require_end (p))
|
|
{
|
|
hostio_packet_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
if (hostio_fs_pid != 0 && the_target->multifs_readlink != NULL)
|
|
ret = the_target->multifs_readlink (hostio_fs_pid, filename,
|
|
linkname,
|
|
sizeof (linkname) - 1);
|
|
else
|
|
ret = readlink (filename, linkname, sizeof (linkname) - 1);
|
|
|
|
if (ret == -1)
|
|
{
|
|
hostio_error (own_buf);
|
|
return;
|
|
}
|
|
|
|
bytes_sent = hostio_reply_with_data (own_buf, linkname, ret, new_packet_len);
|
|
|
|
/* If the response does not fit into a single packet, do not attempt
|
|
to return a partial response, but simply fail. */
|
|
if (bytes_sent < ret)
|
|
sprintf (own_buf, "F-1,%x", FILEIO_ENAMETOOLONG);
|
|
}
|
|
|
|
/* Handle all the 'F' file transfer packets. */
|
|
|
|
int
|
|
handle_vFile (char *own_buf, int packet_len, int *new_packet_len)
|
|
{
|
|
if (startswith (own_buf, "vFile:open:"))
|
|
handle_open (own_buf);
|
|
else if (startswith (own_buf, "vFile:pread:"))
|
|
handle_pread (own_buf, new_packet_len);
|
|
else if (startswith (own_buf, "vFile:pwrite:"))
|
|
handle_pwrite (own_buf, packet_len);
|
|
else if (startswith (own_buf, "vFile:fstat:"))
|
|
handle_fstat (own_buf, new_packet_len);
|
|
else if (startswith (own_buf, "vFile:close:"))
|
|
handle_close (own_buf);
|
|
else if (startswith (own_buf, "vFile:unlink:"))
|
|
handle_unlink (own_buf);
|
|
else if (startswith (own_buf, "vFile:readlink:"))
|
|
handle_readlink (own_buf, new_packet_len);
|
|
else if (startswith (own_buf, "vFile:setfs:"))
|
|
handle_setfs (own_buf);
|
|
else
|
|
return 0;
|
|
|
|
return 1;
|
|
}
|