binutils-gdb/ld
Tamar Christina 796d6298bb Arm: Fix Arm disassembler mapping symbol search.
Similar to the AArch64 patches the Arm disassembler has the same issues with
out of order sections but also a few short comings.

For one thing there are multiple code blocks to determine mapping symbols, and
they all work slightly different, and neither fully correct.  The first thing
this patch does is centralise the mapping symbols search into one function
mapping_symbol_for_insn.  This function is then updated to perform a search in
a similar way as AArch64.

Their used to be a value has_mapping_symbols which was used to determine the
default disassembly for objects that have no mapping symbols.  The problem with
the approach was that it was determining this value in the same loop that needed
it, which is why this field could take on the states -1, 0, 1 where -1 means
"don't know".  However this means that until you actually find a mapping symbol
or reach the end of the disassembly glob, you don't know if you did the right
action or not, and if you didn't you can't correct it anymore.

This is why the two jump-reloc-veneers-* testcases end up disassembling some
insn as data when they shouldn't.

Out of order here refers to an object file where sections are not listed in a
monotonic increasing VMA order.

The ELF ABI for Arm [1] specifies the following for mapping symbols:

  1) A text section must always have a corresponding mapping symbol at it's
     start.
  2) Data sections do not require any mapping symbols.
  3) The range of a mapping symbol extends from the address it starts on up to
     the next mapping symbol (exclusive) or section end (inclusive).

However there is no defined order between a symbol and it's corresponding
mapping symbol in the symbol table.  This means that while in general we look
up for a corresponding mapping symbol, we have to make at least one check of
the symbol below the address being disassembled.

When disassembling different PCs within the same section, the search for mapping
symbol can be cached somewhat.  We know that the mapping symbol corresponding to
the current PC is either the previous one used, or one at the same address as
the current PC.

However this optimization and mapping symbol search must stop as soon as we
reach the end or start of the section.  Furthermore if we're only disassembling
a part of a section, the search is a allowed to search further than the current
chunk, but is not allowed to search past it (The mapping symbol if there, must
be at the same address, so in practice we usually stop at PC+4).

lastly, since only data sections don't require a mapping symbol the default
mapping type should be DATA and not INSN as previously defined, however if the
binary has had all its symbols stripped than this isn't very useful.  To fix
this we determine the default based on the section flags.  This will allow the
disassembler to be more useful on stripped binaries.  If there is no section
than we assume you to be disassembling INSN.

[1] https://developer.arm.com/docs/ihi0044/latest/elf-for-the-arm-architecture-abi-2018q4-documentation#aaelf32-table4-7

binutils/ChangeLog:

	* testsuite/binutils-all/arm/in-order-all.d: New test.
	* testsuite/binutils-all/arm/in-order.d: New test.
	* testsuite/binutils-all/arm/objdump.exp: Support .d tests.
	* testsuite/binutils-all/arm/out-of-order-all.d: New test.
	* testsuite/binutils-all/arm/out-of-order.T: New test.
	* testsuite/binutils-all/arm/out-of-order.d: New test.
	* testsuite/binutils-all/arm/out-of-order.s: New test.

ld/ChangeLog:

	* testsuite/ld-arm/jump-reloc-veneers-cond-long.d: Update disassembly.
	* testsuite/ld-arm/jump-reloc-veneers-long.d: Update disassembly.

opcodes/ChangeLog:

	* arm-dis.c (struct arm_private_data): Remove has_mapping_symbols.
	(mapping_symbol_for_insn): Implement new algorithm.
	(print_insn): Remove duplicate code.
2019-03-25 15:05:53 +00:00
..
emulparams lm32-linux ld testsuite fails 2019-03-21 08:57:30 +10:30
emultempl [BFD, LD, AArch64, 3/3] Add --pac-plt to enable PLTs protected with PAC. 2019-03-13 11:47:33 +00:00
po Updated French translation for ld/ and gold/ subdirectories 2019-02-12 13:22:42 +00:00
scripttempl Add SORT_NONE to .init and .fini in scripts 2019-03-21 22:19:20 +10:30
testsuite Arm: Fix Arm disassembler mapping symbol search. 2019-03-25 15:05:53 +00:00
.gitignore
ChangeLog Arm: Fix Arm disassembler mapping symbol search. 2019-03-25 15:05:53 +00:00
ChangeLog-0001
ChangeLog-0203
ChangeLog-2004
ChangeLog-2005
ChangeLog-2006
ChangeLog-2007
ChangeLog-2008 strip off +x bits on non-executable/script files 2013-12-07 02:03:03 -05:00
ChangeLog-2009 Remove trailing spaces in ld 2015-08-12 04:46:43 -07:00
ChangeLog-2010
ChangeLog-2011
ChangeLog-2012
ChangeLog-2013 New Year - binutils ChangeLog rotation 2014-01-08 05:32:12 -08:00
ChangeLog-2014 ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
ChangeLog-2015 binutils ChangeLog rotation 2016-01-01 22:59:17 +10:30
ChangeLog-2016 ChangeLog rotation 2017-01-02 13:55:05 +10:30
ChangeLog-2017 ChangeLog rotation 2018-01-03 17:49:42 +10:30
ChangeLog-2018 ChangeLog rotation 2019-01-01 21:25:40 +10:30
ChangeLog-9197 Remove trailing spaces in ld 2015-08-12 04:46:43 -07:00
ChangeLog-9899
MAINTAINERS Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
Makefile.am Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
Makefile.in Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
NEWS [BFD, LD, AArch64, 3/3] Add --pac-plt to enable PLTs protected with PAC. 2019-03-13 11:47:33 +00:00
README Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
TODO
aclocal.m4 Bump to autoconf 2.69 and automake 1.15.1 2018-06-19 16:55:06 -04:00
config.in Bump to autoconf 2.69 and automake 1.15.1 2018-06-19 16:55:06 -04:00
configure Change version to 2.32.51 and regenerate configure and pot files. 2019-01-19 16:51:42 +00:00
configure.ac Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
configure.host Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
configure.tgt Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
deffile.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
deffilep.y Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
dep-in.sed
elf-hints-local.h
fdl.texi
gen-doc.texi Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
genscrba.sh
genscripts.sh Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
h8-doc.texi Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ld.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ld.texi Update the documentation describing where the linker will attempt to locate plugins. 2019-03-15 12:08:56 +00:00
ldbuildid.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldbuildid.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldcref.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldctor.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldctor.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldemul.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldemul.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldexp.c Allow the use of the ORIGIN and LENGTH attributes in expressions inside MEMORY regions. 2019-03-06 15:20:29 +00:00
ldexp.h PR24008, Wrong value of ternary expression in map file 2019-01-28 09:59:29 +10:30
ldfile.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldfile.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldgram.y Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldint.texi Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldlang.c Add SORT_NONE to .init and .fini in scripts 2019-03-21 22:19:20 +10:30
ldlang.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldlex-wrapper.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldlex.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldlex.l Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldmain.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldmain.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldmisc.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldmisc.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldver.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldver.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldwrite.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
ldwrite.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
lexsup.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
mri.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
mri.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
pe-dll.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
pe-dll.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
pep-dll.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
pep-dll.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
plugin.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
plugin.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
stamp-h.in
sysdep.h Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
testplug.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
testplug2.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
testplug3.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30
testplug4.c Update year range in copyright notice of binutils files 2019-01-01 22:06:53 +10:30

README

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

		README for LD

This is the GNU linker.  It is distributed with other "binary
utilities" which should be in ../binutils.  See ../binutils/README for
more general notes, including where to send bug reports.

There are many features of the linker:

* The linker uses a Binary File Descriptor library (../bfd)
  that it uses to read and write object files.  This helps
  insulate the linker itself from the format of object files.

* The linker supports a number of different object file
  formats.  It can even handle multiple formats at once:
  Read two input formats and write a third.

* The linker can be configured for cross-linking.

* The linker supports a control language.

* There is a user manual (ld.texi), as well as the
  beginnings of an internals manual (ldint.texi).

Installation
============

See ../binutils/README.

If you want to make a cross-linker, you may want to specify
a different search path of -lfoo libraries than the default.
You can do this by setting the LIB_PATH variable in ./Makefile
or using the --with-lib-path configure switch.

To build just the linker, make the target all-ld from the top level
directory (one directory above this one).

Porting to a new target
=======================

See the ldint.texi manual.

Reporting bugs etc
===========================

See ../binutils/README.

Known problems
==============

The Solaris linker normally exports all dynamic symbols from an
executable.  The GNU linker does not do this by default.  This is
because the GNU linker tries to present the same interface for all
similar targets (in this case, all native ELF targets).  This does not
matter for normal programs, but it can make a difference for programs
which try to dlopen an executable, such as PERL or Tcl.  You can make
the GNU linker export all dynamic symbols with the -E or
--export-dynamic command line option.

HP/UX 9.01 has a shell bug that causes the linker scripts to be
generated incorrectly.  The symptom of this appears to be "fatal error
- scanner input buffer overflow" error messages.  There are various
workarounds to this:
  * Build and install bash, and build with "make SHELL=bash".
  * Update to a version of HP/UX with a working shell (e.g., 9.05).
  * Replace "(. ${srcdir}/scripttempl/${SCRIPT_NAME}.sc)" in
    genscripts.sh with "sh ${srcdir}..." (no parens) and make sure the
    emulparams script used exports any shell variables it sets.

Copyright (C) 2012-2019 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.