f29f4b6ba1
Testing with: $ make check-read1 TESTS="gdb.asm/asm-source.exp" Exposes a testcase bug that can result in racy fails: (gdb) PASS: gdb.asm/asm-source.exp: next over foo3 return Make selected stack frame return now? (y or n) y n #0 main () at /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.asm/asmsrc1.s:53 53 gdbasm_exit0 (gdb) FAIL: gdb.asm/asm-source.exp: return from foo2 (got interactive prompt) n The problem is that the "return now\?.*" regex can match partial output like this: "Make selected stack frame return no" and then we send the 'y' too early, and then the next time around we hit gdb_test_multiple's internal "got interactive prompt" regex. Also, note we match "return no" instead of "return now" because the regex is missing one quote level. gdb/testsuite/ChangeLog: 2017-11-09 Pedro Alves <palves@redhat.com> * gdb.asm/asm-source.exp ("kill" test): Match the whole query output. Fix '?' match. |
||
|---|---|---|
| .. | ||
| aarch64.inc | ||
| alpha.inc | ||
| arm.inc | ||
| asm-source.exp | ||
| asmsrc1.s | ||
| asmsrc2.s | ||
| bfin.inc | ||
| common.inc | ||
| empty.inc | ||
| frv.inc | ||
| h8300.inc | ||
| i386.inc | ||
| ia64.inc | ||
| iq2000.inc | ||
| m32c.inc | ||
| m32r-linux.inc | ||
| m32r.inc | ||
| m68hc11.inc | ||
| m68k.inc | ||
| mips.inc | ||
| netbsd.inc | ||
| openbsd.inc | ||
| pa.inc | ||
| pa64.inc | ||
| powerpc.inc | ||
| powerpc64.inc | ||
| powerpc64le.inc | ||
| s390.inc | ||
| s390x.inc | ||
| sh.inc | ||
| sparc.inc | ||
| sparc64.inc | ||
| spu.inc | ||
| v850.inc | ||
| x86_64.inc | ||
| xstormy16.inc | ||