binutils-gdb/gold
Cary Coutant 2cfbf2fece Fix a file descriptor leak in gold.
When an LTO linker plugin claims an external member of a thin archive, gold
does not properly unlock the file and make its file descriptor available for
reuse. This patch fixes the problem by modifying Archive::include_member to
unlock the object file via an RAII class instance, ensuring that it will be
unlocked no matter what path is taken through the function.

gold/
	PR gold/15660
	* archive.cc (Thin_archive_object_unlocker): New class.
	(Archive::include_member): Unlock external members of thin archives.
	* testsuite/Makefile.am (plugin_test_1): Rename .syms files.
	(plugin_test_2): Likewise.
	(plugin_test_3): Likewise.
	(plugin_test_4): Likewise.
	(plugin_test_5): Likewise.
	(plugin_test_6): Likewise.
	(plugin_test_7): Likewise.
	(plugin_test_8): Likewise.
	(plugin_test_9): Likewise.
	(plugin_test_10): Likewise.
	(plugin_test_11): New test case.
	* testsuite/Makefile.in: Regenerate.
	* testsuite/plugin_test.c (claim_file_hook): Check for parallel .syms
	file to decide whether to claim file.
	(all_symbols_read_hook): Likewise.
	* testsuite/plugin_test_1.sh: Adjust expected output.
	* testsuite/plugin_test_2.sh: Likewise.
	* testsuite/plugin_test_3.sh: Likewise.
	* testsuite/plugin_test_6.sh: Likewise.
	* testsuite/plugin_test_tls.sh: Likewise.
	* testsuite/plugin_test_11.sh: New testcase.
2015-02-03 20:03:42 -08:00
..
po ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
testsuite Fix a file descriptor leak in gold. 2015-02-03 20:03:42 -08:00
aarch64-reloc-property.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
aarch64-reloc-property.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
aarch64-reloc.def ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
aarch64.cc This patch adds IFUNC support for arm gold backend. 2015-01-29 10:15:42 -08:00
aclocal.m4
archive.cc Fix a file descriptor leak in gold. 2015-02-03 20:03:42 -08:00
archive.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
arm-reloc-property.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
arm-reloc-property.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
arm-reloc.def ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
arm.cc This patch adds IFUNC support for arm gold backend. 2015-01-29 10:15:42 -08:00
attributes.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
attributes.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
binary.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
binary.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
ChangeLog Fix bug with previous patch for unresolved TLS symbol. 2015-02-02 11:46:45 -08:00
common.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
common.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
compressed_output.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
compressed_output.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
config.in Add configure checks for <unordered_set> and <unordered_map>. 2013-12-18 15:53:31 -08:00
configure Handle stack split for x32 2015-01-06 15:38:25 -08:00
configure.ac Handle stack split for x32 2015-01-06 15:38:25 -08:00
configure.tgt ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
copy-relocs.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
copy-relocs.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
cref.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
cref.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
debug.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
defstd.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
defstd.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
descriptors.cc Add extra debugging output for files and descriptors. 2015-02-03 20:03:41 -08:00
descriptors.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
dirsearch.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
dirsearch.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
dwarf_reader.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
dwarf_reader.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
dwp.cc Correct printed year in copyright notices for gold. 2015-01-02 08:51:43 +10:30
dwp.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
dynobj.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
dynobj.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
ehframe.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
ehframe.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
errors.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
errors.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
expression.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
ffsll.c ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
fileread.cc Add extra debugging output for files and descriptors. 2015-02-03 20:03:41 -08:00
fileread.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
freebsd.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
ftruncate.c ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
gc.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
gc.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
gdb-index.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
gdb-index.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
gold-threads.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
gold-threads.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
gold.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
gold.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
i386.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
icf.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
icf.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
incremental-dump.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
incremental.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
incremental.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
int_encoding.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
int_encoding.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
layout.cc Don't align start of segment unless alignment is larger than page size. 2015-01-09 15:58:39 -08:00
layout.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
main.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
Makefile.am ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
Makefile.in Regenerate Makeile.in file for copyright update 2015-01-02 22:27:27 +10:30
mapfile.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
mapfile.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
merge.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
merge.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
mips.cc Fix a bug in resolving HI16/LO16 relocation pairs for MIPS. 2015-01-14 10:30:14 -08:00
mremap.c ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
nacl.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
nacl.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
NEWS ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
object.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
object.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
options.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
options.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
output.cc 2015-01-25 Cary Coutant <ccoutant@google.com> 2015-01-25 17:31:32 -08:00
output.h This patch adds IFUNC support for arm gold backend. 2015-01-29 10:15:42 -08:00
parameters.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
parameters.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
plugin.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
plugin.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
powerpc.cc Correct GOLD PowerPC64 local-dynamic TLS linker optimization 2015-01-29 20:34:45 +10:30
pread.c ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
README ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
readsyms.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
readsyms.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
reduced_debug_output.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
reduced_debug_output.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
reloc-types.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
reloc.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
reloc.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
resolve.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
script-c.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
script-sections.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
script-sections.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
script.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
script.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
sparc.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
stringpool.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
stringpool.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
symtab.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
symtab.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
system.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
target-reloc.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
target-select.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
target-select.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
target.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
target.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
tilegx.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
timer.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
timer.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
tls.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
TODO
token.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
version.cc Correct printed year in copyright notices for gold. 2015-01-02 08:51:43 +10:30
workqueue-internal.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
workqueue-threads.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
workqueue.cc ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
workqueue.h ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30
x86_64.cc Fix bug with previous patch for unresolved TLS symbol. 2015-02-02 11:46:45 -08:00
yyscript.y ChangeLog rotatation and copyright year update 2015-01-02 00:53:45 +10:30

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

gold is an ELF linker.  It is intended to have complete support for
ELF and to run as fast as possible on modern systems.  For normal use
it is a drop-in replacement for the older GNU linker.

gold is part of the GNU binutils.  See ../binutils/README for more
general notes, including where to send bug reports.

gold was originally developed at Google, and was contributed to the
Free Software Foundation in March 2008.  At Google it was designed by
Ian Lance Taylor, with major contributions by Cary Coutant, Craig
Silverstein, and Andrew Chatham.

The existing GNU linker manual is intended to be accurate
documentation for features which gold supports.  gold supports most of
the features of the GNU linker for ELF targets.  Notable
omissions--features of the GNU linker not currently supported in
gold--are:
  * MRI compatible linker scripts
  * cross-reference reports (--cref)
  * various other minor options


Notes on the code
=================

These are some notes which may be helpful to people working on the
source code of gold itself.

gold is written in C++.  It is a GNU program, and therefore follows
the GNU formatting standards as modified for C++.  Source documents in
order of decreasing precedence:
    http://www.gnu.org/prep/standards/
    http://gcc.gnu.org/onlinedocs/libstdc++/manual/source_code_style.html
    http://www.zembu.com/eng/procs/c++style.html

The linker is intended to have complete support for cross-compilation,
while still supporting the normal case of native linking as fast as
possible.  In order to do this, many classes are actually templates
whose parameter is the ELF file class (e.g., 32 bits or 64 bits).  The
C++ code is the same, but we don't pay the execution time cost of
always using 64-bit integers if the target is 32 bits.  Many of these
class templates also have an endianness parameter: true for
big-endian, false for little-endian.

The linker is multi-threaded.  The Task class represents a single unit
of work.  Task objects are stored on a single Workqueue object.  Tasks
communicate via Task_token objects.  Task_token objects are only
manipulated while holding the master Workqueue lock.  Relatively few
mutexes are used.


Build requirements
==================

The gold source code uses templates heavily.  Building it requires a
recent version of g++.  g++ 4.0.3 and 4.1.3 are known to work.  g++
3.2, 3.4.3, and 4.1.2 are known to fail.

The linker script parser uses features which are only in newer
versions of bison.  bison 2.3 is known to work.  bison 1.26 is known
to fail.  If you are building gold from an official binutils release,
the bison output should already be included.


Copyright (C) 2012-2015 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.