binutils-gdb/gdb/gdbserver
Antoine Tremblay 2d97cd356e Fix instruction skipping when using software single step in GDBServer
Without this patch, when doing a software single step, with for example
a conditional breakpoint, gdbserver would wrongly avance the pc of
breakpoint_len and skips an instruction.

This is due to gdbserver assuming that it's hardware single stepping.
When it resumes from the breakpoint address it expects the trap to be
caused by ptrace and if it's rather caused by a software breakpoint
it assumes this is a permanent breakpoint and that it needs to skip
over it.

However when software single stepping, this breakpoint is legitimate as
it's the reinsert breakpoint gdbserver has put in place to break at
the next instruction. Thus gdbserver wrongly advances the pc and skips
an instruction.

This patch fixes this behavior so that gdbserver checks if it is a
reinsert breakpoint from software single stepping. If it is it won't
advance the pc. And if there's no reinsert breakpoint there we assume
then that it's a permanent breakpoint and advance the pc.

Here's a commented log of what would happen before and after the fix on
gdbserver :

/* Here there is a conditional breakpoint at 0x10428 that needs to be
stepped over. */

Need step over [LWP 11204]? yes, found breakpoint at 0x10428
...
/* e7f001f0 is a breakpoint instruction on arm
   Here gdbserver writes the software breakpoint we would like to hit
*/
Writing e7f001f0 to 0x0001042c in process 11204
...
Resuming lwp 11220 (continue, signal 0, stop not expected)
  pending reinsert at 0x10428
stop pc is 00010428
  continue from pc 0x10428
...

/* Here gdbserver hit the software breakpoint that was in place
   for the step over */

stop pc is 0001042c
pc is 0x1042c
step-over for LWP 11220.11220 executed software breakpoint
Finished step over.
Could not find fast tracepoint jump at 0x10428 in list (reinserting).

/* Here gdbserver writes back the original instruction */
Writing e50b3008 to 0x0001042c in process 11220
Step-over finished.
Need step over [LWP 11220]? No

/* Here because gdbserver assumes this is a permenant breakpoint it advances
the pc of breakpoint_len, in this case 4 bytes, so we have just skipped
the instruction that was written back here :
Writing e50b3008 to 0x0001042c in process 11220
*/

stop pc is 00010430
pc is 0x10430
Need step over [LWP 11220]? No, no breakpoint found at 0x10430
Proceeding, no step-over needed
proceed_one_lwp: lwp 11220
stop pc is 00010430

This patch fixes this situation and we get the right behavior :

Writing e50b3008 to 0x0001042c in process 11245
Hit a gdbserver breakpoint.
Hit a gdbserver breakpoint.
Step-over finished.
proceeding all threads.
Need step over [LWP 11245]? No
stop pc is 0001042c
pc is 0x1042c
Need step over [LWP 11245]? No, no breakpoint found at 0x1042c
Proceeding, no step-over needed
proceed_one_lwp: lwp 11245
stop pc is 0001042c
pc is 0x1042c
Resuming lwp 11245 (continue, signal 0, stop not expected)
stop pc is 0001042c
  continue from pc 0x1042c

It also works if the value at 0x0001042c is a permanent breakpoint.
If so gdbserver will finish the step over, remove the reinserted breakpoint,
resume at that location and on the next SIGTRAP gdbserver will trigger
the advance PC condition as reinsert_breakpoint_inserted_here will be false.

I also tested this against bp-permanent.exp on arm (with a work in progress
software single step patchset) without any regressions.

It's also tested against x86 bp-permanent.exp without any regression.

So both software and hardware single step are tested.

No regressions on Ubuntu 14.04 on ARMv7 and x86.
With gdbserver-{native,extended} / { -marm -mthumb }

gdb/gdbserver/ChangeLog:

	* linux-low.c (linux_wait_1): Fix pc advance condition.
	* mem-break.c (reinsert_breakpoint_inserted_here): New function.
	* mem-break.h (reinsert_breakpoint_inserted_here): New declaration.
2015-11-30 15:16:22 -05:00
..
.gitignore
ChangeLog Fix instruction skipping when using software single step in GDBServer 2015-11-30 15:16:22 -05:00
Makefile.in [gdbserver/ipa] Fix build dependencies 2015-11-18 13:02:21 +00:00
README
acinclude.m4 make gdbserver use the same ptrace autoconf checks as gdb 2015-07-24 14:57:19 +01:00
aclocal.m4
ax.c Add casts to memory allocation related calls 2015-09-25 14:08:06 -04:00
ax.h
config.in C++: handle glibc's ptrace(enum __ptrace_request, ...) 2015-07-24 15:12:15 +01:00
configure [gdbserver] disable Elf32_auxv_t/Elf64_auxv_t AC_CHECK_TYPES check on Android 2015-11-23 09:48:16 -08:00
configure.ac [gdbserver] disable Elf32_auxv_t/Elf64_auxv_t AC_CHECK_TYPES check on Android 2015-11-23 09:48:16 -08:00
configure.srv Implement breakpoint_kind_from_pc and sw_breakpoint_from_kind for ARM in GDBServer. 2015-10-21 11:26:05 -04:00
debug.c Prepare for gnulib update 2015-08-24 18:50:55 +01:00
debug.h
dll.c Add some more casts (1/2) 2015-09-25 14:08:07 -04:00
dll.h
event-loop.c Replace some xmalloc-family functions with XNEW-family ones 2015-08-26 17:18:12 -04:00
event-loop.h
gdb_proc_service.h
gdbreplay.c
gdbthread.h gdbserver crash running gdb.threads/non-ldr-exc-1.exp 2015-11-30 18:37:25 +00:00
hostio-errno.c
hostio.c Add casts to memory allocation related calls 2015-09-25 14:08:06 -04:00
hostio.h
i387-fp.c
i387-fp.h
inferiors.c gdbserver crash running gdb.threads/non-ldr-exc-1.exp 2015-11-30 18:37:25 +00:00
inferiors.h gdbserver crashes when multiprocess extensions aren't supported 2015-08-24 19:58:31 +01:00
linux-aarch32-low.c gdbserver arm: Add casts 2015-11-03 13:33:13 -05:00
linux-aarch32-low.h New regs_info for aarch32 2015-08-04 14:34:14 +01:00
linux-aarch64-ipa.c Add support for fast tracepoints 2015-09-21 15:01:04 +01:00
linux-aarch64-low.c Change argument opcode type from enum aarch64_opcodes to uint32_t 2015-11-19 14:01:04 +00:00
linux-amd64-ipa.c
linux-arm-low.c Fix breakpoint size when stepping over a permanent breakpoint in GDBServer. 2015-11-30 15:08:04 -05:00
linux-bfin-low.c Add the target_ops needed for software breakpoints in GDBServer. 2015-10-21 11:24:55 -04:00
linux-cris-low.c Add the target_ops needed for software breakpoints in GDBServer. 2015-10-21 11:24:55 -04:00
linux-crisv32-low.c gdbserver/Linux: Introduce NULL_REGSET 2015-10-29 12:55:02 +00:00
linux-i386-ipa.c Remove redundant include directives. 2015-06-24 13:52:29 +01:00
linux-ia64-low.c
linux-low.c Fix instruction skipping when using software single step in GDBServer 2015-11-30 15:16:22 -05:00
linux-low.h Fix breakpoint size when stepping over a permanent breakpoint in GDBServer. 2015-11-30 15:08:04 -05:00
linux-m32r-low.c Add the target_ops needed for software breakpoints in GDBServer. 2015-10-21 11:24:55 -04:00
linux-m68k-low.c gdbserver/Linux: Introduce NULL_REGSET 2015-10-29 12:55:02 +00:00
linux-mips-low.c linux-mips-low.c: Add casts 2015-11-03 13:33:15 -05:00
linux-nios2-low.c gdbserver/Linux: Introduce NULL_REGSET 2015-10-29 12:55:02 +00:00
linux-ppc-low.c linux-ppc-low.c: Add casts 2015-11-03 13:33:11 -05:00
linux-s390-low.c gdbserver/Linux: Introduce NULL_REGSET 2015-10-29 12:55:02 +00:00
linux-sh-low.c gdbserver/Linux: Introduce NULL_REGSET 2015-10-29 12:55:02 +00:00
linux-sparc-low.c gdbserver/Linux: Introduce NULL_REGSET 2015-10-29 12:55:02 +00:00
linux-tic6x-low.c gdbserver/Linux: Introduce NULL_REGSET 2015-10-29 12:55:02 +00:00
linux-tile-low.c gdbserver/Linux: Introduce NULL_REGSET 2015-10-29 12:55:02 +00:00
linux-x86-low.c gdbserver: Fix qSupported:xmlRegisters=i386;UnknownFeature+ handling 2015-11-19 18:32:55 +00:00
linux-xtensa-low.c gdbserver/Linux: Introduce NULL_REGSET 2015-10-29 12:55:02 +00:00
lynx-i386-low.c Remove redundant include directives. 2015-06-24 13:52:29 +01:00
lynx-low.c [LynxOS] GDBserver crash debugging threaded program 2015-11-23 09:56:23 -08:00
lynx-low.h
lynx-ppc-low.c Remove redundant include directives. 2015-06-24 13:52:29 +01:00
mem-break.c Fix instruction skipping when using software single step in GDBServer 2015-11-30 15:16:22 -05:00
mem-break.h Fix instruction skipping when using software single step in GDBServer 2015-11-30 15:16:22 -05:00
notif.c
notif.h
nto-low.c Fix nto,spu and win32 builds of GDBServer. 2015-10-23 13:21:11 -04:00
nto-low.h
nto-x86-low.c
proc-service.c gdbserver/proc-service.c: Change CORE_ADDR cast to uintptr_t 2015-10-30 11:50:00 -04:00
proc-service.list
regcache.c [LynxOS] GDBserver crash debugging threaded program 2015-11-23 09:56:23 -08:00
regcache.h [LynxOS] GDBserver crash debugging threaded program 2015-11-23 09:56:23 -08:00
remote-utils.c gdbserver: don't exit until GDB disconnects 2015-11-30 19:41:38 +00:00
remote-utils.h
server.c gdbserver: don't exit until GDB disconnects 2015-11-30 19:41:38 +00:00
server.h Remote thread create/exit events 2015-11-30 18:40:30 +00:00
spu-low.c Fix nto,spu and win32 builds of GDBServer. 2015-10-23 13:21:11 -04:00
symbol.c
target.c gdbserver:prepare_access_memory: pick another thread 2015-11-30 18:44:51 +00:00
target.h Fix breakpoint size when stepping over a permanent breakpoint in GDBServer. 2015-11-30 15:08:04 -05:00
tdesc.c C++: Initialize a couple const globals 2015-08-21 23:49:37 +01:00
tdesc.h
terminal.h
thread-db.c Add some casts for building on musl. 2015-10-26 13:20:12 -07:00
tracepoint.c gdbserver/tracepoint: Add casts out of tpoint->handle 2015-10-29 12:56:27 +00:00
tracepoint.h
utils.c
utils.h
win32-arm-low.c
win32-i386-low.c [C++/mingw] gdbserver casts 2015-11-17 15:19:42 +00:00
win32-low.c [C++/mingw] gdbserver: gdb/host signal mixup 2015-11-17 15:21:13 +00:00
win32-low.h
wincecompat.c
wincecompat.h
x86-low.c
x86-low.h
xtensa-xtregs.c

README

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol
implemented in remote.c, and various *-stub.c files.  They communicate via
either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual.

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection from `host' to local TCP port
2345.  (Currently, the `host' part is ignored.)  You can choose any number you
want for the port number as long as it does not conflict with any existing TCP
ports on the target system.  This same port number must be used in the host
GDBs `target remote' command, which will be described shortly.  Note that if
you chose a port number that conflicts with another service, GDBserver will
print an error message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

The supported targets as of November 2006 are:
	arm-*-linux*
	bfin-*-uclinux
	bfin-*-linux-uclibc
	crisv32-*-linux*
	cris-*-linux*
	i[34567]86-*-cygwin*
	i[34567]86-*-linux*
	i[34567]86-*-mingw*
	ia64-*-linux*
	m32r*-*-linux*
	m68*-*-linux*
	m68*-*-uclinux*
	mips*64*-*-linux*
	mips*-*-linux*
	powerpc[64]-*-linux*
	s390[x]-*-linux*
	sh-*-linux*
	spu*-*-*
	x86_64-*-linux*

Configuring GDBserver you should specify the same machine for host and
target (which are the machine that GDBserver is going to run on.  This
is not the same as the machine that GDB is going to run on; building
GDBserver automatically as part of building a whole tree of tools does
not currently work if cross-compilation is involved (we don't get the
right CC in the Makefile, to start with)).

Building GDBserver for your target is very straightforward.  If you build
GDB natively on a target which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-gdbserver-sources/configure
	% make

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  In a Bourne shell, for example:

	% export CC=your-cross-compiler
	% path-to-gdbserver-sources/configure your-target-name
	% make

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.  Note
that GDBreplay echos the command lines to stderr, as well as the contents of
the packets it sends and receives.  The last command echoed by GDBreplay is
the next command that needs to be typed to GDB to continue the session in
sync with the original session.