5b6d1e4fa4
This commit adds multi-target support to GDB. What this means is that with this commit, GDB can now be connected to different targets at the same time. E.g., you can debug a live native process and a core dump at the same time, connect to multiple gdbservers, etc. Actually, the word "target" is overloaded in gdb. We already have a target stack, with pushes several target_ops instances on top of one another. We also have "info target" already, which means something completely different to what this patch does. So from here on, I'll be using the "target connections" term, to mean an open process_stratum target, pushed on a target stack. This patch makes gdb have multiple target stacks, and multiple process_stratum targets open simultaneously. The user-visible changes / commands will also use this terminology, but of course it's all open to debate. User-interface-wise, not that much changes. The main difference is that each inferior may have its own target connection. A target connection (e.g., a target extended-remote connection) may support debugging multiple processes, just as before. Say you're debugging against gdbserver in extended-remote mode, and you do "add-inferior" to prepare to spawn a new process, like: (gdb) target extended-remote :9999 ... (gdb) start ... (gdb) add-inferior Added inferior 2 (gdb) inferior 2 [Switching to inferior 2 [<null>] (<noexec>)] (gdb) file a.out ... (gdb) start ... At this point, you have two inferiors connected to the same gdbserver. With this commit, GDB will maintain a target stack per inferior, instead of a global target stack. To preserve the behavior above, by default, "add-inferior" makes the new inferior inherit a copy of the target stack of the current inferior. Same across a fork - the child inherits a copy of the target stack of the parent. While the target stacks are copied, the targets themselves are not. Instead, target_ops is made a refcounted_object, which means that target_ops instances are refcounted, which each inferior counting for a reference. What if you want to create an inferior and connect it to some _other_ target? For that, this commit introduces a new "add-inferior -no-connection" option that makes the new inferior not share the current inferior's target. So you could do: (gdb) target extended-remote :9999 Remote debugging using :9999 ... (gdb) add-inferior -no-connection [New inferior 2] Added inferior 2 (gdb) inferior 2 [Switching to inferior 2 [<null>] (<noexec>)] (gdb) info inferiors Num Description Executable 1 process 18401 target:/home/pedro/tmp/main * 2 <null> (gdb) tar extended-remote :10000 Remote debugging using :10000 ... (gdb) info inferiors Num Description Executable 1 process 18401 target:/home/pedro/tmp/main * 2 process 18450 target:/home/pedro/tmp/main (gdb) A following patch will extended "info inferiors" to include a column indicating which connection an inferior is bound to, along with a couple other UI tweaks. Other than that, debugging is the same as before. Users interact with inferiors and threads as before. The only difference is that inferiors may be bound to processes running in different machines. That's pretty much all there is to it in terms of noticeable UI changes. On to implementation. Since we can be connected to different systems at the same time, a ptid_t is no longer a unique identifier. Instead a thread can be identified by a pair of ptid_t and 'process_stratum_target *', the later being the instance of the process_stratum target that owns the process/thread. Note that process_stratum_target inherits from target_ops, and all process_stratum targets inherit from process_stratum_target. In earlier patches, many places in gdb were converted to refer to threads by thread_info pointer instead of ptid_t, but there are still places in gdb where we start with a pid/tid and need to find the corresponding inferior or thread_info objects. So you'll see in the patch many places adding a process_stratum_target parameter to functions that used to take only a ptid_t. Since each inferior has its own target stack now, we can always find the process_stratum target for an inferior. That is done via a inf->process_target() convenience method. Since each inferior has its own target stack, we need to handle the "beneath" calls when servicing target calls. The solution I settled with is just to make sure to switch the current inferior to the inferior you want before making a target call. Not relying on global context is just not feasible in current GDB. Fortunately, there aren't that many places that need to do that, because generally most code that calls target methods already has the current context pointing to the right inferior/thread. Note, to emphasize -- there's no method to "switch to this target stack". Instead, you switch the current inferior, and that implicitly switches the target stack. In some spots, we need to iterate over all inferiors so that we reach all target stacks. Native targets are still singletons. There's always only a single instance of such targets. Remote targets however, we'll have one instance per remote connection. The exec target is still a singleton. There's only one instance. I did not see the point of instanciating more than one exec_target object. After vfork, we need to make sure to push the exec target on the new inferior. See exec_on_vfork. For type safety, functions that need a {target, ptid} pair to identify a thread, take a process_stratum_target pointer for target parameter instead of target_ops *. Some shared code in gdb/nat/ also need to gain a target pointer parameter. This poses an issue, since gdbserver doesn't have process_stratum_target, only target_ops. To fix this, this commit renames gdbserver's target_ops to process_stratum_target. I think this makes sense. There's no concept of target stack in gdbserver, and gdbserver's target_ops really implements a process_stratum-like target. The thread and inferior iterator functions also gain process_stratum_target parameters. These are used to be able to iterate over threads and inferiors of a given target. Following usual conventions, if the target pointer is null, then we iterate over threads and inferiors of all targets. I tried converting "add-inferior" to the gdb::option framework, as a preparatory patch, but that stumbled on the fact that gdb::option does not support file options yet, for "add-inferior -exec". I have a WIP patchset that adds that, but it's not a trivial patch, mainly due to need to integrate readline's filename completion, so I deferred that to some other time. In infrun.c/infcmd.c, the main change is that we need to poll events out of all targets. See do_target_wait. Right after collecting an event, we switch the current inferior to an inferior bound to the target that reported the event, so that target methods can be used while handling the event. This makes most of the code transparent to multi-targets. See fetch_inferior_event. infrun.c:stop_all_threads is interesting -- in this function we need to stop all threads of all targets. What the function does is send an asynchronous stop request to all threads, and then synchronously waits for events, with target_wait, rinse repeat, until all it finds are stopped threads. Now that we have multiple targets, it's not efficient to synchronously block in target_wait waiting for events out of one target. Instead, we implement a mini event loop, with interruptible_select, select'ing on one file descriptor per target. For this to work, we need to be able to ask the target for a waitable file descriptor. Such file descriptors already exist, they are the descriptors registered in the main event loop with add_file_handler, inside the target_async implementations. This commit adds a new target_async_wait_fd target method that just returns the file descriptor in question. See wait_one / stop_all_threads in infrun.c. The 'threads_executing' global is made a per-target variable. Since it is only relevant to process_stratum_target targets, this is where it is put, instead of in target_ops. You'll notice that remote.c includes some FIXME notes. These refer to the fact that the global arrays that hold data for the remote packets supported are still globals. For example, if we connect to two different servers/stubs, then each might support different remote protocol features. They might even be different architectures, like e.g., one ARM baremetal stub, and a x86 gdbserver, to debug a host/controller scenario as a single program. That isn't going to work correctly today, because of said globals. I'm leaving fixing that for another pass, since it does not appear to be trivial, and I'd rather land the base work first. It's already useful to be able to debug multiple instances of the same server (e.g., a distributed cluster, where you have full control over the servers installed), so I think as is it's already reasonable incremental progress. Current limitations: - You can only resume more that one target at the same time if all targets support asynchronous debugging, and support non-stop mode. It should be possible to support mixed all-stop + non-stop backends, but that is left for another time. This means that currently in order to do multi-target with gdbserver you need to issue "maint set target-non-stop on". I would like to make that mode be the default, but we're not there yet. Note that I'm talking about how the target backend works, only. User-visible all-stop mode works just fine. - As explained above, connecting to different remote servers at the same time is likely to produce bad results if they don't support the exact set of RSP features. FreeBSD updates courtesy of John Baldwin. gdb/ChangeLog: 2020-01-10 Pedro Alves <palves@redhat.com> John Baldwin <jhb@FreeBSD.org> * aarch64-linux-nat.c (aarch64_linux_nat_target::thread_architecture): Adjust. * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call. (task_command_1): Likewise. * aix-thread.c (sync_threadlists, aix_thread_target::resume) (aix_thread_target::wait, aix_thread_target::fetch_registers) (aix_thread_target::store_registers) (aix_thread_target::thread_alive): Adjust. * amd64-fbsd-tdep.c: Include "inferior.h". (amd64fbsd_get_thread_local_address): Pass down target. * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle thread's gdbarch instead of target_gdbarch. * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to get_last_target_status. * break-catch-syscall.c (print_it_catch_syscall): Likewise. * breakpoint.c (breakpoints_should_be_inserted_now): Consider all inferiors. (update_inserted_breakpoint_locations): Skip if inferiors with no execution. (update_global_location_list): When handling moribund locations, find representative inferior for location's pspace, and use thread count of its process_stratum target. * bsd-kvm.c (bsd_kvm_target_open): Pass target down. * bsd-uthread.c (bsd_uthread_target::wait): Use as_process_stratum_target and adjust thread_change_ptid and add_thread calls. (bsd_uthread_target::update_thread_list): Use as_process_stratum_target and adjust find_thread_ptid, thread_change_ptid and add_thread calls. * btrace.c (maint_btrace_packet_history_cmd): Adjust find_thread_ptid call. * corelow.c (add_to_thread_list): Adjust add_thread call. (core_target_open): Adjust add_thread_silent and thread_count calls. (core_target::pid_to_str): Adjust find_inferior_ptid call. * ctf.c (ctf_target_open): Adjust add_thread_silent call. * event-top.c (async_disconnect): Pop targets from all inferiors. * exec.c (add_target_sections): Push exec target on all inferiors sharing the program space. (remove_target_sections): Remove the exec target from all inferiors sharing the program space. (exec_on_vfork): New. * exec.h (exec_on_vfork): Declare. * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter. Pass it down. (fbsd_nat_target::update_thread_list): Adjust. (fbsd_nat_target::resume): Adjust. (fbsd_handle_debug_trap): Add fbsd_nat_target parameter. Pass it down. (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust. * fbsd-tdep.c (fbsd_corefile_thread): Adjust get_thread_arch_regcache call. * fork-child.c (gdb_startup_inferior): Pass target down to startup_inferior and set_executing. * gdbthread.h (struct process_stratum_target): Forward declare. (add_thread, add_thread_silent, add_thread_with_info) (in_thread_list): Add process_stratum_target parameter. (find_thread_ptid(inferior*, ptid_t)): New overload. (find_thread_ptid, thread_change_ptid): Add process_stratum_target parameter. (all_threads()): Delete overload. (all_threads, all_non_exited_threads): Add process_stratum_target parameter. (all_threads_safe): Use brace initialization. (thread_count): Add process_stratum_target parameter. (set_resumed, set_running, set_stop_requested, set_executing) (threads_are_executing, finish_thread_state): Add process_stratum_target parameter. (switch_to_thread): Use is_current_thread. * i386-fbsd-tdep.c: Include "inferior.h". (i386fbsd_get_thread_local_address): Pass down target. * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust. * inf-child.c (inf_child_target::maybe_unpush_target): Remove have_inferiors check. * inf-ptrace.c (inf_ptrace_target::create_inferior) (inf_ptrace_target::attach): Adjust. * infcall.c (run_inferior_call): Adjust. * infcmd.c (run_command_1): Pass target to scoped_finish_thread_state. (proceed_thread_callback): Skip inferiors with no execution. (continue_command): Rename 'all_threads' local to avoid hiding 'all_threads' function. Adjust get_last_target_status call. (prepare_one_step): Adjust set_running call. (signal_command): Use user_visible_resume_target. Compare thread pointers instead of inferior_ptid. (info_program_command): Adjust to pass down target. (attach_command): Mark target's 'thread_executing' flag. (stop_current_target_threads_ns): New, factored out from ... (interrupt_target_1): ... this. Switch inferior before making target calls. * inferior-iter.h (struct all_inferiors_iterator, struct all_inferiors_range) (struct all_inferiors_safe_range) (struct all_non_exited_inferiors_range): Filter on process_stratum_target too. Remove explicit. * inferior.c (inferior::inferior): Push dummy target on target stack. (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors): Add process_stratum_target parameter, and pass it down. (have_live_inferiors): Adjust. (switch_to_inferior_and_push_target): New. (add_inferior_command, clone_inferior_command): Handle "-no-connection" parameter. Use switch_to_inferior_and_push_target. (_initialize_inferior): Mention "-no-connection" option in the help of "add-inferior" and "clone-inferior" commands. * inferior.h: Include "process-stratum-target.h". (interrupt_target_1): Use bool. (struct inferior) <push_target, unpush_target, target_is_pushed, find_target_beneath, top_target, process_target, target_at, m_stack>: New. (discard_all_inferiors): Delete. (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors) (all_inferiors, all_non_exited_inferiors): Add process_stratum_target parameter. * infrun.c: Include "gdb_select.h" and <unordered_map>. (target_last_proc_target): New global. (follow_fork_inferior): Push target on new inferior. Pass target to add_thread_silent. Call exec_on_vfork. Handle target's reference count. (follow_fork): Adjust get_last_target_status call. Also consider target. (follow_exec): Push target on new inferior. (struct execution_control_state) <target>: New field. (user_visible_resume_target): New. (do_target_resume): Call target_async. (resume_1): Set target's threads_executing flag. Consider resume target. (commit_resume_all_targets): New. (proceed): Also consider resume target. Skip threads of inferiors with no execution. Commit resumtion in all targets. (start_remote): Pass current inferior to wait_for_inferior. (infrun_thread_stop_requested): Consider target as well. Pass thread_info pointer to clear_inline_frame_state instead of ptid. (infrun_thread_thread_exit): Consider target as well. (random_pending_event_thread): New inferior parameter. Use it. (do_target_wait): Rename to ... (do_target_wait_1): ... this. Add inferior parameter, and pass it down. (threads_are_resumed_pending_p, do_target_wait): New. (prepare_for_detach): Adjust calls. (wait_for_inferior): New inferior parameter. Handle it. Use do_target_wait_1 instead of do_target_wait. (fetch_inferior_event): Adjust. Switch to representative inferior. Pass target down. (set_last_target_status): Add process_stratum_target parameter. Save target in global. (get_last_target_status): Add process_stratum_target parameter and handle it. (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'. (context_switch): Check inferior_ptid == null_ptid before calling inferior_thread(). (get_inferior_stop_soon): Pass down target. (wait_one): Rename to ... (poll_one_curr_target): ... this. (struct wait_one_event): New. (wait_one): New. (stop_all_threads): Adjust. (handle_no_resumed, handle_inferior_event): Adjust to consider the event's target. (switch_back_to_stepped_thread): Also consider target. (print_stop_event): Update. (normal_stop): Update. Also consider the resume target. * infrun.h (wait_for_inferior): Remove declaration. (user_visible_resume_target): New declaration. (get_last_target_status, set_last_target_status): New process_stratum_target parameter. * inline-frame.c (clear_inline_frame_state(ptid_t)): Add process_stratum_target parameter, and use it. (clear_inline_frame_state (thread_info*)): New. * inline-frame.c (clear_inline_frame_state(ptid_t)): Add process_stratum_target parameter. (clear_inline_frame_state (thread_info*)): Declare. * linux-fork.c (delete_checkpoint_command): Pass target down to find_thread_ptid. (checkpoint_command): Adjust. * linux-nat.c (linux_nat_target::follow_fork): Switch to thread instead of just tweaking inferior_ptid. (linux_nat_switch_fork): Pass target down to thread_change_ptid. (exit_lwp): Pass target down to find_thread_ptid. (attach_proc_task_lwp_callback): Pass target down to add_thread/set_running/set_executing. (linux_nat_target::attach): Pass target down to thread_change_ptid. (get_detach_signal): Pass target down to find_thread_ptid. Consider last target status's target. (linux_resume_one_lwp_throw, resume_lwp) (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp) (stop_wait_callback, save_stop_reason, linux_nat_filter_event) (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down. (linux_nat_target::async_wait_fd): New. (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass target down. * linux-nat.h (linux_nat_target::async_wait_fd): Declare. * linux-tdep.c (get_thread_arch_regcache): Pass target down. * linux-thread-db.c (struct thread_db_info::process_target): New field. (add_thread_db_info): Save target. (get_thread_db_info): New process_stratum_target parameter. Also match target. (delete_thread_db_info): New process_stratum_target parameter. Also match target. (thread_from_lwp): Adjust to pass down target. (thread_db_notice_clone): Pass down target. (check_thread_db_callback): Pass down target. (try_thread_db_load_1): Always push the thread_db target. (try_thread_db_load, record_thread): Pass target down. (thread_db_target::detach): Pass target down. Always unpush the thread_db target. (thread_db_target::wait, thread_db_target::mourn_inferior): Pass target down. Always unpush the thread_db target. (find_new_threads_callback, thread_db_find_new_threads_2) (thread_db_target::update_thread_list): Pass target down. (thread_db_target::pid_to_str): Pass current inferior down. (thread_db_target::get_thread_local_address): Pass target down. (thread_db_target::resume, maintenance_check_libthread_db): Pass target down. * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust. * procfs.c (procfs_target::procfs_init_inferior): Declare. (proc_set_current_signal, do_attach, procfs_target::wait): Adjust. (procfs_init_inferior): Rename to ... (procfs_target::procfs_init_inferior): ... this and adjust. (procfs_target::create_inferior, procfs_notice_thread) (procfs_do_thread_registers): Adjust. * ppc-fbsd-tdep.c: Include "inferior.h". (ppcfbsd_get_thread_local_address): Pass down target. * proc-service.c (ps_xfer_memory): Switch current inferior and program space as well. (get_ps_regcache): Pass target down. * process-stratum-target.c (process_stratum_target::thread_address_space) (process_stratum_target::thread_architecture): Pass target down. * process-stratum-target.h (process_stratum_target::threads_executing): New field. (as_process_stratum_target): New. * ravenscar-thread.c (ravenscar_thread_target::update_inferior_ptid): Pass target down. (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target down. * record-btrace.c (record_btrace_target::info_record): Adjust. (record_btrace_target::record_method) (record_btrace_target::record_is_replaying) (record_btrace_target::fetch_registers) (get_thread_current_frame_id, record_btrace_target::resume) (record_btrace_target::wait, record_btrace_target::stop): Pass target down. * record-full.c (record_full_wait_1): Switch to event thread. Pass target down. * regcache.c (regcache::regcache) (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add process_stratum_target parameter and handle it. (current_thread_target): New global. (get_thread_regcache): Add process_stratum_target parameter and handle it. Switch inferior before calling target method. (get_thread_regcache): Pass target down. (get_thread_regcache_for_ptid): Pass target down. (registers_changed_ptid): Add process_stratum_target parameter and handle it. (registers_changed_thread, registers_changed): Pass target down. (test_get_thread_arch_aspace_regcache): New. (current_regcache_test): Define a couple local test_target_ops instances and use them for testing. (readwrite_regcache): Pass process_stratum_target parameter. (cooked_read_test, cooked_write_test): Pass mock_target down. * regcache.h (get_thread_regcache, get_thread_arch_regcache) (get_thread_arch_aspace_regcache): Add process_stratum_target parameter. (regcache::target): New method. (regcache::regcache, regcache::get_thread_arch_aspace_regcache) (regcache::registers_changed_ptid): Add process_stratum_target parameter. (regcache::m_target): New field. (registers_changed_ptid): Add process_stratum_target parameter. * remote.c (remote_state::supports_vCont_probed): New field. (remote_target::async_wait_fd): New method. (remote_unpush_and_throw): Add remote_target parameter. (get_current_remote_target): Adjust. (remote_target::remote_add_inferior): Push target. (remote_target::remote_add_thread) (remote_target::remote_notice_new_inferior) (get_remote_thread_info): Pass target down. (remote_target::update_thread_list): Skip threads of inferiors bound to other targets. (remote_target::close): Don't discard inferiors. (remote_target::add_current_inferior_and_thread) (remote_target::process_initial_stop_replies) (remote_target::start_remote) (remote_target::remote_serial_quit_handler): Pass down target. (remote_target::remote_unpush_target): New remote_target parameter. Unpush the target from all inferiors. (remote_target::remote_unpush_and_throw): New remote_target parameter. Pass it down. (remote_target::open_1): Check whether the current inferior has execution instead of checking whether any inferior is live. Pass target down. (remote_target::remote_detach_1): Pass down target. Use remote_unpush_target. (extended_remote_target::attach): Pass down target. (remote_target::remote_vcont_probe): Set supports_vCont_probed. (remote_target::append_resumption): Pass down target. (remote_target::append_pending_thread_resumptions) (remote_target::remote_resume_with_hc, remote_target::resume) (remote_target::commit_resume): Pass down target. (remote_target::remote_stop_ns): Check supports_vCont_probed. (remote_target::interrupt_query) (remote_target::remove_new_fork_children) (remote_target::check_pending_events_prevent_wildcard_vcont) (remote_target::remote_parse_stop_reply) (remote_target::process_stop_reply): Pass down target. (first_remote_resumed_thread): New remote_target parameter. Pass it down. (remote_target::wait_as): Pass down target. (unpush_and_perror): New remote_target parameter. Pass it down. (remote_target::readchar, remote_target::remote_serial_write) (remote_target::getpkt_or_notif_sane_1) (remote_target::kill_new_fork_children, remote_target::kill): Pass down target. (remote_target::mourn_inferior): Pass down target. Use remote_unpush_target. (remote_target::core_of_thread) (remote_target::remote_btrace_maybe_reopen): Pass down target. (remote_target::pid_to_exec_file) (remote_target::thread_handle_to_thread_info): Pass down target. (remote_target::async_wait_fd): New. * riscv-fbsd-tdep.c: Include "inferior.h". (riscv_fbsd_get_thread_local_address): Pass down target. * sol2-tdep.c (sol2_core_pid_to_str): Pass down target. * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs) (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback): Adjust. * solib-spu.c (spu_skip_standalone_loader): Pass down target. * solib-svr4.c (enable_break): Pass down target. * spu-multiarch.c (parse_spufs_run): Pass down target. * spu-tdep.c (spu2ppu_sniffer): Pass down target. * target-delegates.c: Regenerate. * target.c (g_target_stack): Delete. (current_top_target): Return the current inferior's top target. (target_has_execution_1): Refer to the passed-in inferior's top target. (target_supports_terminal_ours): Check whether the initial inferior was already created. (decref_target): New. (target_stack::push): Incref/decref the target. (push_target, push_target, unpush_target): Adjust. (target_stack::unpush): Defref target. (target_is_pushed): Return bool. Adjust to refer to the current inferior's target stack. (dispose_inferior): Delete, and inline parts ... (target_preopen): ... here. Only dispose of the current inferior. (target_detach): Hold strong target reference while detaching. Pass target down. (target_thread_name): Add assertion. (target_resume): Pass down target. (target_ops::beneath, find_target_at): Adjust to refer to the current inferior's target stack. (get_dummy_target): New. (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that has a thread running. (initialize_targets): Rename to ... (_initialize_target): ... this. * target.h: Include "gdbsupport/refcounted-object.h". (struct target_ops): Inherit refcounted_object. (target_ops::shortname, target_ops::longname): Make const. (target_ops::async_wait_fd): New method. (decref_target): Declare. (struct target_ops_ref_policy): New. (target_ops_ref): New typedef. (get_dummy_target): Declare function. (target_is_pushed): Return bool. * thread-iter.c (all_matching_threads_iterator::m_inf_matches) (all_matching_threads_iterator::all_matching_threads_iterator): Handle filter target. * thread-iter.h (struct all_matching_threads_iterator, struct all_matching_threads_range, class all_non_exited_threads_range): Filter by target too. Remove explicit. * thread.c (threads_executing): Delete. (inferior_thread): Pass down current inferior. (clear_thread_inferior_resources): Pass down thread pointer instead of ptid_t. (add_thread_silent, add_thread_with_info, add_thread): Add process_stratum_target parameter. Use it for thread and inferior searches. (is_current_thread): New. (thread_info::deletable): Use it. (find_thread_ptid, thread_count, in_thread_list) (thread_change_ptid, set_resumed, set_running): New process_stratum_target parameter. Pass it down. (set_executing): New process_stratum_target parameter. Pass it down. Adjust reference to 'threads_executing'. (threads_are_executing): New process_stratum_target parameter. Adjust reference to 'threads_executing'. (set_stop_requested, finish_thread_state): New process_stratum_target parameter. Pass it down. (switch_to_thread): Also match inferior. (switch_to_thread): New process_stratum_target parameter. Pass it down. (update_threads_executing): Reimplement. * top.c (quit_force): Pop targets from all inferior. (gdb_init): Don't call initialize_targets. * windows-nat.c (windows_nat_target) <get_windows_debug_event>: Declare. (windows_add_thread, windows_delete_thread): Adjust. (get_windows_debug_event): Rename to ... (windows_nat_target::get_windows_debug_event): ... this. Adjust. * tracefile-tfile.c (tfile_target_open): Pass down target. * gdbsupport/common-gdbthread.h (struct process_stratum_target): Forward declare. (switch_to_thread): Add process_stratum_target parameter. * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target parameter. Use it. (mi_on_resume): Pass target down. * nat/fork-inferior.c (startup_inferior): Add process_stratum_target parameter. Pass it down. * nat/fork-inferior.h (startup_inferior): Add process_stratum_target parameter. * python/py-threadevent.c (py_get_event_thread): Pass target down. gdb/gdbserver/ChangeLog: 2020-01-10 Pedro Alves <palves@redhat.com> * fork-child.c (post_fork_inferior): Pass target down to startup_inferior. * inferiors.c (switch_to_thread): Add process_stratum_target parameter. * lynx-low.c (lynx_target_ops): Now a process_stratum_target. * nto-low.c (nto_target_ops): Now a process_stratum_target. * linux-low.c (linux_target_ops): Now a process_stratum_target. * remote-utils.c (prepare_resume_reply): Pass the target to switch_to_thread. * target.c (the_target): Now a process_stratum_target. (done_accessing_memory): Pass the target to switch_to_thread. (set_target_ops): Ajust to use process_stratum_target. * target.h (struct target_ops): Rename to ... (struct process_stratum_target): ... this. (the_target, set_target_ops): Adjust. (prepare_to_access_memory): Adjust comment. * win32-low.c (child_xfer_memory): Adjust to use process_stratum_target. (win32_target_ops): Now a process_stratum_target.
1288 lines
37 KiB
C
1288 lines
37 KiB
C
/* Top level stuff for GDB, the GNU debugger.
|
||
|
||
Copyright (C) 1999-2020 Free Software Foundation, Inc.
|
||
|
||
Written by Elena Zannoni <ezannoni@cygnus.com> of Cygnus Solutions.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "top.h"
|
||
#include "inferior.h"
|
||
#include "infrun.h"
|
||
#include "target.h"
|
||
#include "terminal.h"
|
||
#include "event-loop.h"
|
||
#include "event-top.h"
|
||
#include "interps.h"
|
||
#include <signal.h>
|
||
#include "cli/cli-script.h" /* for reset_command_nest_depth */
|
||
#include "main.h"
|
||
#include "gdbthread.h"
|
||
#include "observable.h"
|
||
#include "continuations.h"
|
||
#include "gdbcmd.h" /* for dont_repeat() */
|
||
#include "annotate.h"
|
||
#include "maint.h"
|
||
#include "gdbsupport/buffer.h"
|
||
#include "ser-event.h"
|
||
#include "gdb_select.h"
|
||
#include "gdbsupport/gdb-sigmask.h"
|
||
|
||
/* readline include files. */
|
||
#include "readline/readline.h"
|
||
#include "readline/history.h"
|
||
|
||
/* readline defines this. */
|
||
#undef savestring
|
||
|
||
static std::string top_level_prompt ();
|
||
|
||
/* Signal handlers. */
|
||
#ifdef SIGQUIT
|
||
static void handle_sigquit (int sig);
|
||
#endif
|
||
#ifdef SIGHUP
|
||
static void handle_sighup (int sig);
|
||
#endif
|
||
static void handle_sigfpe (int sig);
|
||
|
||
/* Functions to be invoked by the event loop in response to
|
||
signals. */
|
||
#if defined (SIGQUIT) || defined (SIGHUP)
|
||
static void async_do_nothing (gdb_client_data);
|
||
#endif
|
||
#ifdef SIGHUP
|
||
static void async_disconnect (gdb_client_data);
|
||
#endif
|
||
static void async_float_handler (gdb_client_data);
|
||
#ifdef SIGTSTP
|
||
static void async_sigtstp_handler (gdb_client_data);
|
||
#endif
|
||
static void async_sigterm_handler (gdb_client_data arg);
|
||
|
||
/* Instead of invoking (and waiting for) readline to read the command
|
||
line and pass it back for processing, we use readline's alternate
|
||
interface, via callback functions, so that the event loop can react
|
||
to other event sources while we wait for input. */
|
||
|
||
/* Important variables for the event loop. */
|
||
|
||
/* This is used to determine if GDB is using the readline library or
|
||
its own simplified form of readline. It is used by the asynchronous
|
||
form of the set editing command.
|
||
ezannoni: as of 1999-04-29 I expect that this
|
||
variable will not be used after gdb is changed to use the event
|
||
loop as default engine, and event-top.c is merged into top.c. */
|
||
bool set_editing_cmd_var;
|
||
|
||
/* This is used to display the notification of the completion of an
|
||
asynchronous execution command. */
|
||
bool exec_done_display_p = false;
|
||
|
||
/* Used by the stdin event handler to compensate for missed stdin events.
|
||
Setting this to a non-zero value inside an stdin callback makes the callback
|
||
run again. */
|
||
int call_stdin_event_handler_again_p;
|
||
|
||
/* Signal handling variables. */
|
||
/* Each of these is a pointer to a function that the event loop will
|
||
invoke if the corresponding signal has received. The real signal
|
||
handlers mark these functions as ready to be executed and the event
|
||
loop, in a later iteration, calls them. See the function
|
||
invoke_async_signal_handler. */
|
||
static struct async_signal_handler *sigint_token;
|
||
#ifdef SIGHUP
|
||
static struct async_signal_handler *sighup_token;
|
||
#endif
|
||
#ifdef SIGQUIT
|
||
static struct async_signal_handler *sigquit_token;
|
||
#endif
|
||
static struct async_signal_handler *sigfpe_token;
|
||
#ifdef SIGTSTP
|
||
static struct async_signal_handler *sigtstp_token;
|
||
#endif
|
||
static struct async_signal_handler *async_sigterm_token;
|
||
|
||
/* This hook is called by gdb_rl_callback_read_char_wrapper after each
|
||
character is processed. */
|
||
void (*after_char_processing_hook) (void);
|
||
|
||
|
||
/* Wrapper function for calling into the readline library. This takes
|
||
care of a couple things:
|
||
|
||
- The event loop expects the callback function to have a parameter,
|
||
while readline expects none.
|
||
|
||
- Propagation of GDB exceptions/errors thrown from INPUT_HANDLER
|
||
across readline requires special handling.
|
||
|
||
On the exceptions issue:
|
||
|
||
DWARF-based unwinding cannot cross code built without -fexceptions.
|
||
Any exception that tries to propagate through such code will fail
|
||
and the result is a call to std::terminate. While some ABIs, such
|
||
as x86-64, require all code to be built with exception tables,
|
||
others don't.
|
||
|
||
This is a problem when GDB calls some non-EH-aware C library code,
|
||
that calls into GDB again through a callback, and that GDB callback
|
||
code throws a C++ exception. Turns out this is exactly what
|
||
happens with GDB's readline callback.
|
||
|
||
In such cases, we must catch and save any C++ exception that might
|
||
be thrown from the GDB callback before returning to the
|
||
non-EH-aware code. When the non-EH-aware function itself returns
|
||
back to GDB, we then rethrow the original C++ exception.
|
||
|
||
In the readline case however, the right thing to do is to longjmp
|
||
out of the callback, rather than do a normal return -- there's no
|
||
way for the callback to return to readline an indication that an
|
||
error happened, so a normal return would have rl_callback_read_char
|
||
potentially continue processing further input, redisplay the
|
||
prompt, etc. Instead of raw setjmp/longjmp however, we use our
|
||
sjlj-based TRY/CATCH mechanism, which knows to handle multiple
|
||
levels of active setjmp/longjmp frames, needed in order to handle
|
||
the readline callback recursing, as happens with e.g., secondary
|
||
prompts / queries, through gdb_readline_wrapper. This must be
|
||
noexcept in order to avoid problems with mixing sjlj and
|
||
(sjlj-based) C++ exceptions. */
|
||
|
||
static struct gdb_exception
|
||
gdb_rl_callback_read_char_wrapper_noexcept () noexcept
|
||
{
|
||
struct gdb_exception gdb_expt;
|
||
|
||
/* C++ exceptions can't normally be thrown across readline (unless
|
||
it is built with -fexceptions, but it won't by default on many
|
||
ABIs). So we instead wrap the readline call with a sjlj-based
|
||
TRY/CATCH, and rethrow the GDB exception once back in GDB. */
|
||
TRY_SJLJ
|
||
{
|
||
rl_callback_read_char ();
|
||
if (after_char_processing_hook)
|
||
(*after_char_processing_hook) ();
|
||
}
|
||
CATCH_SJLJ (ex, RETURN_MASK_ALL)
|
||
{
|
||
gdb_expt = std::move (ex);
|
||
}
|
||
END_CATCH_SJLJ
|
||
|
||
return gdb_expt;
|
||
}
|
||
|
||
static void
|
||
gdb_rl_callback_read_char_wrapper (gdb_client_data client_data)
|
||
{
|
||
struct gdb_exception gdb_expt
|
||
= gdb_rl_callback_read_char_wrapper_noexcept ();
|
||
|
||
/* Rethrow using the normal EH mechanism. */
|
||
if (gdb_expt.reason < 0)
|
||
throw_exception (std::move (gdb_expt));
|
||
}
|
||
|
||
/* GDB's readline callback handler. Calls the current INPUT_HANDLER,
|
||
and propagates GDB exceptions/errors thrown from INPUT_HANDLER back
|
||
across readline. See gdb_rl_callback_read_char_wrapper. This must
|
||
be noexcept in order to avoid problems with mixing sjlj and
|
||
(sjlj-based) C++ exceptions. */
|
||
|
||
static void
|
||
gdb_rl_callback_handler (char *rl) noexcept
|
||
{
|
||
/* This is static to avoid undefined behavior when calling longjmp
|
||
-- gdb_exception has a destructor with side effects. */
|
||
static struct gdb_exception gdb_rl_expt;
|
||
struct ui *ui = current_ui;
|
||
|
||
try
|
||
{
|
||
/* Ensure the exception is reset on each call. */
|
||
gdb_rl_expt = {};
|
||
ui->input_handler (gdb::unique_xmalloc_ptr<char> (rl));
|
||
}
|
||
catch (gdb_exception &ex)
|
||
{
|
||
gdb_rl_expt = std::move (ex);
|
||
}
|
||
|
||
/* If we caught a GDB exception, longjmp out of the readline
|
||
callback. There's no other way for the callback to signal to
|
||
readline that an error happened. A normal return would have
|
||
readline potentially continue processing further input, redisplay
|
||
the prompt, etc. (This is what GDB historically did when it was
|
||
a C program.) Note that since we're long jumping, local variable
|
||
dtors are NOT run automatically. */
|
||
if (gdb_rl_expt.reason < 0)
|
||
throw_exception_sjlj (gdb_rl_expt);
|
||
}
|
||
|
||
/* Change the function to be invoked every time there is a character
|
||
ready on stdin. This is used when the user sets the editing off,
|
||
therefore bypassing readline, and letting gdb handle the input
|
||
itself, via gdb_readline_no_editing_callback. Also it is used in
|
||
the opposite case in which the user sets editing on again, by
|
||
restoring readline handling of the input.
|
||
|
||
NOTE: this operates on input_fd, not instream. If we are reading
|
||
commands from a file, instream will point to the file. However, we
|
||
always read commands from a file with editing off. This means that
|
||
the 'set editing on/off' will have effect only on the interactive
|
||
session. */
|
||
|
||
void
|
||
change_line_handler (int editing)
|
||
{
|
||
struct ui *ui = current_ui;
|
||
|
||
/* We can only have one instance of readline, so we only allow
|
||
editing on the main UI. */
|
||
if (ui != main_ui)
|
||
return;
|
||
|
||
/* Don't try enabling editing if the interpreter doesn't support it
|
||
(e.g., MI). */
|
||
if (!interp_supports_command_editing (top_level_interpreter ())
|
||
|| !interp_supports_command_editing (command_interp ()))
|
||
return;
|
||
|
||
if (editing)
|
||
{
|
||
gdb_assert (ui == main_ui);
|
||
|
||
/* Turn on editing by using readline. */
|
||
ui->call_readline = gdb_rl_callback_read_char_wrapper;
|
||
}
|
||
else
|
||
{
|
||
/* Turn off editing by using gdb_readline_no_editing_callback. */
|
||
if (ui->command_editing)
|
||
gdb_rl_callback_handler_remove ();
|
||
ui->call_readline = gdb_readline_no_editing_callback;
|
||
}
|
||
ui->command_editing = editing;
|
||
}
|
||
|
||
/* The functions below are wrappers for rl_callback_handler_remove and
|
||
rl_callback_handler_install that keep track of whether the callback
|
||
handler is installed in readline. This is necessary because after
|
||
handling a target event of a background execution command, we may
|
||
need to reinstall the callback handler if it was removed due to a
|
||
secondary prompt. See gdb_readline_wrapper_line. We don't
|
||
unconditionally install the handler for every target event because
|
||
that also clears the line buffer, thus installing it while the user
|
||
is typing would lose input. */
|
||
|
||
/* Whether we've registered a callback handler with readline. */
|
||
static int callback_handler_installed;
|
||
|
||
/* See event-top.h, and above. */
|
||
|
||
void
|
||
gdb_rl_callback_handler_remove (void)
|
||
{
|
||
gdb_assert (current_ui == main_ui);
|
||
|
||
rl_callback_handler_remove ();
|
||
callback_handler_installed = 0;
|
||
}
|
||
|
||
/* See event-top.h, and above. Note this wrapper doesn't have an
|
||
actual callback parameter because we always install
|
||
INPUT_HANDLER. */
|
||
|
||
void
|
||
gdb_rl_callback_handler_install (const char *prompt)
|
||
{
|
||
gdb_assert (current_ui == main_ui);
|
||
|
||
/* Calling rl_callback_handler_install resets readline's input
|
||
buffer. Calling this when we were already processing input
|
||
therefore loses input. */
|
||
gdb_assert (!callback_handler_installed);
|
||
|
||
rl_callback_handler_install (prompt, gdb_rl_callback_handler);
|
||
callback_handler_installed = 1;
|
||
}
|
||
|
||
/* See event-top.h, and above. */
|
||
|
||
void
|
||
gdb_rl_callback_handler_reinstall (void)
|
||
{
|
||
gdb_assert (current_ui == main_ui);
|
||
|
||
if (!callback_handler_installed)
|
||
{
|
||
/* Passing NULL as prompt argument tells readline to not display
|
||
a prompt. */
|
||
gdb_rl_callback_handler_install (NULL);
|
||
}
|
||
}
|
||
|
||
/* Displays the prompt. If the argument NEW_PROMPT is NULL, the
|
||
prompt that is displayed is the current top level prompt.
|
||
Otherwise, it displays whatever NEW_PROMPT is as a local/secondary
|
||
prompt.
|
||
|
||
This is used after each gdb command has completed, and in the
|
||
following cases:
|
||
|
||
1. When the user enters a command line which is ended by '\'
|
||
indicating that the command will continue on the next line. In
|
||
that case the prompt that is displayed is the empty string.
|
||
|
||
2. When the user is entering 'commands' for a breakpoint, or
|
||
actions for a tracepoint. In this case the prompt will be '>'
|
||
|
||
3. On prompting for pagination. */
|
||
|
||
void
|
||
display_gdb_prompt (const char *new_prompt)
|
||
{
|
||
std::string actual_gdb_prompt;
|
||
|
||
annotate_display_prompt ();
|
||
|
||
/* Reset the nesting depth used when trace-commands is set. */
|
||
reset_command_nest_depth ();
|
||
|
||
/* Do not call the python hook on an explicit prompt change as
|
||
passed to this function, as this forms a secondary/local prompt,
|
||
IE, displayed but not set. */
|
||
if (! new_prompt)
|
||
{
|
||
struct ui *ui = current_ui;
|
||
|
||
if (ui->prompt_state == PROMPTED)
|
||
internal_error (__FILE__, __LINE__, _("double prompt"));
|
||
else if (ui->prompt_state == PROMPT_BLOCKED)
|
||
{
|
||
/* This is to trick readline into not trying to display the
|
||
prompt. Even though we display the prompt using this
|
||
function, readline still tries to do its own display if
|
||
we don't call rl_callback_handler_install and
|
||
rl_callback_handler_remove (which readline detects
|
||
because a global variable is not set). If readline did
|
||
that, it could mess up gdb signal handlers for SIGINT.
|
||
Readline assumes that between calls to rl_set_signals and
|
||
rl_clear_signals gdb doesn't do anything with the signal
|
||
handlers. Well, that's not the case, because when the
|
||
target executes we change the SIGINT signal handler. If
|
||
we allowed readline to display the prompt, the signal
|
||
handler change would happen exactly between the calls to
|
||
the above two functions. Calling
|
||
rl_callback_handler_remove(), does the job. */
|
||
|
||
if (current_ui->command_editing)
|
||
gdb_rl_callback_handler_remove ();
|
||
return;
|
||
}
|
||
else if (ui->prompt_state == PROMPT_NEEDED)
|
||
{
|
||
/* Display the top level prompt. */
|
||
actual_gdb_prompt = top_level_prompt ();
|
||
ui->prompt_state = PROMPTED;
|
||
}
|
||
}
|
||
else
|
||
actual_gdb_prompt = new_prompt;
|
||
|
||
if (current_ui->command_editing)
|
||
{
|
||
gdb_rl_callback_handler_remove ();
|
||
gdb_rl_callback_handler_install (actual_gdb_prompt.c_str ());
|
||
}
|
||
/* new_prompt at this point can be the top of the stack or the one
|
||
passed in. It can't be NULL. */
|
||
else
|
||
{
|
||
/* Don't use a _filtered function here. It causes the assumed
|
||
character position to be off, since the newline we read from
|
||
the user is not accounted for. */
|
||
fputs_unfiltered (actual_gdb_prompt.c_str (), gdb_stdout);
|
||
gdb_flush (gdb_stdout);
|
||
}
|
||
}
|
||
|
||
/* Return the top level prompt, as specified by "set prompt", possibly
|
||
overridden by the python gdb.prompt_hook hook, and then composed
|
||
with the prompt prefix and suffix (annotations). */
|
||
|
||
static std::string
|
||
top_level_prompt (void)
|
||
{
|
||
char *prompt;
|
||
|
||
/* Give observers a chance of changing the prompt. E.g., the python
|
||
`gdb.prompt_hook' is installed as an observer. */
|
||
gdb::observers::before_prompt.notify (get_prompt ());
|
||
|
||
prompt = get_prompt ();
|
||
|
||
if (annotation_level >= 2)
|
||
{
|
||
/* Prefix needs to have new line at end. */
|
||
const char prefix[] = "\n\032\032pre-prompt\n";
|
||
|
||
/* Suffix needs to have a new line at end and \032 \032 at
|
||
beginning. */
|
||
const char suffix[] = "\n\032\032prompt\n";
|
||
|
||
return std::string (prefix) + prompt + suffix;
|
||
}
|
||
|
||
return prompt;
|
||
}
|
||
|
||
/* See top.h. */
|
||
|
||
struct ui *main_ui;
|
||
struct ui *current_ui;
|
||
struct ui *ui_list;
|
||
|
||
/* Get a pointer to the current UI's line buffer. This is used to
|
||
construct a whole line of input from partial input. */
|
||
|
||
static struct buffer *
|
||
get_command_line_buffer (void)
|
||
{
|
||
return ¤t_ui->line_buffer;
|
||
}
|
||
|
||
/* When there is an event ready on the stdin file descriptor, instead
|
||
of calling readline directly throught the callback function, or
|
||
instead of calling gdb_readline_no_editing_callback, give gdb a
|
||
chance to detect errors and do something. */
|
||
|
||
void
|
||
stdin_event_handler (int error, gdb_client_data client_data)
|
||
{
|
||
struct ui *ui = (struct ui *) client_data;
|
||
|
||
if (error)
|
||
{
|
||
/* Switch to the main UI, so diagnostics always go there. */
|
||
current_ui = main_ui;
|
||
|
||
delete_file_handler (ui->input_fd);
|
||
if (main_ui == ui)
|
||
{
|
||
/* If stdin died, we may as well kill gdb. */
|
||
printf_unfiltered (_("error detected on stdin\n"));
|
||
quit_command ((char *) 0, 0);
|
||
}
|
||
else
|
||
{
|
||
/* Simply delete the UI. */
|
||
delete ui;
|
||
}
|
||
}
|
||
else
|
||
{
|
||
/* Switch to the UI whose input descriptor woke up the event
|
||
loop. */
|
||
current_ui = ui;
|
||
|
||
/* This makes sure a ^C immediately followed by further input is
|
||
always processed in that order. E.g,. with input like
|
||
"^Cprint 1\n", the SIGINT handler runs, marks the async
|
||
signal handler, and then select/poll may return with stdin
|
||
ready, instead of -1/EINTR. The
|
||
gdb.base/double-prompt-target-event-error.exp test exercises
|
||
this. */
|
||
QUIT;
|
||
|
||
do
|
||
{
|
||
call_stdin_event_handler_again_p = 0;
|
||
ui->call_readline (client_data);
|
||
}
|
||
while (call_stdin_event_handler_again_p != 0);
|
||
}
|
||
}
|
||
|
||
/* See top.h. */
|
||
|
||
void
|
||
ui_register_input_event_handler (struct ui *ui)
|
||
{
|
||
add_file_handler (ui->input_fd, stdin_event_handler, ui);
|
||
}
|
||
|
||
/* See top.h. */
|
||
|
||
void
|
||
ui_unregister_input_event_handler (struct ui *ui)
|
||
{
|
||
delete_file_handler (ui->input_fd);
|
||
}
|
||
|
||
/* Re-enable stdin after the end of an execution command in
|
||
synchronous mode, or after an error from the target, and we aborted
|
||
the exec operation. */
|
||
|
||
void
|
||
async_enable_stdin (void)
|
||
{
|
||
struct ui *ui = current_ui;
|
||
|
||
if (ui->prompt_state == PROMPT_BLOCKED)
|
||
{
|
||
target_terminal::ours ();
|
||
ui_register_input_event_handler (ui);
|
||
ui->prompt_state = PROMPT_NEEDED;
|
||
}
|
||
}
|
||
|
||
/* Disable reads from stdin (the console) marking the command as
|
||
synchronous. */
|
||
|
||
void
|
||
async_disable_stdin (void)
|
||
{
|
||
struct ui *ui = current_ui;
|
||
|
||
ui->prompt_state = PROMPT_BLOCKED;
|
||
delete_file_handler (ui->input_fd);
|
||
}
|
||
|
||
|
||
/* Handle a gdb command line. This function is called when
|
||
handle_line_of_input has concatenated one or more input lines into
|
||
a whole command. */
|
||
|
||
void
|
||
command_handler (const char *command)
|
||
{
|
||
struct ui *ui = current_ui;
|
||
const char *c;
|
||
|
||
if (ui->instream == ui->stdin_stream)
|
||
reinitialize_more_filter ();
|
||
|
||
scoped_command_stats stat_reporter (true);
|
||
|
||
/* Do not execute commented lines. */
|
||
for (c = command; *c == ' ' || *c == '\t'; c++)
|
||
;
|
||
if (c[0] != '#')
|
||
{
|
||
execute_command (command, ui->instream == ui->stdin_stream);
|
||
|
||
/* Do any commands attached to breakpoint we stopped at. */
|
||
bpstat_do_actions ();
|
||
}
|
||
}
|
||
|
||
/* Append RL, an input line returned by readline or one of its
|
||
emulations, to CMD_LINE_BUFFER. Returns the command line if we
|
||
have a whole command line ready to be processed by the command
|
||
interpreter or NULL if the command line isn't complete yet (input
|
||
line ends in a backslash). */
|
||
|
||
static char *
|
||
command_line_append_input_line (struct buffer *cmd_line_buffer, const char *rl)
|
||
{
|
||
char *cmd;
|
||
size_t len;
|
||
|
||
len = strlen (rl);
|
||
|
||
if (len > 0 && rl[len - 1] == '\\')
|
||
{
|
||
/* Don't copy the backslash and wait for more. */
|
||
buffer_grow (cmd_line_buffer, rl, len - 1);
|
||
cmd = NULL;
|
||
}
|
||
else
|
||
{
|
||
/* Copy whole line including terminating null, and we're
|
||
done. */
|
||
buffer_grow (cmd_line_buffer, rl, len + 1);
|
||
cmd = cmd_line_buffer->buffer;
|
||
}
|
||
|
||
return cmd;
|
||
}
|
||
|
||
/* Handle a line of input coming from readline.
|
||
|
||
If the read line ends with a continuation character (backslash),
|
||
save the partial input in CMD_LINE_BUFFER (except the backslash),
|
||
and return NULL. Otherwise, save the partial input and return a
|
||
pointer to CMD_LINE_BUFFER's buffer (null terminated), indicating a
|
||
whole command line is ready to be executed.
|
||
|
||
Returns EOF on end of file.
|
||
|
||
If REPEAT, handle command repetitions:
|
||
|
||
- If the input command line is NOT empty, the command returned is
|
||
saved using save_command_line () so that it can be repeated later.
|
||
|
||
- OTOH, if the input command line IS empty, return the saved
|
||
command instead of the empty input line.
|
||
*/
|
||
|
||
char *
|
||
handle_line_of_input (struct buffer *cmd_line_buffer,
|
||
const char *rl, int repeat,
|
||
const char *annotation_suffix)
|
||
{
|
||
struct ui *ui = current_ui;
|
||
int from_tty = ui->instream == ui->stdin_stream;
|
||
char *p1;
|
||
char *cmd;
|
||
|
||
if (rl == NULL)
|
||
return (char *) EOF;
|
||
|
||
cmd = command_line_append_input_line (cmd_line_buffer, rl);
|
||
if (cmd == NULL)
|
||
return NULL;
|
||
|
||
/* We have a complete command line now. Prepare for the next
|
||
command, but leave ownership of memory to the buffer . */
|
||
cmd_line_buffer->used_size = 0;
|
||
|
||
if (from_tty && annotation_level > 1)
|
||
{
|
||
printf_unfiltered (("\n\032\032post-"));
|
||
puts_unfiltered (annotation_suffix);
|
||
printf_unfiltered (("\n"));
|
||
}
|
||
|
||
#define SERVER_COMMAND_PREFIX "server "
|
||
server_command = startswith (cmd, SERVER_COMMAND_PREFIX);
|
||
if (server_command)
|
||
{
|
||
/* Note that we don't call `save_command_line'. Between this
|
||
and the check in dont_repeat, this insures that repeating
|
||
will still do the right thing. */
|
||
return cmd + strlen (SERVER_COMMAND_PREFIX);
|
||
}
|
||
|
||
/* Do history expansion if that is wished. */
|
||
if (history_expansion_p && from_tty && input_interactive_p (current_ui))
|
||
{
|
||
char *cmd_expansion;
|
||
int expanded;
|
||
|
||
expanded = history_expand (cmd, &cmd_expansion);
|
||
gdb::unique_xmalloc_ptr<char> history_value (cmd_expansion);
|
||
if (expanded)
|
||
{
|
||
size_t len;
|
||
|
||
/* Print the changes. */
|
||
printf_unfiltered ("%s\n", history_value.get ());
|
||
|
||
/* If there was an error, call this function again. */
|
||
if (expanded < 0)
|
||
return cmd;
|
||
|
||
/* history_expand returns an allocated string. Just replace
|
||
our buffer with it. */
|
||
len = strlen (history_value.get ());
|
||
xfree (buffer_finish (cmd_line_buffer));
|
||
cmd_line_buffer->buffer = history_value.get ();
|
||
cmd_line_buffer->buffer_size = len + 1;
|
||
cmd = history_value.release ();
|
||
}
|
||
}
|
||
|
||
/* If we just got an empty line, and that is supposed to repeat the
|
||
previous command, return the previously saved command. */
|
||
for (p1 = cmd; *p1 == ' ' || *p1 == '\t'; p1++)
|
||
;
|
||
if (repeat && *p1 == '\0')
|
||
return get_saved_command_line ();
|
||
|
||
/* Add command to history if appropriate. Note: lines consisting
|
||
solely of comments are also added to the command history. This
|
||
is useful when you type a command, and then realize you don't
|
||
want to execute it quite yet. You can comment out the command
|
||
and then later fetch it from the value history and remove the
|
||
'#'. The kill ring is probably better, but some people are in
|
||
the habit of commenting things out. */
|
||
if (*cmd != '\0' && from_tty && input_interactive_p (current_ui))
|
||
gdb_add_history (cmd);
|
||
|
||
/* Save into global buffer if appropriate. */
|
||
if (repeat)
|
||
{
|
||
save_command_line (cmd);
|
||
return get_saved_command_line ();
|
||
}
|
||
else
|
||
return cmd;
|
||
}
|
||
|
||
/* Handle a complete line of input. This is called by the callback
|
||
mechanism within the readline library. Deal with incomplete
|
||
commands as well, by saving the partial input in a global
|
||
buffer.
|
||
|
||
NOTE: This is the asynchronous version of the command_line_input
|
||
function. */
|
||
|
||
void
|
||
command_line_handler (gdb::unique_xmalloc_ptr<char> &&rl)
|
||
{
|
||
struct buffer *line_buffer = get_command_line_buffer ();
|
||
struct ui *ui = current_ui;
|
||
char *cmd;
|
||
|
||
cmd = handle_line_of_input (line_buffer, rl.get (), 1, "prompt");
|
||
if (cmd == (char *) EOF)
|
||
{
|
||
/* stdin closed. The connection with the terminal is gone.
|
||
This happens at the end of a testsuite run, after Expect has
|
||
hung up but GDB is still alive. In such a case, we just quit
|
||
gdb killing the inferior program too. */
|
||
printf_unfiltered ("quit\n");
|
||
execute_command ("quit", 1);
|
||
}
|
||
else if (cmd == NULL)
|
||
{
|
||
/* We don't have a full line yet. Print an empty prompt. */
|
||
display_gdb_prompt ("");
|
||
}
|
||
else
|
||
{
|
||
ui->prompt_state = PROMPT_NEEDED;
|
||
|
||
command_handler (cmd);
|
||
|
||
if (ui->prompt_state != PROMPTED)
|
||
display_gdb_prompt (0);
|
||
}
|
||
}
|
||
|
||
/* Does reading of input from terminal w/o the editing features
|
||
provided by the readline library. Calls the line input handler
|
||
once we have a whole input line. */
|
||
|
||
void
|
||
gdb_readline_no_editing_callback (gdb_client_data client_data)
|
||
{
|
||
int c;
|
||
char *result;
|
||
struct buffer line_buffer;
|
||
static int done_once = 0;
|
||
struct ui *ui = current_ui;
|
||
|
||
buffer_init (&line_buffer);
|
||
|
||
/* Unbuffer the input stream, so that, later on, the calls to fgetc
|
||
fetch only one char at the time from the stream. The fgetc's will
|
||
get up to the first newline, but there may be more chars in the
|
||
stream after '\n'. If we buffer the input and fgetc drains the
|
||
stream, getting stuff beyond the newline as well, a select, done
|
||
afterwards will not trigger. */
|
||
if (!done_once && !ISATTY (ui->instream))
|
||
{
|
||
setbuf (ui->instream, NULL);
|
||
done_once = 1;
|
||
}
|
||
|
||
/* We still need the while loop here, even though it would seem
|
||
obvious to invoke gdb_readline_no_editing_callback at every
|
||
character entered. If not using the readline library, the
|
||
terminal is in cooked mode, which sends the characters all at
|
||
once. Poll will notice that the input fd has changed state only
|
||
after enter is pressed. At this point we still need to fetch all
|
||
the chars entered. */
|
||
|
||
while (1)
|
||
{
|
||
/* Read from stdin if we are executing a user defined command.
|
||
This is the right thing for prompt_for_continue, at least. */
|
||
c = fgetc (ui->instream != NULL ? ui->instream : ui->stdin_stream);
|
||
|
||
if (c == EOF)
|
||
{
|
||
if (line_buffer.used_size > 0)
|
||
{
|
||
/* The last line does not end with a newline. Return it, and
|
||
if we are called again fgetc will still return EOF and
|
||
we'll return NULL then. */
|
||
break;
|
||
}
|
||
xfree (buffer_finish (&line_buffer));
|
||
ui->input_handler (NULL);
|
||
return;
|
||
}
|
||
|
||
if (c == '\n')
|
||
{
|
||
if (line_buffer.used_size > 0
|
||
&& line_buffer.buffer[line_buffer.used_size - 1] == '\r')
|
||
line_buffer.used_size--;
|
||
break;
|
||
}
|
||
|
||
buffer_grow_char (&line_buffer, c);
|
||
}
|
||
|
||
buffer_grow_char (&line_buffer, '\0');
|
||
result = buffer_finish (&line_buffer);
|
||
ui->input_handler (gdb::unique_xmalloc_ptr<char> (result));
|
||
}
|
||
|
||
|
||
/* See event-top.h. */
|
||
|
||
thread_local void (*thread_local_segv_handler) (int);
|
||
|
||
static void handle_sigsegv (int sig);
|
||
|
||
/* Install the SIGSEGV handler. */
|
||
static void
|
||
install_handle_sigsegv ()
|
||
{
|
||
#if defined (HAVE_SIGACTION)
|
||
struct sigaction sa;
|
||
sa.sa_handler = handle_sigsegv;
|
||
sigemptyset (&sa.sa_mask);
|
||
#ifdef HAVE_SIGALTSTACK
|
||
sa.sa_flags = SA_ONSTACK;
|
||
#else
|
||
sa.sa_flags = 0;
|
||
#endif
|
||
sigaction (SIGSEGV, &sa, nullptr);
|
||
#else
|
||
signal (SIGSEGV, handle_sigsegv);
|
||
#endif
|
||
}
|
||
|
||
/* Handler for SIGSEGV. */
|
||
|
||
static void
|
||
handle_sigsegv (int sig)
|
||
{
|
||
install_handle_sigsegv ();
|
||
|
||
if (thread_local_segv_handler == nullptr)
|
||
abort (); /* ARI: abort */
|
||
thread_local_segv_handler (sig);
|
||
}
|
||
|
||
|
||
|
||
/* The serial event associated with the QUIT flag. set_quit_flag sets
|
||
this, and check_quit_flag clears it. Used by interruptible_select
|
||
to be able to do interruptible I/O with no race with the SIGINT
|
||
handler. */
|
||
static struct serial_event *quit_serial_event;
|
||
|
||
/* Initialization of signal handlers and tokens. There is a function
|
||
handle_sig* for each of the signals GDB cares about. Specifically:
|
||
SIGINT, SIGFPE, SIGQUIT, SIGTSTP, SIGHUP, SIGWINCH. These
|
||
functions are the actual signal handlers associated to the signals
|
||
via calls to signal(). The only job for these functions is to
|
||
enqueue the appropriate event/procedure with the event loop. Such
|
||
procedures are the old signal handlers. The event loop will take
|
||
care of invoking the queued procedures to perform the usual tasks
|
||
associated with the reception of the signal. */
|
||
/* NOTE: 1999-04-30 This is the asynchronous version of init_signals.
|
||
init_signals will become obsolete as we move to have to event loop
|
||
as the default for gdb. */
|
||
void
|
||
async_init_signals (void)
|
||
{
|
||
initialize_async_signal_handlers ();
|
||
|
||
quit_serial_event = make_serial_event ();
|
||
|
||
signal (SIGINT, handle_sigint);
|
||
sigint_token =
|
||
create_async_signal_handler (async_request_quit, NULL);
|
||
signal (SIGTERM, handle_sigterm);
|
||
async_sigterm_token
|
||
= create_async_signal_handler (async_sigterm_handler, NULL);
|
||
|
||
/* If SIGTRAP was set to SIG_IGN, then the SIG_IGN will get passed
|
||
to the inferior and breakpoints will be ignored. */
|
||
#ifdef SIGTRAP
|
||
signal (SIGTRAP, SIG_DFL);
|
||
#endif
|
||
|
||
#ifdef SIGQUIT
|
||
/* If we initialize SIGQUIT to SIG_IGN, then the SIG_IGN will get
|
||
passed to the inferior, which we don't want. It would be
|
||
possible to do a "signal (SIGQUIT, SIG_DFL)" after we fork, but
|
||
on BSD4.3 systems using vfork, that can affect the
|
||
GDB process as well as the inferior (the signal handling tables
|
||
might be in memory, shared between the two). Since we establish
|
||
a handler for SIGQUIT, when we call exec it will set the signal
|
||
to SIG_DFL for us. */
|
||
signal (SIGQUIT, handle_sigquit);
|
||
sigquit_token =
|
||
create_async_signal_handler (async_do_nothing, NULL);
|
||
#endif
|
||
#ifdef SIGHUP
|
||
if (signal (SIGHUP, handle_sighup) != SIG_IGN)
|
||
sighup_token =
|
||
create_async_signal_handler (async_disconnect, NULL);
|
||
else
|
||
sighup_token =
|
||
create_async_signal_handler (async_do_nothing, NULL);
|
||
#endif
|
||
signal (SIGFPE, handle_sigfpe);
|
||
sigfpe_token =
|
||
create_async_signal_handler (async_float_handler, NULL);
|
||
|
||
#ifdef SIGTSTP
|
||
sigtstp_token =
|
||
create_async_signal_handler (async_sigtstp_handler, NULL);
|
||
#endif
|
||
|
||
install_handle_sigsegv ();
|
||
}
|
||
|
||
/* See defs.h. */
|
||
|
||
void
|
||
quit_serial_event_set (void)
|
||
{
|
||
serial_event_set (quit_serial_event);
|
||
}
|
||
|
||
/* See defs.h. */
|
||
|
||
void
|
||
quit_serial_event_clear (void)
|
||
{
|
||
serial_event_clear (quit_serial_event);
|
||
}
|
||
|
||
/* Return the selectable file descriptor of the serial event
|
||
associated with the quit flag. */
|
||
|
||
static int
|
||
quit_serial_event_fd (void)
|
||
{
|
||
return serial_event_fd (quit_serial_event);
|
||
}
|
||
|
||
/* See defs.h. */
|
||
|
||
void
|
||
default_quit_handler (void)
|
||
{
|
||
if (check_quit_flag ())
|
||
{
|
||
if (target_terminal::is_ours ())
|
||
quit ();
|
||
else
|
||
target_pass_ctrlc ();
|
||
}
|
||
}
|
||
|
||
/* See defs.h. */
|
||
quit_handler_ftype *quit_handler = default_quit_handler;
|
||
|
||
/* Handle a SIGINT. */
|
||
|
||
void
|
||
handle_sigint (int sig)
|
||
{
|
||
signal (sig, handle_sigint);
|
||
|
||
/* We could be running in a loop reading in symfiles or something so
|
||
it may be quite a while before we get back to the event loop. So
|
||
set quit_flag to 1 here. Then if QUIT is called before we get to
|
||
the event loop, we will unwind as expected. */
|
||
set_quit_flag ();
|
||
|
||
/* In case nothing calls QUIT before the event loop is reached, the
|
||
event loop handles it. */
|
||
mark_async_signal_handler (sigint_token);
|
||
}
|
||
|
||
/* See gdb_select.h. */
|
||
|
||
int
|
||
interruptible_select (int n,
|
||
fd_set *readfds, fd_set *writefds, fd_set *exceptfds,
|
||
struct timeval *timeout)
|
||
{
|
||
fd_set my_readfds;
|
||
int fd;
|
||
int res;
|
||
|
||
if (readfds == NULL)
|
||
{
|
||
readfds = &my_readfds;
|
||
FD_ZERO (&my_readfds);
|
||
}
|
||
|
||
fd = quit_serial_event_fd ();
|
||
FD_SET (fd, readfds);
|
||
if (n <= fd)
|
||
n = fd + 1;
|
||
|
||
do
|
||
{
|
||
res = gdb_select (n, readfds, writefds, exceptfds, timeout);
|
||
}
|
||
while (res == -1 && errno == EINTR);
|
||
|
||
if (res == 1 && FD_ISSET (fd, readfds))
|
||
{
|
||
errno = EINTR;
|
||
return -1;
|
||
}
|
||
return res;
|
||
}
|
||
|
||
/* Handle GDB exit upon receiving SIGTERM if target_can_async_p (). */
|
||
|
||
static void
|
||
async_sigterm_handler (gdb_client_data arg)
|
||
{
|
||
quit_force (NULL, 0);
|
||
}
|
||
|
||
/* See defs.h. */
|
||
volatile int sync_quit_force_run;
|
||
|
||
/* Quit GDB if SIGTERM is received.
|
||
GDB would quit anyway, but this way it will clean up properly. */
|
||
void
|
||
handle_sigterm (int sig)
|
||
{
|
||
signal (sig, handle_sigterm);
|
||
|
||
sync_quit_force_run = 1;
|
||
set_quit_flag ();
|
||
|
||
mark_async_signal_handler (async_sigterm_token);
|
||
}
|
||
|
||
/* Do the quit. All the checks have been done by the caller. */
|
||
void
|
||
async_request_quit (gdb_client_data arg)
|
||
{
|
||
/* If the quit_flag has gotten reset back to 0 by the time we get
|
||
back here, that means that an exception was thrown to unwind the
|
||
current command before we got back to the event loop. So there
|
||
is no reason to call quit again here. */
|
||
QUIT;
|
||
}
|
||
|
||
#ifdef SIGQUIT
|
||
/* Tell the event loop what to do if SIGQUIT is received.
|
||
See event-signal.c. */
|
||
static void
|
||
handle_sigquit (int sig)
|
||
{
|
||
mark_async_signal_handler (sigquit_token);
|
||
signal (sig, handle_sigquit);
|
||
}
|
||
#endif
|
||
|
||
#if defined (SIGQUIT) || defined (SIGHUP)
|
||
/* Called by the event loop in response to a SIGQUIT or an
|
||
ignored SIGHUP. */
|
||
static void
|
||
async_do_nothing (gdb_client_data arg)
|
||
{
|
||
/* Empty function body. */
|
||
}
|
||
#endif
|
||
|
||
#ifdef SIGHUP
|
||
/* Tell the event loop what to do if SIGHUP is received.
|
||
See event-signal.c. */
|
||
static void
|
||
handle_sighup (int sig)
|
||
{
|
||
mark_async_signal_handler (sighup_token);
|
||
signal (sig, handle_sighup);
|
||
}
|
||
|
||
/* Called by the event loop to process a SIGHUP. */
|
||
static void
|
||
async_disconnect (gdb_client_data arg)
|
||
{
|
||
|
||
try
|
||
{
|
||
quit_cover ();
|
||
}
|
||
|
||
catch (const gdb_exception &exception)
|
||
{
|
||
fputs_filtered ("Could not kill the program being debugged",
|
||
gdb_stderr);
|
||
exception_print (gdb_stderr, exception);
|
||
}
|
||
|
||
for (inferior *inf : all_inferiors ())
|
||
{
|
||
switch_to_inferior_no_thread (inf);
|
||
try
|
||
{
|
||
pop_all_targets ();
|
||
}
|
||
catch (const gdb_exception &exception)
|
||
{
|
||
}
|
||
}
|
||
|
||
signal (SIGHUP, SIG_DFL); /*FIXME: ??????????? */
|
||
raise (SIGHUP);
|
||
}
|
||
#endif
|
||
|
||
#ifdef SIGTSTP
|
||
void
|
||
handle_sigtstp (int sig)
|
||
{
|
||
mark_async_signal_handler (sigtstp_token);
|
||
signal (sig, handle_sigtstp);
|
||
}
|
||
|
||
static void
|
||
async_sigtstp_handler (gdb_client_data arg)
|
||
{
|
||
char *prompt = get_prompt ();
|
||
|
||
signal (SIGTSTP, SIG_DFL);
|
||
#if HAVE_SIGPROCMASK
|
||
{
|
||
sigset_t zero;
|
||
|
||
sigemptyset (&zero);
|
||
gdb_sigmask (SIG_SETMASK, &zero, 0);
|
||
}
|
||
#elif HAVE_SIGSETMASK
|
||
sigsetmask (0);
|
||
#endif
|
||
raise (SIGTSTP);
|
||
signal (SIGTSTP, handle_sigtstp);
|
||
printf_unfiltered ("%s", prompt);
|
||
gdb_flush (gdb_stdout);
|
||
|
||
/* Forget about any previous command -- null line now will do
|
||
nothing. */
|
||
dont_repeat ();
|
||
}
|
||
#endif /* SIGTSTP */
|
||
|
||
/* Tell the event loop what to do if SIGFPE is received.
|
||
See event-signal.c. */
|
||
static void
|
||
handle_sigfpe (int sig)
|
||
{
|
||
mark_async_signal_handler (sigfpe_token);
|
||
signal (sig, handle_sigfpe);
|
||
}
|
||
|
||
/* Event loop will call this function to process a SIGFPE. */
|
||
static void
|
||
async_float_handler (gdb_client_data arg)
|
||
{
|
||
/* This message is based on ANSI C, section 4.7. Note that integer
|
||
divide by zero causes this, so "float" is a misnomer. */
|
||
error (_("Erroneous arithmetic operation."));
|
||
}
|
||
|
||
|
||
/* Set things up for readline to be invoked via the alternate
|
||
interface, i.e. via a callback function
|
||
(gdb_rl_callback_read_char), and hook up instream to the event
|
||
loop. */
|
||
|
||
void
|
||
gdb_setup_readline (int editing)
|
||
{
|
||
struct ui *ui = current_ui;
|
||
|
||
/* This function is a noop for the sync case. The assumption is
|
||
that the sync setup is ALL done in gdb_init, and we would only
|
||
mess it up here. The sync stuff should really go away over
|
||
time. */
|
||
if (!batch_silent)
|
||
gdb_stdout = new stdio_file (ui->outstream);
|
||
gdb_stderr = new stderr_file (ui->errstream);
|
||
gdb_stdlog = gdb_stderr; /* for moment */
|
||
gdb_stdtarg = gdb_stderr; /* for moment */
|
||
gdb_stdtargerr = gdb_stderr; /* for moment */
|
||
|
||
/* If the input stream is connected to a terminal, turn on editing.
|
||
However, that is only allowed on the main UI, as we can only have
|
||
one instance of readline. */
|
||
if (ISATTY (ui->instream) && editing && ui == main_ui)
|
||
{
|
||
/* Tell gdb that we will be using the readline library. This
|
||
could be overwritten by a command in .gdbinit like 'set
|
||
editing on' or 'off'. */
|
||
ui->command_editing = 1;
|
||
|
||
/* When a character is detected on instream by select or poll,
|
||
readline will be invoked via this callback function. */
|
||
ui->call_readline = gdb_rl_callback_read_char_wrapper;
|
||
|
||
/* Tell readline to use the same input stream that gdb uses. */
|
||
rl_instream = ui->instream;
|
||
}
|
||
else
|
||
{
|
||
ui->command_editing = 0;
|
||
ui->call_readline = gdb_readline_no_editing_callback;
|
||
}
|
||
|
||
/* Now create the event source for this UI's input file descriptor.
|
||
Another source is going to be the target program (inferior), but
|
||
that must be registered only when it actually exists (I.e. after
|
||
we say 'run' or after we connect to a remote target. */
|
||
ui_register_input_event_handler (ui);
|
||
}
|
||
|
||
/* Disable command input through the standard CLI channels. Used in
|
||
the suspend proc for interpreters that use the standard gdb readline
|
||
interface, like the cli & the mi. */
|
||
|
||
void
|
||
gdb_disable_readline (void)
|
||
{
|
||
struct ui *ui = current_ui;
|
||
|
||
/* FIXME - It is too heavyweight to delete and remake these every
|
||
time you run an interpreter that needs readline. It is probably
|
||
better to have the interpreters cache these, which in turn means
|
||
that this needs to be moved into interpreter specific code. */
|
||
|
||
#if 0
|
||
ui_file_delete (gdb_stdout);
|
||
ui_file_delete (gdb_stderr);
|
||
gdb_stdlog = NULL;
|
||
gdb_stdtarg = NULL;
|
||
gdb_stdtargerr = NULL;
|
||
#endif
|
||
|
||
if (ui->command_editing)
|
||
gdb_rl_callback_handler_remove ();
|
||
delete_file_handler (ui->input_fd);
|
||
}
|