6c2659886f
I'd like to enable the -Wmissing-declarations warning. However, it
warns for every _initialize function, for example:
CXX dcache.o
/home/smarchi/src/binutils-gdb/gdb/dcache.c: In function ‘void _initialize_dcache()’:
/home/smarchi/src/binutils-gdb/gdb/dcache.c:688:1: error: no previous declaration for ‘void _initialize_dcache()’ [-Werror=missing-declarations]
_initialize_dcache (void)
^~~~~~~~~~~~~~~~~~
The only practical way forward I found is to add back the declarations,
which were removed by this commit:
commit 481695ed5f
Author: John Baldwin <jhb@FreeBSD.org>
Date: Sat Sep 9 11:02:37 2017 -0700
Remove unnecessary function prototypes.
I don't think it's a big problem to have the declarations for these
functions, but if anybody has a better solution for this, I'll be happy
to use it.
gdb/ChangeLog:
* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
* aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
* aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
* aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
* aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
* ada-exp.y (_initialize_ada_exp): Add declaration.
* ada-lang.c (_initialize_ada_language): Add declaration.
* ada-tasks.c (_initialize_tasks): Add declaration.
* agent.c (_initialize_agent): Add declaration.
* aix-thread.c (_initialize_aix_thread): Add declaration.
* alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
* alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
* alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
* alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
* alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
* alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
* amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
* amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
* amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
* amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
* amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
* amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
* amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
* amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
* amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
* amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
* amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
* annotate.c (_initialize_annotate): Add declaration.
* arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
* arc-tdep.c (_initialize_arc_tdep): Add declaration.
* arch-utils.c (_initialize_gdbarch_utils): Add declaration.
* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
* arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
* arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
* arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
* arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
* arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
* arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
* arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
* arm-tdep.c (_initialize_arm_tdep): Add declaration.
* arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
* auto-load.c (_initialize_auto_load): Add declaration.
* auxv.c (_initialize_auxv): Add declaration.
* avr-tdep.c (_initialize_avr_tdep): Add declaration.
* ax-gdb.c (_initialize_ax_gdb): Add declaration.
* bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
* bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
* break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
* break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
* break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
* breakpoint.c (_initialize_breakpoint): Add declaration.
* bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
* btrace.c (_initialize_btrace): Add declaration.
* charset.c (_initialize_charset): Add declaration.
* cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
* cli/cli-dump.c (_initialize_cli_dump): Add declaration.
* cli/cli-interp.c (_initialize_cli_interp): Add declaration.
* cli/cli-logging.c (_initialize_cli_logging): Add declaration.
* cli/cli-script.c (_initialize_cli_script): Add declaration.
* cli/cli-style.c (_initialize_cli_style): Add declaration.
* coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
* coffread.c (_initialize_coffread): Add declaration.
* compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
* compile/compile.c (_initialize_compile): Add declaration.
* complaints.c (_initialize_complaints): Add declaration.
* completer.c (_initialize_completer): Add declaration.
* copying.c (_initialize_copying): Add declaration.
* corefile.c (_initialize_core): Add declaration.
* corelow.c (_initialize_corelow): Add declaration.
* cp-abi.c (_initialize_cp_abi): Add declaration.
* cp-namespace.c (_initialize_cp_namespace): Add declaration.
* cp-support.c (_initialize_cp_support): Add declaration.
* cp-valprint.c (_initialize_cp_valprint): Add declaration.
* cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
* cris-tdep.c (_initialize_cris_tdep): Add declaration.
* csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
* csky-tdep.c (_initialize_csky_tdep): Add declaration.
* ctfread.c (_initialize_ctfread): Add declaration.
* d-lang.c (_initialize_d_language): Add declaration.
* darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
* darwin-nat.c (_initialize_darwin_nat): Add declaration.
* dbxread.c (_initialize_dbxread): Add declaration.
* dcache.c (_initialize_dcache): Add declaration.
* disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
* disasm.c (_initialize_disasm): Add declaration.
* dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
* dummy-frame.c (_initialize_dummy_frame): Add declaration.
* dwarf-index-cache.c (_initialize_index_cache): Add declaration.
* dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
* dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
* dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
* dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
* dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
* dwarf2read.c (_initialize_dwarf2_read): Add declaration.
* elfread.c (_initialize_elfread): Add declaration.
* exec.c (_initialize_exec): Add declaration.
* extension.c (_initialize_extension): Add declaration.
* f-lang.c (_initialize_f_language): Add declaration.
* f-valprint.c (_initialize_f_valprint): Add declaration.
* fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
* fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
* filesystem.c (_initialize_filesystem): Add declaration.
* findcmd.c (_initialize_mem_search): Add declaration.
* findvar.c (_initialize_findvar): Add declaration.
* fork-child.c (_initialize_fork_child): Add declaration.
* frame-base.c (_initialize_frame_base): Add declaration.
* frame-unwind.c (_initialize_frame_unwind): Add declaration.
* frame.c (_initialize_frame): Add declaration.
* frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
* frv-tdep.c (_initialize_frv_tdep): Add declaration.
* ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
* gcore.c (_initialize_gcore): Add declaration.
* gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
* gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
* gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
* gdbarch.c (_initialize_gdbarch): Add declaration.
* gdbtypes.c (_initialize_gdbtypes): Add declaration.
* gnu-nat.c (_initialize_gnu_nat): Add declaration.
* gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
* go-lang.c (_initialize_go_language): Add declaration.
* go32-nat.c (_initialize_go32_nat): Add declaration.
* guile/guile.c (_initialize_guile): Add declaration.
* h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
* hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
* hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
* hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
* hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
* hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
* i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
* i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
* i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
* i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
* i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
* i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
* i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
* i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
* i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
* i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
* i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
* i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
* i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
* i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
* i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
* i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
* i386-tdep.c (_initialize_i386_tdep): Add declaration.
* i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
* ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
* ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
* ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
* ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
* ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
* infcall.c (_initialize_infcall): Add declaration.
* infcmd.c (_initialize_infcmd): Add declaration.
* inflow.c (_initialize_inflow): Add declaration.
* infrun.c (_initialize_infrun): Add declaration.
* interps.c (_initialize_interpreter): Add declaration.
* iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
* jit.c (_initialize_jit): Add declaration.
* language.c (_initialize_language): Add declaration.
* linux-fork.c (_initialize_linux_fork): Add declaration.
* linux-nat.c (_initialize_linux_nat): Add declaration.
* linux-tdep.c (_initialize_linux_tdep): Add declaration.
* linux-thread-db.c (_initialize_thread_db): Add declaration.
* lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
* m2-lang.c (_initialize_m2_language): Add declaration.
* m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
* m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
* m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
* m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
* m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
* m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
* m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
* m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
* m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
* machoread.c (_initialize_machoread): Add declaration.
* macrocmd.c (_initialize_macrocmd): Add declaration.
* macroscope.c (_initialize_macroscope): Add declaration.
* maint-test-options.c (_initialize_maint_test_options): Add declaration.
* maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
* maint.c (_initialize_maint_cmds): Add declaration.
* mdebugread.c (_initialize_mdebugread): Add declaration.
* memattr.c (_initialize_mem): Add declaration.
* mep-tdep.c (_initialize_mep_tdep): Add declaration.
* mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
* mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
* mi/mi-interp.c (_initialize_mi_interp): Add declaration.
* mi/mi-main.c (_initialize_mi_main): Add declaration.
* microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
* microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
* mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
* mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
* mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
* mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
* mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
* mips-tdep.c (_initialize_mips_tdep): Add declaration.
* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
* mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
* mipsread.c (_initialize_mipsread): Add declaration.
* mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
* mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
* moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
* msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
* nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
* nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
* nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
* nto-procfs.c (_initialize_procfs): Add declaration.
* objc-lang.c (_initialize_objc_language): Add declaration.
* observable.c (_initialize_observer): Add declaration.
* opencl-lang.c (_initialize_opencl_language): Add declaration.
* or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
* or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
* osabi.c (_initialize_gdb_osabi): Add declaration.
* osdata.c (_initialize_osdata): Add declaration.
* p-valprint.c (_initialize_pascal_valprint): Add declaration.
* parse.c (_initialize_parse): Add declaration.
* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
* ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
* ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
* ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
* ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
* printcmd.c (_initialize_printcmd): Add declaration.
* probe.c (_initialize_probe): Add declaration.
* proc-api.c (_initialize_proc_api): Add declaration.
* proc-events.c (_initialize_proc_events): Add declaration.
* proc-service.c (_initialize_proc_service): Add declaration.
* procfs.c (_initialize_procfs): Add declaration.
* producer.c (_initialize_producer): Add declaration.
* psymtab.c (_initialize_psymtab): Add declaration.
* python/python.c (_initialize_python): Add declaration.
* ravenscar-thread.c (_initialize_ravenscar): Add declaration.
* record-btrace.c (_initialize_record_btrace): Add declaration.
* record-full.c (_initialize_record_full): Add declaration.
* record.c (_initialize_record): Add declaration.
* regcache-dump.c (_initialize_regcache_dump): Add declaration.
* regcache.c (_initialize_regcache): Add declaration.
* reggroups.c (_initialize_reggroup): Add declaration.
* remote-notif.c (_initialize_notif): Add declaration.
* remote-sim.c (_initialize_remote_sim): Add declaration.
* remote.c (_initialize_remote): Add declaration.
* reverse.c (_initialize_reverse): Add declaration.
* riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
* riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
* riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
* riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
* riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
* rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
* rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
* rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
Add declaration.
* rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
* rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
* run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
* rust-exp.y (_initialize_rust_exp): Add declaration.
* rx-tdep.c (_initialize_rx_tdep): Add declaration.
* s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
* s390-linux-nat.c (_initialize_s390_nat): Add declaration.
* s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
* s390-tdep.c (_initialize_s390_tdep): Add declaration.
* score-tdep.c (_initialize_score_tdep): Add declaration.
* ser-go32.c (_initialize_ser_dos): Add declaration.
* ser-mingw.c (_initialize_ser_windows): Add declaration.
* ser-pipe.c (_initialize_ser_pipe): Add declaration.
* ser-tcp.c (_initialize_ser_tcp): Add declaration.
* ser-uds.c (_initialize_ser_socket): Add declaration.
* ser-unix.c (_initialize_ser_hardwire): Add declaration.
* serial.c (_initialize_serial): Add declaration.
* sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
* sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
* sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
* sh-tdep.c (_initialize_sh_tdep): Add declaration.
* skip.c (_initialize_step_skip): Add declaration.
* sol-thread.c (_initialize_sol_thread): Add declaration.
* solib-aix.c (_initialize_solib_aix): Add declaration.
* solib-darwin.c (_initialize_darwin_solib): Add declaration.
* solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
* solib-frv.c (_initialize_frv_solib): Add declaration.
* solib-svr4.c (_initialize_svr4_solib): Add declaration.
* solib-target.c (_initialize_solib_target): Add declaration.
* solib.c (_initialize_solib): Add declaration.
* source-cache.c (_initialize_source_cache): Add declaration.
* source.c (_initialize_source): Add declaration.
* sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
* sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
* sparc-nat.c (_initialize_sparc_nat): Add declaration.
* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
* sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
* sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
* sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
* sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
* sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
* sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
* sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
* sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
* sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
* sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
* sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
* stabsread.c (_initialize_stabsread): Add declaration.
* stack.c (_initialize_stack): Add declaration.
* stap-probe.c (_initialize_stap_probe): Add declaration.
* std-regs.c (_initialize_frame_reg): Add declaration.
* symfile-debug.c (_initialize_symfile_debug): Add declaration.
* symfile-mem.c (_initialize_symfile_mem): Add declaration.
* symfile.c (_initialize_symfile): Add declaration.
* symmisc.c (_initialize_symmisc): Add declaration.
* symtab.c (_initialize_symtab): Add declaration.
* target.c (_initialize_target): Add declaration.
* target-connection.c (_initialize_target_connection): Add
declaration.
* target-dcache.c (_initialize_target_dcache): Add declaration.
* target-descriptions.c (_initialize_target_descriptions): Add declaration.
* thread.c (_initialize_thread): Add declaration.
* tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
* tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
* tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
* tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
* tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
* tracectf.c (_initialize_ctf): Add declaration.
* tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
* tracefile.c (_initialize_tracefile): Add declaration.
* tracepoint.c (_initialize_tracepoint): Add declaration.
* tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
* tui/tui-interp.c (_initialize_tui_interp): Add declaration.
* tui/tui-layout.c (_initialize_tui_layout): Add declaration.
* tui/tui-regs.c (_initialize_tui_regs): Add declaration.
* tui/tui-stack.c (_initialize_tui_stack): Add declaration.
* tui/tui-win.c (_initialize_tui_win): Add declaration.
* tui/tui.c (_initialize_tui): Add declaration.
* typeprint.c (_initialize_typeprint): Add declaration.
* ui-style.c (_initialize_ui_style): Add declaration.
* unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
* unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
* unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
* unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
* unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
* unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
* unittests/filtered_iterator-selftests.c
(_initialize_filtered_iterator_selftests): Add declaration.
* unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
* unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
* unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
* unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
* unittests/main-thread-selftests.c
(_initialize_main_thread_selftests): Add declaration.
* unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
* unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
* unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
* unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
* unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
* unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
* unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
* unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
* unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
* unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
* unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
* unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
* unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
* unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
* unittests/tui-selftests.c (_initialize_tui_selftest): Add
declaration.
* unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
* unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
* unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
* unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
* user-regs.c (_initialize_user_regs): Add declaration.
* utils.c (_initialize_utils): Add declaration.
* v850-tdep.c (_initialize_v850_tdep): Add declaration.
* valops.c (_initialize_valops): Add declaration.
* valprint.c (_initialize_valprint): Add declaration.
* value.c (_initialize_values): Add declaration.
* varobj.c (_initialize_varobj): Add declaration.
* vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
* vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
* vax-tdep.c (_initialize_vax_tdep): Add declaration.
* windows-nat.c (_initialize_windows_nat): Add declaration.
(_initialize_check_for_gdb_ini): Add declaration.
(_initialize_loadable): Add declaration.
* windows-tdep.c (_initialize_windows_tdep): Add declaration.
* x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
* x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
* xcoffread.c (_initialize_xcoffread): Add declaration.
* xml-support.c (_initialize_xml_support): Add declaration.
* xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
* xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
* xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
Change-Id: I13eec7e0ed2b3c427377a7bdb055cf46da64def9
604 lines
17 KiB
C
604 lines
17 KiB
C
/* Generate a core file for the inferior process.
|
|
|
|
Copyright (C) 2001-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "elf-bfd.h"
|
|
#include "infcall.h"
|
|
#include "inferior.h"
|
|
#include "gdbcore.h"
|
|
#include "objfiles.h"
|
|
#include "solib.h"
|
|
#include "symfile.h"
|
|
#include "arch-utils.h"
|
|
#include "completer.h"
|
|
#include "gcore.h"
|
|
#include "cli/cli-decode.h"
|
|
#include <fcntl.h>
|
|
#include "regcache.h"
|
|
#include "regset.h"
|
|
#include "gdb_bfd.h"
|
|
#include "readline/tilde.h"
|
|
#include <algorithm>
|
|
#include "gdbsupport/gdb_unlinker.h"
|
|
#include "gdbsupport/byte-vector.h"
|
|
#include "gdbsupport/scope-exit.h"
|
|
|
|
/* The largest amount of memory to read from the target at once. We
|
|
must throttle it to limit the amount of memory used by GDB during
|
|
generate-core-file for programs with large resident data. */
|
|
#define MAX_COPY_BYTES (1024 * 1024)
|
|
|
|
static const char *default_gcore_target (void);
|
|
static enum bfd_architecture default_gcore_arch (void);
|
|
static unsigned long default_gcore_mach (void);
|
|
static int gcore_memory_sections (bfd *);
|
|
|
|
/* create_gcore_bfd -- helper for gcore_command (exported).
|
|
Open a new bfd core file for output, and return the handle. */
|
|
|
|
gdb_bfd_ref_ptr
|
|
create_gcore_bfd (const char *filename)
|
|
{
|
|
gdb_bfd_ref_ptr obfd (gdb_bfd_openw (filename, default_gcore_target ()));
|
|
|
|
if (obfd == NULL)
|
|
error (_("Failed to open '%s' for output."), filename);
|
|
bfd_set_format (obfd.get (), bfd_core);
|
|
bfd_set_arch_mach (obfd.get (), default_gcore_arch (), default_gcore_mach ());
|
|
return obfd;
|
|
}
|
|
|
|
/* write_gcore_file_1 -- do the actual work of write_gcore_file. */
|
|
|
|
static void
|
|
write_gcore_file_1 (bfd *obfd)
|
|
{
|
|
gdb::unique_xmalloc_ptr<char> note_data;
|
|
int note_size = 0;
|
|
asection *note_sec = NULL;
|
|
|
|
/* An external target method must build the notes section. */
|
|
/* FIXME: uweigand/2011-10-06: All architectures that support core file
|
|
generation should be converted to gdbarch_make_corefile_notes; at that
|
|
point, the target vector method can be removed. */
|
|
if (!gdbarch_make_corefile_notes_p (target_gdbarch ()))
|
|
note_data.reset (target_make_corefile_notes (obfd, ¬e_size));
|
|
else
|
|
note_data.reset (gdbarch_make_corefile_notes (target_gdbarch (), obfd,
|
|
¬e_size));
|
|
|
|
if (note_data == NULL || note_size == 0)
|
|
error (_("Target does not support core file generation."));
|
|
|
|
/* Create the note section. */
|
|
note_sec = bfd_make_section_anyway_with_flags (obfd, "note0",
|
|
SEC_HAS_CONTENTS
|
|
| SEC_READONLY
|
|
| SEC_ALLOC);
|
|
if (note_sec == NULL)
|
|
error (_("Failed to create 'note' section for corefile: %s"),
|
|
bfd_errmsg (bfd_get_error ()));
|
|
|
|
bfd_set_section_vma (note_sec, 0);
|
|
bfd_set_section_alignment (note_sec, 0);
|
|
bfd_set_section_size (note_sec, note_size);
|
|
|
|
/* Now create the memory/load sections. */
|
|
if (gcore_memory_sections (obfd) == 0)
|
|
error (_("gcore: failed to get corefile memory sections from target."));
|
|
|
|
/* Write out the contents of the note section. */
|
|
if (!bfd_set_section_contents (obfd, note_sec, note_data.get (), 0,
|
|
note_size))
|
|
warning (_("writing note section (%s)"), bfd_errmsg (bfd_get_error ()));
|
|
}
|
|
|
|
/* write_gcore_file -- helper for gcore_command (exported).
|
|
Compose and write the corefile data to the core file. */
|
|
|
|
void
|
|
write_gcore_file (bfd *obfd)
|
|
{
|
|
target_prepare_to_generate_core ();
|
|
SCOPE_EXIT { target_done_generating_core (); };
|
|
write_gcore_file_1 (obfd);
|
|
}
|
|
|
|
/* gcore_command -- implements the 'gcore' command.
|
|
Generate a core file from the inferior process. */
|
|
|
|
static void
|
|
gcore_command (const char *args, int from_tty)
|
|
{
|
|
gdb::unique_xmalloc_ptr<char> corefilename;
|
|
|
|
/* No use generating a corefile without a target process. */
|
|
if (!target_has_execution)
|
|
noprocess ();
|
|
|
|
if (args && *args)
|
|
corefilename.reset (tilde_expand (args));
|
|
else
|
|
{
|
|
/* Default corefile name is "core.PID". */
|
|
corefilename.reset (xstrprintf ("core.%d", inferior_ptid.pid ()));
|
|
}
|
|
|
|
if (info_verbose)
|
|
fprintf_filtered (gdb_stdout,
|
|
"Opening corefile '%s' for output.\n",
|
|
corefilename.get ());
|
|
|
|
/* Open the output file. */
|
|
gdb_bfd_ref_ptr obfd (create_gcore_bfd (corefilename.get ()));
|
|
|
|
/* Arrange to unlink the file on failure. */
|
|
gdb::unlinker unlink_file (corefilename.get ());
|
|
|
|
/* Call worker function. */
|
|
write_gcore_file (obfd.get ());
|
|
|
|
/* Succeeded. */
|
|
unlink_file.keep ();
|
|
|
|
fprintf_filtered (gdb_stdout, "Saved corefile %s\n", corefilename.get ());
|
|
}
|
|
|
|
static unsigned long
|
|
default_gcore_mach (void)
|
|
{
|
|
#if 1 /* See if this even matters... */
|
|
return 0;
|
|
#else
|
|
|
|
const struct bfd_arch_info *bfdarch = gdbarch_bfd_arch_info (target_gdbarch ());
|
|
|
|
if (bfdarch != NULL)
|
|
return bfdarch->mach;
|
|
if (exec_bfd == NULL)
|
|
error (_("Can't find default bfd machine type (need execfile)."));
|
|
|
|
return bfd_get_mach (exec_bfd);
|
|
#endif /* 1 */
|
|
}
|
|
|
|
static enum bfd_architecture
|
|
default_gcore_arch (void)
|
|
{
|
|
const struct bfd_arch_info *bfdarch = gdbarch_bfd_arch_info (target_gdbarch ());
|
|
|
|
if (bfdarch != NULL)
|
|
return bfdarch->arch;
|
|
if (exec_bfd == NULL)
|
|
error (_("Can't find bfd architecture for corefile (need execfile)."));
|
|
|
|
return bfd_get_arch (exec_bfd);
|
|
}
|
|
|
|
static const char *
|
|
default_gcore_target (void)
|
|
{
|
|
/* The gdbarch may define a target to use for core files. */
|
|
if (gdbarch_gcore_bfd_target_p (target_gdbarch ()))
|
|
return gdbarch_gcore_bfd_target (target_gdbarch ());
|
|
|
|
/* Otherwise, try to fall back to the exec_bfd target. This will probably
|
|
not work for non-ELF targets. */
|
|
if (exec_bfd == NULL)
|
|
return NULL;
|
|
else
|
|
return bfd_get_target (exec_bfd);
|
|
}
|
|
|
|
/* Derive a reasonable stack segment by unwinding the target stack,
|
|
and store its limits in *BOTTOM and *TOP. Return non-zero if
|
|
successful. */
|
|
|
|
static int
|
|
derive_stack_segment (bfd_vma *bottom, bfd_vma *top)
|
|
{
|
|
struct frame_info *fi, *tmp_fi;
|
|
|
|
gdb_assert (bottom);
|
|
gdb_assert (top);
|
|
|
|
/* Can't succeed without stack and registers. */
|
|
if (!target_has_stack || !target_has_registers)
|
|
return 0;
|
|
|
|
/* Can't succeed without current frame. */
|
|
fi = get_current_frame ();
|
|
if (fi == NULL)
|
|
return 0;
|
|
|
|
/* Save frame pointer of TOS frame. */
|
|
*top = get_frame_base (fi);
|
|
/* If current stack pointer is more "inner", use that instead. */
|
|
if (gdbarch_inner_than (get_frame_arch (fi), get_frame_sp (fi), *top))
|
|
*top = get_frame_sp (fi);
|
|
|
|
/* Find prev-most frame. */
|
|
while ((tmp_fi = get_prev_frame (fi)) != NULL)
|
|
fi = tmp_fi;
|
|
|
|
/* Save frame pointer of prev-most frame. */
|
|
*bottom = get_frame_base (fi);
|
|
|
|
/* Now canonicalize their order, so that BOTTOM is a lower address
|
|
(as opposed to a lower stack frame). */
|
|
if (*bottom > *top)
|
|
{
|
|
bfd_vma tmp_vma;
|
|
|
|
tmp_vma = *top;
|
|
*top = *bottom;
|
|
*bottom = tmp_vma;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
/* call_target_sbrk --
|
|
helper function for derive_heap_segment. */
|
|
|
|
static bfd_vma
|
|
call_target_sbrk (int sbrk_arg)
|
|
{
|
|
struct objfile *sbrk_objf;
|
|
struct gdbarch *gdbarch;
|
|
bfd_vma top_of_heap;
|
|
struct value *target_sbrk_arg;
|
|
struct value *sbrk_fn, *ret;
|
|
bfd_vma tmp;
|
|
|
|
if (lookup_minimal_symbol ("sbrk", NULL, NULL).minsym != NULL)
|
|
{
|
|
sbrk_fn = find_function_in_inferior ("sbrk", &sbrk_objf);
|
|
if (sbrk_fn == NULL)
|
|
return (bfd_vma) 0;
|
|
}
|
|
else if (lookup_minimal_symbol ("_sbrk", NULL, NULL).minsym != NULL)
|
|
{
|
|
sbrk_fn = find_function_in_inferior ("_sbrk", &sbrk_objf);
|
|
if (sbrk_fn == NULL)
|
|
return (bfd_vma) 0;
|
|
}
|
|
else
|
|
return (bfd_vma) 0;
|
|
|
|
gdbarch = get_objfile_arch (sbrk_objf);
|
|
target_sbrk_arg = value_from_longest (builtin_type (gdbarch)->builtin_int,
|
|
sbrk_arg);
|
|
gdb_assert (target_sbrk_arg);
|
|
ret = call_function_by_hand (sbrk_fn, NULL, target_sbrk_arg);
|
|
if (ret == NULL)
|
|
return (bfd_vma) 0;
|
|
|
|
tmp = value_as_long (ret);
|
|
if ((LONGEST) tmp <= 0 || (LONGEST) tmp == 0xffffffff)
|
|
return (bfd_vma) 0;
|
|
|
|
top_of_heap = tmp;
|
|
return top_of_heap;
|
|
}
|
|
|
|
/* Derive a reasonable heap segment for ABFD by looking at sbrk and
|
|
the static data sections. Store its limits in *BOTTOM and *TOP.
|
|
Return non-zero if successful. */
|
|
|
|
static int
|
|
derive_heap_segment (bfd *abfd, bfd_vma *bottom, bfd_vma *top)
|
|
{
|
|
bfd_vma top_of_data_memory = 0;
|
|
bfd_vma top_of_heap = 0;
|
|
bfd_size_type sec_size;
|
|
bfd_vma sec_vaddr;
|
|
asection *sec;
|
|
|
|
gdb_assert (bottom);
|
|
gdb_assert (top);
|
|
|
|
/* This function depends on being able to call a function in the
|
|
inferior. */
|
|
if (!target_has_execution)
|
|
return 0;
|
|
|
|
/* The following code assumes that the link map is arranged as
|
|
follows (low to high addresses):
|
|
|
|
---------------------------------
|
|
| text sections |
|
|
---------------------------------
|
|
| data sections (including bss) |
|
|
---------------------------------
|
|
| heap |
|
|
--------------------------------- */
|
|
|
|
for (sec = abfd->sections; sec; sec = sec->next)
|
|
{
|
|
if (bfd_section_flags (sec) & SEC_DATA
|
|
|| strcmp (".bss", bfd_section_name (sec)) == 0)
|
|
{
|
|
sec_vaddr = bfd_section_vma (sec);
|
|
sec_size = bfd_section_size (sec);
|
|
if (sec_vaddr + sec_size > top_of_data_memory)
|
|
top_of_data_memory = sec_vaddr + sec_size;
|
|
}
|
|
}
|
|
|
|
top_of_heap = call_target_sbrk (0);
|
|
if (top_of_heap == (bfd_vma) 0)
|
|
return 0;
|
|
|
|
/* Return results. */
|
|
if (top_of_heap > top_of_data_memory)
|
|
{
|
|
*bottom = top_of_data_memory;
|
|
*top = top_of_heap;
|
|
return 1;
|
|
}
|
|
|
|
/* No additional heap space needs to be saved. */
|
|
return 0;
|
|
}
|
|
|
|
static void
|
|
make_output_phdrs (bfd *obfd, asection *osec, void *ignored)
|
|
{
|
|
int p_flags = 0;
|
|
int p_type = 0;
|
|
|
|
/* FIXME: these constants may only be applicable for ELF. */
|
|
if (startswith (bfd_section_name (osec), "load"))
|
|
p_type = PT_LOAD;
|
|
else if (startswith (bfd_section_name (osec), "note"))
|
|
p_type = PT_NOTE;
|
|
else
|
|
p_type = PT_NULL;
|
|
|
|
p_flags |= PF_R; /* Segment is readable. */
|
|
if (!(bfd_section_flags (osec) & SEC_READONLY))
|
|
p_flags |= PF_W; /* Segment is writable. */
|
|
if (bfd_section_flags (osec) & SEC_CODE)
|
|
p_flags |= PF_X; /* Segment is executable. */
|
|
|
|
bfd_record_phdr (obfd, p_type, 1, p_flags, 0, 0, 0, 0, 1, &osec);
|
|
}
|
|
|
|
/* find_memory_region_ftype implementation. DATA is 'bfd *' for the core file
|
|
GDB is creating. */
|
|
|
|
static int
|
|
gcore_create_callback (CORE_ADDR vaddr, unsigned long size, int read,
|
|
int write, int exec, int modified, void *data)
|
|
{
|
|
bfd *obfd = (bfd *) data;
|
|
asection *osec;
|
|
flagword flags = SEC_ALLOC | SEC_HAS_CONTENTS | SEC_LOAD;
|
|
|
|
/* If the memory segment has no permissions set, ignore it, otherwise
|
|
when we later try to access it for read/write, we'll get an error
|
|
or jam the kernel. */
|
|
if (read == 0 && write == 0 && exec == 0 && modified == 0)
|
|
{
|
|
if (info_verbose)
|
|
{
|
|
fprintf_filtered (gdb_stdout, "Ignore segment, %s bytes at %s\n",
|
|
plongest (size), paddress (target_gdbarch (), vaddr));
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
if (write == 0 && modified == 0 && !solib_keep_data_in_core (vaddr, size))
|
|
{
|
|
/* See if this region of memory lies inside a known file on disk.
|
|
If so, we can avoid copying its contents by clearing SEC_LOAD. */
|
|
struct obj_section *objsec;
|
|
|
|
for (objfile *objfile : current_program_space->objfiles ())
|
|
ALL_OBJFILE_OSECTIONS (objfile, objsec)
|
|
{
|
|
bfd *abfd = objfile->obfd;
|
|
asection *asec = objsec->the_bfd_section;
|
|
bfd_vma align = (bfd_vma) 1 << bfd_section_alignment (asec);
|
|
bfd_vma start = obj_section_addr (objsec) & -align;
|
|
bfd_vma end = (obj_section_endaddr (objsec) + align - 1) & -align;
|
|
|
|
/* Match if either the entire memory region lies inside the
|
|
section (i.e. a mapping covering some pages of a large
|
|
segment) or the entire section lies inside the memory region
|
|
(i.e. a mapping covering multiple small sections).
|
|
|
|
This BFD was synthesized from reading target memory,
|
|
we don't want to omit that. */
|
|
if (objfile->separate_debug_objfile_backlink == NULL
|
|
&& ((vaddr >= start && vaddr + size <= end)
|
|
|| (start >= vaddr && end <= vaddr + size))
|
|
&& !(bfd_get_file_flags (abfd) & BFD_IN_MEMORY))
|
|
{
|
|
flags &= ~(SEC_LOAD | SEC_HAS_CONTENTS);
|
|
goto keep; /* Break out of two nested for loops. */
|
|
}
|
|
}
|
|
|
|
keep:;
|
|
}
|
|
|
|
if (write == 0)
|
|
flags |= SEC_READONLY;
|
|
|
|
if (exec)
|
|
flags |= SEC_CODE;
|
|
else
|
|
flags |= SEC_DATA;
|
|
|
|
osec = bfd_make_section_anyway_with_flags (obfd, "load", flags);
|
|
if (osec == NULL)
|
|
{
|
|
warning (_("Couldn't make gcore segment: %s"),
|
|
bfd_errmsg (bfd_get_error ()));
|
|
return 1;
|
|
}
|
|
|
|
if (info_verbose)
|
|
{
|
|
fprintf_filtered (gdb_stdout, "Save segment, %s bytes at %s\n",
|
|
plongest (size), paddress (target_gdbarch (), vaddr));
|
|
}
|
|
|
|
bfd_set_section_size (osec, size);
|
|
bfd_set_section_vma (osec, vaddr);
|
|
bfd_set_section_lma (osec, 0);
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
objfile_find_memory_regions (struct target_ops *self,
|
|
find_memory_region_ftype func, void *obfd)
|
|
{
|
|
/* Use objfile data to create memory sections. */
|
|
struct obj_section *objsec;
|
|
bfd_vma temp_bottom, temp_top;
|
|
|
|
/* Call callback function for each objfile section. */
|
|
for (objfile *objfile : current_program_space->objfiles ())
|
|
ALL_OBJFILE_OSECTIONS (objfile, objsec)
|
|
{
|
|
asection *isec = objsec->the_bfd_section;
|
|
flagword flags = bfd_section_flags (isec);
|
|
|
|
/* Separate debug info files are irrelevant for gcore. */
|
|
if (objfile->separate_debug_objfile_backlink != NULL)
|
|
continue;
|
|
|
|
if ((flags & SEC_ALLOC) || (flags & SEC_LOAD))
|
|
{
|
|
int size = bfd_section_size (isec);
|
|
int ret;
|
|
|
|
ret = (*func) (obj_section_addr (objsec), size,
|
|
1, /* All sections will be readable. */
|
|
(flags & SEC_READONLY) == 0, /* Writable. */
|
|
(flags & SEC_CODE) != 0, /* Executable. */
|
|
1, /* MODIFIED is unknown, pass it as true. */
|
|
obfd);
|
|
if (ret != 0)
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
/* Make a stack segment. */
|
|
if (derive_stack_segment (&temp_bottom, &temp_top))
|
|
(*func) (temp_bottom, temp_top - temp_bottom,
|
|
1, /* Stack section will be readable. */
|
|
1, /* Stack section will be writable. */
|
|
0, /* Stack section will not be executable. */
|
|
1, /* Stack section will be modified. */
|
|
obfd);
|
|
|
|
/* Make a heap segment. */
|
|
if (derive_heap_segment (exec_bfd, &temp_bottom, &temp_top))
|
|
(*func) (temp_bottom, temp_top - temp_bottom,
|
|
1, /* Heap section will be readable. */
|
|
1, /* Heap section will be writable. */
|
|
0, /* Heap section will not be executable. */
|
|
1, /* Heap section will be modified. */
|
|
obfd);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void
|
|
gcore_copy_callback (bfd *obfd, asection *osec, void *ignored)
|
|
{
|
|
bfd_size_type size, total_size = bfd_section_size (osec);
|
|
file_ptr offset = 0;
|
|
|
|
/* Read-only sections are marked; we don't have to copy their contents. */
|
|
if ((bfd_section_flags (osec) & SEC_LOAD) == 0)
|
|
return;
|
|
|
|
/* Only interested in "load" sections. */
|
|
if (!startswith (bfd_section_name (osec), "load"))
|
|
return;
|
|
|
|
size = std::min (total_size, (bfd_size_type) MAX_COPY_BYTES);
|
|
gdb::byte_vector memhunk (size);
|
|
|
|
while (total_size > 0)
|
|
{
|
|
if (size > total_size)
|
|
size = total_size;
|
|
|
|
if (target_read_memory (bfd_section_vma (osec) + offset,
|
|
memhunk.data (), size) != 0)
|
|
{
|
|
warning (_("Memory read failed for corefile "
|
|
"section, %s bytes at %s."),
|
|
plongest (size),
|
|
paddress (target_gdbarch (), bfd_section_vma (osec)));
|
|
break;
|
|
}
|
|
if (!bfd_set_section_contents (obfd, osec, memhunk.data (),
|
|
offset, size))
|
|
{
|
|
warning (_("Failed to write corefile contents (%s)."),
|
|
bfd_errmsg (bfd_get_error ()));
|
|
break;
|
|
}
|
|
|
|
total_size -= size;
|
|
offset += size;
|
|
}
|
|
}
|
|
|
|
static int
|
|
gcore_memory_sections (bfd *obfd)
|
|
{
|
|
/* Try gdbarch method first, then fall back to target method. */
|
|
if (!gdbarch_find_memory_regions_p (target_gdbarch ())
|
|
|| gdbarch_find_memory_regions (target_gdbarch (),
|
|
gcore_create_callback, obfd) != 0)
|
|
{
|
|
if (target_find_memory_regions (gcore_create_callback, obfd) != 0)
|
|
return 0; /* FIXME: error return/msg? */
|
|
}
|
|
|
|
/* Record phdrs for section-to-segment mapping. */
|
|
bfd_map_over_sections (obfd, make_output_phdrs, NULL);
|
|
|
|
/* Copy memory region contents. */
|
|
bfd_map_over_sections (obfd, gcore_copy_callback, NULL);
|
|
|
|
return 1;
|
|
}
|
|
|
|
void _initialize_gcore ();
|
|
void
|
|
_initialize_gcore ()
|
|
{
|
|
add_com ("generate-core-file", class_files, gcore_command, _("\
|
|
Save a core file with the current state of the debugged process.\n\
|
|
Usage: generate-core-file [FILENAME]\n\
|
|
Argument is optional filename. Default filename is 'core.PROCESS_ID'."));
|
|
|
|
add_com_alias ("gcore", "generate-core-file", class_files, 1);
|
|
}
|