5b6d1e4fa4
This commit adds multi-target support to GDB. What this means is that with this commit, GDB can now be connected to different targets at the same time. E.g., you can debug a live native process and a core dump at the same time, connect to multiple gdbservers, etc. Actually, the word "target" is overloaded in gdb. We already have a target stack, with pushes several target_ops instances on top of one another. We also have "info target" already, which means something completely different to what this patch does. So from here on, I'll be using the "target connections" term, to mean an open process_stratum target, pushed on a target stack. This patch makes gdb have multiple target stacks, and multiple process_stratum targets open simultaneously. The user-visible changes / commands will also use this terminology, but of course it's all open to debate. User-interface-wise, not that much changes. The main difference is that each inferior may have its own target connection. A target connection (e.g., a target extended-remote connection) may support debugging multiple processes, just as before. Say you're debugging against gdbserver in extended-remote mode, and you do "add-inferior" to prepare to spawn a new process, like: (gdb) target extended-remote :9999 ... (gdb) start ... (gdb) add-inferior Added inferior 2 (gdb) inferior 2 [Switching to inferior 2 [<null>] (<noexec>)] (gdb) file a.out ... (gdb) start ... At this point, you have two inferiors connected to the same gdbserver. With this commit, GDB will maintain a target stack per inferior, instead of a global target stack. To preserve the behavior above, by default, "add-inferior" makes the new inferior inherit a copy of the target stack of the current inferior. Same across a fork - the child inherits a copy of the target stack of the parent. While the target stacks are copied, the targets themselves are not. Instead, target_ops is made a refcounted_object, which means that target_ops instances are refcounted, which each inferior counting for a reference. What if you want to create an inferior and connect it to some _other_ target? For that, this commit introduces a new "add-inferior -no-connection" option that makes the new inferior not share the current inferior's target. So you could do: (gdb) target extended-remote :9999 Remote debugging using :9999 ... (gdb) add-inferior -no-connection [New inferior 2] Added inferior 2 (gdb) inferior 2 [Switching to inferior 2 [<null>] (<noexec>)] (gdb) info inferiors Num Description Executable 1 process 18401 target:/home/pedro/tmp/main * 2 <null> (gdb) tar extended-remote :10000 Remote debugging using :10000 ... (gdb) info inferiors Num Description Executable 1 process 18401 target:/home/pedro/tmp/main * 2 process 18450 target:/home/pedro/tmp/main (gdb) A following patch will extended "info inferiors" to include a column indicating which connection an inferior is bound to, along with a couple other UI tweaks. Other than that, debugging is the same as before. Users interact with inferiors and threads as before. The only difference is that inferiors may be bound to processes running in different machines. That's pretty much all there is to it in terms of noticeable UI changes. On to implementation. Since we can be connected to different systems at the same time, a ptid_t is no longer a unique identifier. Instead a thread can be identified by a pair of ptid_t and 'process_stratum_target *', the later being the instance of the process_stratum target that owns the process/thread. Note that process_stratum_target inherits from target_ops, and all process_stratum targets inherit from process_stratum_target. In earlier patches, many places in gdb were converted to refer to threads by thread_info pointer instead of ptid_t, but there are still places in gdb where we start with a pid/tid and need to find the corresponding inferior or thread_info objects. So you'll see in the patch many places adding a process_stratum_target parameter to functions that used to take only a ptid_t. Since each inferior has its own target stack now, we can always find the process_stratum target for an inferior. That is done via a inf->process_target() convenience method. Since each inferior has its own target stack, we need to handle the "beneath" calls when servicing target calls. The solution I settled with is just to make sure to switch the current inferior to the inferior you want before making a target call. Not relying on global context is just not feasible in current GDB. Fortunately, there aren't that many places that need to do that, because generally most code that calls target methods already has the current context pointing to the right inferior/thread. Note, to emphasize -- there's no method to "switch to this target stack". Instead, you switch the current inferior, and that implicitly switches the target stack. In some spots, we need to iterate over all inferiors so that we reach all target stacks. Native targets are still singletons. There's always only a single instance of such targets. Remote targets however, we'll have one instance per remote connection. The exec target is still a singleton. There's only one instance. I did not see the point of instanciating more than one exec_target object. After vfork, we need to make sure to push the exec target on the new inferior. See exec_on_vfork. For type safety, functions that need a {target, ptid} pair to identify a thread, take a process_stratum_target pointer for target parameter instead of target_ops *. Some shared code in gdb/nat/ also need to gain a target pointer parameter. This poses an issue, since gdbserver doesn't have process_stratum_target, only target_ops. To fix this, this commit renames gdbserver's target_ops to process_stratum_target. I think this makes sense. There's no concept of target stack in gdbserver, and gdbserver's target_ops really implements a process_stratum-like target. The thread and inferior iterator functions also gain process_stratum_target parameters. These are used to be able to iterate over threads and inferiors of a given target. Following usual conventions, if the target pointer is null, then we iterate over threads and inferiors of all targets. I tried converting "add-inferior" to the gdb::option framework, as a preparatory patch, but that stumbled on the fact that gdb::option does not support file options yet, for "add-inferior -exec". I have a WIP patchset that adds that, but it's not a trivial patch, mainly due to need to integrate readline's filename completion, so I deferred that to some other time. In infrun.c/infcmd.c, the main change is that we need to poll events out of all targets. See do_target_wait. Right after collecting an event, we switch the current inferior to an inferior bound to the target that reported the event, so that target methods can be used while handling the event. This makes most of the code transparent to multi-targets. See fetch_inferior_event. infrun.c:stop_all_threads is interesting -- in this function we need to stop all threads of all targets. What the function does is send an asynchronous stop request to all threads, and then synchronously waits for events, with target_wait, rinse repeat, until all it finds are stopped threads. Now that we have multiple targets, it's not efficient to synchronously block in target_wait waiting for events out of one target. Instead, we implement a mini event loop, with interruptible_select, select'ing on one file descriptor per target. For this to work, we need to be able to ask the target for a waitable file descriptor. Such file descriptors already exist, they are the descriptors registered in the main event loop with add_file_handler, inside the target_async implementations. This commit adds a new target_async_wait_fd target method that just returns the file descriptor in question. See wait_one / stop_all_threads in infrun.c. The 'threads_executing' global is made a per-target variable. Since it is only relevant to process_stratum_target targets, this is where it is put, instead of in target_ops. You'll notice that remote.c includes some FIXME notes. These refer to the fact that the global arrays that hold data for the remote packets supported are still globals. For example, if we connect to two different servers/stubs, then each might support different remote protocol features. They might even be different architectures, like e.g., one ARM baremetal stub, and a x86 gdbserver, to debug a host/controller scenario as a single program. That isn't going to work correctly today, because of said globals. I'm leaving fixing that for another pass, since it does not appear to be trivial, and I'd rather land the base work first. It's already useful to be able to debug multiple instances of the same server (e.g., a distributed cluster, where you have full control over the servers installed), so I think as is it's already reasonable incremental progress. Current limitations: - You can only resume more that one target at the same time if all targets support asynchronous debugging, and support non-stop mode. It should be possible to support mixed all-stop + non-stop backends, but that is left for another time. This means that currently in order to do multi-target with gdbserver you need to issue "maint set target-non-stop on". I would like to make that mode be the default, but we're not there yet. Note that I'm talking about how the target backend works, only. User-visible all-stop mode works just fine. - As explained above, connecting to different remote servers at the same time is likely to produce bad results if they don't support the exact set of RSP features. FreeBSD updates courtesy of John Baldwin. gdb/ChangeLog: 2020-01-10 Pedro Alves <palves@redhat.com> John Baldwin <jhb@FreeBSD.org> * aarch64-linux-nat.c (aarch64_linux_nat_target::thread_architecture): Adjust. * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call. (task_command_1): Likewise. * aix-thread.c (sync_threadlists, aix_thread_target::resume) (aix_thread_target::wait, aix_thread_target::fetch_registers) (aix_thread_target::store_registers) (aix_thread_target::thread_alive): Adjust. * amd64-fbsd-tdep.c: Include "inferior.h". (amd64fbsd_get_thread_local_address): Pass down target. * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle thread's gdbarch instead of target_gdbarch. * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to get_last_target_status. * break-catch-syscall.c (print_it_catch_syscall): Likewise. * breakpoint.c (breakpoints_should_be_inserted_now): Consider all inferiors. (update_inserted_breakpoint_locations): Skip if inferiors with no execution. (update_global_location_list): When handling moribund locations, find representative inferior for location's pspace, and use thread count of its process_stratum target. * bsd-kvm.c (bsd_kvm_target_open): Pass target down. * bsd-uthread.c (bsd_uthread_target::wait): Use as_process_stratum_target and adjust thread_change_ptid and add_thread calls. (bsd_uthread_target::update_thread_list): Use as_process_stratum_target and adjust find_thread_ptid, thread_change_ptid and add_thread calls. * btrace.c (maint_btrace_packet_history_cmd): Adjust find_thread_ptid call. * corelow.c (add_to_thread_list): Adjust add_thread call. (core_target_open): Adjust add_thread_silent and thread_count calls. (core_target::pid_to_str): Adjust find_inferior_ptid call. * ctf.c (ctf_target_open): Adjust add_thread_silent call. * event-top.c (async_disconnect): Pop targets from all inferiors. * exec.c (add_target_sections): Push exec target on all inferiors sharing the program space. (remove_target_sections): Remove the exec target from all inferiors sharing the program space. (exec_on_vfork): New. * exec.h (exec_on_vfork): Declare. * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter. Pass it down. (fbsd_nat_target::update_thread_list): Adjust. (fbsd_nat_target::resume): Adjust. (fbsd_handle_debug_trap): Add fbsd_nat_target parameter. Pass it down. (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust. * fbsd-tdep.c (fbsd_corefile_thread): Adjust get_thread_arch_regcache call. * fork-child.c (gdb_startup_inferior): Pass target down to startup_inferior and set_executing. * gdbthread.h (struct process_stratum_target): Forward declare. (add_thread, add_thread_silent, add_thread_with_info) (in_thread_list): Add process_stratum_target parameter. (find_thread_ptid(inferior*, ptid_t)): New overload. (find_thread_ptid, thread_change_ptid): Add process_stratum_target parameter. (all_threads()): Delete overload. (all_threads, all_non_exited_threads): Add process_stratum_target parameter. (all_threads_safe): Use brace initialization. (thread_count): Add process_stratum_target parameter. (set_resumed, set_running, set_stop_requested, set_executing) (threads_are_executing, finish_thread_state): Add process_stratum_target parameter. (switch_to_thread): Use is_current_thread. * i386-fbsd-tdep.c: Include "inferior.h". (i386fbsd_get_thread_local_address): Pass down target. * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust. * inf-child.c (inf_child_target::maybe_unpush_target): Remove have_inferiors check. * inf-ptrace.c (inf_ptrace_target::create_inferior) (inf_ptrace_target::attach): Adjust. * infcall.c (run_inferior_call): Adjust. * infcmd.c (run_command_1): Pass target to scoped_finish_thread_state. (proceed_thread_callback): Skip inferiors with no execution. (continue_command): Rename 'all_threads' local to avoid hiding 'all_threads' function. Adjust get_last_target_status call. (prepare_one_step): Adjust set_running call. (signal_command): Use user_visible_resume_target. Compare thread pointers instead of inferior_ptid. (info_program_command): Adjust to pass down target. (attach_command): Mark target's 'thread_executing' flag. (stop_current_target_threads_ns): New, factored out from ... (interrupt_target_1): ... this. Switch inferior before making target calls. * inferior-iter.h (struct all_inferiors_iterator, struct all_inferiors_range) (struct all_inferiors_safe_range) (struct all_non_exited_inferiors_range): Filter on process_stratum_target too. Remove explicit. * inferior.c (inferior::inferior): Push dummy target on target stack. (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors): Add process_stratum_target parameter, and pass it down. (have_live_inferiors): Adjust. (switch_to_inferior_and_push_target): New. (add_inferior_command, clone_inferior_command): Handle "-no-connection" parameter. Use switch_to_inferior_and_push_target. (_initialize_inferior): Mention "-no-connection" option in the help of "add-inferior" and "clone-inferior" commands. * inferior.h: Include "process-stratum-target.h". (interrupt_target_1): Use bool. (struct inferior) <push_target, unpush_target, target_is_pushed, find_target_beneath, top_target, process_target, target_at, m_stack>: New. (discard_all_inferiors): Delete. (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors) (all_inferiors, all_non_exited_inferiors): Add process_stratum_target parameter. * infrun.c: Include "gdb_select.h" and <unordered_map>. (target_last_proc_target): New global. (follow_fork_inferior): Push target on new inferior. Pass target to add_thread_silent. Call exec_on_vfork. Handle target's reference count. (follow_fork): Adjust get_last_target_status call. Also consider target. (follow_exec): Push target on new inferior. (struct execution_control_state) <target>: New field. (user_visible_resume_target): New. (do_target_resume): Call target_async. (resume_1): Set target's threads_executing flag. Consider resume target. (commit_resume_all_targets): New. (proceed): Also consider resume target. Skip threads of inferiors with no execution. Commit resumtion in all targets. (start_remote): Pass current inferior to wait_for_inferior. (infrun_thread_stop_requested): Consider target as well. Pass thread_info pointer to clear_inline_frame_state instead of ptid. (infrun_thread_thread_exit): Consider target as well. (random_pending_event_thread): New inferior parameter. Use it. (do_target_wait): Rename to ... (do_target_wait_1): ... this. Add inferior parameter, and pass it down. (threads_are_resumed_pending_p, do_target_wait): New. (prepare_for_detach): Adjust calls. (wait_for_inferior): New inferior parameter. Handle it. Use do_target_wait_1 instead of do_target_wait. (fetch_inferior_event): Adjust. Switch to representative inferior. Pass target down. (set_last_target_status): Add process_stratum_target parameter. Save target in global. (get_last_target_status): Add process_stratum_target parameter and handle it. (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'. (context_switch): Check inferior_ptid == null_ptid before calling inferior_thread(). (get_inferior_stop_soon): Pass down target. (wait_one): Rename to ... (poll_one_curr_target): ... this. (struct wait_one_event): New. (wait_one): New. (stop_all_threads): Adjust. (handle_no_resumed, handle_inferior_event): Adjust to consider the event's target. (switch_back_to_stepped_thread): Also consider target. (print_stop_event): Update. (normal_stop): Update. Also consider the resume target. * infrun.h (wait_for_inferior): Remove declaration. (user_visible_resume_target): New declaration. (get_last_target_status, set_last_target_status): New process_stratum_target parameter. * inline-frame.c (clear_inline_frame_state(ptid_t)): Add process_stratum_target parameter, and use it. (clear_inline_frame_state (thread_info*)): New. * inline-frame.c (clear_inline_frame_state(ptid_t)): Add process_stratum_target parameter. (clear_inline_frame_state (thread_info*)): Declare. * linux-fork.c (delete_checkpoint_command): Pass target down to find_thread_ptid. (checkpoint_command): Adjust. * linux-nat.c (linux_nat_target::follow_fork): Switch to thread instead of just tweaking inferior_ptid. (linux_nat_switch_fork): Pass target down to thread_change_ptid. (exit_lwp): Pass target down to find_thread_ptid. (attach_proc_task_lwp_callback): Pass target down to add_thread/set_running/set_executing. (linux_nat_target::attach): Pass target down to thread_change_ptid. (get_detach_signal): Pass target down to find_thread_ptid. Consider last target status's target. (linux_resume_one_lwp_throw, resume_lwp) (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp) (stop_wait_callback, save_stop_reason, linux_nat_filter_event) (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down. (linux_nat_target::async_wait_fd): New. (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass target down. * linux-nat.h (linux_nat_target::async_wait_fd): Declare. * linux-tdep.c (get_thread_arch_regcache): Pass target down. * linux-thread-db.c (struct thread_db_info::process_target): New field. (add_thread_db_info): Save target. (get_thread_db_info): New process_stratum_target parameter. Also match target. (delete_thread_db_info): New process_stratum_target parameter. Also match target. (thread_from_lwp): Adjust to pass down target. (thread_db_notice_clone): Pass down target. (check_thread_db_callback): Pass down target. (try_thread_db_load_1): Always push the thread_db target. (try_thread_db_load, record_thread): Pass target down. (thread_db_target::detach): Pass target down. Always unpush the thread_db target. (thread_db_target::wait, thread_db_target::mourn_inferior): Pass target down. Always unpush the thread_db target. (find_new_threads_callback, thread_db_find_new_threads_2) (thread_db_target::update_thread_list): Pass target down. (thread_db_target::pid_to_str): Pass current inferior down. (thread_db_target::get_thread_local_address): Pass target down. (thread_db_target::resume, maintenance_check_libthread_db): Pass target down. * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust. * procfs.c (procfs_target::procfs_init_inferior): Declare. (proc_set_current_signal, do_attach, procfs_target::wait): Adjust. (procfs_init_inferior): Rename to ... (procfs_target::procfs_init_inferior): ... this and adjust. (procfs_target::create_inferior, procfs_notice_thread) (procfs_do_thread_registers): Adjust. * ppc-fbsd-tdep.c: Include "inferior.h". (ppcfbsd_get_thread_local_address): Pass down target. * proc-service.c (ps_xfer_memory): Switch current inferior and program space as well. (get_ps_regcache): Pass target down. * process-stratum-target.c (process_stratum_target::thread_address_space) (process_stratum_target::thread_architecture): Pass target down. * process-stratum-target.h (process_stratum_target::threads_executing): New field. (as_process_stratum_target): New. * ravenscar-thread.c (ravenscar_thread_target::update_inferior_ptid): Pass target down. (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target down. * record-btrace.c (record_btrace_target::info_record): Adjust. (record_btrace_target::record_method) (record_btrace_target::record_is_replaying) (record_btrace_target::fetch_registers) (get_thread_current_frame_id, record_btrace_target::resume) (record_btrace_target::wait, record_btrace_target::stop): Pass target down. * record-full.c (record_full_wait_1): Switch to event thread. Pass target down. * regcache.c (regcache::regcache) (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add process_stratum_target parameter and handle it. (current_thread_target): New global. (get_thread_regcache): Add process_stratum_target parameter and handle it. Switch inferior before calling target method. (get_thread_regcache): Pass target down. (get_thread_regcache_for_ptid): Pass target down. (registers_changed_ptid): Add process_stratum_target parameter and handle it. (registers_changed_thread, registers_changed): Pass target down. (test_get_thread_arch_aspace_regcache): New. (current_regcache_test): Define a couple local test_target_ops instances and use them for testing. (readwrite_regcache): Pass process_stratum_target parameter. (cooked_read_test, cooked_write_test): Pass mock_target down. * regcache.h (get_thread_regcache, get_thread_arch_regcache) (get_thread_arch_aspace_regcache): Add process_stratum_target parameter. (regcache::target): New method. (regcache::regcache, regcache::get_thread_arch_aspace_regcache) (regcache::registers_changed_ptid): Add process_stratum_target parameter. (regcache::m_target): New field. (registers_changed_ptid): Add process_stratum_target parameter. * remote.c (remote_state::supports_vCont_probed): New field. (remote_target::async_wait_fd): New method. (remote_unpush_and_throw): Add remote_target parameter. (get_current_remote_target): Adjust. (remote_target::remote_add_inferior): Push target. (remote_target::remote_add_thread) (remote_target::remote_notice_new_inferior) (get_remote_thread_info): Pass target down. (remote_target::update_thread_list): Skip threads of inferiors bound to other targets. (remote_target::close): Don't discard inferiors. (remote_target::add_current_inferior_and_thread) (remote_target::process_initial_stop_replies) (remote_target::start_remote) (remote_target::remote_serial_quit_handler): Pass down target. (remote_target::remote_unpush_target): New remote_target parameter. Unpush the target from all inferiors. (remote_target::remote_unpush_and_throw): New remote_target parameter. Pass it down. (remote_target::open_1): Check whether the current inferior has execution instead of checking whether any inferior is live. Pass target down. (remote_target::remote_detach_1): Pass down target. Use remote_unpush_target. (extended_remote_target::attach): Pass down target. (remote_target::remote_vcont_probe): Set supports_vCont_probed. (remote_target::append_resumption): Pass down target. (remote_target::append_pending_thread_resumptions) (remote_target::remote_resume_with_hc, remote_target::resume) (remote_target::commit_resume): Pass down target. (remote_target::remote_stop_ns): Check supports_vCont_probed. (remote_target::interrupt_query) (remote_target::remove_new_fork_children) (remote_target::check_pending_events_prevent_wildcard_vcont) (remote_target::remote_parse_stop_reply) (remote_target::process_stop_reply): Pass down target. (first_remote_resumed_thread): New remote_target parameter. Pass it down. (remote_target::wait_as): Pass down target. (unpush_and_perror): New remote_target parameter. Pass it down. (remote_target::readchar, remote_target::remote_serial_write) (remote_target::getpkt_or_notif_sane_1) (remote_target::kill_new_fork_children, remote_target::kill): Pass down target. (remote_target::mourn_inferior): Pass down target. Use remote_unpush_target. (remote_target::core_of_thread) (remote_target::remote_btrace_maybe_reopen): Pass down target. (remote_target::pid_to_exec_file) (remote_target::thread_handle_to_thread_info): Pass down target. (remote_target::async_wait_fd): New. * riscv-fbsd-tdep.c: Include "inferior.h". (riscv_fbsd_get_thread_local_address): Pass down target. * sol2-tdep.c (sol2_core_pid_to_str): Pass down target. * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs) (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback): Adjust. * solib-spu.c (spu_skip_standalone_loader): Pass down target. * solib-svr4.c (enable_break): Pass down target. * spu-multiarch.c (parse_spufs_run): Pass down target. * spu-tdep.c (spu2ppu_sniffer): Pass down target. * target-delegates.c: Regenerate. * target.c (g_target_stack): Delete. (current_top_target): Return the current inferior's top target. (target_has_execution_1): Refer to the passed-in inferior's top target. (target_supports_terminal_ours): Check whether the initial inferior was already created. (decref_target): New. (target_stack::push): Incref/decref the target. (push_target, push_target, unpush_target): Adjust. (target_stack::unpush): Defref target. (target_is_pushed): Return bool. Adjust to refer to the current inferior's target stack. (dispose_inferior): Delete, and inline parts ... (target_preopen): ... here. Only dispose of the current inferior. (target_detach): Hold strong target reference while detaching. Pass target down. (target_thread_name): Add assertion. (target_resume): Pass down target. (target_ops::beneath, find_target_at): Adjust to refer to the current inferior's target stack. (get_dummy_target): New. (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that has a thread running. (initialize_targets): Rename to ... (_initialize_target): ... this. * target.h: Include "gdbsupport/refcounted-object.h". (struct target_ops): Inherit refcounted_object. (target_ops::shortname, target_ops::longname): Make const. (target_ops::async_wait_fd): New method. (decref_target): Declare. (struct target_ops_ref_policy): New. (target_ops_ref): New typedef. (get_dummy_target): Declare function. (target_is_pushed): Return bool. * thread-iter.c (all_matching_threads_iterator::m_inf_matches) (all_matching_threads_iterator::all_matching_threads_iterator): Handle filter target. * thread-iter.h (struct all_matching_threads_iterator, struct all_matching_threads_range, class all_non_exited_threads_range): Filter by target too. Remove explicit. * thread.c (threads_executing): Delete. (inferior_thread): Pass down current inferior. (clear_thread_inferior_resources): Pass down thread pointer instead of ptid_t. (add_thread_silent, add_thread_with_info, add_thread): Add process_stratum_target parameter. Use it for thread and inferior searches. (is_current_thread): New. (thread_info::deletable): Use it. (find_thread_ptid, thread_count, in_thread_list) (thread_change_ptid, set_resumed, set_running): New process_stratum_target parameter. Pass it down. (set_executing): New process_stratum_target parameter. Pass it down. Adjust reference to 'threads_executing'. (threads_are_executing): New process_stratum_target parameter. Adjust reference to 'threads_executing'. (set_stop_requested, finish_thread_state): New process_stratum_target parameter. Pass it down. (switch_to_thread): Also match inferior. (switch_to_thread): New process_stratum_target parameter. Pass it down. (update_threads_executing): Reimplement. * top.c (quit_force): Pop targets from all inferior. (gdb_init): Don't call initialize_targets. * windows-nat.c (windows_nat_target) <get_windows_debug_event>: Declare. (windows_add_thread, windows_delete_thread): Adjust. (get_windows_debug_event): Rename to ... (windows_nat_target::get_windows_debug_event): ... this. Adjust. * tracefile-tfile.c (tfile_target_open): Pass down target. * gdbsupport/common-gdbthread.h (struct process_stratum_target): Forward declare. (switch_to_thread): Add process_stratum_target parameter. * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target parameter. Use it. (mi_on_resume): Pass target down. * nat/fork-inferior.c (startup_inferior): Add process_stratum_target parameter. Pass it down. * nat/fork-inferior.h (startup_inferior): Add process_stratum_target parameter. * python/py-threadevent.c (py_get_event_thread): Pass target down. gdb/gdbserver/ChangeLog: 2020-01-10 Pedro Alves <palves@redhat.com> * fork-child.c (post_fork_inferior): Pass target down to startup_inferior. * inferiors.c (switch_to_thread): Add process_stratum_target parameter. * lynx-low.c (lynx_target_ops): Now a process_stratum_target. * nto-low.c (nto_target_ops): Now a process_stratum_target. * linux-low.c (linux_target_ops): Now a process_stratum_target. * remote-utils.c (prepare_resume_reply): Pass the target to switch_to_thread. * target.c (the_target): Now a process_stratum_target. (done_accessing_memory): Pass the target to switch_to_thread. (set_target_ops): Ajust to use process_stratum_target. * target.h (struct target_ops): Rename to ... (struct process_stratum_target): ... this. (the_target, set_target_ops): Adjust. (prepare_to_access_memory): Adjust comment. * win32-low.c (child_xfer_memory): Adjust to use process_stratum_target. (win32_target_ops): Now a process_stratum_target.
493 lines
16 KiB
C++
493 lines
16 KiB
C++
/* Cache and manage the values of registers for GDB, the GNU debugger.
|
|
|
|
Copyright (C) 1986-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef REGCACHE_H
|
|
#define REGCACHE_H
|
|
|
|
#include "gdbsupport/common-regcache.h"
|
|
#include "gdbsupport/function-view.h"
|
|
#include <forward_list>
|
|
|
|
struct regcache;
|
|
struct regset;
|
|
struct gdbarch;
|
|
struct address_space;
|
|
class thread_info;
|
|
struct process_stratum_target;
|
|
|
|
extern struct regcache *get_current_regcache (void);
|
|
extern struct regcache *get_thread_regcache (process_stratum_target *target,
|
|
ptid_t ptid);
|
|
|
|
/* Get the regcache of THREAD. */
|
|
extern struct regcache *get_thread_regcache (thread_info *thread);
|
|
|
|
extern struct regcache *get_thread_arch_regcache
|
|
(process_stratum_target *targ, ptid_t, struct gdbarch *);
|
|
extern struct regcache *get_thread_arch_aspace_regcache
|
|
(process_stratum_target *target, ptid_t,
|
|
struct gdbarch *, struct address_space *);
|
|
|
|
extern enum register_status
|
|
regcache_raw_read_signed (struct regcache *regcache,
|
|
int regnum, LONGEST *val);
|
|
|
|
extern void regcache_raw_write_signed (struct regcache *regcache,
|
|
int regnum, LONGEST val);
|
|
extern void regcache_raw_write_unsigned (struct regcache *regcache,
|
|
int regnum, ULONGEST val);
|
|
|
|
/* Return the register's value in signed or throw if it's not
|
|
available. */
|
|
|
|
extern LONGEST regcache_raw_get_signed (struct regcache *regcache,
|
|
int regnum);
|
|
|
|
/* Read a register as a signed/unsigned quantity. */
|
|
extern enum register_status
|
|
regcache_cooked_read_signed (struct regcache *regcache,
|
|
int regnum, LONGEST *val);
|
|
extern enum register_status
|
|
regcache_cooked_read_unsigned (struct regcache *regcache,
|
|
int regnum, ULONGEST *val);
|
|
extern void regcache_cooked_write_signed (struct regcache *regcache,
|
|
int regnum, LONGEST val);
|
|
extern void regcache_cooked_write_unsigned (struct regcache *regcache,
|
|
int regnum, ULONGEST val);
|
|
|
|
/* Special routines to read/write the PC. */
|
|
|
|
/* For regcache_read_pc see gdbsupport/common-regcache.h. */
|
|
extern void regcache_write_pc (struct regcache *regcache, CORE_ADDR pc);
|
|
|
|
/* Mapping between register numbers and offsets in a buffer, for use
|
|
in the '*regset' functions below and with traditional frame caches.
|
|
In an array of 'regcache_map_entry' each element is interpreted
|
|
like follows:
|
|
|
|
- If 'regno' is a register number: Map register 'regno' to the
|
|
current offset (starting with 0) and increase the current offset
|
|
by 'size' (or the register's size, if 'size' is zero). Repeat
|
|
this with consecutive register numbers up to 'regno+count-1'.
|
|
|
|
For each described register, if 'size' is larger than the
|
|
register's size, the register's value is assumed to be stored in
|
|
the first N (where N is the register size) bytes at the current
|
|
offset. The remaining 'size' - N bytes are filled with zeroes by
|
|
'regcache_collect_regset' and ignored by other consumers.
|
|
|
|
If 'size' is smaller than the register's size, only the first
|
|
'size' bytes of a register's value are assumed to be stored at
|
|
the current offset. 'regcache_collect_regset' copies the first
|
|
'size' bytes of a register's value to the output buffer.
|
|
'regcache_supply_regset' copies the bytes from the input buffer
|
|
into the first 'size' bytes of the register's value leaving the
|
|
remaining bytes of the register's value unchanged. Frame caches
|
|
read the 'size' bytes from the stack frame and zero extend them
|
|
to generate the register's value.
|
|
|
|
- If 'regno' is REGCACHE_MAP_SKIP: Add 'count*size' to the current
|
|
offset.
|
|
|
|
- If count=0: End of the map. */
|
|
|
|
struct regcache_map_entry
|
|
{
|
|
int count;
|
|
int regno;
|
|
int size;
|
|
};
|
|
|
|
/* Special value for the 'regno' field in the struct above. */
|
|
|
|
enum
|
|
{
|
|
REGCACHE_MAP_SKIP = -1,
|
|
};
|
|
|
|
/* Calculate and return the total size of all the registers in a
|
|
regcache_map_entry. */
|
|
|
|
static inline int
|
|
regcache_map_entry_size (const struct regcache_map_entry *map)
|
|
{
|
|
int size = 0;
|
|
for (int i = 0; map[i].count != 0; i++)
|
|
size += (map[i].count * map[i].size);
|
|
return size;
|
|
}
|
|
|
|
/* Transfer a set of registers (as described by REGSET) between
|
|
REGCACHE and BUF. If REGNUM == -1, transfer all registers
|
|
belonging to the regset, otherwise just the register numbered
|
|
REGNUM. The REGSET's 'regmap' field must point to an array of
|
|
'struct regcache_map_entry'.
|
|
|
|
These functions are suitable for the 'regset_supply' and
|
|
'regset_collect' fields in a regset structure. */
|
|
|
|
extern void regcache_supply_regset (const struct regset *regset,
|
|
struct regcache *regcache,
|
|
int regnum, const void *buf,
|
|
size_t size);
|
|
extern void regcache_collect_regset (const struct regset *regset,
|
|
const struct regcache *regcache,
|
|
int regnum, void *buf, size_t size);
|
|
|
|
|
|
/* The type of a register. This function is slightly more efficient
|
|
then its gdbarch vector counterpart since it returns a precomputed
|
|
value stored in a table. */
|
|
|
|
extern struct type *register_type (struct gdbarch *gdbarch, int regnum);
|
|
|
|
|
|
/* Return the size of register REGNUM. All registers should have only
|
|
one size. */
|
|
|
|
extern int register_size (struct gdbarch *gdbarch, int regnum);
|
|
|
|
typedef gdb::function_view<register_status (int regnum, gdb_byte *buf)>
|
|
register_read_ftype;
|
|
|
|
/* A (register_number, register_value) pair. */
|
|
|
|
typedef struct cached_reg
|
|
{
|
|
int num;
|
|
gdb_byte *data;
|
|
} cached_reg_t;
|
|
|
|
/* Buffer of registers. */
|
|
|
|
class reg_buffer : public reg_buffer_common
|
|
{
|
|
public:
|
|
reg_buffer (gdbarch *gdbarch, bool has_pseudo);
|
|
|
|
DISABLE_COPY_AND_ASSIGN (reg_buffer);
|
|
|
|
/* Return regcache's architecture. */
|
|
gdbarch *arch () const;
|
|
|
|
/* See gdbsupport/common-regcache.h. */
|
|
enum register_status get_register_status (int regnum) const override;
|
|
|
|
/* See gdbsupport/common-regcache.h. */
|
|
void raw_collect (int regnum, void *buf) const override;
|
|
|
|
/* Collect register REGNUM from REGCACHE. Store collected value as an integer
|
|
at address ADDR, in target endian, with length ADDR_LEN and sign IS_SIGNED.
|
|
If ADDR_LEN is greater than the register size, then the integer will be
|
|
sign or zero extended. If ADDR_LEN is smaller than the register size, then
|
|
the most significant bytes of the integer will be truncated. */
|
|
void raw_collect_integer (int regnum, gdb_byte *addr, int addr_len,
|
|
bool is_signed) const;
|
|
|
|
/* Collect register REGNUM from REGCACHE, starting at OFFSET in register,
|
|
reading only LEN. */
|
|
void raw_collect_part (int regnum, int offset, int len, gdb_byte *out) const;
|
|
|
|
/* See gdbsupport/common-regcache.h. */
|
|
void raw_supply (int regnum, const void *buf) override;
|
|
|
|
void raw_supply (int regnum, const reg_buffer &src)
|
|
{
|
|
raw_supply (regnum, src.register_buffer (regnum));
|
|
}
|
|
|
|
/* Supply register REGNUM to REGCACHE. Value to supply is an integer stored
|
|
at address ADDR, in target endian, with length ADDR_LEN and sign IS_SIGNED.
|
|
If the register size is greater than ADDR_LEN, then the integer will be
|
|
sign or zero extended. If the register size is smaller than the integer,
|
|
then the most significant bytes of the integer will be truncated. */
|
|
void raw_supply_integer (int regnum, const gdb_byte *addr, int addr_len,
|
|
bool is_signed);
|
|
|
|
/* Supply register REGNUM with zeroed value to REGCACHE. This is not the same
|
|
as calling raw_supply with NULL (which will set the state to
|
|
unavailable). */
|
|
void raw_supply_zeroed (int regnum);
|
|
|
|
/* Supply register REGNUM to REGCACHE, starting at OFFSET in register, writing
|
|
only LEN, without editing the rest of the register. */
|
|
void raw_supply_part (int regnum, int offset, int len, const gdb_byte *in);
|
|
|
|
void invalidate (int regnum);
|
|
|
|
virtual ~reg_buffer () = default;
|
|
|
|
/* See gdbsupport/common-regcache.h. */
|
|
bool raw_compare (int regnum, const void *buf, int offset) const override;
|
|
|
|
protected:
|
|
/* Assert on the range of REGNUM. */
|
|
void assert_regnum (int regnum) const;
|
|
|
|
int num_raw_registers () const;
|
|
|
|
gdb_byte *register_buffer (int regnum) const;
|
|
|
|
/* Save a register cache. The set of registers saved into the
|
|
regcache determined by the save_reggroup. COOKED_READ returns
|
|
zero iff the register's value can't be returned. */
|
|
void save (register_read_ftype cooked_read);
|
|
|
|
struct regcache_descr *m_descr;
|
|
|
|
bool m_has_pseudo;
|
|
/* The register buffers. */
|
|
std::unique_ptr<gdb_byte[]> m_registers;
|
|
/* Register cache status. */
|
|
std::unique_ptr<register_status[]> m_register_status;
|
|
|
|
friend class regcache;
|
|
friend class detached_regcache;
|
|
};
|
|
|
|
/* An abstract class which only has methods doing read. */
|
|
|
|
class readable_regcache : public reg_buffer
|
|
{
|
|
public:
|
|
readable_regcache (gdbarch *gdbarch, bool has_pseudo)
|
|
: reg_buffer (gdbarch, has_pseudo)
|
|
{}
|
|
|
|
/* Transfer a raw register [0..NUM_REGS) from core-gdb to this regcache,
|
|
return its value in *BUF and return its availability status. */
|
|
|
|
enum register_status raw_read (int regnum, gdb_byte *buf);
|
|
template<typename T, typename = RequireLongest<T>>
|
|
enum register_status raw_read (int regnum, T *val);
|
|
|
|
/* Partial transfer of raw registers. Return the status of the register. */
|
|
enum register_status raw_read_part (int regnum, int offset, int len,
|
|
gdb_byte *buf);
|
|
|
|
/* Make certain that the register REGNUM is up-to-date. */
|
|
virtual void raw_update (int regnum) = 0;
|
|
|
|
/* Transfer a raw register [0..NUM_REGS+NUM_PSEUDO_REGS) from core-gdb to
|
|
this regcache, return its value in *BUF and return its availability status. */
|
|
enum register_status cooked_read (int regnum, gdb_byte *buf);
|
|
template<typename T, typename = RequireLongest<T>>
|
|
enum register_status cooked_read (int regnum, T *val);
|
|
|
|
/* Partial transfer of a cooked register. */
|
|
enum register_status cooked_read_part (int regnum, int offset, int len,
|
|
gdb_byte *buf);
|
|
|
|
/* Read register REGNUM from the regcache and return a new value. This
|
|
will call mark_value_bytes_unavailable as appropriate. */
|
|
struct value *cooked_read_value (int regnum);
|
|
|
|
protected:
|
|
|
|
/* Perform a partial register transfer using a read, modify, write
|
|
operation. Will fail if register is currently invalid. */
|
|
enum register_status read_part (int regnum, int offset, int len,
|
|
gdb_byte *out, bool is_raw);
|
|
};
|
|
|
|
/* Buffer of registers, can be read and written. */
|
|
|
|
class detached_regcache : public readable_regcache
|
|
{
|
|
public:
|
|
detached_regcache (gdbarch *gdbarch, bool has_pseudo)
|
|
: readable_regcache (gdbarch, has_pseudo)
|
|
{}
|
|
|
|
void raw_update (int regnum) override
|
|
{}
|
|
|
|
DISABLE_COPY_AND_ASSIGN (detached_regcache);
|
|
};
|
|
|
|
class readonly_detached_regcache;
|
|
|
|
/* The register cache for storing raw register values. */
|
|
|
|
class regcache : public detached_regcache
|
|
{
|
|
public:
|
|
DISABLE_COPY_AND_ASSIGN (regcache);
|
|
|
|
/* Return REGCACHE's address space. */
|
|
const address_space *aspace () const
|
|
{
|
|
return m_aspace;
|
|
}
|
|
|
|
/* Restore 'this' regcache. The set of registers restored into
|
|
the regcache determined by the restore_reggroup.
|
|
Writes to regcache will go through to the target. SRC is a
|
|
read-only register cache. */
|
|
void restore (readonly_detached_regcache *src);
|
|
|
|
/* Update the value of raw register REGNUM (in the range [0..NUM_REGS)) and
|
|
transfer its value to core-gdb. */
|
|
|
|
void raw_write (int regnum, const gdb_byte *buf);
|
|
|
|
template<typename T, typename = RequireLongest<T>>
|
|
void raw_write (int regnum, T val);
|
|
|
|
/* Transfer of pseudo-registers. */
|
|
void cooked_write (int regnum, const gdb_byte *buf);
|
|
|
|
template<typename T, typename = RequireLongest<T>>
|
|
void cooked_write (int regnum, T val);
|
|
|
|
void raw_update (int regnum) override;
|
|
|
|
/* Partial transfer of raw registers. Perform read, modify, write style
|
|
operations. */
|
|
void raw_write_part (int regnum, int offset, int len, const gdb_byte *buf);
|
|
|
|
/* Partial transfer of a cooked register. Perform read, modify, write style
|
|
operations. */
|
|
void cooked_write_part (int regnum, int offset, int len,
|
|
const gdb_byte *buf);
|
|
|
|
void supply_regset (const struct regset *regset,
|
|
int regnum, const void *buf, size_t size);
|
|
|
|
|
|
void collect_regset (const struct regset *regset, int regnum,
|
|
void *buf, size_t size) const;
|
|
|
|
/* Return REGCACHE's ptid. */
|
|
|
|
ptid_t ptid () const
|
|
{
|
|
gdb_assert (m_ptid != minus_one_ptid);
|
|
|
|
return m_ptid;
|
|
}
|
|
|
|
void set_ptid (const ptid_t ptid)
|
|
{
|
|
this->m_ptid = ptid;
|
|
}
|
|
|
|
process_stratum_target *target () const
|
|
{
|
|
return m_target;
|
|
}
|
|
|
|
/* Dump the contents of a register from the register cache to the target
|
|
debug. */
|
|
void debug_print_register (const char *func, int regno);
|
|
|
|
static void regcache_thread_ptid_changed (ptid_t old_ptid, ptid_t new_ptid);
|
|
protected:
|
|
regcache (process_stratum_target *target, gdbarch *gdbarch,
|
|
const address_space *aspace);
|
|
|
|
static std::forward_list<regcache *> current_regcache;
|
|
|
|
private:
|
|
|
|
/* Helper function for transfer_regset. Copies across a single register. */
|
|
void transfer_regset_register (struct regcache *out_regcache, int regnum,
|
|
const gdb_byte *in_buf, gdb_byte *out_buf,
|
|
int slot_size, int offs) const;
|
|
|
|
/* Transfer a single or all registers belonging to a certain register
|
|
set to or from a buffer. This is the main worker function for
|
|
regcache_supply_regset and regcache_collect_regset. */
|
|
void transfer_regset (const struct regset *regset,
|
|
struct regcache *out_regcache,
|
|
int regnum, const gdb_byte *in_buf,
|
|
gdb_byte *out_buf, size_t size) const;
|
|
|
|
/* Perform a partial register transfer using a read, modify, write
|
|
operation. */
|
|
enum register_status write_part (int regnum, int offset, int len,
|
|
const gdb_byte *in, bool is_raw);
|
|
|
|
/* The address space of this register cache (for registers where it
|
|
makes sense, like PC or SP). */
|
|
const address_space * const m_aspace;
|
|
|
|
/* If this is a read-write cache, which thread's registers is
|
|
it connected to? */
|
|
process_stratum_target *m_target;
|
|
ptid_t m_ptid;
|
|
|
|
friend struct regcache *
|
|
get_thread_arch_aspace_regcache (process_stratum_target *target, ptid_t ptid,
|
|
struct gdbarch *gdbarch,
|
|
struct address_space *aspace);
|
|
|
|
friend void
|
|
registers_changed_ptid (process_stratum_target *target, ptid_t ptid);
|
|
};
|
|
|
|
class readonly_detached_regcache : public readable_regcache
|
|
{
|
|
public:
|
|
readonly_detached_regcache (regcache &src);
|
|
|
|
/* Create a readonly regcache by getting contents from COOKED_READ. */
|
|
|
|
readonly_detached_regcache (gdbarch *gdbarch, register_read_ftype cooked_read)
|
|
: readable_regcache (gdbarch, true)
|
|
{
|
|
save (cooked_read);
|
|
}
|
|
|
|
DISABLE_COPY_AND_ASSIGN (readonly_detached_regcache);
|
|
|
|
void raw_update (int regnum) override
|
|
{}
|
|
};
|
|
|
|
extern void registers_changed (void);
|
|
extern void registers_changed_ptid (process_stratum_target *target,
|
|
ptid_t ptid);
|
|
|
|
/* Indicate that registers of THREAD may have changed, so invalidate
|
|
the cache. */
|
|
extern void registers_changed_thread (thread_info *thread);
|
|
|
|
/* An abstract base class for register dump. */
|
|
|
|
class register_dump
|
|
{
|
|
public:
|
|
void dump (ui_file *file);
|
|
virtual ~register_dump () = default;
|
|
|
|
protected:
|
|
register_dump (gdbarch *arch)
|
|
: m_gdbarch (arch)
|
|
{}
|
|
|
|
/* Dump the register REGNUM contents. If REGNUM is -1, print the
|
|
header. */
|
|
virtual void dump_reg (ui_file *file, int regnum) = 0;
|
|
|
|
gdbarch *m_gdbarch;
|
|
};
|
|
|
|
#endif /* REGCACHE_H */
|