binutils-gdb/gdb/reverse.c
Pedro Alves 51abb42130 Kill init_sal
Instead, make symtab_and_line initialize its members itself.  Many
symtab_and_line declarations are moved to where the object is
initialized at the same time both for clarity and to avoid double
initialization.  A few functions, like e.g., find_frame_sal are
adjusted to return the sal using normal function return instead of an
output parameter likewise to avoid having to default-construct a sal
and then immediately have the object overwritten.

gdb/ChangeLog:
2017-09-04  Pedro Alves  <palves@redhat.com>

	* ada-lang.c (is_known_support_routine): Move sal declaration to
	where it is initialized.
	* breakpoint.c (create_internal_breakpoint, init_catchpoint)
	(parse_breakpoint_sals, decode_static_tracepoint_spec)
	(clear_command, update_static_tracepoint): Remove init_sal
	references.  Move declarations closer to initializations.
	* cli/cli-cmds.c (list_command): Move sal declarations closer to
	initializations.
	* elfread.c (elf_gnu_ifunc_resolver_stop): Remove init_sal
	references.  Move sal declarations closer to initializations.
	* frame.c (find_frame_sal): Return a symtab_and_line via function
	return instead of output parameter.  Remove init_sal references.
	* frame.h (find_frame_sal): Return a symtab_and_line via function
	return instead of output parameter.
	* guile/scm-frame.c (gdbscm_frame_sal): Adjust.
	* guile/scm-symtab.c (stscm_make_sal_smob): Use in-place new
	instead of memset.
	(gdbscm_find_pc_line): Remove init_sal reference.
	* infcall.c (call_function_by_hand_dummy): Remove init_sal
	references.  Move declarations closer to initializations.
	* infcmd.c (set_step_frame): Update.  Move declarations closer to
	initializations.
	(finish_backward): Remove init_sal references.  Move declarations
	closer to initializations.
	* infrun.c (process_event_stop_test, handle_step_into_function)
	(insert_hp_step_resume_breakpoint_at_frame)
	(insert_step_resume_breakpoint_at_caller): Likewise.
	* linespec.c (create_sals_line_offset, decode_digits_ordinary)
	(symbol_to_sal): Likewise.
	* probe.c (parse_probes_in_pspace): Remove init_sal reference.
	* python/py-frame.c (frapy_find_sal): Move sal declaration closer
	to its initialization.
	* reverse.c (save_bookmark_command): Use new/delete.  Remove
	init_sal references.  Move declarations closer to initializations.
	* source.c (get_current_source_symtab_and_line): Remove brace
	initialization.
	(set_current_source_symtab_and_line): Now takes the sal by const
	reference.  Remove brace initialization.
	(line_info): Remove init_sal reference.
	* source.h (set_current_source_symtab_and_line): Now takes a
	symtab_and_line via const reference.
	* stack.c (set_current_sal_from_frame): Adjust.
	(print_frame_info): Adjust.
	(get_last_displayed_sal): Return the sal via function return
	instead of via output parameter.  Simplify.
	(frame_info): Adjust.
	* stack.h (get_last_displayed_sal): Return the sal via function
	return instead of via output parameter.
	* symtab.c (init_sal): Delete.
	(find_pc_sect_line): Remove init_sal references.  Move
	declarations closer to initializations.
	(find_function_start_sal): Remove init_sal references.  Move
	declarations closer to initializations.
	* symtab.h (struct symtab_and_line): In-class initialize all
	fields.
	* tracepoint.c (set_traceframe_context)
	(print_one_static_tracepoint_marker): Remove init_sal references.
	Move declarations closer to initializations.
	* tui/tui-disasm.c (tui_show_disassem_and_update_source): Adjust.
	* tui/tui-stack.c (tui_show_frame_info): Adjust.  Move
	declarations closer to initializations.
	* tui/tui-winsource.c (tui_update_source_window_as_is): Remove
	init_sal references.  Adjust.
2017-09-04 17:11:45 +01:00

389 lines
10 KiB
C

/* Reverse execution and reverse debugging.
Copyright (C) 2006-2017 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "target.h"
#include "top.h"
#include "cli/cli-cmds.h"
#include "cli/cli-decode.h"
#include "cli/cli-utils.h"
#include "inferior.h"
#include "infrun.h"
#include "regcache.h"
/* User interface:
reverse-step, reverse-next etc. */
/* exec_reverse_once -- accepts an arbitrary gdb command (string),
and executes it with exec-direction set to 'reverse'.
Used to implement reverse-next etc. commands. */
static void
exec_reverse_once (const char *cmd, char *args, int from_tty)
{
enum exec_direction_kind dir = execution_direction;
if (dir == EXEC_REVERSE)
error (_("Already in reverse mode. Use '%s' or 'set exec-dir forward'."),
cmd);
if (!target_can_execute_reverse)
error (_("Target %s does not support this command."), target_shortname);
std::string reverse_command = string_printf ("%s %s", cmd, args ? args : "");
scoped_restore restore_exec_dir
= make_scoped_restore (&execution_direction, EXEC_REVERSE);
execute_command (&reverse_command[0], from_tty);
}
static void
reverse_step (char *args, int from_tty)
{
exec_reverse_once ("step", args, from_tty);
}
static void
reverse_stepi (char *args, int from_tty)
{
exec_reverse_once ("stepi", args, from_tty);
}
static void
reverse_next (char *args, int from_tty)
{
exec_reverse_once ("next", args, from_tty);
}
static void
reverse_nexti (char *args, int from_tty)
{
exec_reverse_once ("nexti", args, from_tty);
}
static void
reverse_continue (char *args, int from_tty)
{
exec_reverse_once ("continue", args, from_tty);
}
static void
reverse_finish (char *args, int from_tty)
{
exec_reverse_once ("finish", args, from_tty);
}
/* Data structures for a bookmark list. */
struct bookmark {
struct bookmark *next;
int number;
CORE_ADDR pc;
struct symtab_and_line sal;
gdb_byte *opaque_data;
};
static struct bookmark *bookmark_chain;
static int bookmark_count;
#define ALL_BOOKMARKS(B) for ((B) = bookmark_chain; (B); (B) = (B)->next)
#define ALL_BOOKMARKS_SAFE(B,TMP) \
for ((B) = bookmark_chain; \
(B) ? ((TMP) = (B)->next, 1) : 0; \
(B) = (TMP))
/* save_bookmark_command -- implement "bookmark" command.
Call target method to get a bookmark identifier.
Insert bookmark identifier into list.
Identifier will be a malloc string (gdb_byte *).
Up to us to free it as required. */
static void
save_bookmark_command (char *args, int from_tty)
{
/* Get target's idea of a bookmark. */
gdb_byte *bookmark_id = target_get_bookmark (args, from_tty);
struct gdbarch *gdbarch = get_regcache_arch (get_current_regcache ());
/* CR should not cause another identical bookmark. */
dont_repeat ();
if (bookmark_id == NULL)
error (_("target_get_bookmark failed."));
/* Set up a bookmark struct. */
bookmark *b = new bookmark ();
b->number = ++bookmark_count;
b->pc = regcache_read_pc (get_current_regcache ());
b->sal = find_pc_line (b->pc, 0);
b->sal.pspace = get_frame_program_space (get_current_frame ());
b->opaque_data = bookmark_id;
b->next = NULL;
/* Add this bookmark to the end of the chain, so that a list
of bookmarks will come out in order of increasing numbers. */
bookmark *b1 = bookmark_chain;
if (b1 == 0)
bookmark_chain = b;
else
{
while (b1->next)
b1 = b1->next;
b1->next = b;
}
printf_filtered (_("Saved bookmark %d at %s\n"), b->number,
paddress (gdbarch, b->sal.pc));
}
/* Implement "delete bookmark" command. */
static int
delete_one_bookmark (int num)
{
struct bookmark *b1, *b;
/* Find bookmark with corresponding number. */
ALL_BOOKMARKS (b)
if (b->number == num)
break;
/* Special case, first item in list. */
if (b == bookmark_chain)
bookmark_chain = b->next;
/* Find bookmark preceding "marked" one, so we can unlink. */
if (b)
{
ALL_BOOKMARKS (b1)
if (b1->next == b)
{
/* Found designated bookmark. Unlink and delete. */
b1->next = b->next;
break;
}
xfree (b->opaque_data);
delete b;
return 1; /* success */
}
return 0; /* failure */
}
static void
delete_all_bookmarks (void)
{
struct bookmark *b, *b1;
ALL_BOOKMARKS_SAFE (b, b1)
{
xfree (b->opaque_data);
xfree (b);
}
bookmark_chain = NULL;
}
static void
delete_bookmark_command (char *args, int from_tty)
{
if (bookmark_chain == NULL)
{
warning (_("No bookmarks."));
return;
}
if (args == NULL || args[0] == '\0')
{
if (from_tty && !query (_("Delete all bookmarks? ")))
return;
delete_all_bookmarks ();
return;
}
number_or_range_parser parser (args);
while (!parser.finished ())
{
int num = parser.get_number ();
if (!delete_one_bookmark (num))
/* Not found. */
warning (_("No bookmark #%d."), num);
}
}
/* Implement "goto-bookmark" command. */
static void
goto_bookmark_command (char *args, int from_tty)
{
struct bookmark *b;
unsigned long num;
char *p = args;
if (args == NULL || args[0] == '\0')
error (_("Command requires an argument."));
if (startswith (args, "start")
|| startswith (args, "begin")
|| startswith (args, "end"))
{
/* Special case. Give target opportunity to handle. */
target_goto_bookmark ((gdb_byte *) args, from_tty);
return;
}
if (args[0] == '\'' || args[0] == '\"')
{
/* Special case -- quoted string. Pass on to target. */
if (args[strlen (args) - 1] != args[0])
error (_("Unbalanced quotes: %s"), args);
target_goto_bookmark ((gdb_byte *) args, from_tty);
return;
}
/* General case. Bookmark identified by bookmark number. */
num = get_number (&args);
if (num == 0)
error (_("goto-bookmark: invalid bookmark number '%s'."), p);
ALL_BOOKMARKS (b)
if (b->number == num)
break;
if (b)
{
/* Found. Send to target method. */
target_goto_bookmark (b->opaque_data, from_tty);
return;
}
/* Not found. */
error (_("goto-bookmark: no bookmark found for '%s'."), p);
}
static int
bookmark_1 (int bnum)
{
struct gdbarch *gdbarch = get_regcache_arch (get_current_regcache ());
struct bookmark *b;
int matched = 0;
ALL_BOOKMARKS (b)
{
if (bnum == -1 || bnum == b->number)
{
printf_filtered (" %d %s '%s'\n",
b->number,
paddress (gdbarch, b->pc),
b->opaque_data);
matched++;
}
}
if (bnum > 0 && matched == 0)
printf_filtered ("No bookmark #%d\n", bnum);
return matched;
}
/* Implement "info bookmarks" command. */
static void
info_bookmarks_command (char *args, int from_tty)
{
if (!bookmark_chain)
printf_filtered (_("No bookmarks.\n"));
else if (args == NULL || *args == '\0')
bookmark_1 (-1);
else
{
number_or_range_parser parser (args);
while (!parser.finished ())
{
int bnum = parser.get_number ();
bookmark_1 (bnum);
}
}
}
/* Provide a prototype to silence -Wmissing-prototypes. */
extern initialize_file_ftype _initialize_reverse;
void
_initialize_reverse (void)
{
add_com ("reverse-step", class_run, reverse_step, _("\
Step program backward until it reaches the beginning of another source line.\n\
Argument N means do this N times (or till program stops for another reason).")
);
add_com_alias ("rs", "reverse-step", class_alias, 1);
add_com ("reverse-next", class_run, reverse_next, _("\
Step program backward, proceeding through subroutine calls.\n\
Like the \"reverse-step\" command as long as subroutine calls do not happen;\n\
when they do, the call is treated as one instruction.\n\
Argument N means do this N times (or till program stops for another reason).")
);
add_com_alias ("rn", "reverse-next", class_alias, 1);
add_com ("reverse-stepi", class_run, reverse_stepi, _("\
Step backward exactly one instruction.\n\
Argument N means do this N times (or till program stops for another reason).")
);
add_com_alias ("rsi", "reverse-stepi", class_alias, 0);
add_com ("reverse-nexti", class_run, reverse_nexti, _("\
Step backward one instruction, but proceed through called subroutines.\n\
Argument N means do this N times (or till program stops for another reason).")
);
add_com_alias ("rni", "reverse-nexti", class_alias, 0);
add_com ("reverse-continue", class_run, reverse_continue, _("\
Continue program being debugged but run it in reverse.\n\
If proceeding from breakpoint, a number N may be used as an argument,\n\
which means to set the ignore count of that breakpoint to N - 1 (so that\n\
the breakpoint won't break until the Nth time it is reached)."));
add_com_alias ("rc", "reverse-continue", class_alias, 0);
add_com ("reverse-finish", class_run, reverse_finish, _("\
Execute backward until just before selected stack frame is called."));
add_com ("bookmark", class_bookmark, save_bookmark_command, _("\
Set a bookmark in the program's execution history.\n\
A bookmark represents a point in the execution history \n\
that can be returned to at a later point in the debug session."));
add_info ("bookmarks", info_bookmarks_command, _("\
Status of user-settable bookmarks.\n\
Bookmarks are user-settable markers representing a point in the \n\
execution history that can be returned to later in the same debug \n\
session."));
add_cmd ("bookmark", class_bookmark, delete_bookmark_command, _("\
Delete a bookmark from the bookmark list.\n\
Argument is a bookmark number or numbers,\n\
or no argument to delete all bookmarks.\n"),
&deletelist);
add_com ("goto-bookmark", class_bookmark, goto_bookmark_command, _("\
Go to an earlier-bookmarked point in the program's execution history.\n\
Argument is the bookmark number of a bookmark saved earlier by using \n\
the 'bookmark' command, or the special arguments:\n\
start (beginning of recording)\n\
end (end of recording)\n"));
}