binutils-gdb/gdb/testsuite/boards
Pedro Alves 5b80f00d51 gdb_load: Fix latent bugs
In a test I was writting, I needed a procedure that would connect to
the target, and do "load", or equivalent.

Years ago, boards would override gdb_load to implement that.  Then
gdb_reload was added, and gdb_load was relaxed to allow boards avoid
the spawing and connecting to the target.  This sped up gdbserver
testing.  See
https://www.sourceware.org/ml/gdb-patches/2007-02/msg00318.html.

To actually spawn the target and load the executable on the target
side, gdb_reload was born:

 # gdb_reload -- load a file into the target.  Called before "running",
 # either the first time or after already starting the program once,
 # for remote targets.  Most files that override gdb_load should now
 # override this instead.

 proc gdb_reload { } {
     # For the benefit of existing configurations, default to gdb_load.
     # Specifying no file defaults to the executable currently being
     # debugged.
     return [gdb_load ""]
 }

Note the comment about specifying no file.  Indeed looking at
config/sid.exp, or config/monitor.exp, we see examples of that.

However, the default gdb_load itself doesn't handle the case of no
file specified.  When passed no file, it just calls gdb_file_cmd with
no file either, which ends up invocing the "file" command with no
argument, which means unloading the file and its symbols...  That
means calling gdb_reload when testing against native targets is
broken.  We don't see that today because the only call to gdb_reload
that exists today is guarded by target_info exists
gdb,do_reload_on_run.

The native-extended-gdbserver.exp board is likewise broken here.  When
[gdb_load ""] is called, the board sets the remote exec-file to "" ...

Tested on x86_64 Fedora 17, native, remote gdbserver and
extended-remote gdbserver.

testsuite/
2014-05-01  Pedro Alves  <palves@redhat.com>

	* lib/gdb.exp (gdb_load): Extend comment.  Skip calling
	gdb_file_cmd if no file is specified.
	* boards/native-extended-gdbserver.exp (gdb_load): Use the
	last_loaded_file to set the remote exec-file.
2014-05-02 00:59:31 +01:00
..
cc-with-tweaks.exp Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
dwarf4-gdb-index.exp Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
fission-dwp.exp Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
fission.exp Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
gdbserver-base.exp Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
local-remote-host-notty.exp Rename testsuite/boards/local-remote-host.exp -> testsuite/boards/local-remote-host-notty.exp 2014-05-01 17:25:51 +01:00
local-remote-host.exp New testsuite/boards/local-remote-host.exp board, now with editing on 2014-05-01 17:25:52 +01:00
native-extended-gdbserver.exp gdb_load: Fix latent bugs 2014-05-02 00:59:31 +01:00
native-gdbserver.exp Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
native-stdio-gdbserver.exp Fix wrapper.exp testcase with stdio gdbserver. 2014-04-16 10:40:41 -07:00
remote-stdio-gdbserver.exp Fix wrapper.exp testcase with stdio gdbserver. 2014-04-16 10:40:41 -07:00