9a3c826307
Note: I needed to split this patch in two, otherwise it's too big for the mailing list. This patch adds explicit casts to situations where a void pointer is assigned to a pointer to the "real" type. Building in C++ mode requires those assignments to use an explicit cast. This includes, for example: - callback arguments (cleanups, comparison functions, ...) - data attached to some object (objfile, program space, etc) in the form of a void pointer - "user data" passed to some function This patch comes from the commit "(mostly) auto-generated patch to insert casts needed for C++", taken from Pedro's C++ branch. Only files built on x86 with --enable-targets=all are modified, so the native files for other arches will need to be dealt with separately. I built-tested this with --enable-targets=all and reg-tested. To my surprise, a test case (selftest.exp) had to be adjusted. Here's the ChangeLog entry. Again, this was relatively quick to make despite the length, thanks to David Malcom's script, although I don't believe it's very useful information in that particular case... gdb/ChangeLog: * aarch64-tdep.c (aarch64_make_prologue_cache): Add cast(s). (aarch64_make_stub_cache): Likewise. (value_of_aarch64_user_reg): Likewise. * ada-lang.c (ada_inferior_data_cleanup): Likewise. (get_ada_inferior_data): Likewise. (get_ada_pspace_data): Likewise. (ada_pspace_data_cleanup): Likewise. (ada_complete_symbol_matcher): Likewise. (ada_exc_search_name_matches): Likewise. * ada-tasks.c (get_ada_tasks_pspace_data): Likewise. (get_ada_tasks_inferior_data): Likewise. * addrmap.c (addrmap_mutable_foreach_worker): Likewise. (splay_obstack_alloc): Likewise. (splay_obstack_free): Likewise. * alpha-linux-tdep.c (alpha_linux_supply_gregset): Likewise. (alpha_linux_collect_gregset): Likewise. (alpha_linux_supply_fpregset): Likewise. (alpha_linux_collect_fpregset): Likewise. * alpha-mdebug-tdep.c (alpha_mdebug_frame_unwind_cache): Likewise. * alpha-tdep.c (alpha_lds): Likewise. (alpha_sts): Likewise. (alpha_sigtramp_frame_unwind_cache): Likewise. (alpha_heuristic_frame_unwind_cache): Likewise. (alpha_supply_int_regs): Likewise. (alpha_fill_int_regs): Likewise. (alpha_supply_fp_regs): Likewise. (alpha_fill_fp_regs): Likewise. * alphanbsd-tdep.c (alphanbsd_supply_fpregset): Likewise. (alphanbsd_aout_supply_gregset): Likewise. (alphanbsd_supply_gregset): Likewise. * amd64-linux-tdep.c (amd64_linux_init_abi): Likewise. (amd64_x32_linux_init_abi): Likewise. * amd64-nat.c (amd64_supply_native_gregset): Likewise. (amd64_collect_native_gregset): Likewise. * amd64-tdep.c (amd64_frame_cache): Likewise. (amd64_sigtramp_frame_cache): Likewise. (amd64_epilogue_frame_cache): Likewise. (amd64_supply_fxsave): Likewise. (amd64_supply_xsave): Likewise. (amd64_collect_fxsave): Likewise. (amd64_collect_xsave): Likewise. * amd64-windows-tdep.c (amd64_windows_frame_cache): Likewise. * amd64obsd-tdep.c (amd64obsd_trapframe_cache): Likewise. * arm-linux-tdep.c (arm_linux_supply_gregset): Likewise. (arm_linux_collect_gregset): Likewise. (arm_linux_supply_nwfpe): Likewise. (arm_linux_collect_nwfpe): Likewise. (arm_linux_supply_vfp): Likewise. (arm_linux_collect_vfp): Likewise. * arm-tdep.c (arm_find_mapping_symbol): Likewise. (arm_prologue_unwind_stop_reason): Likewise. (arm_prologue_this_id): Likewise. (arm_prologue_prev_register): Likewise. (arm_exidx_data_free): Likewise. (arm_find_exidx_entry): Likewise. (arm_stub_this_id): Likewise. (arm_m_exception_this_id): Likewise. (arm_m_exception_prev_register): Likewise. (arm_normal_frame_base): Likewise. (gdb_print_insn_arm): Likewise. (arm_objfile_data_free): Likewise. (arm_record_special_symbol): Likewise. (value_of_arm_user_reg): Likewise. * armbsd-tdep.c (armbsd_supply_fpregset): Likewise. (armbsd_supply_gregset): Likewise. * auto-load.c (auto_load_pspace_data_cleanup): Likewise. (get_auto_load_pspace_data): Likewise. (hash_loaded_script_entry): Likewise. (eq_loaded_script_entry): Likewise. (clear_section_scripts): Likewise. (collect_matching_scripts): Likewise. * auxv.c (auxv_inferior_data_cleanup): Likewise. (get_auxv_inferior_data): Likewise. * avr-tdep.c (avr_frame_unwind_cache): Likewise. * ax-general.c (do_free_agent_expr_cleanup): Likewise. * bfd-target.c (target_bfd_xfer_partial): Likewise. (target_bfd_xclose): Likewise. (target_bfd_get_section_table): Likewise. * bfin-tdep.c (bfin_frame_cache): Likewise. * block.c (find_block_in_blockvector): Likewise. (call_site_for_pc): Likewise. (block_find_non_opaque_type_preferred): Likewise. * break-catch-sig.c (signal_catchpoint_insert_location): Likewise. (signal_catchpoint_remove_location): Likewise. (signal_catchpoint_breakpoint_hit): Likewise. (signal_catchpoint_print_one): Likewise. (signal_catchpoint_print_mention): Likewise. (signal_catchpoint_print_recreate): Likewise. * break-catch-syscall.c (get_catch_syscall_inferior_data): Likewise. * breakpoint.c (do_cleanup_counted_command_line): Likewise. (bp_location_compare_addrs): Likewise. (get_first_locp_gte_addr): Likewise. (check_tracepoint_command): Likewise. (do_map_commands_command): Likewise. (get_breakpoint_objfile_data): Likewise. (free_breakpoint_probes): Likewise. (do_captured_breakpoint_query): Likewise. (compare_breakpoints): Likewise. (bp_location_compare): Likewise. (bpstat_remove_breakpoint_callback): Likewise. (do_delete_breakpoint_cleanup): Likewise. * bsd-uthread.c (bsd_uthread_set_supply_uthread): Likewise. (bsd_uthread_set_collect_uthread): Likewise. (bsd_uthread_activate): Likewise. (bsd_uthread_fetch_registers): Likewise. (bsd_uthread_store_registers): Likewise. * btrace.c (check_xml_btrace_version): Likewise. (parse_xml_btrace_block): Likewise. (parse_xml_btrace_pt_config_cpu): Likewise. (parse_xml_btrace_pt_raw): Likewise. (parse_xml_btrace_pt): Likewise. (parse_xml_btrace_conf_bts): Likewise. (parse_xml_btrace_conf_pt): Likewise. (do_btrace_data_cleanup): Likewise. * c-typeprint.c (find_typedef_for_canonicalize): Likewise. * charset.c (cleanup_iconv): Likewise. (do_cleanup_iterator): Likewise. * cli-out.c (cli_uiout_dtor): Likewise. (cli_table_begin): Likewise. (cli_table_body): Likewise. (cli_table_end): Likewise. (cli_table_header): Likewise. (cli_begin): Likewise. (cli_end): Likewise. (cli_field_int): Likewise. (cli_field_skip): Likewise. (cli_field_string): Likewise. (cli_field_fmt): Likewise. (cli_spaces): Likewise. (cli_text): Likewise. (cli_message): Likewise. (cli_wrap_hint): Likewise. (cli_flush): Likewise. (cli_redirect): Likewise. (out_field_fmt): Likewise. (field_separator): Likewise. (cli_out_set_stream): Likewise. * cli/cli-cmds.c (compare_symtabs): Likewise. * cli/cli-dump.c (call_dump_func): Likewise. (restore_section_callback): Likewise. * cli/cli-script.c (clear_hook_in_cleanup): Likewise. (do_restore_user_call_depth): Likewise. (do_free_command_lines_cleanup): Likewise. * coff-pe-read.c (get_section_vmas): Likewise. (pe_as16): Likewise. (pe_as32): Likewise. * coffread.c (coff_symfile_read): Likewise. * common/agent.c (agent_look_up_symbols): Likewise. * common/filestuff.c (do_close_cleanup): Likewise. * common/format.c (free_format_pieces_cleanup): Likewise. * common/vec.c (vec_o_reserve): Likewise. * compile/compile-c-support.c (print_one_macro): Likewise. * compile/compile-c-symbols.c (hash_symbol_error): Likewise. (eq_symbol_error): Likewise. (del_symbol_error): Likewise. (error_symbol_once): Likewise. (gcc_convert_symbol): Likewise. (gcc_symbol_address): Likewise. (hash_symname): Likewise. (eq_symname): Likewise. * compile/compile-c-types.c (hash_type_map_instance): Likewise. (eq_type_map_instance): Likewise. (insert_type): Likewise. (convert_type): Likewise. * compile/compile-object-load.c (munmap_listp_free_cleanup): Likewise. (setup_sections): Likewise. (link_hash_table_free): Likewise. (copy_sections): Likewise. * compile/compile-object-run.c (do_module_cleanup): Likewise. * compile/compile.c (compile_print_value): Likewise. (do_rmdir): Likewise. (cleanup_compile_instance): Likewise. (cleanup_unlink_file): Likewise. * completer.c (free_completion_tracker): Likewise. * corelow.c (add_to_spuid_list): Likewise. * cp-namespace.c (reset_directive_searched): Likewise. * cp-support.c (reset_directive_searched): Likewise. * cris-tdep.c (cris_sigtramp_frame_unwind_cache): Likewise. (cris_frame_unwind_cache): Likewise. * d-lang.c (builtin_d_type): Likewise. * d-namespace.c (reset_directive_searched): Likewise. * dbxread.c (dbx_free_symfile_info): Likewise. (do_free_bincl_list_cleanup): Likewise. * disasm.c (hash_dis_line_entry): Likewise. (eq_dis_line_entry): Likewise. (dis_asm_print_address): Likewise. (fprintf_disasm): Likewise. (do_ui_file_delete): Likewise. * doublest.c (convert_floatformat_to_doublest): Likewise. * dummy-frame.c (pop_dummy_frame_bpt): Likewise. (dummy_frame_prev_register): Likewise. (dummy_frame_this_id): Likewise. * dwarf2-frame-tailcall.c (cache_hash): Likewise. (cache_eq): Likewise. (cache_find): Likewise. (tailcall_frame_this_id): Likewise. (dwarf2_tailcall_prev_register_first): Likewise. (tailcall_frame_prev_register): Likewise. (tailcall_frame_dealloc_cache): Likewise. (tailcall_frame_prev_arch): Likewise. * dwarf2-frame.c (dwarf2_frame_state_free): Likewise. (dwarf2_frame_set_init_reg): Likewise. (dwarf2_frame_init_reg): Likewise. (dwarf2_frame_set_signal_frame_p): Likewise. (dwarf2_frame_signal_frame_p): Likewise. (dwarf2_frame_set_adjust_regnum): Likewise. (dwarf2_frame_adjust_regnum): Likewise. (clear_pointer_cleanup): Likewise. (dwarf2_frame_cache): Likewise. (find_cie): Likewise. (dwarf2_frame_find_fde): Likewise. * dwarf2expr.c (dwarf_expr_address_type): Likewise. (free_dwarf_expr_context_cleanup): Likewise. * dwarf2loc.c (locexpr_find_frame_base_location): Likewise. (locexpr_get_frame_base): Likewise. (loclist_find_frame_base_location): Likewise. (loclist_get_frame_base): Likewise. (dwarf_expr_dwarf_call): Likewise. (dwarf_expr_get_base_type): Likewise. (dwarf_expr_push_dwarf_reg_entry_value): Likewise. (dwarf_expr_get_obj_addr): Likewise. (entry_data_value_coerce_ref): Likewise. (entry_data_value_copy_closure): Likewise. (entry_data_value_free_closure): Likewise. (get_frame_address_in_block_wrapper): Likewise. (dwarf2_evaluate_property): Likewise. (dwarf2_compile_property_to_c): Likewise. (needs_frame_read_addr_from_reg): Likewise. (needs_frame_get_reg_value): Likewise. (needs_frame_frame_base): Likewise. (needs_frame_frame_cfa): Likewise. (needs_frame_tls_address): Likewise. (needs_frame_dwarf_call): Likewise. (needs_dwarf_reg_entry_value): Likewise. (get_ax_pc): Likewise. (locexpr_read_variable): Likewise. (locexpr_read_variable_at_entry): Likewise. (locexpr_read_needs_frame): Likewise. (locexpr_describe_location): Likewise. (locexpr_tracepoint_var_ref): Likewise. (locexpr_generate_c_location): Likewise. (loclist_read_variable): Likewise. (loclist_read_variable_at_entry): Likewise. (loclist_describe_location): Likewise. (loclist_tracepoint_var_ref): Likewise. (loclist_generate_c_location): Likewise. * dwarf2read.c (line_header_hash_voidp): Likewise. (line_header_eq_voidp): Likewise. (dwarf2_has_info): Likewise. (dwarf2_get_section_info): Likewise. (locate_dwz_sections): Likewise. (hash_file_name_entry): Likewise. (eq_file_name_entry): Likewise. (delete_file_name_entry): Likewise. (dw2_setup): Likewise. (dw2_get_file_names_reader): Likewise. (dw2_find_pc_sect_compunit_symtab): Likewise. (hash_signatured_type): Likewise. (eq_signatured_type): Likewise. (add_signatured_type_cu_to_table): Likewise. (create_debug_types_hash_table): Likewise. (lookup_dwo_signatured_type): Likewise. (lookup_dwp_signatured_type): Likewise. (lookup_signatured_type): Likewise. (hash_type_unit_group): Likewise. (eq_type_unit_group): Likewise. (get_type_unit_group): Likewise. (process_psymtab_comp_unit_reader): Likewise. (sort_tu_by_abbrev_offset): Likewise. (process_skeletonless_type_unit): Likewise. (psymtabs_addrmap_cleanup): Likewise. (dwarf2_read_symtab): Likewise. (psymtab_to_symtab_1): Likewise. (die_hash): Likewise. (die_eq): Likewise. (load_full_comp_unit_reader): Likewise. (reset_die_in_process): Likewise. (free_cu_line_header): Likewise. (handle_DW_AT_stmt_list): Likewise. (hash_dwo_file): Likewise. (eq_dwo_file): Likewise. (hash_dwo_unit): Likewise. (eq_dwo_unit): Likewise. (create_dwo_cu_reader): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (lookup_dwo_unit_in_dwp): Likewise. (dwarf2_locate_dwo_sections): Likewise. (dwarf2_locate_common_dwp_sections): Likewise. (dwarf2_locate_v2_dwp_sections): Likewise. (hash_dwp_loaded_cutus): Likewise. (eq_dwp_loaded_cutus): Likewise. (lookup_dwo_cutu): Likewise. (abbrev_table_free_cleanup): Likewise. (dwarf2_free_abbrev_table): Likewise. (find_partial_die_in_comp_unit): Likewise. (free_line_header_voidp): Likewise. (follow_die_offset): Likewise. (follow_die_sig_1): Likewise. (free_heap_comp_unit): Likewise. (free_stack_comp_unit): Likewise. (dwarf2_free_objfile): Likewise. (per_cu_offset_and_type_hash): Likewise. (per_cu_offset_and_type_eq): Likewise. (get_die_type_at_offset): Likewise. (partial_die_hash): Likewise. (partial_die_eq): Likewise. (dwarf2_per_objfile_free): Likewise. (hash_strtab_entry): Likewise. (eq_strtab_entry): Likewise. (add_string): Likewise. (hash_symtab_entry): Likewise. (eq_symtab_entry): Likewise. (delete_symtab_entry): Likewise. (cleanup_mapped_symtab): Likewise. (add_indices_to_cpool): Likewise. (hash_psymtab_cu_index): Likewise. (eq_psymtab_cu_index): Likewise. (add_address_entry_worker): Likewise. (unlink_if_set): Likewise. (write_one_signatured_type): Likewise. (save_gdb_index_command): Likewise. * elfread.c (elf_symtab_read): Likewise. (elf_gnu_ifunc_cache_hash): Likewise. (elf_gnu_ifunc_cache_eq): Likewise. (elf_gnu_ifunc_record_cache): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_get_probes): Likewise. (probe_key_free): Likewise. * f-lang.c (builtin_f_type): Likewise. * frame-base.c (frame_base_append_sniffer): Likewise. (frame_base_set_default): Likewise. (frame_base_find_by_frame): Likewise. * frame-unwind.c (frame_unwind_prepend_unwinder): Likewise. (frame_unwind_append_unwinder): Likewise. (frame_unwind_find_by_frame): Likewise. * frame.c (frame_addr_hash): Likewise. (frame_addr_hash_eq): Likewise. (frame_stash_find): Likewise. (do_frame_register_read): Likewise. (unwind_to_current_frame): Likewise. (frame_cleanup_after_sniffer): Likewise. * frv-linux-tdep.c (frv_linux_sigtramp_frame_cache): Likewise. * frv-tdep.c (frv_frame_unwind_cache): Likewise. * ft32-tdep.c (ft32_frame_cache): Likewise. * gcore.c (do_bfd_delete_cleanup): Likewise. (gcore_create_callback): Likewise. * gdb_bfd.c (hash_bfd): Likewise. (eq_bfd): Likewise. (gdb_bfd_open): Likewise. (free_one_bfd_section): Likewise. (gdb_bfd_ref): Likewise. (gdb_bfd_unref): Likewise. (get_section_descriptor): Likewise. (gdb_bfd_map_section): Likewise. (gdb_bfd_crc): Likewise. (gdb_bfd_mark_parent): Likewise. (gdb_bfd_record_inclusion): Likewise. (gdb_bfd_requires_relocations): Likewise. (print_one_bfd): Likewise. * gdbtypes.c (type_pair_hash): Likewise. (type_pair_eq): Likewise. (builtin_type): Likewise. (objfile_type): Likewise. * gnu-v3-abi.c (vtable_ptrdiff_type): Likewise. (vtable_address_point_offset): Likewise. (gnuv3_get_vtable): Likewise. (hash_value_and_voffset): Likewise. (eq_value_and_voffset): Likewise. (compare_value_and_voffset): Likewise. (compute_vtable_size): Likewise. (gnuv3_get_typeid_type): Likewise. * go-lang.c (builtin_go_type): Likewise. * guile/scm-block.c (bkscm_hash_block_smob): Likewise. (bkscm_eq_block_smob): Likewise. (bkscm_objfile_block_map): Likewise. (bkscm_del_objfile_blocks): Likewise. * guile/scm-breakpoint.c (bpscm_build_bp_list): Likewise. * guile/scm-disasm.c (gdbscm_disasm_read_memory_worker): Likewise. (gdbscm_disasm_print_address): Likewise. * guile/scm-frame.c (frscm_hash_frame_smob): Likewise. (frscm_eq_frame_smob): Likewise. (frscm_inferior_frame_map): Likewise. (frscm_del_inferior_frames): Likewise. * guile/scm-gsmob.c (gdbscm_add_objfile_ref): Likewise. * guile/scm-objfile.c (ofscm_handle_objfile_deleted): Likewise. (ofscm_objfile_smob_from_objfile): Likewise. * guile/scm-ports.c (ioscm_write): Likewise. (ioscm_file_port_delete): Likewise. (ioscm_file_port_rewind): Likewise. (ioscm_file_port_put): Likewise. (ioscm_file_port_write): Likewise. * guile/scm-progspace.c (psscm_handle_pspace_deleted): Likewise. (psscm_pspace_smob_from_pspace): Likewise. * guile/scm-safe-call.c (scscm_recording_pre_unwind_handler): Likewise. (scscm_recording_unwind_handler): Likewise. (gdbscm_with_catch): Likewise. (scscm_call_0_body): Likewise. (scscm_call_1_body): Likewise. (scscm_call_2_body): Likewise. (scscm_call_3_body): Likewise. (scscm_call_4_body): Likewise. (scscm_apply_1_body): Likewise. (scscm_eval_scheme_string): Likewise. (gdbscm_safe_eval_string): Likewise. (scscm_source_scheme_script): Likewise. (gdbscm_safe_source_script): Likewise. * guile/scm-string.c (gdbscm_call_scm_to_stringn): Likewise. (gdbscm_call_scm_from_stringn): Likewise. * guile/scm-symbol.c (syscm_hash_symbol_smob): Likewise. (syscm_eq_symbol_smob): Likewise. (syscm_get_symbol_map): Likewise. (syscm_del_objfile_symbols): Likewise. * guile/scm-symtab.c (stscm_hash_symtab_smob): Likewise. (stscm_eq_symtab_smob): Likewise. (stscm_objfile_symtab_map): Likewise. (stscm_del_objfile_symtabs): Likewise. * guile/scm-type.c (tyscm_hash_type_smob): Likewise. (tyscm_eq_type_smob): Likewise. (tyscm_type_map): Likewise. (tyscm_copy_type_recursive): Likewise. (save_objfile_types): Likewise. * guile/scm-utils.c (extract_arg): Likewise. * h8300-tdep.c (h8300_frame_cache): Likewise. * hppa-linux-tdep.c (hppa_linux_sigtramp_frame_unwind_cache): Likewise. * hppa-tdep.c (compare_unwind_entries): Likewise. (find_unwind_entry): Likewise. (hppa_frame_cache): Likewise. (hppa_stub_frame_unwind_cache): Likewise. * hppanbsd-tdep.c (hppanbsd_supply_gregset): Likewise. * hppaobsd-tdep.c (hppaobsd_supply_gregset): Likewise. (hppaobsd_supply_fpregset): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. * i386-linux-tdep.c (i386_linux_init_abi): Likewise. * i386-tdep.c (i386_frame_cache): Likewise. (i386_epilogue_frame_cache): Likewise. (i386_sigtramp_frame_cache): Likewise. (i386_supply_gregset): Likewise. (i386_collect_gregset): Likewise. (i386_gdbarch_init): Likewise. * i386obsd-tdep.c (i386obsd_aout_supply_regset): Likewise. (i386obsd_trapframe_cache): Likewise. * i387-tdep.c (i387_supply_fsave): Likewise. (i387_collect_fsave): Likewise. (i387_supply_fxsave): Likewise. (i387_collect_fxsave): Likewise. (i387_supply_xsave): Likewise. (i387_collect_xsave): Likewise. * ia64-tdep.c (ia64_frame_cache): Likewise. (ia64_sigtramp_frame_cache): Likewise. * infcmd.c (attach_command_continuation): Likewise. (attach_command_continuation_free_args): Likewise. * inferior.c (restore_inferior): Likewise. (delete_thread_of_inferior): Likewise. * inflow.c (inflow_inferior_data_cleanup): Likewise. (get_inflow_inferior_data): Likewise. (inflow_inferior_exit): Likewise. * infrun.c (displaced_step_clear_cleanup): Likewise. (restore_current_uiout_cleanup): Likewise. (release_stop_context_cleanup): Likewise. (do_restore_infcall_suspend_state_cleanup): Likewise. (do_restore_infcall_control_state_cleanup): Likewise. (restore_inferior_ptid): Likewise. * inline-frame.c (block_starting_point_at): Likewise. * iq2000-tdep.c (iq2000_frame_cache): Likewise. * jit.c (get_jit_objfile_data): Likewise. (get_jit_program_space_data): Likewise. (jit_object_close_impl): Likewise. (jit_find_objf_with_entry_addr): Likewise. (jit_breakpoint_deleted): Likewise. (jit_unwind_reg_set_impl): Likewise. (jit_unwind_reg_get_impl): Likewise. (jit_dealloc_cache): Likewise. (jit_frame_sniffer): Likewise. (jit_frame_prev_register): Likewise. (jit_prepend_unwinder): Likewise. (jit_inferior_exit_hook): Likewise. (free_objfile_data): Likewise. * jv-lang.c (jv_per_objfile_free): Likewise. (get_dynamics_objfile): Likewise. (get_java_class_symtab): Likewise. (builtin_java_type): Likewise. * language.c (language_string_char_type): Likewise. (language_bool_type): Likewise. (language_lookup_primitive_type): Likewise. (language_lookup_primitive_type_as_symbol): Likewise. * linespec.c (hash_address_entry): Likewise. (eq_address_entry): Likewise. (iterate_inline_only): Likewise. (iterate_name_matcher): Likewise. (decode_line_2_compare_items): Likewise. (collect_one_symbol): Likewise. (compare_symbols): Likewise. (compare_msymbols): Likewise. (add_symtabs_to_list): Likewise. (collect_symbols): Likewise. (compare_msyms): Likewise. (add_minsym): Likewise. (cleanup_linespec_result): Likewise. * linux-fork.c (inferior_call_waitpid_cleanup): Likewise. * linux-nat.c (delete_lwp_cleanup): Likewise. (count_events_callback): Likewise. (select_event_lwp_callback): Likewise. (resume_stopped_resumed_lwps): Likewise. * linux-tdep.c (get_linux_gdbarch_data): Likewise. (invalidate_linux_cache_inf): Likewise. (get_linux_inferior_data): Likewise. (linux_find_memory_regions_thunk): Likewise. (linux_make_mappings_callback): Likewise. (linux_corefile_thread_callback): Likewise. (find_mapping_size): Likewise. * linux-thread-db.c (find_new_threads_callback): Likewise. * lm32-tdep.c (lm32_frame_cache): Likewise. * m2-lang.c (builtin_m2_type): Likewise. * m32c-tdep.c (m32c_analyze_frame_prologue): Likewise. * m32r-linux-tdep.c (m32r_linux_sigtramp_frame_cache): Likewise. (m32r_linux_supply_gregset): Likewise. (m32r_linux_collect_gregset): Likewise. * m32r-tdep.c (m32r_frame_unwind_cache): Likewise. * m68hc11-tdep.c (m68hc11_frame_unwind_cache): Likewise. * m68k-tdep.c (m68k_frame_cache): Likewise. * m68kbsd-tdep.c (m68kbsd_supply_fpregset): Likewise. (m68kbsd_supply_gregset): Likewise. * m68klinux-tdep.c (m68k_linux_sigtramp_frame_cache): Likewise. * m88k-tdep.c (m88k_frame_cache): Likewise. (m88k_supply_gregset): Likewise. gdb/gdbserver/ChangeLog: * dll.c (match_dll): Add cast(s). (unloaded_dll): Likewise. * linux-low.c (second_thread_of_pid_p): Likewise. (delete_lwp_callback): Likewise. (count_events_callback): Likewise. (select_event_lwp_callback): Likewise. (linux_set_resume_request): Likewise. * server.c (accumulate_file_name_length): Likewise. (emit_dll_description): Likewise. (handle_qxfer_threads_worker): Likewise. (visit_actioned_threads): Likewise. * thread-db.c (any_thread_of): Likewise. * tracepoint.c (same_process_p): Likewise. (match_blocktype): Likewise. (build_traceframe_info_xml): Likewise. gdb/testsuite/ChangeLog: * gdb.gdb/selftest.exp (do_steps_and_nexts): Adjust expected source line.
719 lines
22 KiB
C
719 lines
22 KiB
C
/* Read the export table symbols from a portable executable and
|
||
convert to internal format, for GDB. Used as a last resort if no
|
||
debugging symbols recognized.
|
||
|
||
Copyright (C) 2003-2015 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||
|
||
Contributed by Raoul M. Gough (RaoulGough@yahoo.co.uk). */
|
||
|
||
#include "defs.h"
|
||
|
||
#include "coff-pe-read.h"
|
||
|
||
#include "bfd.h"
|
||
#include "gdbtypes.h"
|
||
|
||
#include "command.h"
|
||
#include "gdbcmd.h"
|
||
#include "symtab.h"
|
||
#include "symfile.h"
|
||
#include "objfiles.h"
|
||
#include "common/common-utils.h"
|
||
#include "coff/internal.h"
|
||
|
||
#include <ctype.h>
|
||
|
||
/* Internal section information */
|
||
|
||
/* Coff PE read debugging flag:
|
||
default value is 0,
|
||
value 1 outputs problems encountered while parsing PE file,
|
||
value above 1 also lists all generated minimal symbols. */
|
||
static unsigned int debug_coff_pe_read;
|
||
|
||
struct read_pe_section_data
|
||
{
|
||
CORE_ADDR vma_offset; /* Offset to loaded address of section. */
|
||
unsigned long rva_start; /* Start offset within the pe. */
|
||
unsigned long rva_end; /* End offset within the pe. */
|
||
enum minimal_symbol_type ms_type; /* Type to assign symbols in
|
||
section. */
|
||
unsigned int index; /* BFD section number. */
|
||
char *section_name; /* Recorded section name. */
|
||
};
|
||
|
||
#define IMAGE_SCN_CNT_CODE 0x20
|
||
#define IMAGE_SCN_CNT_INITIALIZED_DATA 0x40
|
||
#define IMAGE_SCN_CNT_UNINITIALIZED_DATA 0x80
|
||
#define PE_SECTION_INDEX_TEXT 0
|
||
#define PE_SECTION_INDEX_DATA 1
|
||
#define PE_SECTION_INDEX_BSS 2
|
||
#define PE_SECTION_TABLE_SIZE 3
|
||
#define PE_SECTION_INDEX_INVALID -1
|
||
|
||
/* Get the index of the named section in our own array, which contains
|
||
text, data and bss in that order. Return PE_SECTION_INDEX_INVALID
|
||
if passed an unrecognised section name. */
|
||
|
||
static int
|
||
read_pe_section_index (const char *section_name)
|
||
{
|
||
if (strcmp (section_name, ".text") == 0)
|
||
{
|
||
return PE_SECTION_INDEX_TEXT;
|
||
}
|
||
|
||
else if (strcmp (section_name, ".data") == 0)
|
||
{
|
||
return PE_SECTION_INDEX_DATA;
|
||
}
|
||
|
||
else if (strcmp (section_name, ".bss") == 0)
|
||
{
|
||
return PE_SECTION_INDEX_BSS;
|
||
}
|
||
|
||
else
|
||
{
|
||
return PE_SECTION_INDEX_INVALID;
|
||
}
|
||
}
|
||
|
||
/* Get the index of the named section in our own full array.
|
||
text, data and bss in that order. Return PE_SECTION_INDEX_INVALID
|
||
if passed an unrecognised section name. */
|
||
|
||
static int
|
||
get_pe_section_index (const char *section_name,
|
||
struct read_pe_section_data *sections,
|
||
int nb_sections)
|
||
{
|
||
int i;
|
||
|
||
for (i = 0; i < nb_sections; i++)
|
||
if (strcmp (sections[i].section_name, section_name) == 0)
|
||
return i;
|
||
return PE_SECTION_INDEX_INVALID;
|
||
}
|
||
|
||
/* Structure used by get_section_vmas function below
|
||
to access section_data array and the size of the array
|
||
stored in nb_sections field. */
|
||
struct pe_sections_info
|
||
{
|
||
int nb_sections;
|
||
struct read_pe_section_data *sections;
|
||
};
|
||
|
||
/* Record the virtual memory address of a section. */
|
||
|
||
static void
|
||
get_section_vmas (bfd *abfd, asection *sectp, void *context)
|
||
{
|
||
struct pe_sections_info *data = (struct pe_sections_info *) context;
|
||
struct read_pe_section_data *sections = data->sections;
|
||
int sectix = get_pe_section_index (sectp->name, sections,
|
||
data->nb_sections);
|
||
|
||
if (sectix != PE_SECTION_INDEX_INVALID)
|
||
{
|
||
/* Data within the section start at rva_start in the pe and at
|
||
bfd_get_section_vma() within memory. Store the offset. */
|
||
|
||
sections[sectix].vma_offset
|
||
= bfd_get_section_vma (abfd, sectp) - sections[sectix].rva_start;
|
||
}
|
||
}
|
||
|
||
/* Create a minimal symbol entry for an exported symbol.
|
||
SYM_NAME contains the exported name or NULL if exported by ordinal,
|
||
FUNC_RVA contains the Relative Virtual Address of the symbol,
|
||
ORDINAL is the ordinal index value of the symbol,
|
||
SECTION_DATA contains information about the section in which the
|
||
symbol is declared,
|
||
DLL_NAME is the internal name of the DLL file,
|
||
OBJFILE is the objfile struct of DLL_NAME. */
|
||
|
||
static void
|
||
add_pe_exported_sym (const char *sym_name,
|
||
unsigned long func_rva,
|
||
int ordinal,
|
||
const struct read_pe_section_data *section_data,
|
||
const char *dll_name, struct objfile *objfile)
|
||
{
|
||
char *qualified_name, *bare_name;
|
||
/* Add the stored offset to get the loaded address of the symbol. */
|
||
CORE_ADDR vma = func_rva + section_data->vma_offset;
|
||
|
||
/* Generate a (hopefully unique) qualified name using the first part
|
||
of the dll name, e.g. KERNEL32!AddAtomA. This matches the style
|
||
used by windbg from the "Microsoft Debugging Tools for Windows". */
|
||
|
||
if (sym_name == NULL || *sym_name == '\0')
|
||
bare_name = xstrprintf ("#%d", ordinal);
|
||
else
|
||
bare_name = xstrdup (sym_name);
|
||
|
||
qualified_name = xstrprintf ("%s!%s", dll_name, bare_name);
|
||
|
||
if ((section_data->ms_type == mst_unknown) && debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog , _("Unknown section type for \"%s\""
|
||
" for entry \"%s\" in dll \"%s\"\n"),
|
||
section_data->section_name, sym_name, dll_name);
|
||
|
||
prim_record_minimal_symbol_and_info (qualified_name, vma,
|
||
section_data->ms_type,
|
||
section_data->index, objfile);
|
||
|
||
/* Enter the plain name as well, which might not be unique. */
|
||
prim_record_minimal_symbol_and_info (bare_name, vma, section_data->ms_type,
|
||
section_data->index, objfile);
|
||
if (debug_coff_pe_read > 1)
|
||
fprintf_unfiltered (gdb_stdlog, _("Adding exported symbol \"%s\""
|
||
" in dll \"%s\"\n"), sym_name, dll_name);
|
||
xfree (qualified_name);
|
||
xfree (bare_name);
|
||
}
|
||
|
||
/* Create a minimal symbol entry for an exported forward symbol.
|
||
Return 1 if the forwarded function was found 0 otherwise.
|
||
SYM_NAME contains the exported name or NULL if exported by ordinal,
|
||
FORWARD_DLL_NAME is the name of the DLL in which the target symobl resides,
|
||
FORWARD_FUNC_NAME is the name of the target symbol in that DLL,
|
||
ORDINAL is the ordinal index value of the symbol,
|
||
DLL_NAME is the internal name of the DLL file,
|
||
OBJFILE is the objfile struct of DLL_NAME. */
|
||
|
||
static int
|
||
add_pe_forwarded_sym (const char *sym_name, const char *forward_dll_name,
|
||
const char *forward_func_name, int ordinal,
|
||
const char *dll_name, struct objfile *objfile)
|
||
{
|
||
CORE_ADDR vma, baseaddr;
|
||
struct bound_minimal_symbol msymbol;
|
||
enum minimal_symbol_type msymtype;
|
||
char *qualified_name, *bare_name;
|
||
int forward_dll_name_len = strlen (forward_dll_name);
|
||
int forward_func_name_len = strlen (forward_func_name);
|
||
int forward_len = forward_dll_name_len + forward_func_name_len + 2;
|
||
char *forward_qualified_name = (char *) alloca (forward_len);
|
||
short section;
|
||
|
||
xsnprintf (forward_qualified_name, forward_len, "%s!%s", forward_dll_name,
|
||
forward_func_name);
|
||
|
||
|
||
msymbol = lookup_minimal_symbol_and_objfile (forward_qualified_name);
|
||
|
||
if (!msymbol.minsym)
|
||
{
|
||
int i;
|
||
|
||
for (i = 0; i < forward_dll_name_len; i++)
|
||
forward_qualified_name[i] = tolower (forward_qualified_name[i]);
|
||
msymbol = lookup_minimal_symbol_and_objfile (forward_qualified_name);
|
||
}
|
||
|
||
if (!msymbol.minsym)
|
||
{
|
||
if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Unable to find function \"%s\" in"
|
||
" dll \"%s\", forward of \"%s\" in dll \"%s\"\n"),
|
||
forward_func_name, forward_dll_name, sym_name,
|
||
dll_name);
|
||
return 0;
|
||
}
|
||
|
||
if (debug_coff_pe_read > 1)
|
||
fprintf_unfiltered (gdb_stdlog, _("Adding forwarded exported symbol"
|
||
" \"%s\" in dll \"%s\", pointing to \"%s\"\n"),
|
||
sym_name, dll_name, forward_qualified_name);
|
||
|
||
vma = BMSYMBOL_VALUE_ADDRESS (msymbol);
|
||
msymtype = MSYMBOL_TYPE (msymbol.minsym);
|
||
section = MSYMBOL_SECTION (msymbol.minsym);
|
||
|
||
/* Generate a (hopefully unique) qualified name using the first part
|
||
of the dll name, e.g. KERNEL32!AddAtomA. This matches the style
|
||
used by windbg from the "Microsoft Debugging Tools for Windows". */
|
||
|
||
if (sym_name == NULL || *sym_name == '\0')
|
||
bare_name = xstrprintf ("#%d", ordinal);
|
||
else
|
||
bare_name = xstrdup (sym_name);
|
||
|
||
qualified_name = xstrprintf ("%s!%s", dll_name, bare_name);
|
||
|
||
/* Note that this code makes a minimal symbol whose value may point
|
||
outside of any section in this objfile. These symbols can't
|
||
really be relocated properly, but nevertheless we make a stab at
|
||
it, choosing an approach consistent with the history of this
|
||
code. */
|
||
baseaddr = ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile));
|
||
|
||
prim_record_minimal_symbol_and_info (qualified_name, vma - baseaddr,
|
||
msymtype, section, objfile);
|
||
|
||
/* Enter the plain name as well, which might not be unique. */
|
||
prim_record_minimal_symbol_and_info (bare_name, vma - baseaddr, msymtype,
|
||
section, objfile);
|
||
xfree (qualified_name);
|
||
xfree (bare_name);
|
||
|
||
return 1;
|
||
}
|
||
|
||
/* Truncate a dll_name at the last dot character. */
|
||
|
||
static void
|
||
read_pe_truncate_name (char *dll_name)
|
||
{
|
||
char *last_point = strrchr (dll_name, '.');
|
||
|
||
if (last_point != NULL)
|
||
*last_point = '\0';
|
||
}
|
||
|
||
/* Low-level support functions, direct from the ld module pe-dll.c. */
|
||
static unsigned int
|
||
pe_get16 (bfd *abfd, int where)
|
||
{
|
||
unsigned char b[2];
|
||
|
||
bfd_seek (abfd, (file_ptr) where, SEEK_SET);
|
||
bfd_bread (b, (bfd_size_type) 2, abfd);
|
||
return b[0] + (b[1] << 8);
|
||
}
|
||
|
||
static unsigned int
|
||
pe_get32 (bfd *abfd, int where)
|
||
{
|
||
unsigned char b[4];
|
||
|
||
bfd_seek (abfd, (file_ptr) where, SEEK_SET);
|
||
bfd_bread (b, (bfd_size_type) 4, abfd);
|
||
return b[0] + (b[1] << 8) + (b[2] << 16) + (b[3] << 24);
|
||
}
|
||
|
||
static unsigned int
|
||
pe_as16 (void *ptr)
|
||
{
|
||
unsigned char *b = (unsigned char *) ptr;
|
||
|
||
return b[0] + (b[1] << 8);
|
||
}
|
||
|
||
static unsigned int
|
||
pe_as32 (void *ptr)
|
||
{
|
||
unsigned char *b = (unsigned char *) ptr;
|
||
|
||
return b[0] + (b[1] << 8) + (b[2] << 16) + (b[3] << 24);
|
||
}
|
||
|
||
/* Read the (non-debug) export symbol table from a portable
|
||
executable. Code originally lifted from the ld function
|
||
pe_implied_import_dll in pe-dll.c. */
|
||
|
||
void
|
||
read_pe_exported_syms (struct objfile *objfile)
|
||
{
|
||
bfd *dll = objfile->obfd;
|
||
unsigned long nbnormal, nbforward;
|
||
unsigned long pe_header_offset, opthdr_ofs, num_entries, i;
|
||
unsigned long export_opthdrrva, export_opthdrsize;
|
||
unsigned long export_rva, export_size, nsections, secptr, expptr;
|
||
unsigned long exp_funcbase;
|
||
unsigned char *expdata, *erva;
|
||
unsigned long name_rvas, ordinals, nexp, ordbase;
|
||
char *dll_name = (char *) dll->filename;
|
||
int otherix = PE_SECTION_TABLE_SIZE;
|
||
int is_pe64 = 0;
|
||
int is_pe32 = 0;
|
||
|
||
/* Array elements are for text, data and bss in that order
|
||
Initialization with RVA_START > RVA_END guarantees that
|
||
unused sections won't be matched. */
|
||
struct read_pe_section_data *section_data;
|
||
struct pe_sections_info pe_sections_info;
|
||
|
||
struct cleanup *back_to = make_cleanup (null_cleanup, 0);
|
||
|
||
char const *target = bfd_get_target (objfile->obfd);
|
||
|
||
section_data = XCNEWVEC (struct read_pe_section_data, PE_SECTION_TABLE_SIZE);
|
||
|
||
make_cleanup (free_current_contents, §ion_data);
|
||
|
||
for (i=0; i < PE_SECTION_TABLE_SIZE; i++)
|
||
{
|
||
section_data[i].vma_offset = 0;
|
||
section_data[i].rva_start = 1;
|
||
section_data[i].rva_end = 0;
|
||
};
|
||
section_data[PE_SECTION_INDEX_TEXT].ms_type = mst_text;
|
||
section_data[PE_SECTION_INDEX_TEXT].section_name = ".text";
|
||
section_data[PE_SECTION_INDEX_DATA].ms_type = mst_data;
|
||
section_data[PE_SECTION_INDEX_DATA].section_name = ".data";
|
||
section_data[PE_SECTION_INDEX_BSS].ms_type = mst_bss;
|
||
section_data[PE_SECTION_INDEX_BSS].section_name = ".bss";
|
||
|
||
is_pe64 = (strcmp (target, "pe-x86-64") == 0
|
||
|| strcmp (target, "pei-x86-64") == 0);
|
||
is_pe32 = (strcmp (target, "pe-i386") == 0
|
||
|| strcmp (target, "pei-i386") == 0
|
||
|| strcmp (target, "pe-arm-wince-little") == 0
|
||
|| strcmp (target, "pei-arm-wince-little") == 0);
|
||
if (!is_pe32 && !is_pe64)
|
||
{
|
||
/* This is not a recognized PE format file. Abort now, because
|
||
the code is untested on anything else. *FIXME* test on
|
||
further architectures and loosen or remove this test. */
|
||
do_cleanups (back_to);
|
||
return;
|
||
}
|
||
|
||
/* Get pe_header, optional header and numbers of export entries. */
|
||
pe_header_offset = pe_get32 (dll, 0x3c);
|
||
opthdr_ofs = pe_header_offset + 4 + 20;
|
||
if (is_pe64)
|
||
num_entries = pe_get32 (dll, opthdr_ofs + 108);
|
||
else
|
||
num_entries = pe_get32 (dll, opthdr_ofs + 92);
|
||
|
||
if (num_entries < 1) /* No exports. */
|
||
{
|
||
do_cleanups (back_to);
|
||
return;
|
||
}
|
||
if (is_pe64)
|
||
{
|
||
export_opthdrrva = pe_get32 (dll, opthdr_ofs + 112);
|
||
export_opthdrsize = pe_get32 (dll, opthdr_ofs + 116);
|
||
}
|
||
else
|
||
{
|
||
export_opthdrrva = pe_get32 (dll, opthdr_ofs + 96);
|
||
export_opthdrsize = pe_get32 (dll, opthdr_ofs + 100);
|
||
}
|
||
nsections = pe_get16 (dll, pe_header_offset + 4 + 2);
|
||
secptr = (pe_header_offset + 4 + 20 +
|
||
pe_get16 (dll, pe_header_offset + 4 + 16));
|
||
expptr = 0;
|
||
export_size = 0;
|
||
|
||
/* Get the rva and size of the export section. */
|
||
for (i = 0; i < nsections; i++)
|
||
{
|
||
char sname[8];
|
||
unsigned long secptr1 = secptr + 40 * i;
|
||
unsigned long vaddr = pe_get32 (dll, secptr1 + 12);
|
||
unsigned long vsize = pe_get32 (dll, secptr1 + 16);
|
||
unsigned long fptr = pe_get32 (dll, secptr1 + 20);
|
||
|
||
bfd_seek (dll, (file_ptr) secptr1, SEEK_SET);
|
||
bfd_bread (sname, (bfd_size_type) sizeof (sname), dll);
|
||
|
||
if ((strcmp (sname, ".edata") == 0)
|
||
|| (vaddr <= export_opthdrrva && export_opthdrrva < vaddr + vsize))
|
||
{
|
||
if (strcmp (sname, ".edata") != 0)
|
||
{
|
||
if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Export RVA for dll "
|
||
"\"%s\" is in section \"%s\"\n"),
|
||
dll_name, sname);
|
||
}
|
||
else if (export_opthdrrva != vaddr && debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Wrong value of export RVA"
|
||
" for dll \"%s\": 0x%lx instead of 0x%lx\n"),
|
||
dll_name, export_opthdrrva, vaddr);
|
||
expptr = fptr + (export_opthdrrva - vaddr);
|
||
break;
|
||
}
|
||
}
|
||
|
||
export_rva = export_opthdrrva;
|
||
export_size = export_opthdrsize;
|
||
|
||
if (export_size == 0)
|
||
{
|
||
/* Empty export table. */
|
||
do_cleanups (back_to);
|
||
return;
|
||
}
|
||
|
||
/* Scan sections and store the base and size of the relevant
|
||
sections. */
|
||
for (i = 0; i < nsections; i++)
|
||
{
|
||
unsigned long secptr1 = secptr + 40 * i;
|
||
unsigned long vsize = pe_get32 (dll, secptr1 + 8);
|
||
unsigned long vaddr = pe_get32 (dll, secptr1 + 12);
|
||
unsigned long characteristics = pe_get32 (dll, secptr1 + 36);
|
||
char sec_name[SCNNMLEN + 1];
|
||
int sectix;
|
||
unsigned int bfd_section_index;
|
||
asection *section;
|
||
|
||
bfd_seek (dll, (file_ptr) secptr1 + 0, SEEK_SET);
|
||
bfd_bread (sec_name, (bfd_size_type) SCNNMLEN, dll);
|
||
sec_name[SCNNMLEN] = '\0';
|
||
|
||
sectix = read_pe_section_index (sec_name);
|
||
section = bfd_get_section_by_name (dll, sec_name);
|
||
if (section)
|
||
bfd_section_index = section->index;
|
||
else
|
||
bfd_section_index = -1;
|
||
|
||
if (sectix != PE_SECTION_INDEX_INVALID)
|
||
{
|
||
section_data[sectix].rva_start = vaddr;
|
||
section_data[sectix].rva_end = vaddr + vsize;
|
||
section_data[sectix].index = bfd_section_index;
|
||
}
|
||
else
|
||
{
|
||
char *name;
|
||
|
||
section_data = XRESIZEVEC (struct read_pe_section_data, section_data,
|
||
otherix + 1);
|
||
name = xstrdup (sec_name);
|
||
section_data[otherix].section_name = name;
|
||
make_cleanup (xfree, name);
|
||
section_data[otherix].rva_start = vaddr;
|
||
section_data[otherix].rva_end = vaddr + vsize;
|
||
section_data[otherix].vma_offset = 0;
|
||
section_data[otherix].index = bfd_section_index;
|
||
if (characteristics & IMAGE_SCN_CNT_CODE)
|
||
section_data[otherix].ms_type = mst_text;
|
||
else if (characteristics & IMAGE_SCN_CNT_INITIALIZED_DATA)
|
||
section_data[otherix].ms_type = mst_data;
|
||
else if (characteristics & IMAGE_SCN_CNT_UNINITIALIZED_DATA)
|
||
section_data[otherix].ms_type = mst_bss;
|
||
else
|
||
section_data[otherix].ms_type = mst_unknown;
|
||
otherix++;
|
||
}
|
||
}
|
||
|
||
expdata = (unsigned char *) xmalloc (export_size);
|
||
make_cleanup (xfree, expdata);
|
||
|
||
bfd_seek (dll, (file_ptr) expptr, SEEK_SET);
|
||
bfd_bread (expdata, (bfd_size_type) export_size, dll);
|
||
erva = expdata - export_rva;
|
||
|
||
nexp = pe_as32 (expdata + 24);
|
||
name_rvas = pe_as32 (expdata + 32);
|
||
ordinals = pe_as32 (expdata + 36);
|
||
ordbase = pe_as32 (expdata + 16);
|
||
exp_funcbase = pe_as32 (expdata + 28);
|
||
|
||
/* Use internal dll name instead of full pathname. */
|
||
dll_name = (char *) (pe_as32 (expdata + 12) + erva);
|
||
|
||
pe_sections_info.nb_sections = otherix;
|
||
pe_sections_info.sections = section_data;
|
||
|
||
bfd_map_over_sections (dll, get_section_vmas, &pe_sections_info);
|
||
|
||
/* Truncate name at first dot. Should maybe also convert to all
|
||
lower case for convenience on Windows. */
|
||
read_pe_truncate_name (dll_name);
|
||
|
||
if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("DLL \"%s\" has %ld export entries,"
|
||
" base=%ld\n"), dll_name, nexp, ordbase);
|
||
nbforward = 0;
|
||
nbnormal = 0;
|
||
/* Iterate through the list of symbols. */
|
||
for (i = 0; i < nexp; i++)
|
||
{
|
||
/* Pointer to the names vector. */
|
||
unsigned long name_rva = pe_as32 (erva + name_rvas + i * 4);
|
||
/* Retrieve ordinal value. */
|
||
|
||
unsigned long ordinal = pe_as16 (erva + ordinals + i * 2);
|
||
|
||
|
||
/* Pointer to the function address vector. */
|
||
/* This is relatived to ordinal value. */
|
||
unsigned long func_rva = pe_as32 (erva + exp_funcbase +
|
||
ordinal * 4);
|
||
|
||
/* Find this symbol's section in our own array. */
|
||
int sectix = 0;
|
||
int section_found = 0;
|
||
|
||
/* First handle forward cases. */
|
||
if (func_rva >= export_rva && func_rva < export_rva + export_size)
|
||
{
|
||
char *forward_name = (char *) (erva + func_rva);
|
||
char *funcname = (char *) (erva + name_rva);
|
||
char *forward_dll_name = forward_name;
|
||
char *forward_func_name = forward_name;
|
||
char *sep = strrchr (forward_name, '.');
|
||
|
||
if (sep)
|
||
{
|
||
int len = (int) (sep - forward_name);
|
||
|
||
forward_dll_name = (char *) alloca (len + 1);
|
||
strncpy (forward_dll_name, forward_name, len);
|
||
forward_dll_name[len] = '\0';
|
||
forward_func_name = ++sep;
|
||
}
|
||
if (add_pe_forwarded_sym (funcname, forward_dll_name,
|
||
forward_func_name, ordinal,
|
||
dll_name, objfile) != 0)
|
||
++nbforward;
|
||
continue;
|
||
}
|
||
|
||
for (sectix = 0; sectix < otherix; ++sectix)
|
||
{
|
||
if ((func_rva >= section_data[sectix].rva_start)
|
||
&& (func_rva < section_data[sectix].rva_end))
|
||
{
|
||
char *sym_name = (char *) (erva + name_rva);
|
||
|
||
section_found = 1;
|
||
add_pe_exported_sym (sym_name, func_rva, ordinal,
|
||
section_data + sectix, dll_name, objfile);
|
||
++nbnormal;
|
||
break;
|
||
}
|
||
}
|
||
if (!section_found)
|
||
{
|
||
char *funcname = (char *) (erva + name_rva);
|
||
|
||
if (name_rva == 0)
|
||
{
|
||
add_pe_exported_sym (NULL, func_rva, ordinal,
|
||
section_data, dll_name, objfile);
|
||
++nbnormal;
|
||
}
|
||
else if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Export name \"%s\" ord. %lu,"
|
||
" RVA 0x%lx in dll \"%s\" not handled\n"),
|
||
funcname, ordinal, func_rva, dll_name);
|
||
}
|
||
}
|
||
|
||
if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Finished reading \"%s\", exports %ld,"
|
||
" forwards %ld, total %ld/%ld.\n"), dll_name, nbnormal,
|
||
nbforward, nbnormal + nbforward, nexp);
|
||
/* Discard expdata and section_data. */
|
||
do_cleanups (back_to);
|
||
}
|
||
|
||
/* Extract from ABFD the offset of the .text section.
|
||
This offset is mainly related to the offset within the file.
|
||
The value was previously expected to be 0x1000 for all files,
|
||
but some Windows OS core DLLs seem to use 0x10000 section alignement
|
||
which modified the return value of that function.
|
||
Still return default 0x1000 value if ABFD is NULL or
|
||
if '.text' section is not found, but that should not happen... */
|
||
|
||
#define DEFAULT_COFF_PE_TEXT_SECTION_OFFSET 0x1000
|
||
|
||
CORE_ADDR
|
||
pe_text_section_offset (struct bfd *abfd)
|
||
|
||
{
|
||
unsigned long pe_header_offset, i;
|
||
unsigned long nsections, secptr;
|
||
int is_pe64 = 0;
|
||
int is_pe32 = 0;
|
||
char const *target;
|
||
|
||
if (!abfd)
|
||
return DEFAULT_COFF_PE_TEXT_SECTION_OFFSET;
|
||
|
||
target = bfd_get_target (abfd);
|
||
|
||
is_pe64 = (strcmp (target, "pe-x86-64") == 0
|
||
|| strcmp (target, "pei-x86-64") == 0);
|
||
is_pe32 = (strcmp (target, "pe-i386") == 0
|
||
|| strcmp (target, "pei-i386") == 0
|
||
|| strcmp (target, "pe-arm-wince-little") == 0
|
||
|| strcmp (target, "pei-arm-wince-little") == 0);
|
||
|
||
if (!is_pe32 && !is_pe64)
|
||
{
|
||
/* This is not a recognized PE format file. Abort now, because
|
||
the code is untested on anything else. *FIXME* test on
|
||
further architectures and loosen or remove this test. */
|
||
return DEFAULT_COFF_PE_TEXT_SECTION_OFFSET;
|
||
}
|
||
|
||
/* Get pe_header, optional header and numbers of sections. */
|
||
pe_header_offset = pe_get32 (abfd, 0x3c);
|
||
nsections = pe_get16 (abfd, pe_header_offset + 4 + 2);
|
||
secptr = (pe_header_offset + 4 + 20 +
|
||
pe_get16 (abfd, pe_header_offset + 4 + 16));
|
||
|
||
/* Get the rva and size of the export section. */
|
||
for (i = 0; i < nsections; i++)
|
||
{
|
||
char sname[SCNNMLEN + 1];
|
||
unsigned long secptr1 = secptr + 40 * i;
|
||
unsigned long vaddr = pe_get32 (abfd, secptr1 + 12);
|
||
|
||
bfd_seek (abfd, (file_ptr) secptr1, SEEK_SET);
|
||
bfd_bread (sname, (bfd_size_type) SCNNMLEN, abfd);
|
||
sname[SCNNMLEN] = '\0';
|
||
if (strcmp (sname, ".text") == 0)
|
||
return vaddr;
|
||
}
|
||
|
||
return DEFAULT_COFF_PE_TEXT_SECTION_OFFSET;
|
||
}
|
||
|
||
/* Implements "show debug coff_pe_read" command. */
|
||
|
||
static void
|
||
show_debug_coff_pe_read (struct ui_file *file, int from_tty,
|
||
struct cmd_list_element *c, const char *value)
|
||
{
|
||
fprintf_filtered (file, _("Coff PE read debugging is %s.\n"), value);
|
||
}
|
||
|
||
/* Provide a prototype to silence -Wmissing-prototypes. */
|
||
|
||
void _initialize_coff_pe_read (void);
|
||
|
||
/* Adds "Set/show debug coff_pe_read" commands. */
|
||
|
||
void
|
||
_initialize_coff_pe_read (void)
|
||
{
|
||
add_setshow_zuinteger_cmd ("coff-pe-read", class_maintenance,
|
||
&debug_coff_pe_read,
|
||
_("Set coff PE read debugging."),
|
||
_("Show coff PE read debugging."),
|
||
_("When set, debugging messages for coff reading "
|
||
"of exported symbols are displayed."),
|
||
NULL, show_debug_coff_pe_read,
|
||
&setdebuglist, &showdebuglist);
|
||
}
|